| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2025-11-25 | |||
| 14:47:23 | opendevreview | Merged openstack/python-openstackclient master: Remove duplicate test utilities https://review.opendev.org/c/openstack/python-openstackclient/+/966420 | |
| 16:12:29 | opendevreview | cid proposed openstack/openstacksdk master: Add Node.instance_name support https://review.opendev.org/c/openstack/openstacksdk/+/955103 | |
| 16:13:22 | opendevreview | cid proposed openstack/openstacksdk master: Add Node.instance_name support https://review.opendev.org/c/openstack/openstacksdk/+/955103 | |
| 17:22:33 | opendevreview | cid proposed openstack/openstacksdk master: Add Node.instance_name support https://review.opendev.org/c/openstack/openstacksdk/+/955103 | |
| 17:32:39 | opendevreview | cid proposed openstack/openstacksdk master: Fix mypy type errors for None handling https://review.opendev.org/c/openstack/openstacksdk/+/968353 | |
| 17:47:34 | opendevreview | cid proposed openstack/openstacksdk master: Fix mypy type check errors https://review.opendev.org/c/openstack/openstacksdk/+/968353 | |
| 18:10:31 | opendevreview | Merged openstack/osc-lib master: typing: Allow use of column subclasses https://review.opendev.org/c/openstack/osc-lib/+/968316 | |
| 18:10:36 | opendevreview | cid proposed openstack/openstacksdk master: Add secure hash validation for image downloads https://review.opendev.org/c/openstack/openstacksdk/+/966291 | |
| 18:35:58 | cid | This should fix the type check failures in the CI: https://review.opendev.org/c/openstack/openstacksdk/+/968353 | |
| 18:47:03 | stephenfin | cid: Thanks, approved | |
| 20:40:50 | opendevreview | Merged openstack/openstacksdk master: Fix mypy type check errors https://review.opendev.org/c/openstack/openstacksdk/+/968353 | |
| 22:05:58 | opendevreview | Oria Weng proposed openstack/openstacksdk master: Identity: Deprecate find_region() https://review.opendev.org/c/openstack/openstacksdk/+/967779 | |
| #openstack-sdks - 2025-11-26 | |||
| 12:29:51 | opendevreview | Merged openstack/openstacksdk master: Identity: Deprecate find_region() https://review.opendev.org/c/openstack/openstacksdk/+/967779 | |
| 12:29:55 | opendevreview | Merged openstack/python-openstackclient master: Change metavar name for `registered limit delete` https://review.opendev.org/c/openstack/python-openstackclient/+/967594 | |
| 19:00:12 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Improve help strings for tap service https://review.opendev.org/c/openstack/python-openstackclient/+/968546 | |
| 19:02:47 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Improve help strings for tap services https://review.opendev.org/c/openstack/python-openstackclient/+/968546 | |
| #openstack-sdks - 2025-11-27 | |||
| 07:59:40 | opendevreview | cid proposed openstack/openstacksdk master: Add secure hash validation for image downloads https://review.opendev.org/c/openstack/openstacksdk/+/966291 | |
| 09:30:50 | opendevreview | nidhi proposed openstack/python-openstackclient master: Change network tests from exact to subset checking. https://review.opendev.org/c/openstack/python-openstackclient/+/963947 | |
| 11:33:05 | opendevreview | nidhi proposed openstack/python-openstackclient master: Change network tests from exact to subset checking. https://review.opendev.org/c/openstack/python-openstackclient/+/963947 | |
| 14:33:19 | opendevreview | cid proposed openstack/openstacksdk master: Add Node.instance_name support https://review.opendev.org/c/openstack/openstacksdk/+/955103 | |
| 14:33:20 | opendevreview | cid proposed openstack/openstacksdk master: Fix `_original_body` synchronization after commit https://review.opendev.org/c/openstack/openstacksdk/+/968708 | |
| 15:28:06 | opendevreview | nidhi proposed openstack/python-openstackclient master: Change network tests from exact to subset checking. https://review.opendev.org/c/openstack/python-openstackclient/+/963947 | |
| #openstack-sdks - 2025-11-28 | |||
| 07:28:33 | opendevreview | nidhi proposed openstack/python-openstackclient master: Change network tests from exact to subset checking. https://review.opendev.org/c/openstack/python-openstackclient/+/963947 | |
| 15:14:51 | opendevreview | Stephen Finucane proposed openstack/cliff master: Revert "Implement conflict resolution" https://review.opendev.org/c/openstack/cliff/+/968813 | |
| 15:14:52 | opendevreview | Stephen Finucane proposed openstack/cliff master: Deprecated CommandManager namespace argument https://review.opendev.org/c/openstack/cliff/+/968815 | |
| 15:14:52 | opendevreview | Stephen Finucane proposed openstack/cliff master: Warn on duplicate commands in the same namespace https://review.opendev.org/c/openstack/cliff/+/968814 | |
| 15:44:47 | opendevreview | Stephen Finucane proposed openstack/cliff master: Warn on duplicate commands in the same namespace https://review.opendev.org/c/openstack/cliff/+/968814 | |
| 15:44:48 | opendevreview | Stephen Finucane proposed openstack/cliff master: Deprecate CommandManager namespace argument https://review.opendev.org/c/openstack/cliff/+/968815 | |
| 15:56:07 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Implement conflict resolution https://review.opendev.org/c/openstack/python-openstackclient/+/968178 | |
| 15:56:07 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Moving tapas osc client code from neutronclient https://review.opendev.org/c/openstack/python-openstackclient/+/963445 | |
| 15:58:46 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Improve help strings for tap services https://review.opendev.org/c/openstack/python-openstackclient/+/968546 | |
| 17:58:50 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: Add is_uuid_like helper https://review.opendev.org/c/openstack/osc-lib/+/968840 | |
| 17:59:09 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: Add is_uuid_like helper https://review.opendev.org/c/openstack/osc-lib/+/968840 | |
| 18:08:45 | opendevreview | Merged openstack/cliff master: Revert "Implement conflict resolution" https://review.opendev.org/c/openstack/cliff/+/968813 | |
| 18:16:13 | opendevreview | Merged openstack/cliff master: Warn on duplicate commands in the same namespace https://review.opendev.org/c/openstack/cliff/+/968814 | |
| 18:35:05 | opendevreview | Merged openstack/cliff master: Deprecate CommandManager namespace argument https://review.opendev.org/c/openstack/cliff/+/968815 | |
| 20:28:59 | opendevreview | Merged openstack/osc-lib master: Add is_uuid_like helper https://review.opendev.org/c/openstack/osc-lib/+/968840 | |
| #openstack-sdks - 2025-12-01 | |||
| 14:10:48 | opendevreview | Riccardo Pittau proposed openstack/ansible-collections-openstack master: Use new bifrost CI jobs names https://review.opendev.org/c/openstack/ansible-collections-openstack/+/969078 | |
| 14:13:04 | opendevreview | Riccardo Pittau proposed openstack/openstacksdk master: Update name of bifrost CI job https://review.opendev.org/c/openstack/openstacksdk/+/969079 | |
| 18:03:38 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'registered limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | |
| 19:02:11 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| #openstack-sdks - 2025-12-02 | |||
| 00:12:50 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'project' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/965317 | |
| 17:05:59 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'project' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/965317 | |
| 17:08:39 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'project' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/965317 | |
| 18:53:02 | opendevreview | Valentin Chassignol proposed openstack/python-openstackclient master: Add retrieve password with private key decryption https://review.opendev.org/c/openstack/python-openstackclient/+/923621 | |
| 21:41:20 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Moving tapas osc client code from neutronclient https://review.opendev.org/c/openstack/python-openstackclient/+/963445 | |
| 21:46:01 | opendevreview | Valentin Chassignol proposed openstack/python-openstackclient master: Add retrieve password with private key decryption https://review.opendev.org/c/openstack/python-openstackclient/+/923621 | |
| 21:47:05 | vinetos | Hey ~ I'm trying to rewrite the test for this change https://review.opendev.org/c/openstack/python-openstackclient/+/923621 but I cannot get the mocking of compute_client.get_server_password correctly. Does anyone see what I am doing wrong ? | |
| #openstack-sdks - 2025-12-03 | |||
| 00:05:21 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'project' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/965317 | |
| 04:29:48 | opendevreview | nidhi proposed openstack/python-openstackclient master: Change network tests from exact to subset checking. https://review.opendev.org/c/openstack/python-openstackclient/+/963947 | |
| 04:39:29 | opendevreview | nidhi proposed openstack/python-openstackclient master: Change network tests from exact to subset checking. https://review.opendev.org/c/openstack/python-openstackclient/+/963947 | |
| 04:45:49 | opendevreview | nidhi proposed openstack/python-openstackclient master: Change network tests from exact to subset checking. https://review.opendev.org/c/openstack/python-openstackclient/+/963947 | |
| 04:52:45 | opendevreview | nidhi proposed openstack/python-openstackclient master: Change network tests from exact to subset checking. https://review.opendev.org/c/openstack/python-openstackclient/+/963947 | |
| 14:13:31 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Improve help strings for tap services https://review.opendev.org/c/openstack/python-openstackclient/+/968546 | |
| 14:18:52 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Use openstacksdk test generate_fake_resources factory https://review.opendev.org/c/openstack/python-openstackclient/+/966354 | |
| 14:18:52 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Moving tapas osc client code from neutronclient https://review.opendev.org/c/openstack/python-openstackclient/+/963445 | |
| #openstack-sdks - 2025-12-04 | |||
| 14:35:22 | zigo | openstacksdk fails with Python 3.14, it seems: https://buildd.debian.org/status/fetch.php?pkg=python-openstacksdk&arch=all&ver=4.7.2-1&stamp=1764789128&raw=0 | |
| 14:40:42 | stephenfin | zigo: that looks like a bug | |
| 14:40:49 | stephenfin | in scoping | |
| 14:41:10 | zigo | stephenfin: Can you expand on this? :) | |
| 14:43:16 | stephenfin | I'll try work on a minimal reproducer, but it seems to be associating 'list' with the class method defined on the class instead of the list primitive | |
| 14:43:30 | stephenfin | that's a change in scoping behavior fwict | |
| 14:43:49 | zigo | New behavior in python 3.14, you mean? | |
| 14:44:10 | stephenfin | yes | |
| 14:44:11 | zigo | (you must know it but... ) you can just pop a Debian Unstable if you want 3.14. | |
| 14:45:04 | stephenfin | All good: I've got it in F43 | |
| 14:54:30 | zigo | Let me know your findings, thanks for taking care of it. | |
| 14:55:21 | stephenfin | zigo: https://github.com/stephenfin/python-314-scoping-reproducer | |
| 14:55:34 | stephenfin | there's a minimal reproducer | |
| 14:56:40 | stephenfin | there's a chance this is an intentional change but I don't see anything in https://docs.python.org/3/whatsnew/3.14.html | |
| 14:57:21 | stephenfin | in any case, the solution will likely be to replace `list[...]` annotations with `builtins.list` in that file | |
| 15:49:56 | zigo | NameError: name 'builtins' is not defined. Did you forget to import 'builtins'? | |
| 15:49:56 | zigo | ^^^^^^^^ | |
| 15:49:56 | zigo | ) -> dict[str, ty.Any] | builtins.list[ty.Any]: | |
| 15:49:56 | zigo | File "/build/python-openstacksdk-RCihkI/python-openstacksdk-4.7.2/openstack/resource.py", line 1117, in __annotate__ | |
| 15:49:56 | zigo | stephenfin: | |
| 15:50:06 | zigo | I can just get rid of the annotation, no ? | |
| 16:27:39 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Use openstacksdk test generate_fake_resources factory https://review.opendev.org/c/openstack/python-openstackclient/+/966354 | |
| 17:02:35 | stephenfin | zigo: we want to be adding annotations, not removing them. you need to import builtins, yes | |
| 19:17:14 | opendevreview | Cyril Roelandt proposed openstack/openstacksdk master: image: Add support for downloading from a specific store https://review.opendev.org/c/openstack/openstacksdk/+/969839 | |
| 19:30:15 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Implement conflict resolution https://review.opendev.org/c/openstack/python-openstackclient/+/968178 | |
| 19:30:21 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Implement conflict resolution https://review.opendev.org/c/openstack/python-openstackclient/+/968178 | |
| 20:20:42 | opendevreview | Austin Jamias proposed openstack/ansible-collections-openstack master: Add ability to allocate floating IP https://review.opendev.org/c/openstack/ansible-collections-openstack/+/969848 | |
| #openstack-sdks - 2025-12-05 | |||
| 11:02:38 | zigo | Should I push them to gerrit then? | |
| 11:02:38 | zigo | https://salsa.debian.org/openstack-team/libs/python-openstacksdk/-/tree/debian/flamingo/debian/patches?ref_type=heads | |
| 11:02:38 | zigo | stephenfin: Here's my 2 patches for py3.13 : | |
| 11:56:26 | zigo | *3.14 I mean | |
| 15:47:50 | stephenfin | zigo: yes please | |
| 15:50:08 | croelandt | Hello! I see upload_image() is marked as deprecated in the SDK and that I should switch to using "create_image". I'm not sure I can use create_image to upload data to an existing image though | |
| 15:50:21 | croelandt | Also I could use the import workflow, but I'd like for the data upload to work in an env where that is not configured | |
| 15:50:24 | croelandt | Any idea? | |
| 15:54:16 | stephenfin | croelandt: the issue with that method was that it was doing too much: it should have only been handling the upload step of the legacy flow but it was instead doing create (which afaik is also part of the image import flow) + upload | |
| 15:54:36 | stephenfin | mrjoshi was working on it in the past but never got to the bottom of it https://review.opendev.org/c/openstack/openstacksdk/+/881939 | |
| 15:55:21 | stephenfin | I still think that's the correct path to take but someone needs to pick it up again | |
| 15:56:54 | croelandt | OK, I see she's answered comments by Artem, Maxim and yourself and then uploaded a patchset that passes the CI. Do you know whether there is something specific to change from patchset #21? | |
| 15:58:49 | stephenfin | croelandt: It's a really hard patch to review, and I struggle each time I've to try. I think it needs to be broken up to reviewable and mergeable, if I'm being honest :( | |
| 15:59:01 | stephenfin | For example, this could be a separate patch https://review.opendev.org/c/openstack/openstacksdk/+/881939/21/openstack/image/v2/image.py | |
| 16:00:29 | stephenfin | I also think we'd benefit from a precursor patch that tests calling upload_image with arguments in various forms | |
| 16:00:37 | stephenfin | e.g. upload_image('ami', None) | |
| 16:00:41 | stephenfin | upload_image('ami', disk_format=None) | |