| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2025-01-24 | |||
| 09:40:00 | gtema | hey hey. It's a curse. I am vice-versa trying to understand why certain patch doesn't work locally while it works remotely :) | |
| 09:40:07 | gtema | looking | |
| 09:40:21 | slaweq | haha | |
| 09:40:24 | slaweq | thx a lot | |
| 09:41:42 | gtema | I see order of columns in the response differs | |
| 09:42:14 | slaweq | there is one "not expected" column there and it is "is_vlan_qinq" | |
| 09:42:22 | gtema | actually this new attr is_vlan_qinq is not defined in the unittest while it is now returned | |
| 09:42:24 | slaweq | this is new thing added by the patch on which it is running | |
| 09:42:42 | slaweq | but why it is passing for me locally? | |
| 09:42:59 | slaweq | I don't understand it :/ | |
| 09:43:15 | gtema | and you see the attr returned when you invoke osc? | |
| 09:48:17 | gtema | slaweq: the test fails for me locally. Can it be that you changed the test locally but didn't pushed it? | |
| 09:48:22 | slaweq | when I run this test locally this new column is there too | |
| 09:50:02 | slaweq | all changes are pushed | |
| 09:50:33 | gtema | I think the problem is (and we had it already) osc respects depends-on, sdk can not install osc patch and it uses the master branch of it | |
| 09:51:07 | slaweq | but then isn't it chicken-egg problem? | |
| 09:51:30 | gtema | it is a circular dependency and you should first prepare osc test (disable it or extend with dummy) | |
| 09:51:37 | gtema | we had this clearly some time ago | |
| 09:51:54 | slaweq | ok, I will do it that way | |
| 09:51:55 | slaweq | thx | |
| 09:51:56 | gtema | once this osc change merges you can proceed with your changes | |
| 09:52:04 | gtema | you are welcome | |
| 09:56:35 | gtema | I see historically there were your/Rodolfo changes that used also depends-on on the sdk change | |
| 09:56:53 | gtema | and Zuul was itself resolving circular dependency - try it this way, slaweq | |
| 09:57:18 | gtema | i.e. https://review.opendev.org/c/openstack/python-openstackclient/+/892792 | |
| 10:09:00 | opendevreview | Slawek Kaplonski proposed openstack/python-openstackclient master: Temporary ignore "is_vlan_qinq" column in the output https://review.opendev.org/c/openstack/python-openstackclient/+/940111 | |
| 10:12:28 | opendevreview | Slawek Kaplonski proposed openstack/python-openstackclient master: Add "qinq-vlan" and "no-qinq-vlan" params to the "network create" cmd https://review.opendev.org/c/openstack/python-openstackclient/+/939706 | |
| 10:12:28 | opendevreview | Slawek Kaplonski proposed openstack/python-openstackclient master: Temporary ignore "is_vlan_qinq" column in the output https://review.opendev.org/c/openstack/python-openstackclient/+/940111 | |
| 10:13:42 | opendevreview | Slawek Kaplonski proposed openstack/openstacksdk master: Add "vlan_qinq" attribute to the "network" resource https://review.opendev.org/c/openstack/openstacksdk/+/939703 | |
| 10:15:50 | slaweq | gtema ok, lets see how ^^ will work | |
| 14:39:06 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: loading.opts: Add 'argparse_envvars' helper https://review.opendev.org/c/openstack/keystoneauth/+/933110 | |
| 14:39:07 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: doc: Fix indentation https://review.opendev.org/c/openstack/keystoneauth/+/933111 | |
| 14:39:08 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: docs: Rework plugin-options doc https://review.opendev.org/c/openstack/keystoneauth/+/933112 | |
| 14:39:09 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: loading: Add blurb for most plugins https://review.opendev.org/c/openstack/keystoneauth/+/933113 | |
| 14:39:11 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: docs: Document CLI options, envvars https://review.opendev.org/c/openstack/keystoneauth/+/933114 | |
| 14:49:40 | stephenfin | gtema: If you've time, would you be able to sweep through those? ^ | |
| 14:49:53 | gtema | ack | |
| 14:53:17 | stephenfin | thanks | |
| 15:10:41 | opendevreview | Matthias Rabe proposed openstack/ansible-collections-openstack master: Let clouds_yaml_path behave as documented (Override path to clouds.yaml file) https://review.opendev.org/c/openstack/ansible-collections-openstack/+/940137 | |
| 15:18:48 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Simplify some types, other TODOs https://review.opendev.org/c/openstack/keystoneauth/+/935764 | |
| 15:18:49 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Remove unused AuthMethod.get_auth_data arguments https://review.opendev.org/c/openstack/keystoneauth/+/935765 | |
| 15:18:50 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Remove unused BaseAuthPlugin.get_auth_ref kwargs https://review.opendev.org/c/openstack/keystoneauth/+/935766 | |
| 15:18:51 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Remove unused _Rescoped.get_unscoped_auth_ref kwargs https://review.opendev.org/c/openstack/keystoneauth/+/935767 | |
| 15:18:52 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Remove unused BaseAuthPlugin.get_headers kwargs https://review.opendev.org/c/openstack/keystoneauth/+/935768 | |
| 15:18:53 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Remove unused BaseAuthPlugin.get_token kwargs https://review.opendev.org/c/openstack/keystoneauth/+/935769 | |
| 15:18:55 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: WIP: typing: Deprecate use of AuthConstructor https://review.opendev.org/c/openstack/keystoneauth/+/935770 | |
| 15:18:57 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: WIP: typing: Removing remaining unused kwargs https://review.opendev.org/c/openstack/keystoneauth/+/935771 | |
| 15:18:59 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: pre-commit: Bump versions https://review.opendev.org/c/openstack/keystoneauth/+/940138 | |
| 15:19:01 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Use builtins https://review.opendev.org/c/openstack/keystoneauth/+/940139 | |
| 18:51:18 | opendevreview | Merged openstack/keystoneauth master: loading.opts: Add 'argparse_envvars' helper https://review.opendev.org/c/openstack/keystoneauth/+/933110 | |
| 18:51:20 | opendevreview | Merged openstack/keystoneauth master: doc: Fix indentation https://review.opendev.org/c/openstack/keystoneauth/+/933111 | |
| 19:01:35 | opendevreview | Merged openstack/keystoneauth master: docs: Rework plugin-options doc https://review.opendev.org/c/openstack/keystoneauth/+/933112 | |
| 19:01:37 | opendevreview | Merged openstack/keystoneauth master: loading: Add blurb for most plugins https://review.opendev.org/c/openstack/keystoneauth/+/933113 | |
| 19:01:38 | opendevreview | Merged openstack/keystoneauth master: docs: Document CLI options, envvars https://review.opendev.org/c/openstack/keystoneauth/+/933114 | |
| #openstack-sdks - 2025-01-26 | |||
| 10:07:53 | opendevreview | Ivan Anfimov proposed openstack/python-openstackclient master: Update README for use python3 https://review.opendev.org/c/openstack/python-openstackclient/+/939769 | |
| 11:25:15 | opendevreview | Ivan Anfimov proposed openstack/python-openstackclient master: Update README for use python3 https://review.opendev.org/c/openstack/python-openstackclient/+/939769 | |
| 11:26:19 | opendevreview | Ivan Anfimov proposed openstack/python-openstackclient master: Update README for use python3 https://review.opendev.org/c/openstack/python-openstackclient/+/939769 | |
| 11:27:14 | opendevreview | Ivan Anfimov proposed openstack/python-openstackclient master: Update README for use python3 https://review.opendev.org/c/openstack/python-openstackclient/+/939769 | |
| #openstack-sdks - 2025-01-27 | |||
| 22:03:32 | opendevreview | Merged openstack/ansible-collections-openstack master: Add the object_containers_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/923334 | |
| 22:45:06 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: identity: Add `--no-region` for limits and registered limits https://review.opendev.org/c/openstack/python-openstackclient/+/940274 | |
| 22:46:04 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: identity: Add `--no-region` for limits and registered limits https://review.opendev.org/c/openstack/python-openstackclient/+/940274 | |
| #openstack-sdks - 2025-01-28 | |||
| 16:51:56 | M0weng[m] | stephenfin: I just realized SetRegisteredLimit also had the `--region None` behavior; would a `--no-region` option be useful there, or should I just deprecate the behavior? I can imagine creating a registered limit with a region, and then wanting to set the region to none. | |
| 16:54:23 | stephenfin | M0weng[m]: What happens if you call 'registered limit set' *without* a '--region' argument? | |
| 16:55:38 | stephenfin | My theory is that it will unset the region | |
| 16:56:07 | stephenfin | Actually, no, this is using keystoneclient. So it will currently do nothing since that filters out None values iirc | |
| 16:57:21 | stephenfin | M0weng[m]: Assuming that's the case, a '--no-region' value would be useful, but only once we're using an SDK that doesn't strip None values (i.e. after your patch openstacksdk migrating us to SDK). Until then, we should just log about '--region None' being deprecated for removal | |
| 16:57:34 | M0weng[m] | 's pace | |
| 16:57:34 | M0weng[m] | My devstack is moving at a turtle | |
| 16:57:42 | M0weng[m] | But yes I imagine it wouldn't change it | |
| 16:57:50 | stephenfin | Check your available disk space on the VM | |
| 16:59:13 | stephenfin | (Just in case. I've seen DevStack filling up the disk. Didn't investigate further and just tore it down/rebuilt it) | |
| 16:59:16 | M0weng[m] | I think it's network issues, my wifi's been a bit slow recently + using a VPN | |
| 16:59:21 | stephenfin | ah, fair | |
| 16:59:38 | M0weng[m] | Yep it doesn't change the region if no --region switch is passed. | |
| 17:00:01 | M0weng[m] | Hmm funnily enough, passing --region None doesn't change it to none either...? | |
| 17:01:19 | stephenfin | Yeah, it's a junk option. I'd nearly be inclined to just remove it outright but the potential complaints aren't worth it | |
| 17:01:31 | stephenfin | https://xkcd.com/1172/ | |
| 17:04:15 | M0weng[m] | Ok, I'll add the --no-region option and deprecate the other one :) | |
| 17:06:07 | M0weng[m] | (oops, I mean I'll add it to my SDK patch potentially) | |
| 17:11:05 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Deprecate using `--region None` https://review.opendev.org/c/openstack/python-openstackclient/+/940321 | |
| 17:19:06 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Deprecate `--region None` in limits/registered limits https://review.opendev.org/c/openstack/python-openstackclient/+/940321 | |
| 17:20:15 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 17:31:37 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 21:12:44 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| #openstack-sdks - 2025-01-29 | |||
| 00:21:08 | opendevreview | Merged openstack/openstacksdk master: identity: Add support for endpoint/project associations https://review.opendev.org/c/openstack/openstacksdk/+/934264 | |
| 10:22:50 | stephenfin | TIL keystone IDs are not UUIDs, despite always looking like (hyphen-less) UUIDs 😭 The rebase of the Nova series is going to be fuuuuuun. | |
| 12:23:23 | tkajinam | gtema, hi do you mind reviewing https://review.opendev.org/c/openstack/releases/+/940190 when you have time? | |
| 12:25:04 | gtema | approved tkajinam | |
| 12:25:28 | tkajinam | gtema, thanks ! | |
| 14:24:42 | opendevreview | Maurice Escher proposed openstack/openstacksdk master: cloud floating ip: fix add_ip_list() for single ip https://review.opendev.org/c/openstack/openstacksdk/+/923505 | |
| 14:35:45 | opendevreview | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Fix image import --disallow-failure flag https://review.opendev.org/c/openstack/python-openstackclient/+/940381 | |
| 15:21:08 | opendevreview | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Fix image import --disallow-failure flag https://review.opendev.org/c/openstack/python-openstackclient/+/940381 | |
| #openstack-sdks - 2025-01-30 | |||
| 09:13:04 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: WIP: test Magnum job https://review.opendev.org/c/openstack/ansible-collections-openstack/+/937903 | |
| 21:26:25 | opendevreview | Michael Still proposed openstack/openstacksdk master: Add support for spice-direct console types. https://review.opendev.org/c/openstack/openstacksdk/+/940479 | |
| 21:28:14 | opendevreview | Michael Still proposed openstack/python-openstackclient master: Add support for spice-direct console types. https://review.opendev.org/c/openstack/python-openstackclient/+/940480 | |
| #openstack-sdks - 2025-01-31 | |||
| 08:25:20 | carthaca | Hi, can you review https://review.opendev.org/c/openstack/openstacksdk/+/923505, please? It is only 1 line and at least to me this seemed pretty straightforward :) | |
| 09:46:58 | opendevreview | Stephen Finucane proposed openstack/openstacksdk stable/2024.2: cloud floating ip: fix add_ip_list() for single ip https://review.opendev.org/c/openstack/openstacksdk/+/940501 | |
| 12:47:41 | opendevreview | Merged openstack/openstacksdk master: cloud floating ip: fix add_ip_list() for single ip https://review.opendev.org/c/openstack/openstacksdk/+/923505 | |
| 20:07:11 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Drop overloaded federation service provider schema https://review.opendev.org/c/openstack/codegenerator/+/939584 | |
| 20:07:12 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: fix generate_openapi_docs script shebang https://review.opendev.org/c/openstack/codegenerator/+/940556 | |