| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2024-10-22 | |||
| 10:50:46 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: identity: Remove support for manual OIDC grant type https://review.opendev.org/c/openstack/keystoneauth/+/932983 | |
| 10:50:48 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: identity: Remove use of kwargs https://review.opendev.org/c/openstack/keystoneauth/+/932984 | |
| 10:50:50 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.identity.access https://review.opendev.org/c/openstack/keystoneauth/+/932985 | |
| 10:50:52 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.identity.v2 https://review.opendev.org/c/openstack/keystoneauth/+/932986 | |
| 10:50:54 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: identity: Remove kwarg-generation helpers https://review.opendev.org/c/openstack/keystoneauth/+/932987 | |
| 10:50:56 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.identity.generic https://review.opendev.org/c/openstack/keystoneauth/+/932988 | |
| 10:50:58 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.identity.v3 https://review.opendev.org/c/openstack/keystoneauth/+/932989 | |
| 10:51:00 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.extras (1/2) https://review.opendev.org/c/openstack/keystoneauth/+/932990 | |
| 10:51:02 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.loading.base https://review.opendev.org/c/openstack/keystoneauth/+/932991 | |
| 10:51:04 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.loading.opts https://review.opendev.org/c/openstack/keystoneauth/+/932992 | |
| 10:51:06 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.loading.cli https://review.opendev.org/c/openstack/keystoneauth/+/932993 | |
| 10:51:08 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.loading.conf https://review.opendev.org/c/openstack/keystoneauth/+/932994 | |
| 10:51:10 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.loading.adapter https://review.opendev.org/c/openstack/keystoneauth/+/932995 | |
| 10:51:12 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.loading.session https://review.opendev.org/c/openstack/keystoneauth/+/932996 | |
| 10:51:14 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.loading.identity https://review.opendev.org/c/openstack/keystoneauth/+/932997 | |
| 10:51:16 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.loading._utils https://review.opendev.org/c/openstack/keystoneauth/+/932998 | |
| 10:51:18 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.loading._plugins https://review.opendev.org/c/openstack/keystoneauth/+/932999 | |
| 10:51:20 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.extras (2/2) https://review.opendev.org/c/openstack/keystoneauth/+/933000 | |
| 10:51:22 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Invert module settings https://review.opendev.org/c/openstack/keystoneauth/+/933001 | |
| 10:51:24 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Set remaining 'disallow_*' opts to 'true' https://review.opendev.org/c/openstack/keystoneauth/+/933002 | |
| 10:51:26 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Move configuration to pyproject.toml https://review.opendev.org/c/openstack/keystoneauth/+/933003 | |
| 10:51:28 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: Add py.typed file https://review.opendev.org/c/openstack/keystoneauth/+/933004 | |
| 10:51:30 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Make loaders broadly generic https://review.opendev.org/c/openstack/keystoneauth/+/933005 | |
| 11:13:33 | opendevreview | Simon Hensel proposed openstack/ansible-collections-openstack master: Allow to specify multiple allocation pools when creating a subnet https://review.opendev.org/c/openstack/ansible-collections-openstack/+/912775 | |
| 15:21:12 | opendevreview | Antonia Gaete proposed openstack/python-openstackclient master: identity: Migrate 'trust' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/931694 | |
| #openstack-sdks - 2024-10-23 | |||
| 06:41:45 | opendevreview | Rodolfo Alonso proposed openstack/openstacksdk master: Add method to create network resource tags https://review.opendev.org/c/openstack/openstacksdk/+/927779 | |
| 14:22:36 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: loading.opts: Add 'argparse_envvars' helper https://review.opendev.org/c/openstack/keystoneauth/+/933110 | |
| 14:22:37 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: doc: Fix indentation https://review.opendev.org/c/openstack/keystoneauth/+/933111 | |
| 14:22:38 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: docs: Rework plugin-options doc https://review.opendev.org/c/openstack/keystoneauth/+/933112 | |
| 14:22:39 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: loading: Add blurb for most plugins https://review.opendev.org/c/openstack/keystoneauth/+/933113 | |
| 14:22:40 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: docs: Document CLI options, envvars https://review.opendev.org/c/openstack/keystoneauth/+/933114 | |
| 16:53:52 | opendevreview | Takashi Kajinami proposed openstack/keystoneauth stable/2023.2: Fix "dictionary changed size during iteration" https://review.opendev.org/c/openstack/keystoneauth/+/933135 | |
| 16:54:44 | opendevreview | Takashi Kajinami proposed openstack/keystoneauth stable/2023.1: Fix "dictionary changed size during iteration" https://review.opendev.org/c/openstack/keystoneauth/+/933136 | |
| 18:36:06 | opendevreview | Rosliakov Andrei proposed openstack/openstacksdk master: Add stream argument to image_download https://review.opendev.org/c/openstack/openstacksdk/+/933143 | |
| #openstack-sdks - 2024-10-24 | |||
| 12:09:13 | opendevreview | yatin proposed openstack/openstacksdk stable/2023.2: [Stable Only] Do not pin openstacksdk to master https://review.opendev.org/c/openstack/openstacksdk/+/933278 | |
| 14:35:58 | JayF | gtema: stephenfin: Ironic is about to talk about codegenerator at :40 after the hour https://meetpad.opendev.org/ironic-ptg-october-2024 | |
| 14:36:15 | JayF | adamcarthur5 and I are there to talk about it too, but I know this is a topic y'all are passionate about | |
| 15:04:15 | gtema | JayF: you mean 15:40 UTC? | |
| 15:04:28 | JayF | I meant 25 minutes ago :) | |
| 15:04:34 | JayF | we got there though | |
| 15:04:54 | gtema | ah ok, sorry, was in Keystone meeting | |
| 15:05:31 | JayF | not a problem; tl;dr was +1 to moving forward but insistence on ensuring we have a lint rule or a test to validate the schemas are valid syntax | |
| 15:05:43 | JayF | cardoe felt pretty strongly about that | |
| 15:06:23 | gtema | ok, for the codegenerator the most important thing that there is way how to construct OpenAPI from what you have. It doesn't insist on you applying jsonschema for validation | |
| 15:06:46 | cardoe | I just want us to have a lint for it before merge. | |
| 15:06:58 | cardoe | To ensure it's valid. | |
| 15:11:09 | JayF | gtema: It kinda is in Ironic, simply because our microversion stuff has to be more progmatically readable. Basically this line of changes + the rest of em: https://review.opendev.org/c/openstack/ironic/+/928919 | |
| 15:13:02 | gtema | perfect, again - I do not really care how you do your stuff I just need to be able to programmatically extract info about request, response, parameters of the operation | |
| 15:13:33 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Start building Ironic OpenAPI https://review.opendev.org/c/openstack/codegenerator/+/928664 | |
| 21:22:54 | opendevreview | Thobias Salazar Trevisan proposed openstack/openstacksdk master: Fix missing 'f' prefix in exception message https://review.opendev.org/c/openstack/openstacksdk/+/933375 | |
| #openstack-sdks - 2024-10-25 | |||
| 09:23:23 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Fix redundant domain id lookup https://review.opendev.org/c/openstack/python-openstackclient/+/933403 | |
| 09:29:08 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Fix ignored --user-domain in role assignment list https://review.opendev.org/c/openstack/python-openstackclient/+/933404 | |
| 09:30:07 | tkajinam | tkajinam------- | |
| 09:33:00 | tkajinam | stephenfin, sorry I definitely did something wrong with my previous patch... ^^^ | |
| 09:55:49 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Fix ignored --user-domain in role assignment list https://review.opendev.org/c/openstack/python-openstackclient/+/933404 | |
| 09:56:21 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Fix ignored --user-domain in role assignment list https://review.opendev.org/c/openstack/python-openstackclient/+/933404 | |
| 11:40:01 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Fix ignored --user-domain in role assignment list https://review.opendev.org/c/openstack/python-openstackclient/+/933404 | |
| #openstack-sdks - 2024-10-26 | |||
| 16:08:43 | opendevreview | Takashi Kajinami proposed openstack/openstackclient master: Test more plugins in plugin tests https://review.opendev.org/c/openstack/openstackclient/+/906195 | |
| 16:23:31 | opendevreview | Merged openstack/openstackclient master: Test more plugins in plugin tests https://review.opendev.org/c/openstack/openstackclient/+/906195 | |
| #openstack-sdks - 2024-10-27 | |||
| 12:04:34 | Yosef | Hi, I have been working on this patch: https://review.opendev.org/c/openstack/python-openstackclient/+/932328 | |
| 12:05:06 | Yosef | I think it is missing workflow +1, can somebody check it? | |
| #openstack-sdks - 2024-10-28 | |||
| 10:23:40 | frickler | gtema: stephenfin: can you please check https://review.opendev.org/c/openstack/openstacksdk/+/933278? looks reasonable to me | |
| 10:24:00 | gtema | Ack | |
| 12:26:53 | opendevreview | Merged openstack/openstacksdk stable/2023.2: [Stable Only] Do not pin openstacksdk to master https://review.opendev.org/c/openstack/openstacksdk/+/933278 | |
| 12:34:56 | servagem | Hello, Could someone please review this small patch (https://review.opendev.org/c/openstack/openstacksdk/+/933375) at your convenience? Thank you | |
| #openstack-sdks - 2024-10-29 | |||
| 07:54:55 | tkajinam | hmm something is wrong with log upload but idk how I can debug it without any logs recorded ... https://review.opendev.org/c/openstack/python-openstackclient/+/933404 | |
| 08:10:52 | frickler | tkajinam: there seems to be some issue with our registry, let's move discussion to #opendev (I do see some log with timeout in "Push tag to intermediate registry") | |
| 08:12:04 | tkajinam | frickler, thanks for checking ! ok let me repost it (with a few more details) in #opendev | |
| 11:42:33 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Fix ignored --user-domain in role assignment list https://review.opendev.org/c/openstack/python-openstackclient/+/933404 | |
| 12:02:31 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Fix ignored --user-domain in role assignment list https://review.opendev.org/c/openstack/python-openstackclient/+/933404 | |
| 12:20:16 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Fix ignored --user-domain in role assignment list https://review.opendev.org/c/openstack/python-openstackclient/+/933404 | |
| 13:01:42 | opendevreview | Niklas Schwarz proposed openstack/python-openstackclient master: Prevent additional calls from identity client when searching by the name for a resource. https://review.opendev.org/c/openstack/python-openstackclient/+/933644 | |
| 15:04:10 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Fix test for server shelve https://review.opendev.org/c/openstack/ansible-collections-openstack/+/933657 | |
| 15:04:51 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: DNM: just test latest CI https://review.opendev.org/c/openstack/ansible-collections-openstack/+/933658 | |
| #openstack-sdks - 2024-10-30 | |||
| 10:13:23 | opendevreview | Merged openstack/ansible-collections-openstack master: Fix test for server shelve https://review.opendev.org/c/openstack/ansible-collections-openstack/+/933657 | |
| 13:22:13 | yosef | Hi guys, should I RECHECK this patch? https://review.opendev.org/c/openstack/python-openstackclient/+/932328 it is failed at gate job, I don't think it is related to my changes! | |
| 17:31:17 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Fix identity resource link code https://review.opendev.org/c/openstack/codegenerator/+/933765 | |
| 18:31:34 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Fix identity resource link code https://review.opendev.org/c/openstack/codegenerator/+/933765 | |
| 18:32:14 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Fix identity resource link code https://review.opendev.org/c/openstack/codegenerator/+/933765 | |
| 19:15:36 | opendevreview | Merged openstack/codegenerator master: Start building Ironic OpenAPI https://review.opendev.org/c/openstack/codegenerator/+/928664 | |
| 19:24:03 | stephenfin | yosef: rechecked. It looks like a timeout | |
| 19:52:24 | adamcarthur5 | Let me know if you guys have anything else you would be interested in me doing, I imagine there is more to do than just repeating the change in 928919, but it'll keep me busy for the coming weeks | |
| 19:52:24 | adamcarthur5 | - Continue adding required elements based on the work done in https://review.opendev.org/c/openstack/ironic/+/928919?tab=comments (Do you want me to get CI passing on this? Happy to do that as a quick starter task) | |
| 19:52:24 | adamcarthur5 | - Setup a Ticket/Bug explaining the work + the "openapi" topic that I can reference when doing the required commits | |
| 19:52:24 | adamcarthur5 | I have the Ironic Spec generated from master since it was merged last week, and it seems to be working fine. My plan is: | |
| 19:52:24 | adamcarthur5 | Hey stephenfin and gtema, after talking about getting what you need in Ironic for code-generator at the PTG, I am planning on dedicating a decent chunk of time to it going forward. | |
| 19:52:25 | adamcarthur5 | - | |
| 20:12:06 | gtema | adamcarthur5: sounds great | |
| 20:13:04 | adamcarthur5 | Cool, I will keep in touch with you guys here, and we can put more permanent discussions of work to complete in the bug | |
| 21:23:42 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Fix identity resource link code https://review.opendev.org/c/openstack/codegenerator/+/933765 | |
| 21:27:34 | adamcarthur5 | And gtema would you be interested in me reviewing codegenerator patches from you? More of a way for me to learn/stay up to date with the project than anything else | |
| 21:27:34 | adamcarthur5 | https://bugs.launchpad.net/ironic/+bug/2086121 | |
| 21:31:32 | opendevreview | Merged openstack/python-openstackclient master: remove project from network flavor profile https://review.opendev.org/c/openstack/python-openstackclient/+/932328 | |
| 22:36:10 | gtema | adamcarthur5: sure | |
| 22:51:57 | opendevreview | Kevin Carter proposed openstack/ansible-collections-openstack master: Allow wait: false when auto_ip is false https://review.opendev.org/c/openstack/ansible-collections-openstack/+/905308 | |
| #openstack-sdks - 2024-10-31 | |||
| 09:31:05 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Fix identity resource link code https://review.opendev.org/c/openstack/codegenerator/+/933765 | |
| 11:23:47 | frickler | stephenfin: gtema: there have been multiple sdk job failures now on the reqs bump to latest sdk, so I'm worried that there is an actual regression there, maybe one of you can take a closer look? https://review.opendev.org/c/openstack/requirements/+/932687 | |
| 11:32:18 | frickler | hmm, interestingly no failure in the combined u-c bump, so maybe only bad luck after all https://review.opendev.org/c/openstack/requirements/+/924547 | |
| 11:55:15 | gtema | frickler: ack, looking | |
| 13:38:44 | stephenfin | adamcarthur5: If you could get 928919 passing, that would be super. Alternatively, if you can think of a better approach then please feel free to explore that | |