| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2024-05-30 | |||
| 07:38:48 | mikal | Hey, twice now openstacksdk has been broken for python3.8 by mypy changes. This seems to be happening because there isn't any CI for that python version upstream, despite python 3.8 being in the support matrix for 2024.1. I get that the universe is imperfect, but I am mostly catching these by pure luck in a downstream project at the moment. Apart from playing whackamole when I find them, is there something w | |
| 07:42:43 | opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: Add support for default volume types https://review.opendev.org/c/openstack/openstacksdk/+/920464 | |
| 08:14:52 | frickler | mikal: are you referring to the stable/2024.1 branch or master? and sure you can do something, create reviews adding testing jobs for what you think is missing | |
| 08:15:48 | mikal | Master is definitely broken for python3.8. I need to rehydrate my state on what pythons OpenStack says they support for 2024.2 to be honest. | |
| 08:16:10 | mikal | I think the issue with upstream CI is I'm not sure there's any distro that has python 3.8 in the supported list any more. | |
| 08:16:20 | mikal | I'm using Rocky 9 out of tree to find these issues. | |
| 08:17:29 | frickler | doesn't that have python3.9 by default? in general, support for py3.8 has been dropped, see https://governance.openstack.org/tc/reference/runtimes/2024.2.html | |
| 08:17:42 | frickler | so testing that would need to be specific to sdk/osc | |
| 08:17:54 | mikal | Yeah, just found the same page. | |
| 08:18:07 | mikal | Definitely the error I see states that you need python 3.10+ for the syntax that is being used. | |
| 08:18:30 | mikal | Let me spin up a quick test VM and double check what version of python it has by default. | |
| 08:24:10 | mikal | Sorry, you're right, Rocky 9 is indeed python 3.9. However, that is still too old for this syntax. | |
| 08:35:04 | frickler | so that's certainly a bug then, that should be fixed | |
| 08:36:44 | mikal | Yeah, I am waiting for my CI to finish running before uploading a fix. I just want to make sure it actually works first. | |
| 08:48:39 | opendevreview | Michael Still proposed openstack/openstacksdk master: Use mypy syntax compatible with older pythons. https://review.opendev.org/c/openstack/openstacksdk/+/920814 | |
| 09:04:35 | frickler | gtema: ^^ iirc we've seen more regressions like this earlier. maybe need a mypy py39 job? (cc stephenfin who has voiced interest in also keeping support for py38) | |
| 09:07:11 | gtema | Have I told how I love modern py madness? | |
| 17:54:19 | opendevreview | Antonia Gaete proposed openstack/python-openstackclient master: identity: Migrate 'service' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/906395 | |
| 23:48:03 | M0weng[m] | <stephenfin> "0weng: Took a look at that error..." <- Ahh I see; I'll take a look at that. Should I fix this in the same patch as the SDK migration or make a separate one? | |
| #openstack-sdks - 2024-06-01 | |||
| 12:28:09 | opendevreview | Tomas Rinblad proposed openstack/openstacksdk master: Compute, migrate: Add support for targeting host. https://review.opendev.org/c/openstack/openstacksdk/+/920948 | |
| 16:51:11 | opendevreview | Tomas Rinblad proposed openstack/openstacksdk master: Compute, migrate: Add support for targeting host. https://review.opendev.org/c/openstack/openstacksdk/+/920948 | |
| #openstack-sdks - 2024-06-03 | |||
| 17:14:15 | opendevreview | Antonia Gaete proposed openstack/python-openstackclient master: identity: Migrate 'service' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/906395 | |
| 18:27:23 | opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: Increase interval between volume GET calls https://review.opendev.org/c/openstack/openstacksdk/+/921062 | |
| 19:15:37 | opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: Add support for default volume types https://review.opendev.org/c/openstack/openstacksdk/+/920464 | |
| #openstack-sdks - 2024-06-04 | |||
| 13:36:26 | opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: WIP: Increase interval between volume GET calls https://review.opendev.org/c/openstack/openstacksdk/+/921062 | |
| 13:38:13 | opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: Add support for default volume types https://review.opendev.org/c/openstack/openstacksdk/+/920464 | |
| 13:39:57 | opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: WIP: Increase interval between volume GET calls https://review.opendev.org/c/openstack/openstacksdk/+/921062 | |
| #openstack-sdks - 2024-06-05 | |||
| 07:52:34 | opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: WIP: Increase interval between volume GET calls https://review.opendev.org/c/openstack/openstacksdk/+/921062 | |
| 10:49:03 | dtantsur | TheJulia: mmm, our openstacksdk job fails on RBAC stuff now.. | |
| 10:49:30 | dtantsur | I mean, the functional one | |
| 14:16:45 | opendevreview | Merged openstack/openstacksdk master: baremetal: Decode 'config_drive' argument to 'set_provision_state' https://review.opendev.org/c/openstack/openstacksdk/+/889690 | |
| 15:00:52 | TheJulia | dtantsur: if you can point me to, happy to take a look | |
| 15:25:38 | dtantsur | TheJulia: https://zuul.opendev.org/t/openstack/build/62accb8ae9ce47dabdcbfc2846f9e93c caught my attention | |
| 15:26:28 | TheJulia | lets put a bug into launchpad and tag ironic on it | |
| 16:24:14 | opendevreview | Antonia Gaete proposed openstack/python-openstackclient master: identity: Migrate 'service' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/906395 | |
| 18:42:40 | opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: [func test] Fix race between attachment delete and server delete https://review.opendev.org/c/openstack/openstacksdk/+/921062 | |
| 20:50:28 | opendevreview | Oria Weng proposed openstack/openstacksdk master: Identity: Add support for `options` property for roles https://review.opendev.org/c/openstack/openstacksdk/+/921411 | |
| 21:02:19 | M0weng[m] | stephenfin: Quick question about the role commands - should `inherited` no longer be an allowable argument for the `role add` commands in openstackclient then? | |
| 21:13:18 | opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: [func test] Fix race between attachment delete and server delete https://review.opendev.org/c/openstack/openstacksdk/+/921062 | |
| 22:47:41 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'role assignment' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/910664 | |
| #openstack-sdks - 2024-06-06 | |||
| 08:06:05 | opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: [func test] Fix race between attachment delete and server delete https://review.opendev.org/c/openstack/openstacksdk/+/921062 | |
| 18:00:32 | opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: title : Implemented snapshot-related features of the stack. https://review.opendev.org/c/openstack/openstacksdk/+/921468 | |
| 18:02:00 | opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: Implemented snapshot-related features of the stack. https://review.opendev.org/c/openstack/openstacksdk/+/921468 | |
| 18:03:27 | opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: Implemented snapshot-related features of the stack. https://review.opendev.org/c/openstack/openstacksdk/+/921469 | |
| 18:04:31 | opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: Implemented snapshot-related features of the stack. https://review.opendev.org/c/openstack/openstacksdk/+/921469 | |
| 18:08:32 | opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: Implemented snapshot-related features of the stack. https://review.opendev.org/c/openstack/openstacksdk/+/921471 | |
| 18:19:20 | opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: Implemented snapshot-related features of the stack. https://review.opendev.org/c/openstack/openstacksdk/+/921471 | |
| #openstack-sdks - 2024-06-07 | |||
| 00:00:54 | opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: Implemented snapshot-related features of the stack. https://review.opendev.org/c/openstack/openstacksdk/+/921471 | |
| 17:24:48 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Prepare regeneration of object-store https://review.opendev.org/c/openstack/codegenerator/+/921547 | |
| 17:27:27 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Update tool scripts https://review.opendev.org/c/openstack/codegenerator/+/921548 | |
| 17:58:55 | opendevreview | Merged openstack/openstacksdk master: [func test] Fix race between attachment delete and server delete https://review.opendev.org/c/openstack/openstacksdk/+/921062 | |
| #openstack-sdks - 2024-06-08 | |||
| 05:21:36 | opendevreview | Merged openstack/codegenerator master: Update tool scripts https://review.opendev.org/c/openstack/codegenerator/+/921548 | |
| 07:46:14 | ZonC | Hi, Any chance that anyone could take a look at this change request? https://review.opendev.org/c/openstack/openstacksdk/+/920948 :) | |
| #openstack-sdks - 2024-06-09 | |||
| 02:57:18 | opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: Implemented snapshot-related features of the stack. https://review.opendev.org/c/openstack/openstacksdk/+/921471 | |
| 03:07:18 | opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: Implemented snapshot-related features of the stack. https://review.opendev.org/c/openstack/openstacksdk/+/921471 | |
| #openstack-sdks - 2024-06-10 | |||
| 14:52:35 | whoami-rajat | stephenfin, hey, can you take another look at this patch? https://review.opendev.org/c/openstack/python-openstackclient/+/919820 | |
| 14:53:39 | stephenfin | whoami-rajat: Ah, I had a draft comment but never submitted it. Done now | |
| 14:58:30 | whoami-rajat | stephenfin, tbh, I'm not sure what the difference is between % and comma (,) in oslo logging but i was using similar code for snapshot unmanage (being proposed first) and volume unmanage and in snapshot delete % is used https://github.com/openstack/python-openstackclient/blob/master/openstackclient/volume/v2/volume_snapshot.py#L193-L198 | |
| 14:59:41 | stephenfin | whoami-rajat: https://docs.python.org/3/howto/logging.html#optimization | |
| 15:00:54 | stephenfin | tldr: if you pass the arguments separate rather than with %, the arguments are deferred until if/when they're needed. I was pretty sure hacking had a check for that but maybe it's not enabled by default | |
| 15:02:44 | stephenfin | Ah, yes, 'H904' which is disabled by default | |
| 15:10:56 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add support for volume unmanage https://review.opendev.org/c/openstack/python-openstackclient/+/919820 | |
| 15:11:42 | whoami-rajat | stephenfin, ack, understood now, updated ^ | |
| 15:13:18 | stephenfin | cool, one comment but +2 | |
| 15:18:41 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add support for volume unmanage https://review.opendev.org/c/openstack/python-openstackclient/+/919820 | |
| 15:19:15 | whoami-rajat | stephenfin, yeah, my bad, updated now | |
| 15:44:17 | opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: Implemented snapshot-related features of the stack. https://review.opendev.org/c/openstack/openstacksdk/+/921471 | |
| 16:56:59 | opendevreview | Antonia Gaete proposed openstack/python-openstackclient master: identity: Migrate 'service' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/906395 | |
| 23:53:35 | M0weng[m] | stephenfin: Quick question about the role commands in openstackclient - should --inherited no longer be an allowable argument for the role add commands since the option isn't passed in to SDK? | |
| #openstack-sdks - 2024-06-11 | |||
| 00:15:11 | opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: Implemented snapshot-related features of the stack. https://review.opendev.org/c/openstack/openstacksdk/+/921471 | |
| 11:26:18 | opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: Implemented snapshot-related features of the stack. https://review.opendev.org/c/openstack/openstacksdk/+/921471 | |
| 11:51:28 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: network: Migrate port list to compute SDK client https://review.opendev.org/c/openstack/python-openstackclient/+/918782 | |
| 11:51:28 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate tests for ShowServer to SDK objects https://review.opendev.org/c/openstack/python-openstackclient/+/879073 | |
| 11:51:29 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate 'host set' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918784 | |
| 11:51:29 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate agent commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918783 | |
| 11:51:30 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: docs: Remove references to novaclient https://review.opendev.org/c/openstack/python-openstackclient/+/918786 | |
| 11:51:30 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate remaining tests to SDK objects https://review.opendev.org/c/openstack/python-openstackclient/+/918785 | |
| 11:51:31 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Add v3-specific volume backup module https://review.opendev.org/c/openstack/python-openstackclient/+/918787 | |
| 11:51:32 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: add v3-specific volume type module https://review.opendev.org/c/openstack/python-openstackclient/+/918789 | |
| 11:51:32 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Add v3-specific volume module https://review.opendev.org/c/openstack/python-openstackclient/+/918788 | |
| 11:51:34 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Add ability to configure fake server API version https://review.opendev.org/c/openstack/python-openstackclient/+/918791 | |
| 11:51:34 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Add v3-specific volume transfer module https://review.opendev.org/c/openstack/python-openstackclient/+/918790 | |
| 11:51:36 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Migrate volume attachment commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/888234 | |
| 11:51:36 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Migrate to 'set_xxx_api_version' helpers https://review.opendev.org/c/openstack/python-openstackclient/+/918792 | |
| 11:51:38 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: common: Migrate 'limits show' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/888673 | |
| 11:51:38 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Migrate 'volume list' command to compute SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918793 | |
| 11:51:40 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate 'server migrate' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918795 | |
| 11:51:40 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate 'server add/remove security group' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918794 | |
| 11:51:42 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Always use SDK client to display server https://review.opendev.org/c/openstack/python-openstackclient/+/918797 | |
| 11:51:42 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate 'server set', 'server unset' commands https://review.opendev.org/c/openstack/python-openstackclient/+/918796 | |
| 11:51:44 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate 'server rebuild' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918798 | |
| 11:51:44 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Avoid third API call during 'server show' https://review.opendev.org/c/openstack/python-openstackclient/+/918800 | |
| 11:51:46 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate 'server evacuate' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918801 | |
| 11:51:46 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate remaining server actions to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918799 | |
| 11:51:48 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: network: Replace use of in-tree API client https://review.opendev.org/c/openstack/python-openstackclient/+/919890 | |
| 11:51:48 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate 'server create' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918802 | |
| 11:51:50 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Remove references to novaclient methods https://review.opendev.org/c/openstack/python-openstackclient/+/919892 | |
| 11:51:50 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: WIP: common: Migrate 'quota *' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/919891 | |
| 11:51:52 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: WIP: Remove TestServer base class https://review.opendev.org/c/openstack/python-openstackclient/+/919893 | |
| 11:51:52 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Remove python-novaclient https://review.opendev.org/c/openstack/python-openstackclient/+/918803 | |