| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2023-11-15 | |||
| 11:33:49 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Address bug in shelve offload logic https://review.opendev.org/c/openstack/python-openstackclient/+/901019 | |
| 11:33:50 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Remove unnecessary file https://review.opendev.org/c/openstack/python-openstackclient/+/901021 | |
| 11:33:50 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Use CommandError, not SystemExit, to exit https://review.opendev.org/c/openstack/python-openstackclient/+/901020 | |
| 11:33:51 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: parseactions: Use ArgumentError, not ArgumentTypeError https://review.opendev.org/c/openstack/python-openstackclient/+/901022 | |
| 11:34:16 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: parseactions: Use ArgumentError, not ArgumentTypeError https://review.opendev.org/c/openstack/osc-lib/+/836204 | |
| 11:41:19 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: test: Ignore 'OS_' environment variables https://review.opendev.org/c/openstack/python-openstackclient/+/900918 | |
| 11:54:53 | opendevreview | Merged openstack/osc-lib master: Blacken code https://review.opendev.org/c/openstack/osc-lib/+/893263 | |
| 12:29:48 | opendevreview | Merged openstack/osc-lib master: pre-commit: Integrate black https://review.opendev.org/c/openstack/osc-lib/+/893264 | |
| 12:30:04 | opendevreview | Merged openstack/osc-lib master: Ignore black changes https://review.opendev.org/c/openstack/osc-lib/+/893265 | |
| 12:30:06 | opendevreview | Merged openstack/osc-lib master: tox: Use pre-commit for style checks https://review.opendev.org/c/openstack/osc-lib/+/893266 | |
| 12:30:07 | opendevreview | Merged openstack/osc-lib master: Remove lower-constraints.txt https://review.opendev.org/c/openstack/osc-lib/+/893267 | |
| 17:01:30 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Check for DHCP agents first in DHCP test https://review.opendev.org/c/openstack/python-openstackclient/+/901054 | |
| 17:03:44 | diablo_rojo | stephenfin: gtema coming to the meeting? | |
| 17:03:55 | stephenfin | yup, zoom is being a pain | |
| 17:04:26 | diablo_rojo | stephenfin: its totally one of those days | |
| 17:04:32 | gtema | yupp, sorry | |
| 17:24:27 | stephenfin | gtema: You haven't pushed the updates to any of that fake generator stuff yet, I assume? | |
| 17:24:41 | stephenfin | I've seen the previous stuff but nothing new recently | |
| 17:24:42 | gtema | nope | |
| 17:25:30 | gtema | I am working hard on getting openapi generated from sources and it 1) pulls lot of energy 2) requires small changes into the generators which I group for later | |
| 17:25:48 | stephenfin | ack okay, I'll wait and watch in that case | |
| 19:46:01 | M0weng[m] | Is it possible to use is_extension_enabled() from a classmethod rather than with self? (Trying to skip the meter_rule test if the metering extension isn't enabled.) | |
| #openstack-sdks - 2023-11-16 | |||
| 10:21:50 | stephenfin | M0weng[m]: You can only use other classmethods and staticmethod (plus external functions, obviously) from classmethods, so if 'is_extension_enabled' is a classmethod then you can use it from another classmethod | |
| 10:22:32 | stephenfin | M0weng[m]: I should rephrase that: classmethods are only allowed to call other classmethods and staticmethods. They can't use instance methods. | |
| 16:13:41 | opendevreview | Merged openstack/os-service-types master: Add Python 3.8 and 3.9 to supported runtimes https://review.opendev.org/c/openstack/os-service-types/+/843266 | |
| 18:26:03 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: WIP: Implement auto-code generation https://review.opendev.org/c/openstack/openstacksdk/+/882326 | |
| 18:27:21 | M0weng[m] | stephenfin: Thanks! I didn't realize there were two different `is_extension_enabled()`s; I was looking at the non-classmethod one by mistake, no wonder things didn't seem to make sense haha | |
| 19:38:01 | frickler | gtema: regarding the sdk cache issue, looking at the implementation it seems that there is no file locking or atomic updates happening, so the errors that yatin found seems very plausible to me https://github.com/jaraco/keyrings.alt/blob/main/keyrings/alt/file_base.py | |
| 19:38:31 | frickler | not sure if other backends would work better or maybe the whole library isn't suited for this usecase | |
| 19:40:30 | gtema | frickler: from the failed jobs I haven't seen a single one where cache seemed like an issue, there were always unrelated issues. So I would be interested to see whether after disabling it failure rate decrease | |
| 19:42:03 | frickler | gtema: did you look at the cache file contents that were posted in the bug report? those looked pretty convincing to me | |
| 19:43:41 | gtema | Even corrupting Cache content SDK will renew it. On the other side in most of failed jobs keystone log was full of db issues | |
| 19:44:08 | gtema | And that is not related to osc token. It may be exactly causing that | |
| 19:45:00 | gtema | I haven't looked into updates to the bug, LP doesn't send me notifications (need to look where to enable that) | |
| 19:45:06 | frickler | the library wants to read the cache file for updates, so if the read fails, it cannot update or delete the cache entry. at least that's my reading of the code above | |
| 19:46:02 | gtema | Pls try to use osc with broken cache state. Historically for me it was working fine | |
| 19:46:11 | gtema | Haven't checked recently though | |
| 19:46:51 | frickler | ok, I can try that tomorrow | |
| 19:51:48 | M0weng[m] | I'm trying to submit a patch using `git review` but it says I have the wrong email set. I changed the email to the one registered with gerrit using `git config user.email <email>` and re-ran `git review -s`, but it's still trying to use the incorrect email. | |
| 19:52:51 | M0weng[m] | * <email>` and `git config --global gitreview.email <email>` and re-ran `git | |
| 19:53:26 | gtema | 0weng, use sure it tries to use wrong email or it is just a mismatch to the account you setup in Gerrit? | |
| 19:53:47 | gtema | s/Use/you | |
| 19:53:56 | frickler | M0weng[m]: please show the full error on paste.opendev.org | |
| 19:59:21 | frickler | gtema: if I mangle the cache file to contain two entries with identical key like in https://bugs.launchpad.net/devstack/+bug/2042943/comments/11 , I'm getting the same error locally | |
| 20:00:11 | frickler | I also get a different error, but similarly corrupted cache file, pretty fast when running just "openstack token issue" for two clouds in multiple parallel invocations? | |
| 20:05:01 | gtema | Hmm, ok, will think about it. This "file" backend is the only thing which work in real detached mode. Maybe we should drop that completely, I never was really convinced in that lib | |
| #openstack-sdks - 2023-11-17 | |||
| 10:48:33 | opendevreview | Mridula Joshi proposed openstack/python-openstackclient master: Adds command ``image metadef object delete`` https://review.opendev.org/c/openstack/python-openstackclient/+/893310 | |
| 21:13:36 | M0weng[m] | gtema frickler : Never mind, I figured it out - I had to manually edit the author on my existing commit (setting the email in the config only sets the address for future commits). | |
| 23:16:41 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: tests: Handle missing extensions in network tests https://review.opendev.org/c/openstack/python-openstackclient/+/901340 | |
| 23:35:11 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: tests: Handle missing extensions in network tests https://review.opendev.org/c/openstack/python-openstackclient/+/901340 | |
| 23:44:24 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: tests: Handle missing extensions in network tests https://review.opendev.org/c/openstack/python-openstackclient/+/901340 | |
| #openstack-sdks - 2023-11-18 | |||
| 00:42:44 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: tests: Handle missing extensions in network tests https://review.opendev.org/c/openstack/python-openstackclient/+/901340 | |
| #openstack-sdks - 2023-11-20 | |||
| 10:24:09 | opendevreview | Mridula Joshi proposed openstack/openstacksdk master: Adding support for image upload https://review.opendev.org/c/openstack/openstacksdk/+/881939 | |
| 12:35:39 | opendevreview | Rajesh Tailor proposed openstack/python-openstackclient master: [codespell] fix typos in doc,tests and help messages https://review.opendev.org/c/openstack/python-openstackclient/+/901458 | |
| 18:21:41 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: tests: Handle missing extensions in network tests https://review.opendev.org/c/openstack/python-openstackclient/+/901340 | |
| 18:42:40 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: tests: Check for DHCP agents first in DHCP test https://review.opendev.org/c/openstack/python-openstackclient/+/901054 | |
| 18:48:17 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: tests: Handle missing extensions in network tests https://review.opendev.org/c/openstack/python-openstackclient/+/901340 | |
| #openstack-sdks - 2023-11-21 | |||
| 06:08:00 | opendevreview | Rajesh Tailor proposed openstack/python-openstackclient master: [codespell] fix typos in doc,tests and help messages https://review.opendev.org/c/openstack/python-openstackclient/+/901458 | |
| 10:31:25 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Check for DHCP agents first in DHCP test https://review.opendev.org/c/openstack/python-openstackclient/+/901054 | |
| 10:31:26 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Handle missing extensions in network tests https://review.opendev.org/c/openstack/python-openstackclient/+/901340 | |
| 16:51:30 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: WIP: Implement auto-code generation https://review.opendev.org/c/openstack/openstacksdk/+/882326 | |
| 17:51:40 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: tests: Handle missing extensions in network tests https://review.opendev.org/c/openstack/python-openstackclient/+/901340 | |
| #openstack-sdks - 2023-11-22 | |||
| 08:21:25 | frickler | "Neutron is very special" is a good summary for a lot of things, /me likes | |
| 10:34:34 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume snapshot unmanage command https://review.opendev.org/c/openstack/python-openstackclient/+/894634 | |
| 10:58:35 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume snapshot unmanage command https://review.opendev.org/c/openstack/python-openstackclient/+/894634 | |
| 11:05:27 | opendevreview | Merged openstack/python-openstackclient master: Adds command ``image metadef object delete`` https://review.opendev.org/c/openstack/python-openstackclient/+/893310 | |
| 12:20:47 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Migrate volume snapshot commands https://review.opendev.org/c/openstack/python-openstackclient/+/894824 | |
| 12:20:48 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add support for snapshot parameters https://review.opendev.org/c/openstack/python-openstackclient/+/894939 | |
| 13:36:18 | opendevreview | Mridula Joshi proposed openstack/openstacksdk master: Adding SDK support for ``glance md-namespace-objects-delete`` https://review.opendev.org/c/openstack/openstacksdk/+/901671 | |
| 13:46:43 | opendevreview | Merged openstack/python-openstackclient master: tests: Check for DHCP agents first in DHCP test https://review.opendev.org/c/openstack/python-openstackclient/+/901054 | |
| #openstack-sdks - 2023-11-23 | |||
| 15:11:09 | opendevreview | Florian Streibelt proposed openstack/python-openstackclient master: enable clearing of dns_domain on a network by setting to empty string https://review.opendev.org/c/openstack/python-openstackclient/+/901765 | |
| 15:43:14 | opendevreview | Florian Streibelt proposed openstack/python-openstackclient master: Fix clearing of dns_domain on a network by setting to empty string https://review.opendev.org/c/openstack/python-openstackclient/+/901765 | |
| #openstack-sdks - 2023-11-24 | |||
| 07:37:57 | opendevreview | Mridula Joshi proposed openstack/openstacksdk master: Adding SDK support for ``glance md-namespace-objects-delete`` https://review.opendev.org/c/openstack/openstacksdk/+/901671 | |
| 07:40:34 | opendevreview | Mridula Joshi proposed openstack/openstacksdk master: Adding SDK support for ``glance md-namespace-objects-delete`` https://review.opendev.org/c/openstack/openstacksdk/+/901671 | |
| 11:40:51 | opendevreview | Florian Streibelt proposed openstack/python-openstackclient master: Fix clearing of dns_domain and description on a network by setting to empty strings https://review.opendev.org/c/openstack/python-openstackclient/+/901765 | |
| 15:09:35 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: WIP: Implement auto-code generation https://review.opendev.org/c/openstack/openstacksdk/+/882326 | |
| 15:19:33 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: WIP: Implement auto-code generation https://review.opendev.org/c/openstack/openstacksdk/+/882326 | |
| #openstack-sdks - 2023-11-28 | |||
| 09:07:49 | lajoskatona | gtema: Hi , I would like to ask about your OpenAPI work (https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/BU5JH7FJ5VPS75QWPW47IYSZOFDI5R2W/ ) | |
| 09:08:15 | lajoskatona | gtema: I added this topic to today's Neutron meeting | |
| 09:08:37 | lajoskatona | to have some more attention. | |
| 09:09:35 | lajoskatona | gtema: do you think that as Neutron team can somehow help this effort? Or perhaps from the other perspective: how users can benefit from it and how we can make this experience better and more visible? | |
| 09:15:49 | gtema | lajoskatona: I could participate probably in the meeting to answer all questions. When is it? | |
| 09:16:10 | gtema | generally yes, there is both how Neutron team can help me and how users can benefit from it | |
| 09:24:14 | lajoskatona | gtema: the meeting is from 1400UTC, I added the topic to the ondemand agenda, as that is at the end of the meeting usually I can ping you | |
| 09:24:31 | lajoskatona | gtema: thanks for your time | |
| 09:24:48 | gtema | perfect, thanks | |
| 14:49:24 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: RFC: Statically typed resources https://review.opendev.org/c/openstack/openstacksdk/+/902087 | |
| 14:51:01 | stephenfin | gtema: Think you might be interested in ^. It could work quite nicely with your OpenAPI stuff, either as a source or (more likely now) as an output of the OpenAPI schemas | |
| 14:51:13 | stephenfin | super WIP! | |
| 14:59:02 | gtema | stephenfin - if you end up in a better design of individual resources we can definitely generate it new style from openapi | |
| 14:59:11 | gtema | that is what I was roughly thinking of | |
| 15:00:15 | gtema | I actually thought of starting using pydantic for resources and generate as a code all the parameter mapping (for every api call, since the dynamics of attributes_iterator are too expensive | |
| 15:01:25 | stephenfin | Yeah, I think we'd be able to do that with the above example, since the base class only describes the resource while the nested classes describe the various request parameters (CRUD) | |
| 15:02:01 | stephenfin | It's just a case of figuring out a way to (a) implement it and (b) have a gradual transition that doesn't necessitate us rewriting everything at once | |
| 15:02:21 | stephenfin | unless I can learn how to use codepilot and train it to do that for me | |
| 15:02:23 | stephenfin | :) | |
| 15:02:39 | gtema | :) | |
| 15:03:25 | gtema | I think it should not be a big deal even having multiple iterations of the regeneration (step-by-step) | |
| 15:04:20 | gtema | I now already have experience (lol) of using inspect.getcode/obj) and looking at the code | |
| 15:04:46 | gtema | so generally we could gradually regenerate code by slowly adding bits into the existing code | |