| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2023-08-28 | |||
| 17:06:49 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: docs: Add exception documentation https://review.opendev.org/c/openstack/openstacksdk/+/891689 | |
| 17:06:50 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: tox: Add coverage docs builder https://review.opendev.org/c/openstack/openstacksdk/+/891690 | |
| 17:08:23 | stephenfin | gtema: It would be good to get those doc patches in also, but they're not urgent | |
| 17:08:34 | stephenfin | they are, however, quite useful | |
| 17:08:46 | stephenfin | ...if I do say so myself :) | |
| 17:08:50 | stephenfin | andrewbogott_: looking | |
| 17:08:56 | andrewbogott_ | thank you! | |
| 17:10:13 | stephenfin | Okay, so suggestion is that environment variables should trump cloud variables. This is complicated because of how much the options can potentially layer over each other | |
| 17:10:28 | andrewbogott_ | Can you give me an example? | |
| 17:10:36 | andrewbogott_ | (Or, maybe better to discuss on the task) | |
| 17:12:54 | andrewbogott_ | mostly I want the --os-<whatever> args to trump, but maybe in code that's the same thing as the env variables | |
| 17:13:04 | stephenfin | auth types would be the first thing that jumps to mind because it's been a source of bugs | |
| 17:13:29 | andrewbogott_ | I'm not sure I know what 'auth types' means | |
| 17:14:07 | andrewbogott_ | you mean like admin/public/internal? | |
| 17:14:07 | stephenfin | ah, the 'auth_types' setting in cloud.conf / 'OS_AUTH_TYPE' envvar lets us determine which keystone authentication type to use | |
| 17:14:22 | stephenfin | v3password, v3token, v3applicationcredential etc. | |
| 17:14:28 | andrewbogott_ | oh, I see | |
| 17:14:33 | stephenfin | Setting 'clouds.$cloud.auth_type' completely changes what we look for in 'clouds.$cloud.auth' | |
| 17:15:36 | stephenfin | iirc if it's 'auth_type=v3applicationcredential' but a user sets 'OS_PASSWORD', then we try passing passwords also | |
| 17:16:06 | andrewbogott_ | huh... that seems wrong to me but probably you've already had that conversation :) | |
| 17:16:31 | stephenfin | It is. Unfortunately keystoneauth is a rats nest :) | |
| 17:16:57 | andrewbogott_ | That I know from experience | |
| 17:17:27 | opendevreview | SongSuheon proposed openstack/openstacksdk master: Implement heat 'stack event list' https://review.opendev.org/c/openstack/openstacksdk/+/892836 | |
| 17:17:29 | stephenfin | however, that's kind of tangential to what you're asking | |
| 17:17:36 | andrewbogott_ | So what instead of saying 'env variables trump clouds variables' we say 'select env variables trump clouds variables' | |
| 17:17:53 | andrewbogott_ | and start with project/domain being part of that select | |
| 17:19:45 | andrewbogott_ | Sorry, that was confusing, I'll try again: What if the task is "Allow CLI and env to override the project specified in clouds.yaml"? That would fix /my/ workflows I think. | |
| 17:20:26 | andrewbogott_ | hm. The fact that the same variable OS_PROJECT is used for auth and also used to affect what the command does seems broken either way :( | |
| 17:21:03 | stephenfin | what do you mean? | |
| 17:22:29 | stephenfin | btw, the commands that allow you to specify '--project' rely on server-side support. OSC is merely exposing that. I would guess that those will not be usable by users with standard project-scoped tokens in the future but I can't say for sure | |
| 17:22:46 | andrewbogott_ | Eh, I guess that isn't really right, if you don't have auth in a project you shouldn't be able to do things there anyway. | |
| 17:23:09 | stephenfin | '--os-project' is the keystone thing | |
| 17:24:11 | andrewbogott_ | sorry, had to answer the phone and got confused :) | |
| 17:24:46 | opendevreview | SongSuheon proposed openstack/openstacksdk master: Implement heat 'stack event list' https://review.opendev.org/c/openstack/openstacksdk/+/892836 | |
| 17:24:52 | stephenfin | I have no issues with allowing overriding of clouds.yaml config with CLI args and env vars | |
| 17:24:54 | andrewbogott_ | But yeah, I realize that the --project thing is only selectively implemented for some commands. | |
| 17:25:14 | andrewbogott_ | stephenfin: ok then :) I will try to write a patch, and see how lost I get. | |
| 17:25:29 | andrewbogott_ | Do you think the change should be for /all/ CLI args and env vars, or only for a limited list? | |
| 17:25:35 | stephenfin | I would just ask that we provide a mechanism to disable the env var aspect or set the env var prefix to something other than 'OS_' (if that doesn't exist already) | |
| 17:26:04 | andrewbogott_ | hm... | |
| 17:26:17 | andrewbogott_ | a mechanism other than "Don't set that in your env if you don't want it in your env"? | |
| 17:26:48 | gtema | I was thinking quite some time about that. I think what should always win is "--os-XX" argument. | |
| 17:26:59 | gtema | I would personally even kill the whole env part as such | |
| 17:27:13 | gtema | this is simply terrible stuff from my pov (OS_CLOUD is the only exception) | |
| 17:27:27 | stephenfin | Yes, I know it's ridiculous _but_ we've had bugs in some k8s components because of this (Gophercloud already behaves the way you're suggesting) | |
| 17:27:45 | andrewbogott_ | Yeah, I agree that ideally clouds.yaml is a full substitute for ready-made env files. But that might not be a simple migration path. | |
| 17:28:48 | andrewbogott_ | Some days you're the guy wishing that there weren't existing silly workflows, and some days you're the guy complaining about your existing silly workflow being broken. I guess today I'm the second guy :( | |
| 17:30:25 | gtema | heh, maybe. I the guy not using ENVs in OpenStack context at all and happy | |
| 17:30:58 | andrewbogott_ | that sounds nice | |
| 17:32:02 | stephenfin | okay, no rational attached but here's on example https://github.com/kubernetes/cloud-provider-openstack/pull/733/files | |
| 17:32:21 | stephenfin | See the `EnvPrefix` attribute in `pkg/cloudprovider/providers/openstack/openstack.go` | |
| 17:33:13 | stephenfin | gtema: Alas, I am afraid we are stuck with environment variables for the long-term. TripleO still deploys rc files everywhere, and internally I note all our QE and many field engineers still use them | |
| 17:33:47 | gtema | I know, it is just my opinion that it should have not been existing | |
| 17:34:00 | stephenfin | on that we can agree | |
| 17:34:20 | gtema | but wrt CPO - another param to disable/enable ENVs sounds even more crazy | |
| 17:34:20 | stephenfin | the mistakes of (project) youth | |
| 17:35:02 | gtema | lets see whether the new OSC (;-) can get this addressed | |
| 17:35:35 | andrewbogott_ | Thank you for your thoughts! I will work on a strawman/minimal patch (assuming that's even possible) and then we can see if we want to get more ambitious. | |
| 18:07:45 | opendevreview | Suyeon Cha proposed openstack/openstacksdk master: reset_state, force_delete for Share, ShareSnapshot https://review.opendev.org/c/openstack/openstacksdk/+/888311 | |
| 18:43:26 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: [WIP] Add OpenAPI invocation interface https://review.opendev.org/c/openstack/openstacksdk/+/892161 | |
| 19:27:37 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: block storage: Add query string params for many APIs https://review.opendev.org/c/openstack/openstacksdk/+/892974 | |
| 19:42:25 | opendevreview | Pavlo Shchelokovskyy proposed openstack/cliff master: Autofit table output if stdout is a tty https://review.opendev.org/c/openstack/cliff/+/892991 | |
| 20:37:50 | chris218 | Hi again so when I try to stop server through conn.compute.start_server(server) it works but when trying to do it with server.start(conn) it errors with AttributeError 'Connection' object has no attribute 'default_microversion' | |
| 21:45:46 | opendevreview | Merged openstack/openstacksdk master: docs: Add missing docs for identity resources https://review.opendev.org/c/openstack/openstacksdk/+/891682 | |
| 21:48:39 | opendevreview | Merged openstack/openstacksdk master: docs: Add missing docs for compute resources https://review.opendev.org/c/openstack/openstacksdk/+/891683 | |
| 21:56:48 | opendevreview | Merged openstack/openstacksdk master: docs: Add missing docs for block storage resources https://review.opendev.org/c/openstack/openstacksdk/+/891684 | |
| 22:15:55 | chris218 | also wanted to note that being able to use OpenAPI spec for openstack sounds supper exciting kudos to you guys :) | |
| 23:15:37 | opendevreview | Merged openstack/openstacksdk master: openstack.format: Remove 'serialize' classmethod https://review.opendev.org/c/openstack/openstacksdk/+/889983 | |
| 23:15:39 | opendevreview | Merged openstack/openstacksdk master: mypy: Address issues with top-level files https://review.opendev.org/c/openstack/openstacksdk/+/889984 | |
| 23:15:41 | opendevreview | Merged openstack/openstacksdk master: Run mypy as pre-commit https://review.opendev.org/c/openstack/openstacksdk/+/889985 | |
| 23:24:36 | opendevreview | Merged openstack/openstacksdk master: block storage: Add query string params for many APIs https://review.opendev.org/c/openstack/openstacksdk/+/892974 | |
| 23:24:38 | opendevreview | Merged openstack/openstacksdk master: compute: Add missing docstrings https://review.opendev.org/c/openstack/openstacksdk/+/891685 | |
| 23:24:40 | opendevreview | Merged openstack/openstacksdk master: block storage: Add missing docstrings https://review.opendev.org/c/openstack/openstacksdk/+/891686 | |
| 23:27:01 | opendevreview | Merged openstack/openstacksdk master: baremetal: Add missing docstrings https://review.opendev.org/c/openstack/openstacksdk/+/891687 | |
| 23:45:03 | chris218 | I figured it out!! needed to pass connection.compute instead of just connection | |
| #openstack-sdks - 2023-08-29 | |||
| 00:21:31 | chris218 | So if somebody could one again walk me through, what do you guys mean by session, client and connection. And when does each get created after I do `with openstack.connection() as conn` or after `conn.compute` gets called or something else? | |
| 00:56:24 | opendevreview | SongSuheon proposed openstack/openstacksdk master: Implement heat 'stack event list' https://review.opendev.org/c/openstack/openstacksdk/+/892836 | |
| 06:14:40 | opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: Fix: Update type encryption operation https://review.opendev.org/c/openstack/openstacksdk/+/893010 | |
| 08:05:09 | whoami-rajat | gtema, hey, replied to your comments on this https://review.opendev.org/c/openstack/python-openstackclient/+/889748 | |
| 08:05:42 | whoami-rajat | unfortunately i found out while making changes that update backup support is not there in SDK, hence we need to keep cinderclient dependency | |
| 08:36:34 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: add new version handling method https://review.opendev.org/c/openstack/openstacksdk/+/891663 | |
| 08:36:35 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: [WIP] Add OpenAPI invocation interface https://review.opendev.org/c/openstack/openstacksdk/+/892161 | |
| 09:46:09 | opendevreview | Mridula Joshi proposed openstack/python-openstackclient master: WIP: Adding CLI support for ``glance image-create-via-import`` https://review.opendev.org/c/openstack/python-openstackclient/+/893022 | |
| 09:52:15 | opendevreview | Merged openstack/openstacksdk master: docs: Document various warnings https://review.opendev.org/c/openstack/openstacksdk/+/891688 | |
| 10:31:26 | opendevreview | Mridula Joshi proposed openstack/python-openstackclient master: Adds command ``image metadef object list`` https://review.opendev.org/c/openstack/python-openstackclient/+/886821 | |
| 10:48:03 | opendevreview | Merged openstack/openstacksdk master: docs: Add exception documentation https://review.opendev.org/c/openstack/openstacksdk/+/891689 | |
| 12:49:22 | opendevreview | Mridula Joshi proposed openstack/python-openstackclient master: Adds command ``image metadef object create`` https://review.opendev.org/c/openstack/python-openstackclient/+/888765 | |
| 13:01:14 | opendevreview | Pavlo Shchelokovskyy proposed openstack/cliff master: Autofit table output if stdout is a tty https://review.opendev.org/c/openstack/cliff/+/892991 | |
| 13:01:15 | opendevreview | Pavlo Shchelokovskyy proposed openstack/cliff master: Fix flake8 violation E721 https://review.opendev.org/c/openstack/cliff/+/893047 | |
| 13:27:56 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Remove dead method https://review.opendev.org/c/openstack/openstacksdk/+/884500 | |
| 13:27:57 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Remove '_orchestration_client' https://review.opendev.org/c/openstack/openstacksdk/+/884498 | |
| 13:27:57 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Convert 'get_volume_limits' to use proxy layer https://review.opendev.org/c/openstack/openstacksdk/+/889870 | |
| 13:27:58 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Remove '_get_raw_client' https://review.opendev.org/c/openstack/openstacksdk/+/889942 | |
| 13:32:49 | opendevreview | Felix Huettner proposed openstack/openstacksdk master: Support passing a subnetpool for create_subnet https://review.opendev.org/c/openstack/openstacksdk/+/868104 | |
| 13:55:20 | opendevreview | Christian Rohmann proposed openstack/openstacksdk master: Fix swift info endpoint url extraction and add unit tests https://review.opendev.org/c/openstack/openstacksdk/+/893062 | |
| 14:52:00 | opendevreview | Christian Rohmann proposed openstack/openstacksdk master: Fix bulk_delete support determination https://review.opendev.org/c/openstack/openstacksdk/+/893071 | |
| 15:00:08 | gtema | stephenfin: can you explain me how Nova wants type: bool to be ["bool", "string"]. What the heck is that? It is about server.live_migrate.block_migration which is boolean OR "auto" | |
| 15:02:09 | stephenfin | Yeah, that's one case | |
| 15:02:12 | stephenfin | there might be more | |
| 15:06:27 | gtema | this is really insane | |