| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2022-11-03 | |||
| 20:19:23 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| #openstack-sdks - 2022-11-04 | |||
| 08:54:53 | opendevreview | Merged openstack/ansible-collections-openstack master: Fix documentation defaults for modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | |
| 10:25:02 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 10:26:09 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_snapshot{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863498 | |
| 10:28:19 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | |
| 10:28:52 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | |
| 10:38:03 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Fix backup metadata management https://review.opendev.org/c/openstack/openstacksdk/+/863634 | |
| 10:38:26 | gtema | jm1 - this is for you | |
| 10:39:11 | jm1 | gtema: uuuh nice :D thx! | |
| 10:39:51 | gtema | as usual - one line of code is causing heavy misbehave | |
| 10:41:55 | jm1 | gtema: this has never worked before, has it? wondering how people tested their code when they contributed it .. | |
| 10:42:40 | gtema | well, this is metadata. It is not a scope of SDK to test functionality of the service itself with all possible combinations | |
| 10:42:50 | gtema | in this case backup was copied from v2 | |
| 10:43:01 | jm1 | gtema: btw do we have to use 3.56 instead of 3.51 because of this? https://review.opendev.org/c/openstack/openstacksdk/+/863634/1/openstack/block_storage/v3/backup.py#84 | |
| 10:43:38 | gtema | no, max_microversion is something like: client support max 3.51 for this resource | |
| 10:44:04 | gtema | so we eventually downgrade server side just to be sure server doesn't send us back what we are not supporting | |
| 10:45:04 | jm1 | gtema: what microversion would be used without your patch? | |
| 10:45:12 | gtema | 3.51 | |
| 10:45:34 | gtema | because there is no changes to backup resource afterwards | |
| 10:46:01 | jm1 | gtema: so why do you set it to 3.51 if 3.51 would be used anyway? | |
| 10:46:23 | gtema | no, without that 3.0 is used | |
| 10:46:34 | jm1 | gtema: ah ok, so 3.0 is the default | |
| 10:46:36 | gtema | I misread the question, sorry | |
| 10:47:16 | gtema | SDK opts for max_microversion if set on the resource, otherwise not specify microver at all | |
| 10:47:27 | jm1 | gtema: but how are users supposed to use the user_id attribute if we set microversio to 3.51 instead of 3.56? | |
| 10:48:10 | gtema | where you get 3.56 from? | |
| 10:48:34 | gtema | ah, I missed to look at "get" response | |
| 10:48:43 | jm1 | "The UUID of the project owner. New in 3.56" < https://review.opendev.org/c/openstack/openstacksdk/+/863634/1/openstack/block_storage/v3/backup.py#84 | |
| 10:49:15 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Fix backup metadata management https://review.opendev.org/c/openstack/openstacksdk/+/863634 | |
| 10:49:41 | jm1 | gtema: :D thank you | |
| 10:50:11 | gtema | now I see this is again not really correct, since in 3.64 also encryption_key_id is being added | |
| 10:50:51 | jm1 | gtema: one would think that cinder folks would add their new features to osc | |
| 10:50:55 | jm1 | ..and sdk | |
| 10:51:09 | gtema | yupp | |
| 10:57:38 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Fix backup metadata management and update https://review.opendev.org/c/openstack/openstacksdk/+/863634 | |
| 12:44:38 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 12:45:07 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_snapshot{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863498 | |
| 12:45:30 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | |
| 12:45:52 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | |
| 12:51:46 | opendevreview | Merged openstack/openstacksdk master: image: Correct typo with 'get_import_info' proxy method https://review.opendev.org/c/openstack/openstacksdk/+/862177 | |
| 13:01:47 | opendevreview | Merged openstack/openstacksdk master: image: Correct typo https://review.opendev.org/c/openstack/openstacksdk/+/862178 | |
| 13:01:51 | opendevreview | Merged openstack/openstacksdk master: image: Allow listing detailed view of stores https://review.opendev.org/c/openstack/openstacksdk/+/862179 | |
| 13:01:54 | opendevreview | Merged openstack/openstacksdk master: image: Add 'store' argument to 'delete_image' proxy method https://review.opendev.org/c/openstack/openstacksdk/+/862180 | |
| 13:01:57 | opendevreview | Merged openstack/openstacksdk master: tests: Avoid potential aliasing of imports https://review.opendev.org/c/openstack/openstacksdk/+/862297 | |
| 13:48:37 | diablo_rojo_phone | gtema: should I join? I was driving my mom to work and am running late | |
| 13:48:55 | gtema | no problem, we are fine | |
| 13:55:10 | opendevreview | Eunyoung Kim proposed openstack/openstacksdk master: image: Add metadef resource type operations https://review.opendev.org/c/openstack/openstacksdk/+/861490 | |
| 14:38:01 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Introduce resource_registry in the proxies https://review.opendev.org/c/openstack/openstacksdk/+/863658 | |
| 16:23:47 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Implement unified search_resources method https://review.opendev.org/c/openstack/openstacksdk/+/859845 | |
| 16:48:50 | opendevreview | Merged openstack/openstacksdk master: Fix backup metadata management and update https://review.opendev.org/c/openstack/openstacksdk/+/863634 | |
| 16:48:53 | opendevreview | Merged openstack/openstacksdk master: Fix creation of protected image for old user code https://review.opendev.org/c/openstack/openstacksdk/+/838941 | |
| 19:06:58 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 19:09:05 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_snapshot{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863498 | |
| 19:09:29 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | |
| 19:09:49 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | |
| 19:10:16 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored project_access module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863696 | |
| #openstack-sdks - 2022-11-05 | |||
| 00:34:14 | opendevreview | Huda Irshad proposed openstack/python-openstackclient master: after adding get_server_action and providing the necessary inputs the return from sever event show is a openstack error https://review.opendev.org/c/openstack/python-openstackclient/+/863718 | |
| 09:09:17 | opendevreview | Merged openstack/python-openstackclient master: quota: Allow showing project-specific quotas https://review.opendev.org/c/openstack/python-openstackclient/+/859957 | |
| 09:09:19 | opendevreview | Merged openstack/python-openstackclient master: quota: Deprecate 'quota show --class', 'quota set --class' arguments https://review.opendev.org/c/openstack/python-openstackclient/+/859958 | |
| 09:09:22 | opendevreview | Merged openstack/python-openstackclient master: quota: Trivial style fixups https://review.opendev.org/c/openstack/python-openstackclient/+/859959 | |
| 09:09:24 | opendevreview | Merged openstack/python-openstackclient master: tests: Move fake clients to top of file https://review.opendev.org/c/openstack/python-openstackclient/+/859960 | |
| 09:10:12 | opendevreview | Merged openstack/python-openstackclient master: tests: Remove duplicate FakeImagev1Client https://review.opendev.org/c/openstack/python-openstackclient/+/859961 | |
| 09:10:15 | opendevreview | Merged openstack/python-openstackclient master: tests: Remove unnecessary nesting of volume resources https://review.opendev.org/c/openstack/python-openstackclient/+/859962 | |
| 09:24:50 | opendevreview | Merged openstack/python-openstackclient master: quota: Fix issues with delete quota command https://review.opendev.org/c/openstack/python-openstackclient/+/860721 | |
| 09:24:52 | opendevreview | Merged openstack/python-openstackclient master: quota: Deprecate "force" behavior for network quotas https://review.opendev.org/c/openstack/python-openstackclient/+/819627 | |
| 19:45:16 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_snapshot{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863498 | |
| 19:45:41 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | |
| 19:46:01 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | |
| 19:46:26 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored project_access module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863696 | |
| #openstack-sdks - 2022-11-07 | |||
| 09:12:39 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | |
| 09:16:46 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | |
| 09:54:21 | opendevreview | Hervé Beraud proposed openstack/js-openstack-lib master: Remove python-dev from bindep https://review.opendev.org/c/openstack/js-openstack-lib/+/863833 | |
| 09:54:44 | opendevreview | Hervé Beraud proposed openstack/keystoneauth master: Remove python-dev from bindep https://review.opendev.org/c/openstack/keystoneauth/+/863834 | |
| 10:02:30 | opendevreview | Hervé Beraud proposed openstack/openstacksdk master: Remove python-dev from bindep https://review.opendev.org/c/openstack/openstacksdk/+/863839 | |
| 10:08:15 | opendevreview | Hervé Beraud proposed openstack/shade master: Remove python-dev from bindep https://review.opendev.org/c/openstack/shade/+/863851 | |
| 11:42:30 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored compute_flavor module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863868 | |
| 13:33:39 | opendevreview | Merged openstack/openstacksdk master: Remove python-dev from bindep https://review.opendev.org/c/openstack/openstacksdk/+/863839 | |
| 14:10:38 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Split project_access into {compute_flavor,volume_type}_access modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863696 | |
| 16:24:41 | opendevreview | Artem Goncharov proposed openstack/cliff master: Add method to load builtins by string https://review.opendev.org/c/openstack/cliff/+/735465 | |
| 16:24:41 | opendevreview | Artem Goncharov proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/c/openstack/cliff/+/733961 | |
| 16:26:43 | opendevreview | Artem Goncharov proposed openstack/cliff master: Add method to load builtins by string https://review.opendev.org/c/openstack/cliff/+/735465 | |
| 16:27:13 | opendevreview | Artem Goncharov proposed openstack/osc-lib master: WIP Add support for deferred plugin loading https://review.opendev.org/c/openstack/osc-lib/+/735430 | |
| 16:28:01 | opendevreview | Artem Goncharov proposed openstack/python-openstackclient master: WIP Use deferred plugin loading https://review.opendev.org/c/openstack/python-openstackclient/+/735431 | |
| 16:45:17 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: zuul: Merge osc-functional-devstack-base into only child https://review.opendev.org/c/openstack/python-openstackclient/+/863898 | |
| 16:45:17 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: zuul: Remove nova-network tests https://review.opendev.org/c/openstack/python-openstackclient/+/863897 | |
| 16:45:18 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: zuul: Enable Swift tests https://review.opendev.org/c/openstack/python-openstackclient/+/863899 | |
| 16:46:00 | stephenfin | gtema: Are you picking up mordred's patches? | |
| 16:46:06 | gtema | yes | |
| 16:46:10 | stephenfin | nice | |
| 16:46:23 | stephenfin | will review once they're ready (showing merge conflict messages rn) | |
| 16:46:37 | gtema | so far was able to have something like 200ms - 1s improvement depending on the command and conditions | |
| 16:47:16 | gtema | one really dirty thing however is how to get rid of reading own entrypoints - possible only by having terribly long dictionary in the code | |
| 16:51:00 | opendevreview | Artem Goncharov proposed openstack/python-openstackclient master: Register base commands as builtins https://review.opendev.org/c/openstack/python-openstackclient/+/735434 | |
| 17:14:46 | frickler | that sounds interesting, makes me want to have more time to look at this | |
| 17:15:26 | gtema | not yet, I still try to figure out all the edges (and I can't put to WIP not my patches) | |
| 17:15:43 | gtema | but in principle - sure, maybe you notice what I have missed | |
| 17:15:48 | frickler | can that dict be autogenerated and placed into a dedicated file? | |
| 17:16:23 | gtema | well, we either put this data in entrypoints or as dict | |
| 17:16:40 | gtema | I was thinking to actually move those into individual clients to keep it a bit lighter | |
| 17:22:12 | frickler | ah, that's kind of 1:1 moved from setup.cfg, that seems manageable. I'll take a closer look later | |