| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2022-07-21 | |||
| 15:50:09 | jm1 | gtema: hello :) is there a reason why cloud.create_server does not accept a description parameter? https://review.opendev.org/c/openstack/openstacksdk/+/850671 | |
| 15:50:59 | gtema | historical - not implemented in cloud layer | |
| 15:52:17 | jm1 | gtema: so we can add it? | |
| 15:52:28 | gtema | sure | |
| 15:53:18 | jm1 | gtema: cool, then we can continue to use create_server in openstack.cloud.server. would require a lot of new code in that module without cloud.create_server() | |
| 15:53:55 | gtema | for server sadly you NEED to continue using cloud layer, since there are too many things happening under the hood | |
| 15:54:14 | gtema | but glad you reached it now ;-) | |
| 15:57:17 | jm1 | gtema: adding more tests for server revealed more issues 🙈 like the one above where i would like to pass description but create_server does not accept that.. | |
| 15:57:42 | gtema | yeah, and we also have open issue about volume | |
| 15:57:49 | gtema | (in the server create) | |
| 16:02:55 | jm1 | gtema: refering to any bug report? maybe this one? https://storyboard.openstack.org/#!/story/2010103 | |
| 16:03:16 | gtema | yes, this one | |
| 16:14:17 | jm1 | gtema: yeah, working on this one | |
| 16:14:24 | gtema | awesome | |
| 16:22:28 | jm1 | gtema: servers will always be assigned a security group by nova even if no security group was requested? | |
| 16:23:34 | gtema | hmm, not sure | |
| 16:24:05 | gtema | from docs: | |
| 16:24:06 | gtema | One or more security groups. Specify the name of the security group in the name attribute. If you omit this attribute, the API creates the server in the default security group. Requested security groups are not applied to pre-existing ports. | |
| 16:24:40 | gtema | whether this "default" SG is configurable I do not know | |
| 17:03:03 | jm1 | gtema: omg, i should have rtfm 🙈 thanks! | |
| 18:58:31 | opendevreview | Merged openstack/openstacksdk master: Allow to pass description parameter to cloud.create_server() https://review.opendev.org/c/openstack/openstacksdk/+/850671 | |
| 19:10:17 | jm1 | gtema: still working? | |
| 19:11:34 | jm1 | gtema: compute.add_security_group_to_server() claims it takes an id as security_group. https://opendev.org/openstack/openstacksdk/src/commit/1ce15c9a8758b4d978eb5239bae100ddc13c8875/openstack/compute/v2/_proxy.py#L1028 | |
| 19:12:08 | jm1 | gtema: doing so results in BadRequestException: 400: Client Error for url: http://***/compute/v2.1/servers/***/action, Security group name cannot be empty | |
| 19:12:26 | jm1 | gtema: passing a SecurityGroup object instead works as expected | |
| 19:18:39 | jm1 | gtema: another issue is, after calling compute.fetch_server_security_groups one cannot call compute.update_server with this server object because raises "BadRequestException: 400: Client Error for url:... Invalid input for field/attribute server. Value: ... Additional properties are not allowed ('security_groups' was unexpected)" | |
| 19:48:56 | opendevreview | Violet Kurtz proposed openstack/python-openstackclient master: Migrate server_groups to the new API https://review.opendev.org/c/openstack/python-openstackclient/+/837615 | |
| 19:54:42 | opendevreview | Violet Kurtz proposed openstack/python-openstackclient master: Migrate server_groups to the new API https://review.opendev.org/c/openstack/python-openstackclient/+/837615 | |
| 20:46:18 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update router for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846446 | |
| 21:18:56 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update router for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846446 | |
| #openstack-sdks - 2022-07-22 | |||
| 03:08:02 | opendevreview | huang liujie proposed openstack/openstacksdk master: Replace deprecated failUnlessEqual with assertEqual https://review.opendev.org/c/openstack/openstacksdk/+/850708 | |
| 05:36:38 | gtema | jm1: it claims it accepts Id or name or object. Looking at the code I can't understand where it may fail, therefore I would need to see how you invoke it | |
| 05:37:40 | gtema | On the other side, once you have server object (created or fetched via cloud layer) you can fully use proxy/resource layer to do further stuff on it | |
| 06:31:17 | jm1 | gtema: let me update the patch for openstack.cloud.server and then its easier to pin down. found some other funny issues as well, which are probably in neutron | |
| 06:39:14 | gtema | Good | |
| 07:05:54 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored server and server_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849423 | |
| #openstack-sdks - 2022-07-25 | |||
| 03:01:10 | opendevreview | Ke Niu proposed openstack/python-openstackclient master: Update python testing as per zed cycle teting runtime https://review.opendev.org/c/openstack/python-openstackclient/+/850327 | |
| 11:45:45 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Testing bifrost jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850876 | |
| 14:13:48 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update router for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846446 | |
| 14:13:49 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: DNM: debugging router https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850895 | |
| 14:16:14 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: DNM: debugging router https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850895 | |
| 14:21:38 | opendevreview | Felipe Reyes proposed openstack/python-openstackclient master: Drop second argument passed to emit_duplicated_warning() https://review.opendev.org/c/openstack/python-openstackclient/+/850896 | |
| 14:36:18 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: DNM: debugging router https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850895 | |
| 14:55:41 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: makes stack module compatible with new sdk version https://review.opendev.org/c/openstack/ansible-collections-openstack/+/848266 | |
| 14:56:53 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: makes stack module compatible with new sdk version https://review.opendev.org/c/openstack/ansible-collections-openstack/+/848266 | |
| 15:05:44 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Testing bifrost jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850876 | |
| 15:40:04 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Makes stack module compatible with new sdk version https://review.opendev.org/c/openstack/ansible-collections-openstack/+/848266 | |
| 15:54:54 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: DNM: debugging router https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850895 | |
| 16:06:49 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: DNM: debugging router https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850895 | |
| 18:27:02 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Use master branch of openstacksdk in Bifrost jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850876 | |
| 18:58:36 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: DNM: debugging router https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850895 | |
| #openstack-sdks - 2022-07-26 | |||
| 02:27:49 | opendevreview | Ke Niu proposed openstack/python-openstackclient master: Update python testing as per zed cycle testing runtime https://review.opendev.org/c/openstack/python-openstackclient/+/850327 | |
| 07:36:24 | opendevreview | Merged openstack/ansible-collections-openstack master: Use master branch of openstacksdk in Bifrost jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850876 | |
| 07:39:18 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored server and server_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849423 | |
| 07:45:02 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored server and server_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849423 | |
| 07:56:05 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Use stable/yoga branch of openstacksdk in Bifrost jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850995 | |
| 15:34:19 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update baremetal_inspect to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843334 | |
| 15:39:48 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update baremetal_inspect to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843334 | |
| 16:28:23 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update baremetal_inspect to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843334 | |
| 18:07:58 | stephenfin | gtema: Before I forget, can you look at my response on https://review.opendev.org/c/openstack/python-openstackclient/+/844259 tomorrow please/thank you | |
| 18:18:12 | gtema | yes stephenfin, opening tab for tomorrow | |
| 18:33:38 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update compute flavor module for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850069 | |
| 21:13:22 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update router for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846446 | |
| 21:23:15 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update compute flavor module for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850069 | |
| 21:49:59 | opendevreview | Violet Kurtz proposed openstack/python-openstackclient master: Migrate server_groups to the new API https://review.opendev.org/c/openstack/python-openstackclient/+/837615 | |
| #openstack-sdks - 2022-07-27 | |||
| 02:01:33 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update compute flavor module for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850069 | |
| 02:11:49 | opendevreview | Ke Niu proposed openstack/python-openstackclient master: Use py3 as the default runtime for tox https://review.opendev.org/c/openstack/python-openstackclient/+/850988 | |
| 05:19:16 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update compute flavor module for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850069 | |
| 09:33:37 | jm1 | gtema: wtf? https://opendev.org/openstack/openstacksdk/src/commit/1ce15c9a8758b4d978eb5239bae100ddc13c8875/openstack/cloud/_floating_ip.py#L894 | |
| 09:34:07 | jm1 | gtema: shouldn't this be a loop? | |
| 10:03:17 | gtema | Hmm, really weird | |
| 10:15:04 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored server and server_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849423 | |
| 10:42:14 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Dropped default module options https://review.opendev.org/c/openstack/ansible-collections-openstack/+/851208 | |
| 10:53:50 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Don't use deprecated distutils from python 3.10 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/851210 | |
| 11:29:57 | iurygregory | good morning ironic | |
| 11:30:08 | iurygregory | ops wrong channel =) | |
| 11:45:07 | opendevreview | Merged openstack/python-openstackclient master: Drop support for Python 3.6, 3.7 https://review.opendev.org/c/openstack/python-openstackclient/+/844259 | |
| 13:04:43 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Restore functionality to attach multiple floating ips with add_ip_list() https://review.opendev.org/c/openstack/openstacksdk/+/851221 | |
| 13:05:36 | jm1 | gtema: https://review.opendev.org/c/openstack/openstacksdk/+/851221 | |
| 13:10:30 | jm1 | gtema: but maybe we should also update those places in return value docs stating that Munch objects are returned. afaik no munch objects are returned. | |
| 13:11:03 | gtema | sorry jm1, currently 3 talks parallel, will answer you later | |
| 13:15:15 | jm1 | gtema: sure, np | |
| 13:58:55 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored server and server_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849423 | |
| 14:02:51 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored port and port_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850627 | |
| 14:03:30 | opendevreview | Merged openstack/ansible-collections-openstack master: Dropped default module options https://review.opendev.org/c/openstack/ansible-collections-openstack/+/851208 | |
| 14:04:00 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Don't use deprecated distutils from python 3.10 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/851210 | |
| 16:21:28 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update compute flavor module for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850069 | |
| 16:48:57 | opendevreview | Merged openstack/ansible-collections-openstack master: Don't use deprecated distutils from python 3.10 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/851210 | |
| 17:26:05 | opendevreview | Sylvain Bauza proposed openstack/python-openstackclient master: Add nova v2.92 support for import keypair mandatory https://review.opendev.org/c/openstack/python-openstackclient/+/851244 | |
| 18:40:58 | jm1 | gtema: https://review.opendev.org/c/openstack/openstacksdk/+/851221 passed all tests and is ready for merging! not that there is any test that properly tests add_ip_list ;) | |
| 18:41:56 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update baremetal_inspect to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843334 | |
| 19:17:36 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update compute flavor module for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850069 | |
| 19:28:35 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update router for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846446 | |
| 20:40:34 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update compute flavor module for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850069 | |
| #openstack-sdks - 2022-07-28 | |||
| 00:59:37 | opendevreview | Ke Niu proposed openstack/microversion-parse master: remove unicode from code https://review.opendev.org/c/openstack/microversion-parse/+/851187 | |
| 01:26:44 | opendevreview | Ke Niu proposed openstack/api-sig master: remove unicode from code https://review.opendev.org/c/openstack/api-sig/+/851292 | |
| 02:41:17 | opendevreview | Ke Niu proposed openstack/openstackclient master: remove unicode from code https://review.opendev.org/c/openstack/openstackclient/+/851305 | |
| 06:50:39 | gtema | jm1 - approved | |
| 06:54:03 | jm1 | gtema: thank you, sir :) | |
| 06:54:53 | gtema | you are welcome, sir | |