| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2022-07-15 | |||
| 10:21:41 | elodilles | just a question: do you plan to release 1.0.0 @ zed-3? | |
| 10:24:16 | elodilles | or it is not planned yet / will be released in the next cycle after Zed? | |
| 10:25:06 | elodilles | (i'm just asking this out of curiosity, no official statement is needed or something like that [4~:)) | |
| 10:25:41 | gtema | I fear zed-3 will not be reachable - there are still lots of issues fron Ansible collections side | |
| 10:26:05 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 10:28:03 | elodilles | gtema: ack, i see, thanks! | |
| 10:34:46 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Replaced code in routers_info module with openstacksdk function https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849975 | |
| 10:48:04 | jm1 | gtema: having issues with unit tests for this one here https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 10:48:19 | jm1 | gtema: any idea how to change the mock uris? https://291f4451bebc670e507b-a999ae1d5baedde86711d4f3bf719537.ssl.cf1.rackcdn.com/849967/3/check/openstack-tox-py38/863c9c3/job-output.txt | |
| 10:48:36 | jm1 | gtema: that is the error: requests_mock.exceptions.NoMockAddress: No mock address: GET https://network.example.com/v2.0/ports?device_id=57076620-dcfb-42ed-8ad6-79ccb4a79ed2 | |
| 10:49:31 | jm1 | gtema: this is the location where mock is created: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/unit/cloud/test_router.py#L377 | |
| 10:50:17 | gtema | hehe, I admit I reworked how mocks are filled here | |
| 10:52:18 | gtema | why do you delete device_id filter? | |
| 10:53:59 | jm1 | gtema: i dont, do i? | |
| 10:54:40 | gtema | need to look deeper, but that should be the reason for mock not being recognized | |
| 10:55:10 | gtema | ah, this is vice versa, this is the only one remaining now | |
| 10:55:40 | gtema | i will update your change after lunch if you don't mind | |
| 10:55:48 | jm1 | gtema: yes, instead of doing 4 api calls with different device_owner's i am doing just a single one | |
| 10:57:29 | gtema | sure, makes sense. There are too many places to simplify - that is the whole sense of breaking ansible ;-) | |
| 10:59:30 | jm1 | gtema: maybe you can give me a hint on how to remove the device_owner from the mock url? | |
| 11:00:13 | gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/unit/cloud/test_router.py#L374 | |
| 11:01:15 | gtema | maybe extend the function _get_mock_dict to not to include it in the QS if param is empty | |
| 11:24:12 | opendevreview | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Fix server evacuate command https://review.opendev.org/c/openstack/python-openstackclient/+/849990 | |
| 12:42:31 | jm1 | gtema: omg, of course 😂 wood and all those trees, you know.. | |
| 12:42:50 | gtema | yeah | |
| 12:46:11 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 12:54:23 | anskiy | gtema: hello! I've made this thing: https://review.opendev.org/c/openstack/openstacksdk/+/848095, it's not thoroughly tested (I'm using a bit less functionality: just basic create/delete/find and ...s(), without extensive filters and such), but it works as expected from what I can see now. Can you take a look and tell me what's left for it to be merged? | |
| 12:54:48 | gtema | ok, will try to get some time for that | |
| 12:56:02 | anskiy | I'm gonna remove the "WIP" in the heading, CI should be fine as those issues look temporary. Thank you! | |
| 12:58:18 | opendevreview | Danila Balagansky proposed openstack/openstacksdk master: Cron Triggers proxy https://review.opendev.org/c/openstack/openstacksdk/+/848095 | |
| 14:02:07 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 14:49:49 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 15:06:31 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 15:08:54 | opendevreview | Stephen Finucane proposed openstack/cliff master: Remove final use of pkg_resources https://review.opendev.org/c/openstack/cliff/+/842350 | |
| 15:14:01 | gtema | stephenfin, I feel nearly ashamed, but how have you found syntax from https://review.opendev.org/c/openstack/openstacksdk/+/846214/2/openstack/resource.py#1303? | |
| 15:14:28 | stephenfin | gtema: https://peps.python.org/pep-3102/ | |
| 15:14:45 | stephenfin | that's for kwarg-only arguments | |
| 15:14:45 | gtema | ugh | |
| 15:15:17 | gtema | I've never seen single "*" | |
| 15:15:20 | stephenfin | which I think make sense here. No one should ever be passing those args positionally. It also means we can opt to move things around down the line if we like | |
| 15:15:29 | stephenfin | Yeah, it's a Python 3-only thing afaik | |
| 15:15:45 | stephenfin | so we could only use it in the last two years or so | |
| 15:16:27 | gtema | yeah, feels now totally "weird". Moving more and more into the static languages with pointers and so on | |
| 15:19:42 | stephenfin | you've also got positional-only arguments since Python 3.8, though I've yet to find a reason for those https://peps.python.org/pep-0570/ | |
| 15:20:41 | gtema | oh man, going into rust direction nearly | |
| 15:29:46 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 15:56:45 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update router for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846446 | |
| 16:11:01 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: block storage: Add support for the Group resource https://review.opendev.org/c/openstack/openstacksdk/+/782013 | |
| 16:33:19 | stephenfin | gtema: Nice find on ^ | |
| 16:33:37 | gtema | thks | |
| 17:49:41 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update router for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846446 | |
| 18:24:21 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Adds mechanisms to extend OpenstackModule behaviors https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843324 | |
| 18:24:22 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update baremetal_inspect to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843334 | |
| 18:24:48 | opendevreview | Merged openstack/openstacksdk master: Add VPNaaS Endpoint Group resource https://review.opendev.org/c/openstack/openstacksdk/+/846016 | |
| 18:24:51 | opendevreview | Merged openstack/openstacksdk master: Reorg existing vpnaas content https://review.opendev.org/c/openstack/openstacksdk/+/846017 | |
| 18:24:54 | opendevreview | Merged openstack/openstacksdk master: Add VPNaaS IpsecPolicy resource https://review.opendev.org/c/openstack/openstacksdk/+/846595 | |
| 18:24:58 | opendevreview | Merged openstack/openstacksdk master: Allow unknown attributes in project resources https://review.opendev.org/c/openstack/openstacksdk/+/843964 | |
| 19:04:45 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 19:18:44 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 19:28:35 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 19:41:58 | jm1 | gtema: unit tests for list_router_interfaces fixed. it took me a while until i realized that network.ports() returns a generator and those are iterable only once of course 🙄😂 https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| #openstack-sdks - 2022-07-16 | |||
| 00:40:06 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update compute flavor module for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850069 | |
| 08:00:25 | opendevreview | Merged openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 08:25:31 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: block storage: Add support for the GroupSnapshot resource https://review.opendev.org/c/openstack/openstacksdk/+/781163 | |
| 09:57:30 | opendevreview | Merged openstack/openstacksdk master: block storage: Add support for the Group resource https://review.opendev.org/c/openstack/openstacksdk/+/782013 | |
| #openstack-sdks - 2022-07-17 | |||
| 03:36:46 | opendevreview | Yuriy Halytskyy proposed openstack/openstacksdk master: support nat_destination when attaching existing floating_ip to a server https://review.opendev.org/c/openstack/openstacksdk/+/850115 | |
| 07:06:27 | opendevreview | Yuriy Halytskyy proposed openstack/openstacksdk master: support nat_destination when attaching existing floating_ip to a server https://review.opendev.org/c/openstack/openstacksdk/+/850115 | |
| 08:45:57 | opendevreview | Yuriy Halytskyy proposed openstack/openstacksdk master: support nat_destination when attaching existing floating_ip to a server https://review.opendev.org/c/openstack/openstacksdk/+/850115 | |
| 10:24:55 | opendevreview | Yuriy Halytskyy proposed openstack/openstacksdk master: support nat_destination when attaching existing floating_ip to a server https://review.opendev.org/c/openstack/openstacksdk/+/850115 | |
| 21:49:13 | opendevreview | Yuriy Halytskyy proposed openstack/openstacksdk master: support nat_destination when attaching existing floating_ip to a server https://review.opendev.org/c/openstack/openstacksdk/+/850115 | |
| #openstack-sdks - 2022-07-18 | |||
| 08:04:43 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update federation_idp_info module to use proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849282 | |
| 09:16:44 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update federation_idp to use proxy https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850146 | |
| 10:21:03 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored TripleO jobs, e.g. to use latest openstacksdk RPM https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657 | |
| 10:23:03 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored TripleO jobs, e.g. to use latest openstacksdk RPM https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657 | |
| 10:26:26 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored TripleO jobs, e.g. to use latest openstacksdk RPM https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657 | |
| 10:31:51 | opendevreview | Merged openstack/ansible-collections-openstack master: Replaced code in routers_info module with openstacksdk function https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849975 | |
| 11:43:08 | opendevreview | Danila Balagansky proposed openstack/openstacksdk master: Cron Triggers proxy https://review.opendev.org/c/openstack/openstacksdk/+/848095 | |
| 11:56:04 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored TripleO jobs, e.g. to use latest openstacksdk RPM https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657 | |
| 12:00:52 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored TripleO jobs, e.g. to use latest openstacksdk RPM https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657 | |
| 12:03:29 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored TripleO jobs, e.g. to use latest openstacksdk RPM https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657 | |
| 12:36:09 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored TripleO jobs, e.g. to use latest openstacksdk RPM https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657 | |
| 12:53:37 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Makes security group rule info compatible with new sdk version https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846148 | |
| 12:59:47 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Makes security group rule info compatible with new sdk version https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846148 | |
| 13:06:29 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored TripleO jobs, e.g. to use latest openstacksdk RPM https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657 | |
| 13:25:24 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Makes security group rule info compatible with new sdk version https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846148 | |
| 14:44:39 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored TripleO jobs, e.g. to use latest openstacksdk RPM https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657 | |
| 15:28:05 | opendevreview | Merged openstack/ansible-collections-openstack master: Refactored TripleO jobs, e.g. to use latest openstacksdk RPM https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657 | |
| 18:31:12 | opendevreview | Merged openstack/cliff master: requirements: Remove explicit pbr dependency https://review.opendev.org/c/openstack/cliff/+/842346 | |
| 18:40:52 | opendevreview | Merged openstack/cliff master: requirements: Remove explicit python-subunit dependency https://review.opendev.org/c/openstack/cliff/+/842347 | |
| 18:40:54 | opendevreview | Merged openstack/cliff master: Defer loading cmd2 https://review.opendev.org/c/openstack/cliff/+/842348 | |
| 18:49:01 | opendevreview | Merged openstack/cliff master: Defer loading PyYAML https://review.opendev.org/c/openstack/cliff/+/842349 | |
| 18:49:04 | opendevreview | Merged openstack/cliff master: Remove final use of pkg_resources https://review.opendev.org/c/openstack/cliff/+/842350 | |
| 19:16:37 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Refactored TripleO jobs, e.g. to use latest openstacksdk RPM https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850249 | |
| 19:23:35 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: [DNM] Refactored TripleO jobs, e.g. to use latest openstacksdk RPM https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850249 | |
| #openstack-sdks - 2022-07-19 | |||
| 07:24:25 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Refactored TripleO jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850249 | |
| 07:30:54 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Dropped CentOS8-based TripleO job https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850287 | |
| 08:31:23 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Refactored TripleO jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850249 | |
| 08:43:50 | opendevreview | Merged openstack/ansible-collections-openstack master: Dropped CentOS8-based TripleO job https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850287 | |
| 09:53:41 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Raise minimum OpenStack SDK version to 0.99.0 again https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850040 | |
| 09:55:13 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Raise minimum OpenStack SDK version to 0.99.0 again https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850040 | |