| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2022-05-26 | |||
| 10:15:48 | stephenfin | Yeah, I assume that is an oversight though and those will change | |
| 10:16:29 | jm1 | stephenfin: we had some discussions about that some time ago and i think gtema did not yet decide on that yet. in the end someone has to (re)implement them | |
| 10:17:23 | jm1 | stephenfin: we use filters in a lot of *_info modules in ansible openstack collection and thus would like to continue using them to break less use cases | |
| 10:18:05 | jm1 | stephenfin: gtema has public holiday today and will be back tomorrow ;) | |
| 10:20:47 | stephenfin | jm1: Thanks for the info (on both fronts) | |
| 12:00:07 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Update docstrings for network functions https://review.opendev.org/c/openstack/openstacksdk/+/843435 | |
| 12:00:07 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Remove unused normalization helpers https://review.opendev.org/c/openstack/openstacksdk/+/843434 | |
| 12:00:08 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Update docstrings for image functions https://review.opendev.org/c/openstack/openstacksdk/+/843437 | |
| 12:00:08 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Update docstrings for accelerator functions https://review.opendev.org/c/openstack/openstacksdk/+/843436 | |
| 12:00:09 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Update docstrings for identity functions https://review.opendev.org/c/openstack/openstacksdk/+/843439 | |
| 12:00:09 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Update docstrings for block storage functions https://review.opendev.org/c/openstack/openstacksdk/+/843438 | |
| 12:00:10 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Update docstrings for object store functions https://review.opendev.org/c/openstack/openstacksdk/+/843440 | |
| 12:00:11 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Update docstrings for compute functions https://review.opendev.org/c/openstack/openstacksdk/+/843441 | |
| 12:06:13 | gtema | My garden shed is disassembled, pause before preparing foundation for the new one. Repeating for myself about filters: | |
| 12:06:31 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Add support for os-simple-tenant-usages API https://review.opendev.org/c/openstack/openstacksdk/+/843442 | |
| 12:06:37 | gtema | We should try implementing filters deep in base proxy list function | |
| 12:24:00 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Add support for instance actions https://review.opendev.org/c/openstack/openstacksdk/+/843449 | |
| 12:24:00 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Correct some docstrings https://review.opendev.org/c/openstack/openstacksdk/+/843448 | |
| 12:24:01 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: compute: Add functional tests for server events https://review.opendev.org/c/openstack/openstacksdk/+/843450 | |
| 12:50:26 | opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Add support for CRUD operations for QoS minimum packet rate rule https://review.opendev.org/c/openstack/python-openstackclient/+/810559 | |
| #openstack-sdks - 2022-05-27 | |||
| 06:07:10 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Warn users about us breaking backward compatibility https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843419 | |
| 06:28:44 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Use bifrost's stable/yoga branch for jobs with OpenStack SDK 0.x.x https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843569 | |
| 07:16:56 | opendevreview | Jan Horstmann proposed openstack/ansible-collections-openstack master: Return details in baremetal_node_info when iterating over all machines https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839776 | |
| 07:38:25 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Use bifrost's stable/yoga branch for jobs with OpenStack SDK 0.x.x https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843569 | |
| 09:31:55 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: [DNM] Added generic resource filtering by name_or_id, jmespath and dicts https://review.opendev.org/c/openstack/openstacksdk/+/843587 | |
| 09:32:55 | jm1 | gtema: moin :) filters proof of concept for discussion https://review.opendev.org/c/openstack/openstacksdk/+/843587 | |
| 09:33:38 | jm1 | gtema: is this similar to what you had in mind? | |
| 09:34:09 | gtema | yes, the direction is right | |
| 09:34:31 | gtema | we might need to think how to deal with whichever filters are supported or not | |
| 09:35:08 | gtema | and list should never get name_or_id argument | |
| 09:39:56 | jm1 | gtema: name_or_id could be replaced with a jsonpath filter in "filters" or something similar | |
| 09:40:58 | gtema | well, the point is that you should not call list function when you expect single entry | |
| 09:41:42 | gtema | for us it was always: if name_or_id is given we invoke search, otherwise go to list with filters | |
| 09:41:53 | gtema | s/search/find/ | |
| 09:48:26 | jm1 | gtema: makes sense. so we drop name_or_id from Resource.list() in that patch. | |
| 09:48:41 | gtema | yeah, I would say we should | |
| 09:48:53 | gtema | we do not want to have even more breaking changes ;-) | |
| 09:49:09 | jm1 | gtema: Cloud layer search_* functions always returned lists even with name_or_id given, unlike find functions. To keep this functionality we could add jsonpath expr. or similar things to filters in cloud function | |
| 09:49:53 | jm1 | gtema: maybe let me code an example, hard to describe.. | |
| 09:50:06 | gtema | yes, we can do with cloud functions pretty much everything what we now need | |
| 09:50:08 | gtema | yupp | |
| 09:50:50 | jm1 | gtema: what did you mean "we might need to think how to deal with whichever filters are supported or not"? like dropping jmespath stuff or something? | |
| 09:51:13 | gtema | not really | |
| 09:51:38 | gtema | we pass already query params as **params | |
| 09:51:50 | gtema | and those already implement most of the queries | |
| 09:51:58 | gtema | mean most of the params | |
| 09:52:27 | gtema | so we might want jmespath not to overtake everything | |
| 09:52:44 | gtema | filter on server side is better then on client | |
| 09:53:09 | gtema | so we might also "try" to parse jmsepath and whatever is supported as server-side filter pass it this way | |
| 09:53:34 | gtema | but maybe for beginning (just to improve broken backward compatibility) we can skip this for now | |
| 09:53:58 | gtema | so whatever is passed in query params is applied on server, whatever through jmes - on client side | |
| 09:57:44 | jm1 | gtema: my first idea was to drop this "filters" argument and instead add a param like "use_unknown_params_as_filters=False". We know what params are query params, so we could use all non-query-params as postprocessing filters. But i dropped that idea because this would not allow us to implement name_or_id in Resource.list() and does not allow using jmespath exprs. like a dedicated "filters" param does. But maybe you like that idea more? | |
| 10:00:04 | gtema | strategically this idea is better. We want to give user possibility to apply filters even if server side doesn't support this | |
| 10:00:34 | gtema | but it should be also disabled by default, since currently we through exception when user passes some unsupported query params | |
| 10:06:01 | jm1 | gtema: ack, let me updated the proc | |
| 10:06:04 | jm1 | *poc | |
| 10:06:26 | gtema | sure, thanks | |
| 12:10:32 | opendevreview | Merged openstack/ansible-collections-openstack master: Warn users about us breaking backward compatibility https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843419 | |
| 12:43:09 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: [DNM] Added generic resource filtering by name_or_id, jmespath and dicts https://review.opendev.org/c/openstack/openstacksdk/+/843587 | |
| 12:44:10 | jm1 | gtema: updated poc https://review.opendev.org/c/openstack/openstacksdk/+/843587 | |
| 12:44:38 | gtema | cool, will look deeper once I have some spare time | |
| 12:44:51 | jm1 | gtema: sure, np | |
| 12:48:29 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Warn users about us breaking backward compatibility https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843528 | |
| 12:54:55 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Warn users about us breaking backward compatibility https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843528 | |
| 13:29:50 | opendevreview | Merged openstack/cliff master: Update Python testing per Zed cycle testing runtime https://review.opendev.org/c/openstack/cliff/+/843312 | |
| 14:36:38 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Use bifrost's stable/yoga branch for jobs with OpenStack SDK 0.x.x https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843569 | |
| 14:37:58 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Warn users about us breaking backward compatibility https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843528 | |
| #openstack-sdks - 2022-05-30 | |||
| 07:40:18 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update endpoint to new proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840640 | |
| 07:43:44 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update project_info module to new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837276 | |
| 08:09:11 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update recordset module to be compatible with OpenStack SDK 0.90.x/1.0.x https://review.opendev.org/c/openstack/ansible-collections-openstack/+/842575 | |
| 08:39:21 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update port info https://review.opendev.org/c/openstack/ansible-collections-openstack/+/833083 | |
| 09:46:53 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update role_assignment to use proxy https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843830 | |
| 10:41:02 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Moves security_group_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840660 | |
| 10:53:03 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update recordset module to be compatible with OpenStack SDK 0.99.x/1.0.x https://review.opendev.org/c/openstack/ansible-collections-openstack/+/842575 | |
| 12:52:00 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update role_assignment to use proxy https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843830 | |
| 13:06:46 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Warn when no statsd library available https://review.opendev.org/c/openstack/openstacksdk/+/843855 | |
| 16:29:09 | opendevreview | ribaudr proposed openstack/python-openstackclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-openstackclient/+/831902 | |
| 17:16:49 | opendevreview | ribaudr proposed openstack/python-openstackclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-openstackclient/+/831902 | |
| 17:31:57 | opendevreview | ribaudr proposed openstack/python-openstackclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-openstackclient/+/831902 | |
| 18:41:41 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update project module to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839640 | |
| 18:44:58 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update recordset module to be compatible with OpenStack SDK 0.99.x/1.0.x https://review.opendev.org/c/openstack/ansible-collections-openstack/+/842575 | |
| 19:08:43 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update recordset module to be compatible with OpenStack SDK 0.99.x/1.0.x https://review.opendev.org/c/openstack/ansible-collections-openstack/+/842575 | |
| 22:06:29 | opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Allow unknown attributes in project resources https://review.opendev.org/c/openstack/openstacksdk/+/843964 | |
| 22:06:29 | opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Allow Resource.to_dict to allow returning unknown values https://review.opendev.org/c/openstack/openstacksdk/+/843963 | |
| 22:37:00 | opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Allow unknown attributes in project resources https://review.opendev.org/c/openstack/openstacksdk/+/843964 | |
| 23:57:23 | opendevreview | Ghanshyam proposed openstack/openstacksdk master: Use compatible nodeset in openstacksdk-functional-devstack https://review.opendev.org/c/openstack/openstacksdk/+/843968 | |
| #openstack-sdks - 2022-05-31 | |||
| 00:39:25 | opendevreview | Ghanshyam proposed openstack/openstacksdk stable/yoga: Use compatible nodeset in openstacksdk-functional-devstack https://review.opendev.org/c/openstack/openstacksdk/+/843974 | |
| 00:40:29 | opendevreview | Ghanshyam proposed openstack/openstacksdk stable/xena: Use compatible nodeset in openstacksdk-functional-devstack https://review.opendev.org/c/openstack/openstacksdk/+/843975 | |
| 00:41:30 | opendevreview | Ghanshyam proposed openstack/openstacksdk stable/wallaby: Use compatible nodeset in openstacksdk-functional-devstack https://review.opendev.org/c/openstack/openstacksdk/+/843976 | |
| 00:42:04 | opendevreview | Ghanshyam proposed openstack/openstacksdk stable/victoria: Use compatible nodeset in openstacksdk-functional-devstack https://review.opendev.org/c/openstack/openstacksdk/+/843977 | |
| 00:42:50 | opendevreview | Ghanshyam proposed openstack/openstacksdk stable/ussuri: Use compatible nodeset in openstacksdk-functional-devstack https://review.opendev.org/c/openstack/openstacksdk/+/843978 | |
| 01:24:48 | opendevreview | Ghanshyam proposed openstack/openstacksdk stable/ussuri: [stable-only] Pin openstacksdk in openstacksdk-functional-devstack https://review.opendev.org/c/openstack/openstacksdk/+/843978 | |
| 04:46:18 | frickler | network jobs on master are ooming https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b7b/843968/1/check/openstacksdk-functional-devstack-networking/b7b0921/controller/logs/syslog.txt | |
| 07:44:02 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update recordset module to be compatible with OpenStack SDK 0.99.x/1.0.x https://review.opendev.org/c/openstack/ansible-collections-openstack/+/842575 | |
| 08:15:29 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update role_assignment to use proxy https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843830 | |
| 08:28:39 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update project module to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839640 | |
| 08:35:29 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update project module to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839640 | |
| 08:38:53 | opendevreview | Yusuke Niimi proposed openstack/keystoneauth master: OAuth2.0 Client Credentials Grant Flow Support https://review.opendev.org/c/openstack/keystoneauth/+/830734 | |
| 08:46:23 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update endpoint to new proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840640 | |
| 08:52:20 | opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: DNM: Test networking job w/o cinder https://review.opendev.org/c/openstack/openstacksdk/+/844010 | |