| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2022-05-05 | |||
| 20:46:09 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Add script to test return values based off of doc string https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840713 | |
| 22:17:15 | opendevreview | Merged openstack/openstacksdk master: Allow to filter endpoints by region_id https://review.opendev.org/c/openstack/openstacksdk/+/836350 | |
| 22:17:18 | opendevreview | Merged openstack/openstacksdk master: Add R1 summary release note https://review.opendev.org/c/openstack/openstacksdk/+/838178 | |
| 22:28:20 | opendevreview | Merged openstack/openstacksdk master: fix: improperly encoded object names https://review.opendev.org/c/openstack/openstacksdk/+/818795 | |
| 23:05:48 | opendevreview | Merged openstack/os-api-ref master: Drop python3.6/3.7 support in testing runtime https://review.opendev.org/c/openstack/os-api-ref/+/840631 | |
| #openstack-sdks - 2022-05-06 | |||
| 06:37:46 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Backported changes to identity_user from master branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840613 | |
| 08:36:53 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Backported changes to identity_user from master branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840613 | |
| 09:37:13 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update project_info module to new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837276 | |
| 09:37:28 | arxcruz | jm1 ^ ready for review, i address your comments | |
| 10:01:52 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Backported changes to identity_user from master branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840613 | |
| 12:28:42 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Backported changes to identity_user from master branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840613 | |
| 15:14:42 | opendevreview | Merged openstack/openstacksdk master: Improve StatsD metric precision https://review.opendev.org/c/openstack/openstacksdk/+/838183 | |
| 16:05:28 | opendevreview | ribaudr proposed openstack/python-openstackclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-openstackclient/+/831902 | |
| 16:53:42 | opendevreview | Pedro Henrique Pereira Martins proposed openstack/keystoneauth master: Add OTP to v3OIDCpassword plugin https://review.opendev.org/c/openstack/keystoneauth/+/697348 | |
| 16:55:10 | opendevreview | Merged openstack/keystoneauth master: Drop lower-constraints.txt and its testing https://review.opendev.org/c/openstack/keystoneauth/+/840067 | |
| 16:55:13 | opendevreview | Merged openstack/keystoneauth master: bump py37 to py38 in tox.ini https://review.opendev.org/c/openstack/keystoneauth/+/757420 | |
| 16:59:42 | opendevreview | Merged openstack/keystoneauth master: Use TOX_CONSTRAINTS_FILE https://review.opendev.org/c/openstack/keystoneauth/+/768440 | |
| 17:06:20 | opendevreview | Merged openstack/keystoneauth master: fix: miss attr _discovery_cache in ServiceTokenAuthWrapper https://review.opendev.org/c/openstack/keystoneauth/+/777739 | |
| 17:06:22 | opendevreview | Merged openstack/keystoneauth master: remove unicode from code https://review.opendev.org/c/openstack/keystoneauth/+/822889 | |
| 17:07:05 | opendevreview | Merged openstack/keystoneauth master: User-friendly error message for DiscoveryFailure https://review.opendev.org/c/openstack/keystoneauth/+/825540 | |
| 17:13:29 | opendevreview | Merged openstack/keystoneauth master: Improve help messages for a few options https://review.opendev.org/c/openstack/keystoneauth/+/830684 | |
| 21:29:00 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Backported changes to identity_user from master branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840613 | |
| #openstack-sdks - 2022-05-09 | |||
| 07:34:15 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update identity_domain_info to use proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839445 | |
| 08:00:08 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored identity_domain_info https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839445 | |
| 08:34:20 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Reverted identity_role_info from identity.users() to search_users() https://review.opendev.org/c/openstack/ansible-collections-openstack/+/841082 | |
| 08:43:20 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Reverted identity_user_info from identity.users() to search_users() https://review.opendev.org/c/openstack/ansible-collections-openstack/+/841082 | |
| 08:53:55 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update catalog service for the new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839352 | |
| 09:01:24 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update routers_info for the new SDK https://review.opendev.org/c/openstack/ansible-collections-openstack/+/838489 | |
| 09:03:38 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update port info https://review.opendev.org/c/openstack/ansible-collections-openstack/+/833083 | |
| 09:07:18 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update identity_role_info for latest openstacksdk release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837751 | |
| 09:32:33 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Synchronize updates to identity_domain_info from master branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/841085 | |
| 09:46:26 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: [DNM] Backported changes to identity_domain_info from master branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/841085 | |
| 09:47:07 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: [DNM] Backported changes to identity_role_info from master branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/841091 | |
| 10:04:16 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update identity_group_info to new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839365 | |
| 10:12:12 | opendevreview | Merged openstack/ansible-collections-openstack master: Refactored identity_domain_info https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839445 | |
| 10:22:50 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Backported changes to identity_domain_info from master branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/841085 | |
| 10:31:50 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update identity_group_info to new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839365 | |
| 10:38:00 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update identity_group_info to new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839365 | |
| 11:18:57 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update identity_group_info to new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839365 | |
| 11:25:37 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Backported changes to identity_domain_info from master branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/841085 | |
| 12:03:21 | opendevreview | Merged openstack/ansible-collections-openstack master: Reverted identity_user_info from identity.users() to search_users() https://review.opendev.org/c/openstack/ansible-collections-openstack/+/841082 | |
| 12:59:50 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update identity_group_info to new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839365 | |
| 13:10:34 | opendevreview | Hervé Beraud proposed openstack/microversion-parse master: Drop python3.6/3.7 support in testing runtime https://review.opendev.org/c/openstack/microversion-parse/+/840621 | |
| 13:25:22 | opendevreview | Merged openstack/ansible-collections-openstack master: Update identity_role_info for latest openstacksdk release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837751 | |
| 15:05:57 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Backported changes to identity_role_info from master branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/841091 | |
| 15:23:48 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Moves image_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828158 | |
| 15:52:51 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Moves image_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828158 | |
| 16:14:32 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Backported changes to identity_domain_info from master branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/841085 | |
| 16:17:40 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Moves image_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828158 | |
| 16:54:25 | opendevreview | ribaudr proposed openstack/python-openstackclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-openstackclient/+/831902 | |
| 16:56:04 | opendevreview | ribaudr proposed openstack/python-openstackclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-openstackclient/+/831902 | |
| 17:57:15 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Add script to test return values based off of doc string https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840713 | |
| 18:02:00 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Moves image_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828158 | |
| 18:29:03 | TheJulia | Oh hai everybody! | |
| 18:29:09 | dtantsur | o/ | |
| 18:29:35 | TheJulia | I believe we've found an issue when using the sdk. Specifically when the SDK gets a 307 Redirect to a new host, it turns around and starts to duplicate the arguments | |
| 18:29:45 | dtantsur | likely even keystoneauth | |
| 18:30:00 | TheJulia | quite possible as it seem sto have redirect handling there | |
| 18:30:02 | TheJulia | https://storyboard.openstack.org/#!/story/2010029 | |
| 18:31:11 | dtantsur | I was able to reproduce it locally by inserting a redirect in front of ironic: https://paste.opendev.org/show/b7NUZbgk2HNMinwqOTik/ | |
| 18:32:02 | TheJulia | dtantsur: any chance you can see what the actual http response body is on the redirect? | |
| 18:32:09 | dtantsur | let me hack it | |
| 18:32:38 | TheJulia | k, because the redirect takes the new location and all the prior args | |
| 18:33:08 | TheJulia | and possibly cats... and whiskey | |
| 18:34:06 | dtantsur | we silence keystoneauth logging, don't we... | |
| 18:35:24 | TheJulia | I think the default is things >= warning are suppressed | |
| 18:35:29 | TheJulia | err <= warning | |
| 18:35:41 | dtantsur | hmmmmmm, I definitely use a warning | |
| 18:36:00 | dtantsur | hold on, I'm stupid | |
| 18:36:33 | dtantsur | moral: don't debug stuff with cold | |
| 18:37:43 | TheJulia | ++ | |
| 18:37:50 | TheJulia | I was doing that last week... it was not fun | |
| 18:37:58 | TheJulia | still am a little bit | |
| 18:39:09 | dtantsur | Redirecting to http://127.0.0.1:6385/ | |
| 18:39:11 | dtantsur | Redirecting to http://127.0.0.1:6385/v1/ | |
| 18:39:13 | dtantsur | Redirecting to http://127.0.0.1:6385/v1/nodes?provision_state=active | |
| 18:39:22 | dtantsur | the last one is probably relevant | |
| 18:40:31 | TheJulia | so the server, as it should, responds with the full location | |
| 18:41:22 | dtantsur | ending GET to http://127.0.0.1:6385/v1/nodes?provision_state=active with {'headers': {...}, 'params': {'provision_state': 'active'}, 'verify': True, 'allow_redirects': False} | |
| 18:41:28 | dtantsur | yep yep | |
| 18:41:39 | dtantsur | we have params both in the URL (from the redirect) and in kwargs | |
| 18:41:52 | TheJulia | and yeah, the code is just not *really* redirect safe if there are parameters | |
| 18:41:58 | dtantsur | the bug is somewhere around Session._send_request | |
| 18:42:14 | TheJulia | yup | |
| 18:42:47 | TheJulia | maybe strip params out if they are already in the url? | |
| 18:43:01 | dtantsur | is it safe to just drop params on redirect? | |
| 18:43:21 | dtantsur | I feel like it is, but maybe my brain is missing anything? | |
| 18:43:23 | TheJulia | I think it is going to depend on the server response | |
| 18:43:36 | dtantsur | well, the server knows nothing about our split between the URL and params | |
| 18:43:43 | dtantsur | it receives http://server?foo=bar | |
| 18:43:51 | dtantsur | if it drops foo=bar from the redirect, I guess it means that? | |
| 18:47:44 | TheJulia | the RFC suggests a final end location for the request | |
| 18:47:54 | TheJulia | but that may of course be dynamic | |
| 18:47:54 | dtantsur | I don't see the same problem in pure requests | |
| 18:48:12 | dtantsur | I wonder if it gets rid of params pretty early | |
| 18:49:17 | dtantsur | yeah, it merges params into the URL: https://github.com/psf/requests/blob/40956723f27daf5e0d9759208ca69cef236ab339/requests/models.py#L474-L481 | |
| 18:49:26 | dtantsur | and thus it does not have issues like this | |
| 18:49:28 | TheJulia | It that seems like an okay-ish thing to do on redirect since the response body is supposed to have the uri | |
| 18:50:28 | dtantsur | yep. and it effectively drops the params on redirect since it takes the new URL | |
| 18:51:03 | dtantsur | TheJulia: I don't think we haver HTTP->HTTPS redirects | |