Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2022-01-13
13:42:48 opendevreview Merged openstack/ansible-collections-openstack master: Release 1.6.0 version https://review.opendev.org/c/openstack/ansible-collections-openstack/+/824559
17:13:12 ralonsoh stephenfin, hi! do you have a couple of mins for https://review.opendev.org/c/openstack/openstacksdk/+/804979?
17:13:19 ralonsoh thanks in advance!
17:22:19 outbrito Howdy folks!
17:22:53 outbrito gtema, I just got some time to check on your comment on this patch: https://review.opendev.org/c/openstack/openstacksdk/+/777801/3#message-1d4c80ba284da4feaf2da6497fa8fa5db833024f
17:23:02 outbrito Do you know what is the plan to merge those changes on feature/r1 on master?
19:14:21 gtema R1 to master merge is in progress. I need to analyse test failures which are most likely due to merge issues
19:55:10 frickler gtema: is that for https://review.opendev.org/c/openstack/openstacksdk/+/823961 ? I saw that, but was wondering if that was just an intermediate test. will you postpone the cache rework, then?
19:55:35 frickler I can help looking at the failures if that's the only thing left
20:13:28 opendevreview Merged openstack/openstacksdk master: Add "security_group_ids" to Port's query parameters https://review.opendev.org/c/openstack/openstacksdk/+/804979
20:13:31 opendevreview Merged openstack/python-openstackclient master: Add --security-group to port list https://review.opendev.org/c/openstack/python-openstackclient/+/815506
20:14:33 outbrito gtema, nice, so I'll abandon that change and rebase the other ones
21:19:12 frickler gtema: stephenfin: finding 1: https://review.opendev.org/c/openstack/openstacksdk/+/813233 is broken, allow_get is still being used in osc_lib. it is strange that the osc test only fails for flavors, because all resources seem to have "name" appearing twice in keys() after that
21:22:11 frickler reverting that and adding original_name to hidden_columns for flavors fixes the osc unit tests for me
21:22:36 frickler tomorrow I'll take a look at the tenant_id things
21:24:00 frickler this is the reference in osc-lib fwiw https://opendev.org/openstack/osc-lib/src/branch/master/osc_lib/utils/__init__.py#L726
#openstack-sdks - 2022-01-14
05:28:24 gtema Thks frickler
05:30:43 gtema I also experienced merge issues (lost parts). Especially on such huge merge this can also easily happen. Would also try to check today
06:13:36 frickler gtema: with https://review.opendev.org/c/openstack/openstacksdk/+/824674 you can now see the osc-unit failures on the r1 branch already. I can try to do the same for the osc-functional job, then we could clean up the issues on the feature branch directly
06:55:34 gtema Yeah, thanks
14:56:05 opendevreview Nicolas Belouin proposed openstack/python-openstackclient master: Add trustor and trustee filtering to trusts list https://review.opendev.org/c/openstack/python-openstackclient/+/824721
16:39:18 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Skip original_name from flavor info https://review.opendev.org/c/openstack/python-openstackclient/+/824733
16:41:25 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Revert "Add "security_group_ids" to Port's query parameters" https://review.opendev.org/c/openstack/openstacksdk/+/824751
17:00:06 opendevreview Thobias Trevisan proposed openstack/python-openstackclient master: compute: Add 'Security Groups' for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/819368
17:01:14 opendevreview Dr. Jens Harbott proposed openstack/python-openstackclient master: Fixes for the upcoming major release of the SDK https://review.opendev.org/c/openstack/python-openstackclient/+/824737
17:01:50 gtema oh frickler, I was also on that right now :)
17:02:05 gtema https://review.opendev.org/c/openstack/python-openstackclient/+/824733 is what you also changed
17:02:26 gtema and for network it will be a little bigger patch - need to clean more network resources - I am on it now
17:12:06 frickler gtema: ah, I submitted without checking. I also pushed https://review.opendev.org/c/openstack/openstacksdk/+/824741 to test my change with the r1 branch, will wait for results there before abandoning my change again
17:12:28 gtema sure
17:13:05 gtema I think it is worse having 2 patches for cleaning up flavors and network stuff in sdk. Especially network is a bigger one
17:13:38 gtema additionally flavor failures are voting, network non voting (may help merging pain)
17:14:38 frickler gtema: yeah, I'm fine with that, I was mainly wanting to see now whether my local testing would also be confirmed by the CI
17:14:47 gtema cool
17:53:42 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Get rid of tenant_id in the network commands https://review.opendev.org/c/openstack/python-openstackclient/+/824746
17:56:05 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Merge feature/r1 branch into master https://review.opendev.org/c/openstack/openstacksdk/+/823961
18:39:20 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434
19:15:27 frickler gtema: the revert together with your osc patches passes osc unit+func https://review.opendev.org/c/openstack/openstacksdk/+/824741 , with that I'm out for now, feel free to ping if anything else comes up
21:28:39 gtema Cool, thks
#openstack-sdks - 2022-01-15
14:23:11 opendevreview Merged openstack/openstacksdk master: Revert "Add "security_group_ids" to Port's query parameters" https://review.opendev.org/c/openstack/openstacksdk/+/824751
15:00:14 opendevreview Merged openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434
#openstack-sdks - 2022-01-17
08:16:03 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Ensure flavor attributes are unique https://review.opendev.org/c/openstack/python-openstackclient/+/824865
08:17:15 thomasb06 gtema: Hello, my script is ready. You only need one commit per service?
08:17:26 gtema yes, please
08:17:35 thomasb06 let's g
08:17:38 thomasb06 *go
08:19:41 thomasb06 For the commit message, something like "Cloud / Baremetal service - reindentation of the docstrings" is ok?
08:19:50 gtema sure
08:23:23 isabek gtema: Hi! Can you please take a look this patches, when you have a time? Thanks in advance! 1) https://review.opendev.org/c/openstack/openstacksdk/+/822305
08:23:40 isabek 2) https://review.opendev.org/c/openstack/python-openstackclient/+/805618
08:24:15 gtema unless sdk r1 lands I will not merge anything else - there are quite some merge issues
08:24:45 isabek sdk patch no merge conflict with r1 branch
08:25:09 gtema it's more that
08:25:34 thomasb06 Gerrit's angry again: https://x0.at/onOB.txt
08:31:25 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Get rid of tenant_id in the network commands https://review.opendev.org/c/openstack/python-openstackclient/+/824746
08:33:12 thomasb06 Ah, maybe I have a hint
08:34:00 gtema na well - it states explicitly that you have unstaged files in the checkout
08:36:18 thomasb06 of course... Getting rusty
08:36:35 thomasb06 Cloud/Baremetal: https://review.opendev.org/c/openstack/openstacksdk/+/824869
08:38:10 thomasb06 Cloud / Coe service : https://review.opendev.org/c/openstack/openstacksdk/+/824890
08:39:37 thomasb06 Cloud / Compute service : https://review.opendev.org/c/openstack/openstacksdk/+/824891
08:43:34 thomasb06 Cloud / Dns service : https://review.opendev.org/c/openstack/openstacksdk/+/824892
08:44:27 thomasb06 https://review.opendev.org/c/openstack/openstacksdk/+/824893 Cloud / Floating service
08:45:34 thomasb06 https://review.opendev.org/c/openstack/openstacksdk/+/824894 Cloud / Identity service
08:46:26 thomasb06 https://review.opendev.org/c/openstack/openstacksdk/+/824896 Cloud / Network service
08:47:20 thomasb06 https://review.opendev.org/c/openstack/openstacksdk/+/824897 Cloud / Normalize
08:48:03 thomasb06 https://review.opendev.org/c/openstack/openstacksdk/+/824898 Cloud / Security group service
08:48:51 thomasb06 https://review.opendev.org/c/openstack/openstacksdk/+/824900 Cloud / Utils service
08:49:02 thomasb06 Except for errors, this should be it
09:28:38 opendevreview Merged openstack/python-openstackclient master: Skip original_name from flavor info https://review.opendev.org/c/openstack/python-openstackclient/+/824733
09:40:10 isabek gtema: Thanks got it. I will update patches with tenant_id deprecation and will wait for r1 branch merge to master
10:02:44 opendevreview Artem Goncharov proposed openstack/osc-lib master: Replace allow_get check with allow_fetch https://review.opendev.org/c/openstack/osc-lib/+/824909
10:03:20 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Merge feature/r1 branch into master https://review.opendev.org/c/openstack/openstacksdk/+/823961
10:33:41 opendevreview Artem Goncharov proposed openstack/osc-lib master: Replace allow_get check with allow_fetch https://review.opendev.org/c/openstack/osc-lib/+/824909
10:34:40 opendevreview Artem Goncharov proposed openstack/osc-lib master: Replace allow_get check with try block https://review.opendev.org/c/openstack/osc-lib/+/824909
10:39:51 opendevreview Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618
13:58:12 opendevreview Dr. Jens Harbott proposed openstack/osc-lib master: Replace allow_get check with try block https://review.opendev.org/c/openstack/osc-lib/+/824909
14:19:45 opendevreview Artem Goncharov proposed openstack/osc-lib master: Replace allow_get check with allow_fetch https://review.opendev.org/c/openstack/osc-lib/+/824909
15:34:57 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Merge feature/r1 branch into master https://review.opendev.org/c/openstack/openstacksdk/+/823961
16:29:05 opendevreview Ivan ROGER proposed openstack/ansible-collections-openstack master: Fix identity user lookup with a domain https://review.opendev.org/c/openstack/ansible-collections-openstack/+/824993
17:39:21 opendevreview Merged openstack/python-openstackclient master: Get rid of tenant_id in the network commands https://review.opendev.org/c/openstack/python-openstackclient/+/824746
#openstack-sdks - 2022-01-18
10:02:43 opendevreview Jan Hartkopf proposed openstack/openstacksdk master: fix creation of protected image https://review.opendev.org/c/openstack/openstacksdk/+/820926
12:38:48 thomasb06 gtema: do you see anything wrong in the `register_machine` function? There seem to be an error of block quoting: https://zuul.opendev.org/t/openstack/build/d412329810e941cabf4b7c4794cb5781
12:40:28 gtema looking
12:43:43 thomasb06 The error is triggered during the Coe compilation while the Baremetal one went well
12:50:43 gtema mostly you will need to "rebase" on top of parent change every time you update previous commit
12:51:06 gtema alternatively (preferred) you break chain by rebasing each change on top of base branch
12:53:16 thomasb06 Wow... How can I do this now? Move head backward to the Coe commit and pull?
12:53:45 gtema in the UI
12:54:11 gtema go to rebase and select " Rebase on top of the feature/r1 branch (breaks relation chain) "
12:54:14 gtema and this for every change you created
12:54:28 thomasb06 In the Coe commit? Let me check
12:55:16 thomasb06 Found. This is it?
12:56:04 thomasb06 Before, I need to 'recheck' maybe?
12:56:12 gtema no
12:56:25 gtema this will trigger it automatically
12:56:46 thomasb06 Ah, you did it. This is why it didn't work, there was an error message
12:57:00 thomasb06 For the next ones, I'll know. Thanks
12:57:28 gtema I rebased still on the latest version of the previous change (updated underlaying ver)
12:57:39 gtema but as I meant - best is to break dependency

Earlier   Later