| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-12-07 | |||
| 14:28:35 | gtema | uhm, reverting sdk patch would require release to unblock SDK. Perhaps we should rather really mark functest as failing while we are searching for proper fix | |
| 14:52:24 | frickler | gtema: do you really mean @unittest.expectedFailure or just skipping the test? I haven't seen the former used in openstack yet, though it might indeed be useful | |
| 14:53:15 | gtema | expectedFailure perhaps | |
| 14:53:38 | frickler | o.k., I'll propose a patch | |
| 14:54:23 | gtema | great, thks | |
| 14:58:40 | opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient master: Mark test_server_add_remove_volume as expected failure https://review.opendev.org/c/openstack/python-openstackclient/+/820895 | |
| 15:06:24 | frickler | meh, that is lacking an import | |
| 15:11:33 | opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient master: Mark test_server_add_remove_volume as expected failure https://review.opendev.org/c/openstack/python-openstackclient/+/820895 | |
| 17:36:46 | opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient master: Fix RemoveServerVolume https://review.opendev.org/c/openstack/python-openstackclient/+/820917 | |
| 17:38:29 | frickler | gtema: stephenfin: ^^ this would actually seem to be the fix for OSC matching the current SDK behavior. not sure if you'd want to use that and just amend the descriptions of the sdk functions accordingly, or whether you have an idea to make this volume attachment thing work both with and without 2.89 | |
| 17:39:21 | gtema | ideally should work with and without. Will have a look tomorrow | |
| 17:39:26 | gtema | thanks a lot | |
| 17:49:39 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add network update quota "limit_check" parameter https://review.opendev.org/c/openstack/python-openstackclient/+/806016 | |
| 17:56:07 | opendevreview | Jan Hartkopf proposed openstack/openstacksdk master: fix creation of protected image https://review.opendev.org/c/openstack/openstacksdk/+/820926 | |
| 23:06:20 | opendevreview | melanie witt proposed openstack/python-openstackclient stable/victoria: compute: Show flavor in 'server list' with API >= 2.47 https://review.opendev.org/c/openstack/python-openstackclient/+/820960 | |
| 23:06:20 | opendevreview | melanie witt proposed openstack/python-openstackclient stable/victoria: compute: Reorder building of columns for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/820959 | |
| #openstack-sdks - 2021-12-08 | |||
| 00:41:25 | opendevreview | melanie witt proposed openstack/python-openstackclient stable/victoria: compute: Show flavor in 'server list' with API >= 2.47 https://review.opendev.org/c/openstack/python-openstackclient/+/820960 | |
| 15:09:26 | thomasb06 | gtema: Hello. Shared file system: https://review.opendev.org/c/openstack/openstacksdk/+/821083 | |
| 16:29:06 | opendevreview | Ujjval proposed openstack/python-openstackclient master: compute: Switch server group to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820070 | |
| 17:57:54 | stephenfin | frickler: Great spot on the SDK front. I've no idea how that got through the gate though. I'm going to push a fix for the unit test so we can merge that. Hopefully that's okay | |
| 17:58:09 | stephenfin | *weird nova API behaviour front | |
| 17:59:50 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Fix RemoveServerVolume https://review.opendev.org/c/openstack/python-openstackclient/+/820917 | |
| 18:10:31 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Switch server group to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820070 | |
| 18:17:11 | frickler | stephenfin: thx, lgtm, I was just waiting for feedback whether that's the way we want to go before looking at the unit test. do you also have an idea for the SDK side yet? | |
| 18:17:35 | stephenfin | wdym? | |
| 18:22:35 | frickler | well the real issue is that the function in sdk claims to use attachment_id as parameter, when in fact it needs a volume_id | |
| 18:23:10 | frickler | the=delete_volume_attachment() | |
| 18:23:38 | frickler | in addition, the help text also claims that the server argument might be optional, which it isn't | |
| 18:24:45 | stephenfin | Gotcha. As I mentioned to gtema a few weeks ago, that whole part of SDK is pretty badly broken and need a rewrite | |
| 18:24:50 | stephenfin | This is another thing to add to the list | |
| 20:15:16 | opendevreview | Merged openstack/python-openstackclient master: Fix RemoveServerVolume https://review.opendev.org/c/openstack/python-openstackclient/+/820917 | |
| 20:35:20 | opendevreview | melanie witt proposed openstack/python-openstackclient stable/ussuri: compute: Reorder building of columns for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/821122 | |
| 20:35:21 | opendevreview | melanie witt proposed openstack/python-openstackclient stable/ussuri: compute: Show flavor in 'server list' with API >= 2.47 https://review.opendev.org/c/openstack/python-openstackclient/+/821123 | |
| 20:47:40 | opendevreview | Thobias Trevisan proposed openstack/python-openstackclient master: compute: Add 'Security Groups' for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/819368 | |
| 20:58:16 | opendevreview | melanie witt proposed openstack/python-openstackclient stable/train: compute: Reorder building of columns for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/821127 | |
| 20:58:17 | opendevreview | melanie witt proposed openstack/python-openstackclient stable/train: compute: Show flavor in 'server list' with API >= 2.47 https://review.opendev.org/c/openstack/python-openstackclient/+/821128 | |
| 23:27:18 | opendevreview | melanie witt proposed openstack/python-openstackclient stable/train: compute: Show flavor in 'server list' with API >= 2.47 https://review.opendev.org/c/openstack/python-openstackclient/+/821128 | |
| #openstack-sdks - 2021-12-09 | |||
| 12:42:03 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 13:49:28 | opendevreview | Artem Goncharov proposed openstack/python-openstackclient master: Allow setting gateway when creating a router https://review.opendev.org/c/openstack/python-openstackclient/+/736973 | |
| 15:37:20 | opendevreview | Merged openstack/python-openstackclient master: Allow setting gateway when creating a router https://review.opendev.org/c/openstack/python-openstackclient/+/736973 | |
| 17:23:47 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Improve logging for executed commands https://review.opendev.org/c/openstack/python-openstackclient/+/820512 | |
| 18:09:28 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Add support for triggering crash dumps https://review.opendev.org/c/openstack/openstacksdk/+/821270 | |
| 18:41:53 | opendevreview | Suneeth Ravi proposed openstack/python-openstackclient master: Switch server lock to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/819517 | |
| #openstack-sdks - 2021-12-10 | |||
| 04:46:38 | opendevreview | melanie witt proposed openstack/python-openstackclient master: Add 'Host Status' to 'server list --long' with >= v2.16 https://review.opendev.org/c/openstack/python-openstackclient/+/818306 | |
| 07:26:06 | thomasb06 | gtema: Hello. An old commit goes wrong, would you have an idea why: https://review.opendev.org/c/openstack/openstacksdk/+/814395 ? | |
| 08:25:51 | thomasb06 | Network: https://review.opendev.org/c/openstack/openstacksdk/+/821373 | |
| 09:22:57 | frickler | thomasb06: adding a blank line in front of the ":rtype::" lines fixes 814395 for me | |
| 09:34:34 | opendevreview | LEDUC Florian proposed openstack/openstacksdk master: Add get_actions for server resource https://review.opendev.org/c/openstack/openstacksdk/+/675113 | |
| 09:36:02 | thomasb06 | frickler: thanks for the hint, maybe it's fixed now | |
| 19:52:00 | fungi | mordred: (and anyone else who's a debian developer), responses to the ml thread at http://lists.spi-inc.org/pipermail/spi-general/2021-December/004172.html with your opinions would be most helpful | |
| #openstack-sdks - 2021-12-13 | |||
| 07:37:57 | isabek | stephenfin: Good morning! Can you please take a look to this patch [1] when you have a time? Fixed all comments. Thanks in advance! 1) https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 08:03:39 | opendevreview | LEDUC Florian proposed openstack/openstacksdk master: Add get_actions for server resource https://review.opendev.org/c/openstack/openstacksdk/+/675113 | |
| 08:16:56 | slaweq | gtema hi, if You will have some time, please check https://review.opendev.org/c/openstack/python-openstackclient/+/819024 | |
| 08:17:15 | gtema | Ok | |
| 08:17:22 | slaweq | thx | |
| 08:26:41 | opendevreview | LEDUC Florian proposed openstack/openstacksdk master: Add get_actions for server resource https://review.opendev.org/c/openstack/openstacksdk/+/675113 | |
| 10:26:19 | opendevreview | Merged openstack/python-openstackclient master: Allow unset port's host_id https://review.opendev.org/c/openstack/python-openstackclient/+/819024 | |
| 10:34:28 | opendevreview | Jan Hartkopf proposed openstack/openstacksdk master: fix creation of protected image https://review.opendev.org/c/openstack/openstacksdk/+/820926 | |
| 14:36:09 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| #openstack-sdks - 2021-12-14 | |||
| 08:05:06 | thomasb06 | gtema: Hello. In "Shared file system", one escaped me: https://review.opendev.org/c/openstack/openstacksdk/+/821656 | |
| 08:06:03 | thomasb06 | After a commit, I need to do `git reset --soft HEAD~1` to have one commit per service? | |
| 08:12:14 | thomasb06 | Block storage: https://review.opendev.org/c/openstack/openstacksdk/+/821657 | |
| 08:15:00 | frickler | thomasb06: if I understand your question correctly, the answer is to create a new branch each time before you commit something. then you can do "git review -f" and that will put you back to the branch you came from automatically | |
| 08:17:10 | thomasb06 | frickler: cheers, I'm doing it manually until now and it takes to restore the _proxy files each times. Thank you for the tip | |
| 08:18:40 | thomasb06 | By the way, in identity/v3/_proxy.py line 1591, it seems a piece is missing proper: `:class:`~openstack.identity.v3.federation_protocol.` should probably be `:class:`~openstack.identity.v3.federation_protocol.FederationProtocol`? | |
| 08:20:55 | thomasb06 | same line 1545 | |
| 08:24:08 | frickler | thomasb06: yes, both are missing the "FederationProtocol` instance." part | |
| 08:27:10 | thomasb06 | fixed, thanks | |
| 08:27:41 | thomasb06 | gtema: (or maybe it was RussianFederationProtocol, hehe...) | |
| 08:38:41 | thomasb06 | The Identity service: https://review.opendev.org/c/openstack/openstacksdk/+/821668 | |
| 08:49:13 | thomasb06 | The Instance HA service: https://review.opendev.org/c/openstack/openstacksdk/+/821674 | |
| 08:50:15 | thomasb06 | According to my script, this is it for the :class: links | |
| 15:55:52 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Switch add fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820050 | |
| 15:55:53 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Return information about fixed IP https://review.opendev.org/c/openstack/python-openstackclient/+/821728 | |
| 16:04:53 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Switch remove fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820420 | |
| 16:44:01 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Fix 'update_volume_attachment' https://review.opendev.org/c/openstack/openstacksdk/+/821733 | |
| 16:44:26 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Switch server volume update to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/821734 | |
| 16:44:26 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| 21:22:42 | dking | Does the python-openstackclient happen to have any option to set a timeout or a maximum amount of time before it stops trying to connect? | |
| #openstack-sdks - 2021-12-15 | |||
| 05:02:04 | frickler | dking: I have been wondering about that, too, seems at least by default it doesn't | |
| 05:28:48 | gtema | dking, frickler: In the clouds.yaml you can set api_timeout per each connection | |
| 05:34:20 | dking | gtema: I thought that clouds.yaml usually just matched existing command line options. Is there a related command line option for that? Also, is that documented anywhere? I'm not seeing api_timeout listed. | |
| 05:34:45 | dking | I'm checking in the online man page, but also https://docs.openstack.org/python-openstackclient/latest/cli/man/openstack.html and https://docs.openstack.org/python-openstackclient/latest/configuration/index.html and I don't see that option. | |
| 05:35:08 | gtema | No, that one is not listed and coming from SDK reading the config | |
| 05:37:17 | gtema | Moreover you'll not find it in any SDK docs sadly, but here it is in the code: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/config/cloud_region.py#L636 | |
| 05:44:44 | dking | gtema: Thanks for pointing that out. However, from looking at the code, that seems like maybe it's a timeout for the keystone session itself. I'm referring to the actual request to the API. Specifically, I'm connecting to Ironic with "openstack baremetal node ..." commands, but when Ironic-API gets bogged down, it causes some of my scripts using it to get stuck. | |
| 05:46:46 | dking | I'm probably going to have to just specifically wrap the openstack command in the timeout command, but I was hoping that there was something built in for that. If it's not there, perhaps that would be a good option to add? | |
| 05:46:52 | gtema | That one is used as a timeout parameter on that python requests | |
| 06:01:41 | frickler | gtema: oh, wow, I just found _fix_backwards_api_timeout() and that is really ... surprising. thx mordred ;) | |
| 08:47:48 | isabek | Hi openstackclient cores! If you have some time, can you please take a look https://review.opendev.org/c/openstack/python-openstackclient/+/805618 ? | |
| 12:36:37 | opendevreview | Merged openstack/osc-lib master: Update master for stable/xena https://review.opendev.org/c/openstack/osc-lib/+/808366 | |
| 13:27:43 | opendevreview | Merged openstack/osc-lib master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/osc-lib/+/808368 | |
| 16:54:36 | dking | gtema: So, I decided to actually try the timeout, and unless I'm doing something wrong, it doesn't seem to work. Here's the clouds.yaml file: https://paste.opendev.org/show/811703/ | |
| 16:55:54 | dking | I added an endpoint override so that I could be sure that the file is being read and also it provided a handy way to break the requests which is the failure scenario to need the timeout. Then, I added api_timeout, and it still seems to take just as long to fail. | |
| 17:00:08 | gtema | It works for me definitely, so you might be doing something wrong | |
| 17:44:21 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix weird option definition for 'server ssh' https://review.opendev.org/c/openstack/python-openstackclient/+/821867 | |
| 17:44:21 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Pass through args to ssh https://review.opendev.org/c/openstack/python-openstackclient/+/402530 | |
| #openstack-sdks - 2021-12-16 | |||
| 12:38:46 | frickler | gtema: stephenfin: https://review.opendev.org/c/openstack/python-openstackclient/+/815032 causes a regression, 5.7.0 shows the location Munch noise again for neutron objects | |
| 12:45:45 | frickler | ah, because it simply dropped my beautiful special case https://review.opendev.org/c/openstack/python-openstackclient/+/815032/1/openstackclient/network/sdk_utils.py#b43 | |
| 12:46:01 | frickler | :-( | |