| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-12-03 | |||
| 08:48:56 | thomasb06 | what is the line length limit, 82 characters? | |
| 08:49:02 | gtema | 80 | |
| 08:49:22 | thomasb06 | arg... Good thing I asked | |
| 08:56:50 | thomasb06 | so 81 triggers an error but 80 is ok? | |
| 08:57:22 | gtema | actually 79 is ok, but 80 is not good anymore | |
| 08:57:35 | thomasb06 | alright | |
| 09:01:45 | thomasb06 | line 1097 or so, there is ":class:`~openstack.load_balancer.v2.availability_zone.AvailabilityZone`," but it can fit 79 characters | |
| 09:02:30 | thomasb06 | maybe for the docstrings, the 80 limit is not blocking? | |
| 09:06:29 | thomasb06 | *can't fit | |
| 09:10:06 | gtema | those particular lines must stay on the same line, and pep should not actually complain about it - it should know what to ignore | |
| 09:10:19 | thomasb06 | great, thank you | |
| 09:10:31 | gtema | but just ensure that :class:`blabla` stays on the single line | |
| 09:11:11 | thomasb06 | so ":rtype: :class:`~openstack.load_balancer.v2.availability_zone_profile.AvailabilityZoneProfile`" takes to be split in two lines? | |
| 09:12:27 | gtema | yes, ":rtype: \n :class:`blabla`" | |
| 09:17:47 | thomasb06 | here it is: https://review.opendev.org/c/openstack/openstacksdk/+/820357 | |
| 09:24:26 | gtema | yeah, let's see what checks will say | |
| 09:25:23 | gtema | oh, I missed in the reviews list. -https://review.opendev.org/c/openstack/openstacksdk/+/816809 - this was the initial change for fixing it in the LB, but checks failed | |
| 09:27:45 | thomasb06 | so maybe we wait for this one? It doesn't seem related to the docstrings, is it? | |
| 09:28:18 | gtema | we take the latest one once it passes | |
| 09:28:46 | thomasb06 | so I abandon number 816809? | |
| 09:30:04 | gtema | yeah, perhaps | |
| 09:30:09 | thomasb06 | sure | |
| 09:34:44 | thomasb06 | Orchestration is ready too: https://review.opendev.org/c/openstack/openstacksdk/+/820360 | |
| 11:26:39 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 12:53:08 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Adding "files/config_drive_files" to server module. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/819657 | |
| 18:44:33 | opendevreview | Suneeth Ravi proposed openstack/python-openstackclient master: Switch server lock to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/819517 | |
| 19:02:18 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 22:51:46 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch add fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820050 | |
| 22:53:44 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch add fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820050 | |
| 22:55:53 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch add fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820050 | |
| #openstack-sdks - 2021-12-04 | |||
| 00:19:32 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch add fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820050 | |
| 00:22:43 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch add fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820050 | |
| 01:44:41 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch add fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820050 | |
| 16:12:16 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch remove fixed ip to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/820420 | |
| 16:15:11 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch add fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820050 | |
| 16:51:41 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch remove fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820420 | |
| 16:54:47 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch remove fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820420 | |
| 21:32:01 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch remove fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820420 | |
| 21:39:29 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch remove fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820420 | |
| 21:45:39 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch remove fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820420 | |
| #openstack-sdks - 2021-12-05 | |||
| 15:40:00 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch remove fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820420 | |
| 22:10:51 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch server dump create to using sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816296 | |
| 22:42:23 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| #openstack-sdks - 2021-12-06 | |||
| 02:00:43 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Fixing issue with functional test https://review.opendev.org/c/openstack/python-openstackclient/+/820466 | |
| 08:30:12 | slaweq | gtema hi, can You check https://review.opendev.org/c/openstack/python-openstackclient/+/819024 once again when You will have some time? thx in advance | |
| 08:45:32 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: DNM test CI https://review.opendev.org/c/openstack/ansible-collections-openstack/+/820480 | |
| 10:27:59 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Improve logging for executed commands https://review.opendev.org/c/openstack/python-openstackclient/+/820512 | |
| 13:45:44 | sshnaidm | when is "files" in config-drive deprecated? https://github.com/openstack/openstacksdk/blob/215403731db17e14506d2d83b17afd6df6d257d4/openstack/cloud/_compute.py#L687 | |
| 13:45:57 | sshnaidm | is there replacement? | |
| 14:35:23 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Improve logging for executed commands https://review.opendev.org/c/openstack/python-openstackclient/+/820512 | |
| 14:43:44 | opendevreview | Thobias Trevisan proposed openstack/python-openstackclient master: compute: Add 'Security Groups' for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/819368 | |
| 17:34:21 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch openstack server show to using sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/817871 | |
| #openstack-sdks - 2021-12-07 | |||
| 10:22:29 | frickler | gtema: could you have another look at https://review.opendev.org/c/openstack/python-openstackclient/+/736973 pls? I had messed up pep8. slaweq this may also be interesting for you | |
| 10:23:08 | gtema | sure, but first need to find reason for one functest failure we currently have | |
| 10:24:25 | frickler | gtema: I haven't seen that, do you have a pointer? | |
| 10:24:52 | gtema | https://review.opendev.org/c/openstack/python-openstackclient/+/820512 | |
| 10:26:27 | frickler | volumes once again ... sigh ... will take a look | |
| 10:26:38 | gtema | thks a lot | |
| 13:15:05 | frickler | gtema: so I can reproduce locally and if I revert https://review.opendev.org/c/openstack/python-openstackclient/+/817989/8 the issue is gone. maybe try to revert that for now? | |
| 13:15:58 | gtema | we thought yesterday on marking the test as expected to fail | |
| 13:16:23 | gtema | https://review.opendev.org/c/openstack/python-openstackclient/+/819473/1 added the functest itself (was not tested before at all) | |
| 13:18:34 | frickler | gtema: my current suspicion is that the test is good, but 817989 broken | |
| 13:18:45 | frickler | or is might be uncovering some issue in nova | |
| 13:19:58 | gtema | yeah, everything is possible | |
| 13:29:25 | frickler | so 817989 is broken for sure. nova returns a 404 for the delete_volume_attachment(), but the code ignores that instead of raising an error | |
| 13:31:08 | frickler | gtema: stephenfin: ^^ | |
| 13:34:24 | frickler | e.g. 15:08:07.785042 in https://210be1f5cbeabbdaba80-eeccdc6968a6b16fa4ca2e3ee7c1080d.ssl.cf2.rackcdn.com/820512/2/check/osc-functional-devstack-tips/4af9a0d/controller/logs/screen-n-api.txt | |
| 13:41:38 | frickler | delete_volume_attachment() expects the ID of the attachment, while the OSC patch hands it the volume ID | |
| 13:42:36 | frickler | hmm, no, ignore that | |
| 13:58:29 | frickler | the sdk code is broken it seems, it uses the attachment_id for the _delete call instead of the volume id | |
| 13:59:36 | gtema | ouch, bad | |
| 14:02:40 | frickler | this may be somehow related to https://review.opendev.org/c/openstack/openstacksdk/+/817997/1/openstack/compute/v2/volume_attachment.py , but I'm kinda confused about it still. I do remember trying to make sense of the nova api-ref there | |
| 14:03:36 | frickler | I also don't understand how it could pass CI if that were true | |
| 14:05:34 | gtema | and so the loop closes :-) | |
| 14:05:49 | gtema | we started failing with the raising of openstacksdk | |
| 14:14:28 | frickler | oh, wow, this is even weirder. with old microversion, nova returns the volume_id as attachment_id. with 2.89, it returns the real attachment_id. | |
| 14:18:08 | frickler | so that's actually the non-voting failure for 817997 https://zuul.opendev.org/t/openstack/build/1f7a3ab5e8b942c2b7b58b9ec2e27367 | |
| 14:18:53 | frickler | and it has been failing since then https://zuul.opendev.org/t/openstack/builds?job_name=osc-functional-devstack-tips&project=openstack/openstacksdk | |
| 14:19:53 | frickler | gtema: stephenfin: ^^ I have no idea how to actually fix that, so maybe that would be the patch to revert for now | |
| 14:28:35 | gtema | uhm, reverting sdk patch would require release to unblock SDK. Perhaps we should rather really mark functest as failing while we are searching for proper fix | |
| 14:52:24 | frickler | gtema: do you really mean @unittest.expectedFailure or just skipping the test? I haven't seen the former used in openstack yet, though it might indeed be useful | |
| 14:53:15 | gtema | expectedFailure perhaps | |
| 14:53:38 | frickler | o.k., I'll propose a patch | |
| 14:54:23 | gtema | great, thks | |
| 14:58:40 | opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient master: Mark test_server_add_remove_volume as expected failure https://review.opendev.org/c/openstack/python-openstackclient/+/820895 | |
| 15:06:24 | frickler | meh, that is lacking an import | |
| 15:11:33 | opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient master: Mark test_server_add_remove_volume as expected failure https://review.opendev.org/c/openstack/python-openstackclient/+/820895 | |
| 17:36:46 | opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient master: Fix RemoveServerVolume https://review.opendev.org/c/openstack/python-openstackclient/+/820917 | |
| 17:38:29 | frickler | gtema: stephenfin: ^^ this would actually seem to be the fix for OSC matching the current SDK behavior. not sure if you'd want to use that and just amend the descriptions of the sdk functions accordingly, or whether you have an idea to make this volume attachment thing work both with and without 2.89 | |
| 17:39:21 | gtema | ideally should work with and without. Will have a look tomorrow | |
| 17:39:26 | gtema | thanks a lot | |
| 17:49:39 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add network update quota "limit_check" parameter https://review.opendev.org/c/openstack/python-openstackclient/+/806016 | |
| 17:56:07 | opendevreview | Jan Hartkopf proposed openstack/openstacksdk master: fix creation of protected image https://review.opendev.org/c/openstack/openstacksdk/+/820926 | |
| 23:06:20 | opendevreview | melanie witt proposed openstack/python-openstackclient stable/victoria: compute: Show flavor in 'server list' with API >= 2.47 https://review.opendev.org/c/openstack/python-openstackclient/+/820960 | |
| 23:06:20 | opendevreview | melanie witt proposed openstack/python-openstackclient stable/victoria: compute: Reorder building of columns for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/820959 | |
| #openstack-sdks - 2021-12-08 | |||
| 00:41:25 | opendevreview | melanie witt proposed openstack/python-openstackclient stable/victoria: compute: Show flavor in 'server list' with API >= 2.47 https://review.opendev.org/c/openstack/python-openstackclient/+/820960 | |
| 15:09:26 | thomasb06 | gtema: Hello. Shared file system: https://review.opendev.org/c/openstack/openstacksdk/+/821083 | |
| 16:29:06 | opendevreview | Ujjval proposed openstack/python-openstackclient master: compute: Switch server group to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820070 | |
| 17:57:54 | stephenfin | frickler: Great spot on the SDK front. I've no idea how that got through the gate though. I'm going to push a fix for the unit test so we can merge that. Hopefully that's okay | |
| 17:58:09 | stephenfin | *weird nova API behaviour front | |