| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-09-29 | |||
| 07:51:58 | gtema | hi thomasb06. Yes | |
| 07:52:08 | gtema | this is also part of the bigger cleanup | |
| 07:52:32 | gtema | it's about fixing identation of the docstrings through the code | |
| 07:52:43 | thomasb06 | cool. Then, I can go on elsewhere | |
| 07:53:08 | gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/block_storage/v3/_proxy.py#L574 - good example of docstring identation | |
| 07:53:18 | gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/block_storage/v3/_proxy.py#L368 - bad example | |
| 07:54:06 | gtema | so overall I want our docstring to be properly idented (so that linebreak of the param description gets +4 chars identation and not something else | |
| 07:54:37 | thomasb06 | it's all in openstacksdk/openstack ? | |
| 07:55:02 | gtema | I would say it currently distracts in openstack///_proxy.py and openstack/cloud/**.py | |
| 07:55:20 | gtema | s//////* */* *// | |
| 07:55:57 | gtema | maybe same is also present in tons of other places (in the resource files themselves) and it should be also fixed there, but proxy files are the most disturbing ones | |
| 07:56:59 | thomasb06 | alright, then switch on indenting | |
| 07:57:10 | gtema | thks a lot | |
| 08:43:56 | thomasb06 | First attempt: https://review.opendev.org/c/openstack/openstacksdk/+/811658 | |
| 08:44:13 | thomasb06 | It seems it can be handled by a regexp script | |
| 08:47:10 | thomasb06 | the keywords are: `:param ?:`, `:returns:`, `:rtype:`, and `:raises:`. And there are second level indentation after a `*` | |
| 08:47:41 | thomasb06 | maybe I go for an awk script for a couple of days | |
| 09:04:22 | gtema | I doubt it can be very easy with regex | |
| 10:27:02 | gtema | stephenfin: I remember around a year ago we were discussing what to do with hypervisor statistics in OSC but I forgot what we actually agreed upon | |
| 10:27:42 | gtema | I try to rebase my hypervisor change now https://review.opendev.org/c/openstack/python-openstackclient/+/763414 and figure out it doesn't work really, cause in SDK there is no support for statistics | |
| 10:29:33 | stephenfin | Could you leave that using novaclient and simply deprecate it? | |
| 10:29:56 | stephenfin | The alternative to provide something like it by querying placement, but we haven't completed placement support in SDK yet either | |
| 10:30:18 | gtema | can be done. But then we can not get rid of dependency on novaclient (I was actually sure we do not have it, but we do) | |
| 10:30:42 | stephenfin | We can't do it this cycle, but we can do it in Z | |
| 10:30:47 | stephenfin | that's not that far away, tbf | |
| 10:31:15 | gtema | that's clear, I mean even overall | |
| 10:31:30 | gtema | what I can do actually is to use SDK for direct API call from OSC | |
| 10:31:38 | gtema | so that we do not need to implement it in SDK | |
| 10:32:00 | stephenfin | I didn't know that was an option. Sure, that works for me too | |
| 10:32:22 | gtema | ok, will do so. I actually used this few times in ansible modules already | |
| 13:23:37 | opendevreview | Artem Goncharov proposed openstack/python-openstackclient master: Switch hypervisor operations to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/763414 | |
| 13:49:54 | opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Add BFD monitor commands https://review.opendev.org/c/openstack/python-openstackclient/+/810286 | |
| 15:14:14 | opendevreview | Sven Anders proposed openstack/ansible-collections-openstack master: Flavor properties are not deleted on changes and id will stay https://review.opendev.org/c/openstack/ansible-collections-openstack/+/811739 | |
| 15:40:13 | opendevreview | Sven Anders proposed openstack/ansible-collections-openstack master: Flavor properties are not deleted on changes and id will stay https://review.opendev.org/c/openstack/ansible-collections-openstack/+/811739 | |
| #openstack-sdks - 2021-09-30 | |||
| 11:37:28 | opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Add BFD monitor commands https://review.opendev.org/c/openstack/python-openstackclient/+/810286 | |
| 14:27:27 | opendevreview | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Add --trusted-image-cert option for server create https://review.opendev.org/c/openstack/python-openstackclient/+/811981 | |
| 16:42:36 | opendevreview | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Add --trusted-image-cert option for server create https://review.opendev.org/c/openstack/python-openstackclient/+/811981 | |
| 16:57:11 | opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Add bfd_monitor as optional arg to route https://review.opendev.org/c/openstack/python-openstackclient/+/810370 | |
| #openstack-sdks - 2021-10-01 | |||
| 08:59:16 | opendevreview | Alexandru Verdes proposed openstack/ansible-collections-openstack master: Add client and member listener timeouts for persistence (Ex. SSH) https://review.opendev.org/c/openstack/ansible-collections-openstack/+/812110 | |
| 09:17:56 | opendevreview | Alexandru Verdes proposed openstack/ansible-collections-openstack master: Add client and member listener timeouts for persistence (Ex. SSH) https://review.opendev.org/c/openstack/ansible-collections-openstack/+/812110 | |
| 14:57:00 | noonedeadpunk | hey! I was wondering if there's any good way to import one of the commands to reuse code inside other one? I guess no? | |
| 14:57:20 | noonedeadpunk | regsarding openstackclient | |
| 14:58:35 | gtema | can you be please more precise with your example? what are you thinking of? | |
| 15:03:08 | noonedeadpunk | So, I'm trying to write host-evacuate command for openstackclient. And what I;d ove to do is re-use https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/compute/v2/server.py#L3458 | |
| 15:03:15 | noonedeadpunk | But I guess I can't do that? | |
| 15:03:52 | noonedeadpunk | so the way would be copy/pasting code? Which I'd hate doing... | |
| 15:04:47 | gtema | reuse in the sense of a complete copy or only parts? | |
| 15:05:05 | noonedeadpunk | I guess that was kind of reason why it hasn't been implemented yet... | |
| 15:05:44 | noonedeadpunk | complete copy but pass different parsed_args | |
| 15:06:13 | gtema | and what about the action itself? it currently invoke server.evacuate(xx) | |
| 15:07:09 | noonedeadpunk | yeah, it will be the same. So host evacuate is basically retrieves all servers for hypervisors and iterate on them | |
| 15:07:31 | noonedeadpunk | ie https://github.com/openstack/python-novaclient/blob/8066f8c745054caeb7bd66d4c2be15ab5fac1d1f/novaclient/v2/shell.py#L5190-L5199 | |
| 15:08:41 | gtema | but it is the still not really same. I would suggest just move evacuate implementation into helper function | |
| 15:08:52 | gtema | so that you can also iterate and invoke it | |
| 15:13:17 | noonedeadpunk | Sounds reasonable. And can you kindly point to some helper sample? Can find quickly in tree. Or they are osc_lib or somewhere? | |
| 15:14:22 | gtema | https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/common/sdk_utils.py | |
| 15:14:27 | gtema | whatever is currently in common | |
| 15:14:40 | gtema | but I would rather simply have something in the compute part | |
| 15:14:56 | gtema | https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/network/common.py | |
| 15:16:16 | noonedeadpunk | yeah, great, thanks! | |
| 18:23:05 | opendevreview | Merged openstack/osc-lib stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/osc-lib/+/808361 | |
| 18:23:29 | opendevreview | Merged openstack/osc-lib stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/osc-lib/+/808362 | |
| #openstack-sdks - 2021-10-02 | |||
| 12:53:10 | opendevreview | Pavlo Shchelokovskyy proposed openstack/keystoneauth master: Enforce scope mutual exclusion for system https://review.opendev.org/c/openstack/keystoneauth/+/802683 | |
| 19:54:43 | jsmdk | Hi, I have a long time pending review here https://review.opendev.org/c/openstack/openstacksdk/+/787952. Can someone have a look? | |
| #openstack-sdks - 2021-10-03 | |||
| 12:44:36 | opendevreview | Merged openstack/openstacksdk master: Change image.hw_qemu_guest_agent to be string https://review.opendev.org/c/openstack/openstacksdk/+/808101 | |
| 18:17:12 | opendevreview | ChoiDoa proposed openstack/python-openstackclient stable/wallaby: title: Update Nova CLI decoder document https://review.opendev.org/c/openstack/python-openstackclient/+/812267 | |
| #openstack-sdks - 2021-10-04 | |||
| 07:57:41 | opendevreview | ChoiDoa proposed openstack/python-openstackclient stable/wallaby: Update the Nova CLI decoder document https://review.opendev.org/c/openstack/python-openstackclient/+/812287 | |
| 08:35:14 | opendevreview | ChoiDoa proposed openstack/python-openstackclient stable/wallaby: Update the Nova CLI decoder document. https://review.opendev.org/c/openstack/python-openstackclient/+/812294 | |
| 09:05:11 | opendevreview | ChoiDoa proposed openstack/python-openstackclient stable/wallaby: Update the Nova CLI decoder document https://review.opendev.org/c/openstack/python-openstackclient/+/812305 | |
| 09:12:14 | opendevreview | ChoiDoa proposed openstack/python-openstackclient stable/wallaby: Update the Nova CLI decoder document https://review.opendev.org/c/openstack/python-openstackclient/+/812306 | |
| 09:17:24 | opendevreview | ChoiDoa proposed openstack/python-openstackclient stable/wallaby: Update the Nova CLI decoder document https://review.opendev.org/c/openstack/python-openstackclient/+/812294 | |
| 09:26:27 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Move CI to use Ansible 2.12 version as main https://review.opendev.org/c/openstack/ansible-collections-openstack/+/812308 | |
| 12:06:52 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Move CI to use Ansible 2.12 version as main https://review.opendev.org/c/openstack/ansible-collections-openstack/+/812308 | |
| 15:59:14 | diablo_rojo_phone | gtema: stephenfin as a heads up I am in a meeting that's going long so you might want to get started without me. | |
| 15:59:31 | gtema | ok, thks | |
| 21:20:18 | opendevreview | Ashraf Hasson proposed openstack/ansible-collections-openstack master: Add Neutron RBAC modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/799896 | |
| #openstack-sdks - 2021-10-05 | |||
| 02:30:55 | opendevreview | JIHOJU proposed openstack/python-openstackclient master: Update the Nova CLI docoder document https://review.opendev.org/c/openstack/python-openstackclient/+/812421 | |
| 10:44:27 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Clean up the old jobs for rocky,stein,queens https://review.opendev.org/c/openstack/ansible-collections-openstack/+/812476 | |
| 10:47:57 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Clean up the old jobs for rocky,stein,queens https://review.opendev.org/c/openstack/ansible-collections-openstack/+/812476 | |
| 11:49:04 | opendevreview | Merged openstack/ansible-collections-openstack master: Move CI to use Ansible 2.12 version as main https://review.opendev.org/c/openstack/ansible-collections-openstack/+/812308 | |
| 11:54:44 | opendevreview | Artem Goncharov proposed openstack/python-openstackclient master: Switch hypervisor operations to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/763414 | |
| 13:30:13 | opendevreview | Merged openstack/ansible-collections-openstack master: Clean up the old jobs for rocky,stein,queens https://review.opendev.org/c/openstack/ansible-collections-openstack/+/812476 | |
| 15:44:50 | opendevreview | Merged openstack/ansible-collections-openstack master: Add client and member listener timeouts for persistence (Ex. SSH) https://review.opendev.org/c/openstack/ansible-collections-openstack/+/812110 | |
| 17:29:14 | opendevreview | Rafael Weingartner proposed openstack/os-api-ref master: Fix exception logging https://review.opendev.org/c/openstack/os-api-ref/+/799216 | |
| 17:52:08 | opendevreview | Rafael Weingartner proposed openstack/os-api-ref master: Fix exception logging https://review.opendev.org/c/openstack/os-api-ref/+/799216 | |
| #openstack-sdks - 2021-10-06 | |||
| 08:35:06 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Add Neutron RBAC modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/799896 | |
| 10:54:46 | opendevreview | Seunghyun LIm proposed openstack/python-openstackclient master: Remove non-working code after method return. https://review.opendev.org/c/openstack/python-openstackclient/+/812661 | |
| 11:36:48 | opendevreview | ChoiDoa proposed openstack/python-openstackclient master: Update Nova CLI decoder document https://review.opendev.org/c/openstack/python-openstackclient/+/812566 | |
| 11:55:33 | opendevreview | ChoiDoa proposed openstack/python-openstackclient master: Update the Nova CLI decoder document https://review.opendev.org/c/openstack/python-openstackclient/+/812668 | |
| 12:11:07 | opendevreview | Merged openstack/python-openstackclient master: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/c/openstack/python-openstackclient/+/808079 | |
| 12:11:08 | opendevreview | Merged openstack/python-openstackclient master: Fix that the path of functional test https://review.opendev.org/c/openstack/python-openstackclient/+/811008 | |
| 12:12:10 | gtema | I see stephenfin you blowed my attempt to have easy rebase for osc patch ;-) Will try to find time to address your concerns this week. Thks | |
| 13:28:26 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Add Neutron RBAC modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/799896 | |
| 13:42:23 | thomasb06 | gtema: awk processes the files line by line... But with a python script, it should be possible to format all the docstrings at once | |
| 13:54:19 | thomasb06 | when there are * bullet points, the indentation should be 8? | |
| 13:55:59 | stephenfin | gtema: :) Sorry! | |
| 15:35:04 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Add Neutron RBAC modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/799896 | |
| 15:40:08 | opendevreview | ChoiDoa proposed openstack/python-openstackclient master: Update the Nova CLI decoder document https://review.opendev.org/c/openstack/python-openstackclient/+/812721 | |
| 15:49:23 | seongsoocho | stephenfin: Hi. I'm seongsoo from openstack korea user group. and we are doing mentoring program to contribute openstack. Since it is the first time using gerrit, so several reviews with the same content were created and there were many abandoned ones. Sorry to bother you with the review and thank you :-) | |
| 16:34:54 | stephenfin | seongsoocho: Oh, okay, no problem :) Thank you for the context | |