| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-09-06 | |||
| 10:13:17 | gtema | which split test functions base on the "resource" we test | |
| 10:13:44 | gtema | similar is present in https://opendev.org/openstack/openstacksdk/src/branch/feature/r1/openstack/tests/unit/compute/v2/test_proxy.py | |
| 10:14:18 | gtema | so if you can apply the same pattern (splitting single test class into multiple) for all the other services it would be great | |
| 10:14:34 | gtema | basically openstacl/tests/unit//v/test_proxy.py | |
| 10:14:40 | gtema | * basically openstack/tests/unit//v/test_proxy.py | |
| 10:29:24 | thomasb06 | If I understood well you would need all the files `openstack/tests/unit/*/v/test_proxy.py` to be split into test classes as in `block_storage/v3/test_proxy.py` and `compute/v2/test_proxy.py` ? | |
| 10:30:42 | gtema | Yes | |
| 10:31:25 | thomasb06 | Very well, I start today | |
| 10:31:36 | gtema | You can also consult with the corresponding proxy file at all | |
| 10:32:13 | gtema | If you want, we can perhaps have a call today so that I get you briefly through the structure of the project | |
| 10:32:41 | thomasb06 | Maybe it's safer indeed | |
| 10:33:45 | thomasb06 | We have the same timezone so between 4 and 6, you can call any time. And at other moments too, I can take a 5mn break | |
| 10:34:16 | thomasb06 | may I post my number here? Not too sure about it... | |
| 10:35:46 | gtema | Not necessary | |
| 10:36:00 | gtema | I will send link for web conference | |
| 10:36:07 | gtema | Around 17 | |
| 10:36:36 | thomasb06 | Alright, I'll by my mailbox | |
| 11:41:39 | opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: Add Neutron Local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | |
| 14:36:21 | gtema | thomasb06, are you here? Having time now? | |
| 14:38:51 | thomasb06 | Yes, I'm ready | |
| 14:40:07 | gtema | https://meetpad.opendev.org/sdk | |
| #openstack-sdks - 2021-09-07 | |||
| 12:07:40 | opendevreview | Laurent Almeras proposed openstack/ansible-collections-openstack master: use idempotent behavior + diff https://review.opendev.org/c/openstack/ansible-collections-openstack/+/806745 | |
| 14:21:45 | thomasb06 | gtema: Hello. Maybe I can start with `feature/r1/openstack/tests/unit/image/v2`, there seem to be few test files in the tree? | |
| 14:36:37 | thomasb06 | first trial of spliting the `TestImageProxy` class: https://review.opendev.org/c/openstack/openstacksdk/+/807734 | |
| 14:41:24 | gtema | yeah thomasb06 - left comments. You need to split it further as this change (one file per change, and not one split per change | |
| 14:53:42 | thomasb06 | corrected | |
| 14:57:36 | gtema | thks | |
| 15:21:21 | thomasb06 | and I just added the `TestMisc` class | |
| #openstack-sdks - 2021-09-08 | |||
| 14:21:09 | opendevreview | Rodolfo Alonso proposed openstack/openstacksdk master: Add "check_limit" to network Quota class https://review.opendev.org/c/openstack/openstacksdk/+/806254 | |
| 14:33:57 | thomasb06 | gtema: the accelerator unit test can split too | |
| 14:34:11 | gtema | Ok | |
| 14:36:48 | thomasb06 | how can I make a `git pull` to get the latest files? This command asks for a distant and a branch | |
| 14:44:47 | thomasb06 | Here is the commit: https://review.opendev.org/c/openstack/openstacksdk/+/807886 | |
| #openstack-sdks - 2021-09-09 | |||
| 13:21:31 | gtema | thomasb06 - if your question is still valid - you should not really use git pull (unless willing to go to real clean master). Instead you do `git review -d CHANGE_ID`. This will ensure you get latest version of your change | |
| 13:21:51 | gtema | otherwise (for branch) `git checkout master && git pull` | |
| 13:50:56 | opendevreview | Alfredo Moralejo proposed openstack/python-openstackclient master: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/c/openstack/python-openstackclient/+/808079 | |
| 14:52:24 | ebbex | I have a problem where "openstack image set --property hw_qemu_guest_agent=no <uuid> && openstack image show <uuid>" always shows up as hw_qemu_guest_agent='True' in the output, can anyone else see if they get the same result? | |
| 14:53:52 | gtema | you may try to use `openstack image unset --property hw_qemu_guest_agent <uuid>`. Maybe this can make it | |
| 14:53:59 | ebbex | "glance image-show <uuid>" shows it correctly as "no". | |
| 14:54:48 | ebbex | I can even set the property to "horse" and glance shows it correctly but the openstack-client always evaluates it to 'True' for some reason. | |
| 14:54:59 | gtema | hmm, can you post output of the API response from`openstack image show <uuid> --debug`? | |
| 14:55:39 | ebbex | and it's only this property for some reason, hw_machine_type, hw_disk_bus, hw_scsi_model, etc. all fine. | |
| 14:55:49 | gtema | hmm | |
| 14:56:17 | gtema | ok, found | |
| 14:56:26 | gtema | in the SDK the attribute is declared as bool | |
| 14:56:45 | gtema | which means it will not really support `no`, but `false` | |
| 14:59:32 | ebbex | aha, that explains that I suppose. | |
| 15:00:55 | ebbex | the docs I've read on the property say it should be "yes", so really scratched my head when I set it to "no" but it still showed as 'True'. | |
| 15:03:09 | gtema | that was quite bad implementation decision in glance/wherever, cause all other known attributes are really bools, here it is described as "boolean `yes` or `no`" | |
| 15:09:18 | ebbex | hmm, well it doesn't help that i set the property to 'False', 'false' or 'no'. It still reports it back as 'True'. | |
| 15:11:26 | gtema | well: | |
| 15:13:12 | ebbex | oh dear :( | |
| 15:14:44 | ebbex | so there is only setting the property or unsetting it? But nova respects the property if 'no' or 'yes'? (I'll have to check that out next) | |
| 15:15:19 | gtema | this question I can not answer sadly | |
| 15:16:59 | ebbex | nova/objects/image_meta.py: 'hw_qemu_guest_agent': fields.FlexibleBooleanField() | |
| 15:19:34 | ebbex | so nova seems to respect the the value, they even have tests for it with values "yes" and "no". | |
| 15:20:11 | gtema | https://opendev.org/openstack/oslo.utils/src/branch/master/oslo_utils/strutils.py#L122 | |
| 15:20:15 | gtema | this is where it lands | |
| 15:20:47 | gtema | anyway - we should fix it in SDK. This is clearly not a bool, but string for us | |
| 15:22:57 | ebbex | thanks, any place I should file a bug for this? | |
| 15:23:20 | gtema | reports are not welcome, but fixes are ;-) | |
| 15:23:28 | gtema | I will do this shortly | |
| 15:24:07 | opendevreview | Merged openstack/openstacksdk master: Add compute microversion 2.78 https://review.opendev.org/c/openstack/openstacksdk/+/786290 | |
| 15:24:52 | ebbex | Is it as easy as changing the line "hw_qemu_guest_agent = resource.Body('hw_qemu_guest_agent', type=bool)" ? | |
| 15:25:14 | ebbex | (to something else that is) | |
| 15:31:07 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Change image.hw_qemu_guest_agent to be string https://review.opendev.org/c/openstack/openstacksdk/+/808101 | |
| 15:31:30 | gtema | yeah ebbex - like that but also test should be adapted | |
| #openstack-sdks - 2021-09-10 | |||
| 12:56:05 | thomasb06 | gtema: Hello. The directory baremetal could be split too but it's v1 only. It is ok? | |
| 12:56:27 | gtema | sure - everything what you find and you think is reasonable | |
| 12:57:15 | thomasb06 | cool. It's the third I make so maybe I should follow the alphabetical order from now on | |
| 12:57:42 | gtema | yeah | |
| 13:13:42 | thomasb06 | There's TestMisc too: https://review.opendev.org/c/openstack/openstacksdk/+/808209 | |
| 14:34:25 | opendevreview | OpenStack Release Bot proposed openstack/cliff stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/cliff/+/808339 | |
| 14:34:27 | opendevreview | OpenStack Release Bot proposed openstack/cliff stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/cliff/+/808340 | |
| 14:34:29 | opendevreview | OpenStack Release Bot proposed openstack/cliff master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/cliff/+/808341 | |
| 14:35:09 | opendevreview | OpenStack Release Bot proposed openstack/openstacksdk stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/openstacksdk/+/808353 | |
| 14:35:12 | opendevreview | OpenStack Release Bot proposed openstack/openstacksdk stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/openstacksdk/+/808355 | |
| 14:35:15 | opendevreview | OpenStack Release Bot proposed openstack/openstacksdk master: Update master for stable/xena https://review.opendev.org/c/openstack/openstacksdk/+/808356 | |
| 14:35:18 | opendevreview | OpenStack Release Bot proposed openstack/openstacksdk master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/openstacksdk/+/808360 | |
| 14:35:37 | opendevreview | OpenStack Release Bot proposed openstack/osc-lib stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/osc-lib/+/808361 | |
| 14:35:41 | opendevreview | OpenStack Release Bot proposed openstack/osc-lib stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/osc-lib/+/808362 | |
| 14:35:51 | opendevreview | OpenStack Release Bot proposed openstack/osc-lib master: Update master for stable/xena https://review.opendev.org/c/openstack/osc-lib/+/808366 | |
| 14:35:55 | opendevreview | OpenStack Release Bot proposed openstack/osc-lib master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/osc-lib/+/808368 | |
| 17:39:18 | opendevreview | Merged openstack/openstacksdk master: Add support for reading node's "boot_mode" and "secure_boot" fields https://review.opendev.org/c/openstack/openstacksdk/+/802101 | |
| 17:39:28 | opendevreview | Merged openstack/openstacksdk master: Add support for changing baremetal node's boot_mode and secure_boot states https://review.opendev.org/c/openstack/openstacksdk/+/804529 | |
| #openstack-sdks - 2021-09-13 | |||
| 05:46:16 | thomasb06 | gtema: the build didn't rerun, would you have an idea why: https://review.opendev.org/c/openstack/openstacksdk/+/808209 ? | |
| 05:51:34 | gtema | What do you mean? It finished | |
| 05:57:17 | thomasb06 | The build didn't rerun over my last commit | |
| 05:58:09 | thomasb06 | Next folder in the list seems to be `instance_ha`, if I didn't forget one in the middle | |
| 06:03:43 | gtema | What was you expecting that you say "didn't return"? | |
| 06:06:41 | thomasb06 | Zuul should have run the build again, shouldn't it? | |
| 06:18:55 | gtema | Why? When? | |
| 06:19:59 | gtema | According to https://review.opendev.org/c/openstack/openstacksdk/+/808209 you pushed on Sep. 10 last time, Zuul checked and posted results | |
| 06:29:13 | thomasb06 | Ha, I didn't refresh the web page... My bad | |
| 06:30:28 | thomasb06 | The last one: https://review.opendev.org/c/openstack/openstacksdk/+/808580 | |
| 08:24:59 | thomasb06 | The build fails but it doesn't seem to have something to do with me? | |
| 08:27:00 | gtema | nope, it's not. You can leave comment "recheck" in the web ui. Zuul will restart | |
| 10:04:30 | thomasb06 | indeed, this time it passed. Thanks | |
| 12:55:02 | thomasb06 | class KeyManager: https://review.opendev.org/c/openstack/openstacksdk/+/808761 | |
| #openstack-sdks - 2021-09-14 | |||
| 07:41:23 | thomasb06 | The Message class: https://review.opendev.org/c/openstack/openstacksdk/+/808876 | |