Earlier  
Posted Nick Remark
#openstack-sdks - 2021-05-05
13:08:15 noonedeadpunk oh, well, I think you're right gtema
13:08:45 noonedeadpunk frickler: well, you can use --tag several times, right?
13:08:46 noonedeadpunk frickler: well, you can use --tag several times, right?
13:08:51 gtema noonedeadpunk - will you prepare change or should I?
13:08:51 gtema noonedeadpunk - will you prepare change or should I?
13:09:10 gtema yes - you should be able to have same interface of repeating multiple --tag
13:09:10 gtema yes - you should be able to have same interface of repeating multiple --tag
13:09:23 noonedeadpunk doesn't matter for me:)
13:09:23 noonedeadpunk doesn't matter for me:)
13:09:38 noonedeadpunk probably to merge things faster (in terms of self vote) I can push it
13:09:38 noonedeadpunk probably to merge things faster (in terms of self vote) I can push it
13:09:40 gtema if you have time - please, I'm pretty overloaded right now
13:09:40 gtema if you have time - please, I'm pretty overloaded right now
13:27:24 noonedeadpunk sure, testing it :)
13:27:24 noonedeadpunk sure, testing it :)
13:27:35 gtema thks
13:40:16 noonedeadpunk gtema: nah, I was right with https://review.opendev.org/c/openstack/openstacksdk/+/789827
13:40:16 noonedeadpunk gtema: nah, I was right with https://review.opendev.org/c/openstack/openstacksdk/+/789827
13:40:43 gtema why?
13:40:43 gtema why?
13:40:51 noonedeadpunk as with your suggestion sdk sends request /v2/images?tags=openstack
13:40:51 noonedeadpunk as with your suggestion sdk sends request /v2/images?tags=openstack
13:41:08 noonedeadpunk and glance list api has only tag
13:41:09 noonedeadpunk and glance list api has only tag
13:41:29 noonedeadpunk while create is tags
13:41:30 noonedeadpunk while create is tags
13:41:48 noonedeadpunk https://docs.openstack.org/api-ref/image/v2/index.html?expanded=list-images-detail,create-image-detail#id10
13:41:48 noonedeadpunk https://docs.openstack.org/api-ref/image/v2/index.html?expanded=list-images-detail,create-image-detail#id10
13:42:28 gtema oh thats not cool
13:42:28 gtema oh thats not cool
13:42:41 noonedeadpunk so there's kind of inconsistency in glance itself I really skipped
13:42:41 noonedeadpunk so there's kind of inconsistency in glance itself I really skipped
13:43:56 gtema and what if we pass array of tags as "tag" into SDK. What does it send to glance? I roughly remenber some other case
13:43:56 gtema and what if we pass array of tags as "tag" into SDK. What does it send to glance? I roughly remenber some other case
13:44:19 gtema where we need to send same attirbute multiple times, but I can't recall where it was
13:44:20 gtema where we need to send same attirbute multiple times, but I can't recall where it was
13:44:25 noonedeadpunk it's sending only last mentioned one
13:44:25 noonedeadpunk it's sending only last mentioned one
13:44:50 noonedeadpunk ie `openstack image list --tag openstack --tag test ` ends up in `/v2/images?tag=test`
13:44:50 noonedeadpunk ie `openstack image list --tag openstack --tag test ` ends up in `/v2/images?tag=test`
13:45:07 noonedeadpunk but maybe we can make it list... not sure
13:45:07 noonedeadpunk but maybe we can make it list... not sure
13:45:25 gtema there is way, I'm searching
13:45:25 gtema there is way, I'm searching
13:45:56 noonedeadpunk Yeah, I think we can just change to append here
13:45:56 noonedeadpunk Yeah, I think we can just change to append here
13:46:14 noonedeadpunk https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L612-L616
13:46:14 noonedeadpunk https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L612-L616
13:47:02 noonedeadpunk will produce /v2/images?tag=openstack&tag=test
13:47:02 noonedeadpunk will produce /v2/images?tag=openstack&tag=test
13:47:08 gtema that's what I meant, but exactly here I'm not sure how SDK passes this to glance
13:47:08 gtema that's what I meant, but exactly here I'm not sure how SDK passes this to glance
13:49:51 noonedeadpunk doh. indeed
13:49:51 noonedeadpunk doh. indeed
13:51:01 noonedeadpunk reverting like 789827 breaks image update...
13:51:01 noonedeadpunk reverting like 789827 breaks image update...
13:53:45 openstackgerrit Dmitriy Rabotyagov proposed openstack/openstacksdk master: Revert tags option back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827
13:59:34 openstackgerrit Dmitriy Rabotyagov proposed openstack/python-openstackclient master: Allow to filter multiple tags for image list https://review.opendev.org/c/openstack/python-openstackclient/+/789838
14:23:33 nightmare_unreal https://www.irccloud.com/pastebin/1JKwl1hg/
14:23:33 nightmare_unreal https://www.irccloud.com/pastebin/1JKwl1hg/
14:28:37 openstackgerrit Dmitriy Rabotyagov proposed openstack/openstacksdk master: Revert tags option back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827
14:28:38 openstackgerrit Dmitriy Rabotyagov proposed openstack/openstacksdk master: Revert tags option back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827
14:29:24 openstackgerrit Dmitriy Rabotyagov proposed openstack/openstacksdk master: Revert tags query_params back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827
14:29:24 openstackgerrit Dmitriy Rabotyagov proposed openstack/openstacksdk master: Revert tags query_params back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827
15:20:34 openstackgerrit Artem Goncharov proposed openstack/ansible-collections-openstack master: Switch project and project_info module to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789793
15:30:03 openstackgerrit Dmitriy Rabotyagov proposed openstack/python-openstackclient master: Allow to filter multiple tags for image list https://review.opendev.org/c/openstack/python-openstackclient/+/789838
15:33:31 openstackgerrit Dmitriy Rabotyagov proposed openstack/python-openstackclient master: Allow to filter multiple tags for image list https://review.opendev.org/c/openstack/python-openstackclient/+/789838
15:37:06 openstackgerrit Dmitriy Rabotyagov proposed openstack/python-openstackclient master: Allow to filter multiple tags for image list https://review.opendev.org/c/openstack/python-openstackclient/+/789838
16:33:51 openstackgerrit Artem Goncharov proposed openstack/ansible-collections-openstack master: Switch project and project_info module to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789793
16:33:51 openstackgerrit Artem Goncharov proposed openstack/ansible-collections-openstack master: Switch project and project_info module to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789793
16:57:50 openstackgerrit Dmitriy Rabotyagov proposed openstack/python-openstackclient master: Allow to filter multiple tags for image list https://review.opendev.org/c/openstack/python-openstackclient/+/789838
#openstack-sdks - 2021-05-06
09:39:46 openstackgerrit Riccardo Pittau proposed openstack/openstacksdk master: Fix import order in load_balancer unit tests https://review.opendev.org/c/openstack/openstacksdk/+/790025
09:39:46 openstackgerrit Riccardo Pittau proposed openstack/openstacksdk master: Fix import order in load_balancer unit tests https://review.opendev.org/c/openstack/openstacksdk/+/790025
10:32:04 openstackgerrit Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Add TripleO job on collections used in TripleO https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789818
10:33:14 openstackgerrit Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Add TripleO job on collections used in TripleO https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789818
11:19:19 openstackgerrit Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Add TripleO job on collections used in TripleO https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789818
11:24:31 openstackgerrit Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: DNM test jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/790041
11:24:31 openstackgerrit Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: DNM test jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/790041
11:25:35 gtema slaweq: is vpnaas alive from Neutron POV or not?
11:25:35 gtema slaweq: is vpnaas alive from Neutron POV or not?
11:25:47 slaweq gtema: yes, it is
11:25:47 slaweq gtema: yes, it is
11:25:54 slaweq is't one of the stadium projects
11:25:54 slaweq is't one of the stadium projects
11:26:01 gtema cool, then we proceed with https://review.opendev.org/c/openstack/openstacksdk/+/788474
11:26:01 gtema cool, then we proceed with https://review.opendev.org/c/openstack/openstacksdk/+/788474
11:26:08 slaweq there isn't a lot of new development there but it's still maintained
11:26:08 slaweq there isn't a lot of new development there but it's still maintained
11:26:17 gtema that is good to hear
11:26:17 gtema that is good to hear
11:26:18 gtema thanks
11:26:19 gtema thanks
11:26:32 slaweq thx for the heads up
11:26:32 slaweq thx for the heads up
11:26:36 gtema under "proceed" I mean we will proceed with development
11:26:36 slaweq I will take a look
11:26:36 gtema under "proceed" I mean we will proceed with development
11:26:36 slaweq I will take a look
11:26:42 slaweq and will also ask amotoki to check that patch
11:26:43 slaweq and will also ask amotoki to check that patch

Earlier   Later