| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-04-14 | |||
| 21:19:37 | ade_lee_ | or do I need to define something like a devstack-tox-functional-fips etc.? | |
| 21:20:17 | ade_lee_ | sorry - not sure if this is the right channel for these questions .. | |
| 21:20:17 | ade_lee_ | sorry - not sure if this is the right channel for these questions .. | |
| 21:25:14 | fungi | ade_lee_: well, this is more appropriate for openstacksdk and openstackclient discussions, but no worries. yeah what you've got there could be included in devstack or openstack-zuul-jobs... you might consider making it an ansible role rather than a playbook though, as that would allow you to include it in a job variant without having to rely on more heavyweight job inheritance | |
| 21:25:14 | fungi | ade_lee_: well, this is more appropriate for openstacksdk and openstackclient discussions, but no worries. yeah what you've got there could be included in devstack or openstack-zuul-jobs... you might consider making it an ansible role rather than a playbook though, as that would allow you to include it in a job variant without having to rely on more heavyweight job inheritance | |
| 21:26:33 | ade_lee_ | fungi, do you have an example of where that is used? | |
| 21:26:33 | ade_lee_ | fungi, do you have an example of where that is used? | |
| 21:26:45 | fungi | i'll see what i can dig up, just a sec | |
| 21:26:45 | fungi | i'll see what i can dig up, just a sec | |
| 21:33:52 | fungi | may take me a little longer to find a good example of what i'm thinking of (job writing isn't actually one of my strengths, but you've got me curious now too) | |
| 21:33:52 | fungi | may take me a little longer to find a good example of what i'm thinking of (job writing isn't actually one of my strengths, but you've got me curious now too) | |
| 21:34:41 | ade_lee_ | fungi, ack - thanks -- no problem -- I'll just check back here later to see if you've found something | |
| 21:34:41 | ade_lee_ | fungi, ack - thanks -- no problem -- I'll just check back here later to see if you've found something | |
| 21:41:54 | fungi | ade_lee_: okay, i have a fairly concise example relevant to the sdk channel even... ;) | |
| 21:41:54 | fungi | ade_lee_: okay, i have a fairly concise example relevant to the sdk channel even... ;) | |
| 21:41:58 | fungi | https://opendev.org/openstack/openstacksdk/src/branch/master/playbooks/devstack/post.yaml#L9 | |
| 21:41:58 | fungi | https://opendev.org/openstack/openstacksdk/src/branch/master/playbooks/devstack/post.yaml#L9 | |
| 21:42:39 | fungi | that "devstack" playbook in openstacksdk includes the process-stackviz role, which is itself defined in the devstack repo: https://opendev.org/openstack/devstack/src/branch/master/roles/process-stackviz | |
| 21:42:39 | fungi | that "devstack" playbook in openstacksdk includes the process-stackviz role, which is itself defined in the devstack repo: https://opendev.org/openstack/devstack/src/branch/master/roles/process-stackviz | |
| 21:43:18 | ade_lee_ | fungi, cool | |
| 21:43:18 | ade_lee_ | fungi, cool | |
| 21:43:35 | fungi | so what i was (poorly) trying to express earlier is that by encapsulating your tasks into a role, that role can reside easily in a different repository than the playbooks (and hence job definitions) which rely on it | |
| 21:43:35 | fungi | so what i was (poorly) trying to express earlier is that by encapsulating your tasks into a role, that role can reside easily in a different repository than the playbooks (and hence job definitions) which rely on it | |
| 21:44:35 | fungi | so multiple jobs and their playbooks in different projects, e.g. nova, heat, grenade... reuse that role in jobs they've defined | |
| 21:44:35 | fungi | so multiple jobs and their playbooks in different projects, e.g. nova, heat, grenade... reuse that role in jobs they've defined | |
| 21:44:56 | ade_lee_ | fungi, ack thats the model I was looking for , rather than job inheritance | |
| 21:44:56 | ade_lee_ | fungi, ack thats the model I was looking for , rather than job inheritance | |
| 21:45:42 | ade_lee_ | fungi, thanks -- looking at how opensdk uses that now | |
| 21:45:42 | ade_lee_ | fungi, thanks -- looking at how opensdk uses that now | |
| 21:45:50 | ade_lee_ | but this is great - thanks! | |
| 21:45:50 | ade_lee_ | but this is great - thanks! | |
| 21:46:52 | fungi | in the case of openstacksdk, it's using its devstack playbook in post-run phase for jobs: https://opendev.org/openstack/devstack/src/branch/master/roles/process-stackviz | |
| 21:46:52 | fungi | in the case of openstacksdk, it's using its devstack playbook in post-run phase for jobs: https://opendev.org/openstack/devstack/src/branch/master/roles/process-stackviz | |
| 21:46:57 | fungi | er, sorry wrong buffer | |
| 21:46:57 | fungi | er, sorry wrong buffer | |
| 21:47:03 | fungi | https://opendev.org/openstack/openstacksdk/src/branch/master/.zuul.yaml#L30 | |
| 21:47:03 | fungi | https://opendev.org/openstack/openstacksdk/src/branch/master/.zuul.yaml#L30 | |
| 21:48:46 | ade_lee_ | fungi, yup - so in nova for instance, I'd have to define a playbook that would include the fips role (that would be checked into devstack) | |
| 21:48:46 | ade_lee_ | fungi, yup - so in nova for instance, I'd have to define a playbook that would include the fips role (that would be checked into devstack) | |
| 21:49:03 | ade_lee_ | and call that playbook in my nova job? | |
| 21:49:03 | ade_lee_ | and call that playbook in my nova job? | |
| 21:49:13 | ade_lee_ | and a pre-run or whatever .. | |
| 21:49:13 | ade_lee_ | and a pre-run or whatever .. | |
| 21:49:14 | fungi | so similar to your change, except that enable-fips.yaml could just be a hollow inclusion directive and the meat of it can then go in whatever repo you want | |
| 21:49:14 | fungi | so similar to your change, except that enable-fips.yaml could just be a hollow inclusion directive and the meat of it can then go in whatever repo you want | |
| 21:49:45 | ade_lee_ | yup cool - that makes sense | |
| 21:49:45 | ade_lee_ | yup cool - that makes sense | |
| 21:49:59 | fungi | and that way you don't have to copy it into multiple different repos | |
| 21:49:59 | fungi | and that way you don't have to copy it into multiple different repos | |
| 21:50:22 | ade_lee_ | yup indeed | |
| 21:50:22 | ade_lee_ | yup indeed | |
| 21:50:58 | fungi | that way it can also be added to existing playbooks in other jobs just by adding an include statement | |
| 21:50:58 | fungi | that way it can also be added to existing playbooks in other jobs just by adding an include statement | |
| 21:51:24 | ade_lee_ | cool | |
| 21:51:24 | ade_lee_ | cool | |
| 21:52:04 | ade_lee_ | thanks a lot! | |
| 21:52:04 | ade_lee_ | thanks a lot! | |
| 21:53:21 | fungi | yw | |
| 21:53:21 | fungi | yw | |
| 21:54:14 | fungi | ade_lee_: if you have related questions, #openstack-infra or #openstack-qa are probably better places to get help since more folks with experience in this are likely to be paying attention | |
| 21:54:14 | fungi | ade_lee_: if you have related questions, #openstack-infra or #openstack-qa are probably better places to get help since more folks with experience in this are likely to be paying attention | |
| 21:55:27 | ade_lee_ | fungi, thanks - I was wondering where to go - and figured you might know :) | |
| 21:55:27 | ade_lee_ | fungi, thanks - I was wondering where to go - and figured you might know :) | |
| 21:55:52 | fungi | you bet | |
| 21:55:52 | fungi | you bet | |
| #openstack-sdks - 2021-04-15 | |||
| 00:24:11 | twilit_dragon | stephenfin, I have a merge conflict that I need to resolve before I can make a final amendment to my commit (for resource_filters). Just want to verify with you that I have to rebase my commit to solve this issue? | |
| 00:24:11 | twilit_dragon | stephenfin, I have a merge conflict that I need to resolve before I can make a final amendment to my commit (for resource_filters). Just want to verify with you that I have to rebase my commit to solve this issue? | |
| 04:02:32 | openstackgerrit | Kajal Sah proposed openstack/openstacksdk master: Adds Node Vendor passthru https://review.opendev.org/c/openstack/openstacksdk/+/785445 | |
| 08:31:30 | stephenfin | twilit_dragon: Yup, you'll have to rebase that to resolve it | |
| 08:31:30 | stephenfin | twilit_dragon: Yup, you'll have to rebase that to resolve it | |
| 12:38:45 | openstackgerrit | Guravareddy proposed openstack/ansible-collections-openstack master: Adding new parameter for the os_stack module that provides option to skip the existing stack updation if the stack is present in Openstack. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/786416 | |
| 12:56:37 | openstackgerrit | Guravareddy proposed openstack/ansible-collections-openstack master: Adding new parameter for the os_stack module that provides option to skip the existing stack updation if the stack is present in Openstack. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/786416 | |
| 12:56:37 | openstackgerrit | Guravareddy proposed openstack/ansible-collections-openstack master: Adding new parameter for the os_stack module that provides option to skip the existing stack updation if the stack is present in Openstack. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/786416 | |
| 13:03:37 | openstackgerrit | Guravareddy proposed openstack/ansible-collections-openstack master: Adding new parameter for the os_stack module that provides option to skip the existing stack update. Change-Id: I34697db9a6c3b56720fdaed8dc4f06518f61afc9 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/786416 | |
| 13:13:44 | openstackgerrit | Kajal Sah proposed openstack/openstacksdk master: Adds Node Vendor passthru https://review.opendev.org/c/openstack/openstacksdk/+/785445 | |
| 13:35:15 | openstackgerrit | Guravareddy proposed openstack/ansible-collections-openstack master: Adding new parameter for the os_stack module that provides option to skip the existing stack update. Change-Id: I34697db9a6c3b56720fdaed8dc4f06518f61afc9 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/786416 | |
| 13:35:15 | openstackgerrit | Guravareddy proposed openstack/ansible-collections-openstack master: Adding new parameter for the os_stack module that provides option to skip the existing stack update. Change-Id: I34697db9a6c3b56720fdaed8dc4f06518f61afc9 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/786416 | |
| 13:44:51 | openstackgerrit | Guravareddy proposed openstack/ansible-collections-openstack master: Adding new parameter for the os_stack module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/786416 | |
| 14:42:25 | diablo_rojo | stephenfin, gtema_ I will be a few min late to the meeting with the NDSU students. I am probably going to get held up in the community meeting a bit. We are running about 7 min late atm.. | |
| 14:42:25 | diablo_rojo | stephenfin, gtema_ I will be a few min late to the meeting with the NDSU students. I am probably going to get held up in the community meeting a bit. We are running about 7 min late atm.. | |
| 14:43:21 | gtema_ | ok | |
| 14:43:21 | gtema_ | ok | |
| 14:43:46 | diablo_rojo | Go ahead and get started without me :) | |
| 14:43:46 | diablo_rojo | Go ahead and get started without me :) | |
| 14:43:56 | diablo_rojo | Unless you want to just talk about redbull till I arrive. | |
| 14:43:56 | diablo_rojo | Unless you want to just talk about redbull till I arrive. | |
| 14:46:49 | stephenfin | no issues | |
| 14:46:49 | stephenfin | no issues | |
| 14:50:37 | openstackgerrit | Guravareddy proposed openstack/ansible-collections-openstack master: Adding new parameter for the os_stack module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/786416 | |
| 14:50:38 | openstackgerrit | Guravareddy proposed openstack/ansible-collections-openstack master: Adding new parameter for the os_stack module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/786416 | |
| 15:13:18 | diablo_rojo | Sorry..still in this meeting, but we are wrapping up now. | |
| 15:13:18 | diablo_rojo | Sorry..still in this meeting, but we are wrapping up now. | |
| 15:13:21 | diablo_rojo | Will be there soon. | |
| 15:13:21 | diablo_rojo | Will be there soon. | |
| 16:04:46 | openstackgerrit | Merged openstack/osc-lib master: Update master for stable/wallaby https://review.opendev.org/c/openstack/osc-lib/+/781703 | |
| 16:04:46 | openstackgerrit | Merged openstack/osc-lib master: Update master for stable/wallaby https://review.opendev.org/c/openstack/osc-lib/+/781703 | |
| 16:43:06 | openstackgerrit | Merged openstack/osc-lib master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/osc-lib/+/781704 | |
| 16:43:06 | openstackgerrit | Merged openstack/osc-lib master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/osc-lib/+/781704 | |
| 17:31:40 | openstackgerrit | Merged openstack/cliff master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/cliff/+/781695 | |
| 17:31:40 | openstackgerrit | Merged openstack/cliff master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/cliff/+/781695 | |