Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2021-03-12
14:03:03 mordred yah - this is why our system-config jobs add bridge as an inventory host and the zuul job runs ansible on bridge in a shell task
14:03:06 gtema I am willing to also implement searching
14:03:31 mordred do you mean https://codesearch.opendev.org/ ?
14:03:48 gtema nope, the search.openstack.org used by docs.openstack.org
14:04:52 mordred I honestly don't know - I think the foundation might have set that up? fungi or clarkb might know
14:05:06 gtema okay, thanks a lot anyway
14:05:50 gtema btw, with https://review.opendev.org/c/openstack/openstacksdk/+/766783 I have figured out that we break ansible a lot
14:06:23 gtema already clarified with the collection, that we will update all modules to enforce doing to_dict for whatever SDK returns to ansible
14:06:30 fungi search.openstack.org does seem to be something related to the foundation-run openstack.org website, yes
14:06:41 gtema as usual - Ansible is doing some weird things, but we can't really blame it
14:07:13 gtema fungi - the question is basically which software is running there and how it indexes the content
14:07:55 fungi i can ask the webdev folks, it's almost certainly outsourced to a third party to maintain
14:08:56 gtema fungi - no worries. In that case it is most likely to be something more complex then I was supposing
14:09:19 gtema mordred: I think I will shortly start a "r1" branch where we can complete switch of the cloud layer to proxy, so that cloud returns always resources, and not munches
14:09:42 fungi gtema: what were you wanting to search with it? maybe they're willing to add something
14:09:57 gtema and once it is complete we can merge it and cut a release, which is partly breaking interface (depending on your usage pattern)
14:10:37 gtema fungi - no, I am "mimicing" OpenStack infra setup for our cloud and need to find a way to index html content in docs "portal"
14:10:49 fungi aha, got it
14:11:07 gtema just want to understand how it works
14:11:16 fungi if it were a single sphix document, then sphinx's search capability would be an option
14:11:52 fungi but if it's a copy of the openstack project docs, that's all different projects so the indices aren't merged
14:11:52 gtema yeah, but we talk about multiple subprojects pushing their own content
14:11:59 fungi right
14:12:46 gtema ok, will think deeper on possibilities
14:13:10 gtema thanks
14:13:40 fungi classical approach would be to rely on one of the numerous open source solutions which spider your site content and create trigram indices, though you'd need to adjust the sphinx theme to embed the form field calling out to whatever index interface it provides
14:14:07 gtema exact
19:05:52 yoctozepto morning gentlefolks, a little emergency in here
19:06:06 yoctozepto the newly released openstacksdk includes a breaking change
19:06:09 yoctozepto at least for masakari
19:06:17 yoctozepto (and it's not the one for masakari)
19:06:21 yoctozepto this -> https://review.opendev.org/c/openstack/openstacksdk/+/776205
19:06:48 yoctozepto I don't know about other projects but all might be impacted in subtle ways
19:07:05 mordred gtema: discovery in #zuul - api output can be different between list servers and get server - in this particular case, list shows a server stuck in building, but get doesn't show it existing at all. nodepool does the right thing because it always uses list and client-side filter - but the behavior can be confusing from OSC
19:07:07 mordred yoctozepto: looking
19:07:56 yoctozepto this patch essentially adds new props on listings
19:08:08 mordred yoctozepto: I don't have enough context here, sorry. ... and poop, gtema isn't here
19:08:11 mordred yoctozepto: why is that breaking things?
19:08:41 yoctozepto because, at least masakari, has tests that compare things 1:1
19:08:50 mordred oh - that's a bug in masakari
19:08:59 yoctozepto :D
19:09:08 mordred the sdk interface contract does not consider adding properties to be a breaking change
19:09:08 yoctozepto could be
19:09:33 mordred it is always fair for us to add without warning. we will not, however, take properties away - that is a breaking change
19:09:46 mordred so tests that test for 1:1 are bad tests
19:10:05 mordred (sorry, I know that doesn't put you in an awesome position at this moment)
19:10:13 yoctozepto ok, note taken
19:10:18 yoctozepto haha, I have not written them
19:10:25 mordred I know :P)
19:10:26 yoctozepto I don't like the "functional" tests that we have
19:10:56 yoctozepto they are like glorified unit tests that require full devstack deployment :D
19:11:04 mordred gross
19:11:38 mordred also - we have unit tests that test api structures in sdk - so masakari doesn't really need to also test that the sdk works
19:11:39 yoctozepto yeah, it's more like half-bottomed thing that should be in tempest but otoh is still too basic to go there
19:12:16 yoctozepto :D
19:13:18 yoctozepto ok, so I will adapt these tests to make sense and not break
19:13:53 yoctozepto and you know what happened if any other project comes crying their ci broke for no apparent reason :D
19:19:30 mordred :)
19:20:30 mordred yoctozepto: might be worth making a masakari functional test job that uses the functional tests in sdk (maybe adding more) and run it on both sdk and masakari changes - we do that for a few other services
19:21:34 yoctozepto mordred: ack, that would likely make sense
19:21:45 yoctozepto I think sdk does only unit tests for masakari atm
19:26:08 yoctozepto I honestly can't wrap my head around the usefulness of the now-failing test
19:33:35 mordred yoctozepto: what do you want to bet it's testing that the test tests what the test tests?
19:35:41 yoctozepto WHA? :D
20:00:53 openstackgerrit Merged openstack/ansible-collections-openstack master: security_group_rule: add support ipv6-icmp https://review.opendev.org/c/openstack/ansible-collections-openstack/+/778627
20:12:42 yoctozepto mordred: by the look at those test, you might be right that they would gladly belong in openstacksdk's functional ones
20:13:18 yoctozepto mordred: I have proposed https://review.opendev.org/c/openstack/masakari/+/780319 - I would appreciate if you could take a look at the change as well as other functional tests around and advise me
20:23:03 openstackgerrit Dylan Zapzalka proposed openstack/openstacksdk master: Added support for the Limits resource https://review.opendev.org/c/openstack/openstacksdk/+/780323
#openstack-sdks - 2021-03-15
08:40:12 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
14:31:56 openstackgerrit Takashi Kajinami proposed openstack/python-openstackclient master: Update the file paths mentioned in README.rst https://review.opendev.org/c/openstack/python-openstackclient/+/780599
14:34:27 openstackgerrit Takashi Kajinami proposed openstack/openstackclient master: Include osc-placement in the plugin check job https://review.opendev.org/c/openstack/openstackclient/+/780601
19:30:40 openstackgerrit Merged openstack/python-openstackclient master: Update the file paths mentioned in README.rst https://review.opendev.org/c/openstack/python-openstackclient/+/780599
#openstack-sdks - 2021-03-16
02:01:15 openstackgerrit Dylan Zapzalka proposed openstack/openstacksdk master: Added support for the Limits resource https://review.opendev.org/c/openstack/openstacksdk/+/780323
12:31:45 openstackgerrit Merged openstack/openstacksdk master: Apply pep8 import order style https://review.opendev.org/c/openstack/openstacksdk/+/779288
13:35:58 openstackgerrit Brian Haley proposed openstack/python-openstackclient master: Add --subnet-pool to subnet list https://review.opendev.org/c/openstack/python-openstackclient/+/778521
13:54:57 openstackgerrit Merged openstack/api-sig master: Change primary eamil for Rico Lin https://review.opendev.org/c/openstack/api-sig/+/778863
14:47:55 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
14:50:08 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
14:50:55 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
14:57:26 openstackgerrit Riccardo Pittau proposed openstack/openstacksdk master: Apply import order in some tests https://review.opendev.org/c/openstack/openstacksdk/+/780872
15:04:16 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
15:34:51 openstackgerrit Riccardo Pittau proposed openstack/openstacksdk master: Fix more import order in tests https://review.opendev.org/c/openstack/openstacksdk/+/780903
22:44:30 openstackgerrit Nicole Chen proposed openstack/openstacksdk master: Add export location resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/780990
#openstack-sdks - 2021-03-17
00:10:01 openstackgerrit Goutham Pacha Ravi proposed openstack/openstacksdk master: Add export location resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/780990
00:24:51 openstackgerrit Ashley Rodriguez proposed openstack/openstacksdk master: Add share resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/775707
00:43:43 openstackgerrit Ashley Rodriguez proposed openstack/openstacksdk master: Add share resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/775707
05:06:21 openstackgerrit Goutham Pacha Ravi proposed openstack/openstacksdk master: Add export location resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/780990
17:09:01 openstackgerrit Ryan Zimmerman proposed openstack/openstacksdk master: Add compute microversion 2.57 https://review.opendev.org/c/openstack/openstacksdk/+/781131
17:24:31 openstackgerrit Ryan Zimmerman proposed openstack/openstacksdk master: Add compute microversion 2.57 https://review.opendev.org/c/openstack/openstacksdk/+/781131
17:24:56 openstackgerrit Ryan Zimmerman proposed openstack/openstacksdk master: Add compute microversion 2.57 https://review.opendev.org/c/openstack/openstacksdk/+/781131
17:37:57 diablo_rojo stephenfin, gtema do you have some time today to review zimmerry's patch?
17:38:04 diablo_rojo zimmerry, got a link for them? :)
17:38:19 zimmerry https://review.opendev.org/c/openstack/openstacksdk/+/745375
17:39:28 gtema ok, will try to have another look tomorrow, today no buffer, sorry
17:39:42 diablo_rojo no worries gtema tomorrow works
21:07:36 openstackgerrit Dylan Zapzalka proposed openstack/openstacksdk master: Added support for the GroupSnapshot resource https://review.opendev.org/c/openstack/openstacksdk/+/781163
21:42:58 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Object module for management Swift objects https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779718
#openstack-sdks - 2021-03-18
02:27:15 openstackgerrit Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Object module for management Swift objects https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779718
08:39:40 openstackgerrit Merged openstack/python-openstackclient master: project cleanup https://review.opendev.org/c/openstack/python-openstackclient/+/734485
08:40:15 openstackgerrit Merged openstack/python-openstackclient stable/victoria: Add reno for change Ic3c555226a220efd9b0f27edffccf6c4c95c2747 https://review.opendev.org/c/openstack/python-openstackclient/+/770130

Earlier   Later