Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2021-03-06
13:57:30 openstackgerrit Merged openstack/python-openstackclient master: network: Add missing subnet unset --gateway https://review.opendev.org/c/openstack/python-openstackclient/+/778906
#openstack-sdks - 2021-03-08
08:06:17 openstackgerrit Dylan Zapzalka proposed openstack/openstacksdk master: Added support for the Default Volume Types resource https://review.opendev.org/c/openstack/openstacksdk/+/779172
12:08:14 openstackgerrit Akihiro Motoki proposed openstack/openstackclient master: DNM: Test openstackclient-check-plugins job https://review.opendev.org/c/openstack/openstackclient/+/779240
15:52:25 openstackgerrit Riccardo Pittau proposed openstack/openstacksdk master: Apply pep8 import order style https://review.opendev.org/c/openstack/openstacksdk/+/779288
#openstack-sdks - 2021-03-09
18:09:07 openstackgerrit Radosław Piliszek proposed openstack/openstackclient master: osc-check-plugins job: Ensure OSC plugins from git https://review.opendev.org/c/openstack/openstackclient/+/779240
18:09:27 openstackgerrit Radosław Piliszek proposed openstack/openstackclient master: Add python-masakariclient https://review.opendev.org/c/openstack/openstackclient/+/778542
18:10:07 openstackgerrit Radosław Piliszek proposed openstack/openstackclient master: Add python-masakariclient https://review.opendev.org/c/openstack/openstackclient/+/778542
20:32:44 yoctozepto I might have a dumb question
20:33:12 yoctozepto but is not the 'type' in 'Body' meant to convert the values on create/update?
20:33:23 yoctozepto I would assume it, but it is not what I am observing
20:33:47 yoctozepto when trying to get masakari segment to update its is_enabled
20:34:00 yoctozepto it just passes the string 'False' or 'True' through
20:34:10 yoctozepto remaps the attribute name properly
20:34:16 yoctozepto but not the value
21:05:06 mordred yoctozepto: what you want is: type=format.BoolStr
21:05:47 mordred yoctozepto: (grep for "format.BoolStr" and you can see examples of use
21:07:19 yoctozepto mordred: thanks, will check this out tomorrow; a quick followup question: any downsides to this? i.e., when stick to 'bool'
21:08:45 yoctozepto when to* stick to
21:09:58 mordred yoctozepto: I don't think there are any downsides - the main thinng is that the conversion code needs a constructor
21:10:12 mordred if it's not a list or dict (which need logic) - the conversion code does type(value)
21:10:22 mordred and sadly bool('False') == True
21:11:11 mordred I honestly can't think of a reason why special casing bool in _convert_type would be bad ...
21:11:51 mordred but there might be a reason I'm not thinking of, and using format.BoolStr is safe enough until we could be happy of that
21:12:02 mordred so - long story short - no, I can't think of many reasons to just use bool somewhere
21:12:51 mordred yoctozepto: type=bool works fine if the server is returning a json bool and not a string
#openstack-sdks - 2021-03-10
06:02:53 frickler this reminds me of https://twitter.com/RachelTrue/status/1365461618977476610 , not sure if that's really a True story, though
06:17:49 yoctozepto mordred: thanks for your answer
06:18:01 yoctozepto the server returns a bool
06:18:17 yoctozepto I am asking about converting what client sets
06:18:33 yoctozepto (just in case these are two different things)
06:19:54 yoctozepto frickler: hehehe, I saw that already, that was an overly smart form haha
09:44:11 yoctozepto mordred: yeah, I figured there was a misunderstanding between us - the server uses json booleans and it's the client that does not do the conversion
09:44:24 yoctozepto so I understand this is only from the server to client
09:44:35 yoctozepto and client should know what to set locally
10:59:01 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
11:09:28 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Object module for management Swift objects https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779718
11:16:33 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Object module for management Swift objects https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779718
11:17:18 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
11:17:43 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
11:18:45 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
11:20:51 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Object module for management Swift objects https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779718
11:21:50 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
11:32:56 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
11:33:50 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Object module for management Swift objects https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779718
14:41:33 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
15:14:02 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Object module for management Swift objects https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779718
15:43:12 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
15:46:44 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Object module for management Swift objects https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779718
19:16:40 yoctozepto I just realised that for an update (PUT), osdk gives me GET-PUT-GET even though the PUT sends the objects in full
19:16:48 yoctozepto so it's quite wasteful
19:17:11 yoctozepto any reasoning behind that?
19:17:55 gtema all depends on the dedicated set of calls. If you have concrete object - it should not, if you have just name - we will first search
19:39:13 yoctozepto but if I have the UUID
19:39:24 yoctozepto no search should be happening, PUT can happen directly
19:39:50 gtema gimme you script please
19:45:40 yoctozepto sorry, my eyes tricked me, it's only PUT-GET (doing it consecutively I mistakenly saw GET-PUT-GET)
19:45:51 yoctozepto so the issue is only
19:45:55 yoctozepto why PUT&GET
19:46:14 gtema no problem. There are definitely cases it will do it this way if SDK doesn't really know what it has
19:46:56 yoctozepto ignore me, I should rest more, I have this another GET too
19:47:10 yoctozepto :D
19:47:12 gtema PUT&GET - which service/call? there afair cases where it is required
19:47:40 yoctozepto noo, it's just me overlooking own code
19:47:53 yoctozepto twice in one case, need to go rest
19:48:02 gtema oki :)
20:12:09 mordred :)
20:13:01 mordred (there are definitely cases where we do a followup GET on the user's behalf, because sometimes the result from the PUT is not a useable full object - server comes to mind ... but glad to hear this time it wasn't us)
#openstack-sdks - 2021-03-11
07:36:18 yoctozepto cross-posting this message on #openstack-release and #openstack-sdks)
07:36:18 yoctozepto hello dears, I have a question regarding openstacksdk release; I have just noticed it is not treated as "client library" and had its "final release" on Mar 03; the issue is masakariclient has code that depends on unreleased openstacksdk features; please let me know if openstacksdk may release again for wallaby or masakari is doomed (/me
08:13:49 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Object module for management Swift objects https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779718
08:49:48 yoctozepto specifically I am about https://review.opendev.org/c/openstack/openstacksdk/+/777299
09:56:30 yoctozepto (I got answers on #openstack-sdk)
09:58:13 yoctozepto (I got answers on #openstack-release) sorry :-)
09:59:05 gtema yoctozepto, we can release SDK "any" point in time
10:00:13 yoctozepto gtema: +/- as far as features are concerned
10:00:14 yoctozepto but yeah
10:00:16 yoctozepto seem so
12:44:51 openstackgerrit Merged openstack/python-openstackclient master: compute: Add functional tests for --block-device https://review.opendev.org/c/openstack/python-openstackclient/+/778763
12:49:13 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Object module for management Swift objects https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779718
12:51:52 openstackgerrit Merged openstack/python-openstackclient master: compute: Add support for loading BDMs from files https://review.opendev.org/c/openstack/python-openstackclient/+/778910
15:57:33 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: compute: Remove 'file://' prefix from '--block-device' https://review.opendev.org/c/openstack/python-openstackclient/+/780025
16:21:03 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Add pre-commit https://review.opendev.org/c/openstack/python-openstackclient/+/780030
16:23:49 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Add pre-commit https://review.opendev.org/c/openstack/python-openstackclient/+/780030
16:29:13 openstackgerrit Stephen Finucane proposed openstack/openstacksdk master: Add pre-commit https://review.opendev.org/c/openstack/openstacksdk/+/780032
16:40:59 stephenfin gtema: For after the meeting, I pushed the fix to drop the 'file://' prefix from that '--block-device' opt above ^
16:41:06 stephenfin Since you mentioned it on the review
16:52:05 gtema yupp, noticed already
18:10:05 yoctozepto [drop-the-legacy-client c36e647] Drop the legacy client
18:10:06 yoctozepto 16 files changed, 8 insertions(+), 1590 deletions(-)
18:10:11 yoctozepto how refreshing
18:10:30 gtema :)
22:41:45 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove some duplicate methods https://review.opendev.org/c/openstack/openstacksdk/+/780127
23:22:39 openstackgerrit Merged openstack/python-openstackclient master: compute: Remove 'file://' prefix from '--block-device' https://review.opendev.org/c/openstack/python-openstackclient/+/780025
#openstack-sdks - 2021-03-12
08:17:39 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
08:26:17 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
11:37:37 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
13:19:57 openstackgerrit Polina Gubina proposed openstack/ansible-collections-openstack master: Container module for management Swift containers https://review.opendev.org/c/openstack/ansible-collections-openstack/+/779712
13:51:24 mordred gtema: so - I pushed up a change yesterday that was the result of me falling down a little rabbit hole looking at sdk in lgtm.com: https://lgtm.com/projects/g/openstack/openstacksdk/?mode=list
13:52:05 gtema wow
13:52:10 mordred many of the things are competely lame, and its warnings about multiple calls of constructors are not super accurate. but the duplicate code warnings seem to be reasonable

Earlier   Later