Posted	Nick	Remark
#openstack-sdks - 2020-12-07
17:33:56	hyang	Hello team, can I get some reviews for https://review.opendev.org/c/openstack/openstacksdk/+/755644, thanks in advance!
17:34:42	openstackgerrit	Tino Schreiber proposed openstack/ansible-collections-openstack master: WIP: Add security_group_rule_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765580
17:48:15	openstackgerrit	Hang Yang proposed openstack/python-openstackclient master: Support Neutron Address Group CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/747279
17:49:52	openstackgerrit	Hang Yang proposed openstack/python-openstackclient master: Support remote-address-group in SG rules https://review.opendev.org/c/openstack/python-openstackclient/+/758211
17:55:29	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Show flavor in 'server list' with API >= 2.47 https://review.opendev.org/c/openstack/python-openstackclient/+/761772
18:02:40	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: trivial: Cleanup docs for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/765361
18:02:40	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add missing options for 'server rebuild' https://review.opendev.org/c/openstack/python-openstackclient/+/765360
18:02:41	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add missing options for 'keypair list' https://review.opendev.org/c/openstack/python-openstackclient/+/765364
18:02:41	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add missing options for 'server set' https://review.opendev.org/c/openstack/python-openstackclient/+/765363
18:02:41	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add missing options for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/765362
18:02:42	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add missing options for 'server image create' https://review.opendev.org/c/openstack/python-openstackclient/+/765365
18:02:43	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: WIP: compute: Add missing options for 'hypervisor list' https://review.opendev.org/c/openstack/python-openstackclient/+/765368
18:02:43	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: WIP: compute: Add 'server volume list' command https://review.opendev.org/c/openstack/python-openstackclient/+/765367
18:02:43	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add 'server volume update' command https://review.opendev.org/c/openstack/python-openstackclient/+/765366
18:02:44	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: WIP: Add '--force' option to 'server delete' https://review.opendev.org/c/openstack/python-openstackclient/+/765369
18:02:45	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: WIP: compute: Improve 'server migration list --project' option https://review.opendev.org/c/openstack/python-openstackclient/+/765370
18:12:45	openstackgerrit	Ananya proposed openstack/ansible-collections-openstack master: Migrating network from AnsibleModule to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/764411
20:08:22	openstackgerrit	Ananya proposed openstack/ansible-collections-openstack master: Migrating network from AnsibleModule to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/764411
20:28:56	openstackgerrit	Ananya proposed openstack/ansible-collections-openstack master: Migrating network from AnsibleModule to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/764411
20:43:42	openstackgerrit	Ananya proposed openstack/ansible-collections-openstack master: Migrating network from AnsibleModule to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/764411
#openstack-sdks - 2020-12-08
07:48:56	openstackgerrit	Polina Gubina proposed openstack/ansible-collections-openstack master: Enabling update for recordset https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765913
09:55:45	openstackgerrit	Tino Schreiber proposed openstack/ansible-collections-openstack master: Add security_group_rule_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765580
10:06:54	openstackgerrit	Shnaidman Sagi proposed openstack/ansible-collections-openstack master: Fix docs-args mismatch in modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765960
11:23:35	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: Fix lower-constraints job https://review.opendev.org/c/openstack/python-openstackclient/+/765968
11:23:36	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: Update lower-constraints https://review.opendev.org/c/openstack/python-openstackclient/+/765969
11:23:46	stephenfin	gtema: dtantsur: That should fix the OSC gate ^
11:24:05	gtema	is it again broken?
11:24:29	stephenfin	I don't know if you've a patch proposed to fix it but master is broken locally for me, yes
11:24:49	gtema	I haven't recognized so far it was broken
11:25:34	stephenfin	it's the new pip dependency resolver highlighting bugs in our lower-cosntraints
11:25:38	stephenfin	*constraints
11:25:58	stephenfin	openstacksdk is okay
11:31:23	gtema	okay. Let's wait what zuul tells
11:45:22	dtantsur	pip releases are always fun
11:49:08	openstackgerrit	Tino Schreiber proposed openstack/openstacksdk master: Add id query parameter to sg rules https://review.opendev.org/c/openstack/openstacksdk/+/765980
13:26:26	openstackgerrit	Merged openstack/ansible-collections-openstack master: Fix docs-args mismatch in modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765960
13:58:58	openstackgerrit	Polina Gubina proposed openstack/ansible-collections-openstack master: Enabling update for recordset https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765913
14:52:40	openstackgerrit	Shnaidman Sagi proposed openstack/ansible-collections-openstack master: Add security_group_rule_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765580
14:56:49	openstackgerrit	Shnaidman Sagi proposed openstack/ansible-collections-openstack master: Migrating network from AnsibleModule to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/764411
15:05:12	openstackgerrit	Shnaidman Sagi proposed openstack/ansible-collections-openstack master: WIP add network tests for versioned args https://review.opendev.org/c/openstack/ansible-collections-openstack/+/766013
15:05:44	openstackgerrit	Ghanshyam proposed openstack/openstackclient master: Remove retired Qinling & Searchlight usage https://review.opendev.org/c/openstack/openstackclient/+/764556
15:27:08	gmann	stephenfin: amotoki gtema squashed the Qinling and Searchlight retirement patches as they conflict with each other: https://review.opendev.org/c/openstack/openstackclient/+/764556/2
15:27:38	gtema	thanks
15:46:28	openstackgerrit	Merged openstack/openstackclient master: Remove retired Qinling & Searchlight usage https://review.opendev.org/c/openstack/openstackclient/+/764556
16:00:27	sshnaidm	gtema, do you know maybe since which version openstack client has arg '--long'? Is it old enough?
16:00:44	gtema	yes, enough age
16:01:12	gtema	at least since queens, but sure it was even earlier
16:01:18	gtema	it all depends on concrete command
16:05:05	openstackgerrit	Merged openstack/ansible-collections-openstack master: Migrating volume from AnsibleModule to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765542
16:13:14	openstackgerrit	Merged openstack/python-openstackclient master: Fix lower-constraints job https://review.opendev.org/c/openstack/python-openstackclient/+/765968
16:32:49	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Show flavor in 'server list' with API >= 2.47 https://review.opendev.org/c/openstack/python-openstackclient/+/761772
16:38:04	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: trivial: Cleanup docs for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/765361
16:38:04	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add missing options for 'server rebuild' https://review.opendev.org/c/openstack/python-openstackclient/+/765360
16:38:05	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add missing options for 'server set' https://review.opendev.org/c/openstack/python-openstackclient/+/765363
16:38:05	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add missing options for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/765362
16:38:06	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add missing options for 'server image create' https://review.opendev.org/c/openstack/python-openstackclient/+/765365
16:38:06	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add missing options for 'keypair list' https://review.opendev.org/c/openstack/python-openstackclient/+/765364
16:38:07	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add 'server volume update' command https://review.opendev.org/c/openstack/python-openstackclient/+/765366
16:38:08	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add missing options for 'hypervisor list' https://review.opendev.org/c/openstack/python-openstackclient/+/765368
16:38:08	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add 'server volume list' command https://review.opendev.org/c/openstack/python-openstackclient/+/765367
16:38:09	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add '--force' option to 'server delete' https://review.opendev.org/c/openstack/python-openstackclient/+/765369
16:38:13	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Improve 'server migration list' options https://review.opendev.org/c/openstack/python-openstackclient/+/765370
16:38:16	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: tests: Remove unused fake method https://review.opendev.org/c/openstack/python-openstackclient/+/766040
16:39:41	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'server * -f yaml' output https://review.opendev.org/c/openstack/python-openstackclient/+/761205
16:39:41	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: Make use of comparable 'FormattableColumn' subclasses https://review.opendev.org/c/openstack/python-openstackclient/+/761447
16:39:42	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'server group * -f yaml' output https://review.opendev.org/c/openstack/python-openstackclient/+/761596
16:39:42	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'usage * -f yaml' output https://review.opendev.org/c/openstack/python-openstackclient/+/761595
16:39:43	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add 'server group create --rule' option https://review.opendev.org/c/openstack/python-openstackclient/+/761597
16:39:43	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'hypervisor show -f yaml' output https://review.opendev.org/c/openstack/python-openstackclient/+/763004
16:39:44	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: trivial: Use plural for appended parameters https://review.opendev.org/c/openstack/python-openstackclient/+/761598
16:39:44	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add 'server show --topology' option https://review.opendev.org/c/openstack/python-openstackclient/+/680928
16:40:21	stephenfin	alright, I'll go review stuff inside of writing code now :)
16:40:42	stephenfin	Though i would appreciate reviews. It's all very trivial and everything has tests fwict
16:54:46	openstackgerrit	Will Tome proposed openstack/ansible-collections-openstack master: add option to exclude legacy groups https://review.opendev.org/c/openstack/ansible-collections-openstack/+/766047
17:28:40	openstackgerrit	Merged openstack/python-openstackclient master: Update lower-constraints https://review.opendev.org/c/openstack/python-openstackclient/+/765969
18:05:40	openstackgerrit	Ananya proposed openstack/ansible-collections-openstack master: WIP add network tests for versioned args https://review.opendev.org/c/openstack/ansible-collections-openstack/+/766013
19:50:38	openstackgerrit	Ghanshyam proposed openstack/python-openstackclient master: Remove retired Searchlight support https://review.opendev.org/c/openstack/python-openstackclient/+/764569
19:51:35	gmann	stephenfin: ^^ resolved merge conflict for lower-constraints, please check again
21:11:47	rm_work	So, looks like the SDK supports a cert/key for mTLS with services -- does this for sure work with EVERY service? do they all generate their clients in a unified way? or is it possible some SDK service doesn't support this and silently ignores it?
23:21:23	mordred	rm_work: it's actually keystoneauth that's the one that supports that - it's all passthrough/exposure support from an openstacksdk perspective
23:21:52	rm_work	ok cool
23:23:13	mordred	rm_work: that said - unless you say "insecure: true" - any cert/ca settings that are invalid will cause keystoneuath to vomit - so I do not think silent ignoring will be a thing
23:23:21	mordred	worth testing though
23:23:35	rm_work	i was more concerned with like, one of the clients not actually using the Session thing
23:23:42	rm_work	and therefore just not using the settings
23:25:18	mordred	rm_work: openstacksdk does not use any of the clients
23:25:29	mordred	it only taks to services using keystoneauth
23:25:50	mordred	the thing you mention is one of many reasons this is true
23:26:33	rm_work	hmm k
23:27:02	rm_work	i guess i meant like, the individual service-client implementations INSIDE sdk
23:27:19	rm_work	but maybe the requirement for them to be in SDK is they must use that auth framework
23:27:34	mordred	yes. they actually arent' individual implementations
23:27:58	mordred	they are all subclasses of openstack.proxy.Proxy which is a subclass of keystoneauth1.adapter.Adapter :)
23:28:19	mordred	the amount of work to make a service proxy in sdk that did not use keystoneauth properly would be GIANT
23:28:30	mordred	I'm honestly not sure I could even write that code
#openstack-sdks - 2020-12-09
03:19:24	openstackgerrit	Khomesh Thakre proposed openstack/python-openstackclient master: compute: Show flavor in 'server list' with API >= 2.47 https://review.opendev.org/c/openstack/python-openstackclient/+/761772
06:05:38	openstackgerrit	Mukesh Singh proposed openstack/python-openstackclient master: Display flavor info for os-compute-api-version>2.46 https://review.opendev.org/c/openstack/python-openstackclient/+/766132
12:18:59	openstackgerrit	Merged openstack/python-openstackclient master: Remove retired Searchlight support https://review.opendev.org/c/openstack/python-openstackclient/+/764569
14:07:16	openstackgerrit	Shnaidman Sagi proposed openstack/ansible-collections-openstack master: WIP add network tests for versioned args https://review.opendev.org/c/openstack/ansible-collections-openstack/+/766013
15:11:47	openstackgerrit	Anuradha proposed openstack/openstacksdk master: Improve Ironic API on OpenStack SDK https://review.opendev.org/c/openstack/openstacksdk/+/766237

Earlier   Later