| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-11-18 | |||
| 13:26:51 | stephenfin | gtema: FYI https://review.opendev.org/#/c/763178/ | |
| 13:27:08 | stephenfin | that should unblock your aggregate and flavor OSC changes | |
| 13:27:41 | gtema | hmm, I wanted to go with hypervisors further, but ok | |
| 13:28:18 | gtema | do not really want to make release each week ;-), but is still required | |
| 13:28:44 | stephenfin | meh, releases are cheap :) | |
| 13:28:56 | openstackgerrit | Merged openstack/python-openstackclient master: Add a few selectable fields to the "openstack server list" output https://review.opendev.org/741181 | |
| 13:28:57 | openstackgerrit | Merged openstack/openstacksdk master: Update TOX_CONSTRAINTS_FILE https://review.opendev.org/761055 | |
| 13:28:59 | openstackgerrit | Merged openstack/python-openstackclient master: update lower-constraints.txt https://review.opendev.org/760270 | |
| 13:29:03 | stephenfin | but we can wait of course, if you'd prefer | |
| 13:29:06 | gtema | yes, they are | |
| 13:29:14 | gtema | already +1-ed | |
| 13:30:54 | stephenfin | sweet | |
| 13:32:09 | gtema | hypervisors API is also not so straight forward | |
| 13:32:16 | gtema | but not that bad as host | |
| 14:16:48 | openstackgerrit | Gregory Thiemonge proposed openstack/openstacksdk master: Add tls_enabled param for Octavia Pools https://review.opendev.org/763189 | |
| 14:17:36 | openstackgerrit | Gregory Thiemonge proposed openstack/openstacksdk master: Add tls_enabled param for Octavia Pools https://review.opendev.org/763189 | |
| 15:26:17 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Complete compute.hypervisor functions https://review.opendev.org/763202 | |
| 17:42:15 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add "fields" parameter to ListPort query https://review.opendev.org/754117 | |
| 18:06:07 | openstackgerrit | Stephen Finucane proposed openstack/cliff master: trivial: Remove references to Python 2.7 https://review.opendev.org/760334 | |
| 19:56:57 | openstackgerrit | Merged openstack/cliff master: Remove six https://review.opendev.org/754683 | |
| 21:08:27 | openstackgerrit | Merged openstack/cliff master: trivial: Remove references to Python 2.7 https://review.opendev.org/760334 | |
| 21:42:40 | openstackgerrit | Merged openstack/openstacksdk master: Add tls_enabled param for Octavia Pools https://review.opendev.org/763189 | |
| #openstack-sdks - 2020-11-19 | |||
| 01:31:19 | iokiwi | Hi I am working on a fix for this, https://storyboard.openstack.org/#!/story/2007672. According to the docs, the default behavior for `openstack image save` should go to stdout, but recent changes / current implimentation makes it go to memory. | |
| 01:52:52 | iokiwi | Is it still desireable that output go to stdout? Should I restore this as the default output? | |
| 05:08:44 | openstackgerrit | Merged openstack/python-openstackclient master: Add "fields" parameter to ListPort query https://review.opendev.org/754117 | |
| 06:35:45 | frickler | iokiwi: it seems there are actually two issues here, both related to the switch from glanceclient to sdk: | |
| 06:36:02 | frickler | a) the default output to stdout is broken | |
| 06:37:11 | frickler | b) osc now tries to buffer the complete image in memory before saving it to a file or stdout, leading to an OOM when the image size is larger than available memory | |
| 06:37:34 | frickler | waiting for gtema to be back online for further discussion | |
| 06:38:24 | frickler | for me, while a) certainly is a regression that should be fixed, b) is the more severe issue | |
| 07:11:41 | openstackgerrit | Simon Merrick proposed openstack/python-openstackclient master: stop image downloads to memory https://review.opendev.org/763317 | |
| 07:32:37 | iokiwi | frickler thanks my patch addresses both. Certainly agree that b) is the bigger issue (especially when downloading a 100gb image) | |
| 07:34:51 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Complete compute.hypervisor functions https://review.opendev.org/763202 | |
| 07:36:38 | frickler | iokiwi: thanks, that looks much simpler than I had expected. will test later today. it might be good to add a releasenote, though. | |
| 07:37:02 | gtema | that is definitely needed | |
| 07:37:15 | iokiwi | fickler sure I'll add one now | |
| 07:37:21 | gtema | things go easy when you use SDK ;-) | |
| 07:38:06 | iokiwi | Based on the docs, I am not sure sdk will do md5 checksum when stream=True | |
| 07:38:13 | iokiwi | Do you think this will be a problem? | |
| 07:38:39 | gtema | well, the checksum validation is anyway doomed, since many clouds do not do this properly | |
| 07:39:01 | gtema | checking | |
| 07:40:55 | iokiwi | I think the sdk just wont/can't try to do md5 sum so to be more specific, is the md5 checksum important enough to us to implement it? Based on your comment above, maybe not. | |
| 07:41:38 | gtema | it is important that this possibility remains in SDK as is, since there are other users (except OSC) depending on it | |
| 07:43:26 | gtema | well, looking to the code I don't see it would change the behaviour really. | |
| 07:43:45 | gtema | it was initially designed to be either output or stream, not both together | |
| 07:48:23 | gtema | so as long as you download image into file I do not think there is effect of this change | |
| 07:48:54 | gtema | (since my cloud disabled image download I can't really verify anything) | |
| 07:50:28 | frickler | gtema: saving a 50g image to a file gives OOM for me with latest, works fine with 5.1.0. setting test up with the patch now | |
| 07:54:43 | frickler | the patch fixes that and also the stdout issue. does get some not so nice output when pipe fails, but that might be fixed in a followup http://paste.openstack.org/show/800191/ | |
| 07:58:08 | openstackgerrit | Simon Merrick proposed openstack/python-openstackclient master: stop image downloads to memory https://review.opendev.org/763317 | |
| 07:59:32 | gtema | that's weird. I can't understand why it should change the behavior | |
| 08:00:54 | gtema | aah, overseen where it goes also to | |
| 08:00:54 | openstackgerrit | Carlos Goncalves proposed openstack/openstacksdk master: Add ALPN support to load balancer pools https://review.opendev.org/752097 | |
| 08:01:49 | frickler | gtema: see the sdk docs, default downloads the complete image to memory before writing it to the file | |
| 08:02:17 | gtema | I know, I was reworking this whole stuff heavily | |
| 08:02:30 | gtema | just forgot where which param goes into - it's a spaghetti | |
| 10:27:16 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Complete compute.hypervisor functions https://review.opendev.org/763202 | |
| 10:28:29 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Migrating routers_info from AnsibleModule to OpenStackModule https://review.opendev.org/763149 | |
| 10:44:24 | openstackgerrit | Mark Chappell proposed openstack/openstacksdk master: Add support for Block Storage (v3) VolumeType Encyption resources https://review.opendev.org/756655 | |
| 13:47:46 | openstackgerrit | Merged openstack/ansible-collections-openstack master: Migrating routers_info from AnsibleModule to OpenStackModule https://review.opendev.org/763149 | |
| 14:01:32 | gtema | how was that command to start meeting? | |
| 14:02:17 | gtema | #startmeeting SDK/OSC | |
| 14:02:18 | openstack | Meeting started Thu Nov 19 14:02:17 2020 UTC and is due to finish in 60 minutes. The chair is gtema. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 14:02:19 | openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 14:02:21 | openstack | The meeting name has been set to 'sdk_osc' | |
| 14:02:48 | diablo_rojo | o/ | |
| 14:02:51 | amotoki | hi | |
| 14:03:02 | gtema | hey | |
| 14:03:09 | stephenfin | o/ | |
| 14:03:18 | gtema | ping gouthamr | |
| 14:03:38 | gouthamr | o/ | |
| 14:03:47 | gtema | do we want to use meetpad for voice meeting, or due to the time differences better in text ;-) | |
| 14:04:56 | gtema | no opinions? | |
| 14:05:47 | gtema | agenda for the meeting is under https://etherpad.opendev.org/p/openstacksdk-meeting-agenda | |
| 14:05:49 | amotoki | I have no strong preference on it, but most openstack projects use irc meetings and text meeting would be preferred in general. | |
| 14:05:59 | gtema | no problem | |
| 14:06:00 | diablo_rojo | Please just text lol | |
| 14:06:09 | gtema | oki, was thinking | |
| 14:06:27 | gtema | #topic Add Resolution of TC stance on the OpenStackClient Patch | |
| 14:06:35 | diablo_rojo | This way we have logs and don't need to take notes. | |
| 14:06:54 | gtema | I left my +1 (yet again) | |
| 14:07:20 | gtema | I am (not actually really wondering) - even this way there is some resistance from the community | |
| 14:08:08 | gtema | what is the plan of TC, to push on it or still try to get agreement from everyone | |
| 14:08:09 | gtema | ? | |
| 14:08:17 | gtema | https://review.opendev.org/#/c/759904/ | |
| 14:08:29 | diablo_rojo | We are trying to get that merged as a way forward. | |
| 14:08:48 | diablo_rojo | I do think its close, people just want more detail than we originally wanted to provide. | |
| 14:09:17 | gtema | this is already expressed very "weak". Is there a plan to really have a harder control? | |
| 14:10:53 | gtema | ok, moving next, since there is actually no further action points | |
| 14:10:57 | gtema | #topic Gerrit Breach Audit | |
| 14:11:31 | gtema | I did audit immediately when it was announced, but most likely forgot to send info about that | |
| 14:11:46 | diablo_rojo | the resolution is more of a stepping stone towards the end goal. A diplomatic way of starting to make progress. | |
| 14:11:50 | gtema | I have updated the linked etherpad with the info as well | |
| 14:11:54 | diablo_rojo | Oh cool, so all good then? | |
| 14:11:56 | diablo_rojo | Perfect. | |
| 14:12:00 | diablo_rojo | Thanks gtema! | |
| 14:12:04 | gtema | welcome | |
| 14:12:30 | stephenfin | gtema: You mean force patches for OSC? Not beyond the TC proposal, no. We need to rely on soft power more than hard power. It's not possible to force things through without the approval of the team, so we need to work to win those people over | |
| 14:12:31 | amotoki | gtema: did you audit all repos under openstacksdk? | |
| 14:12:38 | gtema | I reviewed both from gerrit side and from the attached commits. But due to the amount of projects under the SDK team ;-) I might have missed something | |