Posted	Nick	Remark
#openstack-sdks - 2020-11-14
13:44:03	openstackgerrit	Marta Laís de Macedo Dantas proposed openstack/openstacksdk master: Volume Target support for Ironic on OpenStack SDK https://review.opendev.org/753092
14:08:42	openstackgerrit	Marta Laís de Macedo Dantas proposed openstack/openstacksdk master: Volume Target support for Ironic on OpenStack SDK https://review.opendev.org/753092
15:16:20	openstackgerrit	Marta Laís de Macedo Dantas proposed openstack/openstacksdk master: Volume Target support for Ironic on OpenStack SDK https://review.opendev.org/753092
#openstack-sdks - 2020-11-15
08:29:31	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add "fields" parameter to ListPort query https://review.opendev.org/754117
#openstack-sdks - 2020-11-16
08:35:44	openstackgerrit	Dmitriy Rabotyagov (noonedeadpunk) proposed openstack/ansible-collections-openstack master: Do not fail when endpoint state is absent https://review.opendev.org/762798
11:16:48	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: trivial: Document removal of support for agents https://review.opendev.org/762825
11:16:48	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: tests: Remove 'agent' functional tests https://review.opendev.org/762824
11:17:19	stephenfin	gtema: Can you look at https://review.opendev.org/762824 to unblock the gate?
11:26:47	gtema	stephenfin - https://review.opendev.org/#/c/762559/ is to unblock the gate (pep8 problem)
11:27:08	gtema	or this is a "yet another" unblock
11:27:14	stephenfin	This is another one
11:27:18	stephenfin	We might need to roll them into one
11:28:30	gtema	have a meeting now. Will have a look in 30 minutes
11:29:48	frickler	stephenfin: is it too much effort to keep the tests in place and make them conditional? maybe folks operating against older clouds might still want to verify things?
11:32:15	stephenfin	frickler: Given OSC is branched, I don't think we should. People can just check out the old branches if they want the tests. If we kept it in master but didn't run it, it would eventually degrade due to bitrot
11:32:36	stephenfin	There's also Tempest tests to validate the API itself
11:32:40	stephenfin	*there are
11:48:33	openstackgerrit	Merged openstack/ansible-collections-openstack master: Do not fail when endpoint state is absent https://review.opendev.org/762798
12:17:55	frickler	stephenfin: o.k., seems reasonable to me
14:38:42	gtema	stephenfin, sorry took a bit longer ;-) You are right, we need to squeeze 2 unblocks changes together
14:39:03	stephenfin	It's all good. Do you want to do that or should I?
14:54:43	openstackgerrit	Artem Goncharov proposed openstack/python-openstackclient master: tests: Remove 'agent' functional tests https://review.opendev.org/762824
16:31:23	openstackgerrit	Merged openstack/keystoneauth master: Provide the default get_auth_ref implementation https://review.opendev.org/747670
16:54:17	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Complete compute aggregate functions https://review.opendev.org/762131
17:08:37	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Complete compute aggregate functions https://review.opendev.org/762131
19:23:40	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Complete compute aggregate functions https://review.opendev.org/762131
21:37:18	openstackgerrit	Merged openstack/python-openstackclient master: tests: Remove 'agent' functional tests https://review.opendev.org/762824
#openstack-sdks - 2020-11-17
09:14:43	openstackgerrit	zhufl proposed openstack/openstacksdk master: Fix the invalid if statement https://review.opendev.org/762975
09:43:04	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Complete compute aggregate functions https://review.opendev.org/762131
10:57:40	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Add update_flavor method https://review.opendev.org/762989
11:31:28	openstackgerrit	Artem Goncharov proposed openstack/python-openstackclient master: Switch compute flavors from novaclient/direct to SDK https://review.opendev.org/750151
11:44:32	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: trivial: Document removal of support for agents https://review.opendev.org/762825
11:51:20	openstackgerrit	Artem Goncharov proposed openstack/python-openstackclient master: Switch compute aggregate functions to SDK https://review.opendev.org/762134
12:49:38	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Format 'cpu_info' field of 'hypervisor show' https://review.opendev.org/763004
14:17:59	openstackgerrit	Merged openstack/os-service-types master: bump py37 to py38 in tox.ini https://review.opendev.org/757430
14:23:54	openstackgerrit	Merged openstack/keystoneauth master: Update master for stable/victoria https://review.opendev.org/751054
14:51:43	openstackgerrit	Merged openstack/python-openstackclient master: Allow to resize in-use volumes https://review.opendev.org/761633
14:53:12	openstackgerrit	Merged openstack/python-openstackclient master: Switch 'openstack keypair' ops to use SDK https://review.opendev.org/761904
15:25:19	openstackgerrit	Merged openstack/openstacksdk master: Fix the invalid if statement https://review.opendev.org/762975
16:55:46	openstackgerrit	Artem Goncharov proposed openstack/python-openstackclient master: Switch compute aggregate functions to SDK https://review.opendev.org/762134
17:33:40	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: Make use of comparable 'FormattableColumn' subclasses https://review.opendev.org/761447
17:33:41	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'usage * -f yaml' output https://review.opendev.org/761595
17:33:41	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'server * -f yaml' output https://review.opendev.org/761205
17:33:42	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'hypervisor show -f yaml' output https://review.opendev.org/763004
17:33:42	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'server group * -f yaml' output https://review.opendev.org/761596
17:33:43	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: trivial: Use plural for appended parameters https://review.opendev.org/761598
17:33:43	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: Add support for 'server group create --rule' parameter https://review.opendev.org/761597
17:52:06	openstackgerrit	Mark Chappell proposed openstack/openstacksdk master: Add support for Block Storage (v3) VolumeType Encyption resources https://review.opendev.org/756655
17:59:47	openstackgerrit	Mark Chappell proposed openstack/openstacksdk master: Remove duplicate test_zone_create https://review.opendev.org/763062
18:27:13	openstackgerrit	Stephen Finucane proposed openstack/openstacksdk master: Add update_flavor method https://review.opendev.org/762989
18:59:05	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Add update_flavor method https://review.opendev.org/762989
19:03:19	openstackgerrit	Artem Goncharov proposed openstack/python-openstackclient master: Switch compute aggregate functions to SDK https://review.opendev.org/762134
19:05:58	gtema	stephenfin, are you here?
20:29:37	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: WIP Add support for deprecated nova hosts https://review.opendev.org/763081
#openstack-sdks - 2020-11-18
01:22:01	openstackgerrit	Merged openstack/openstacksdk master: Remove duplicate test_zone_create https://review.opendev.org/763062
01:22:03	openstackgerrit	Merged openstack/python-openstackclient master: trivial: Document removal of support for agents https://review.opendev.org/762825
03:01:16	openstackgerrit	Emilien Macchi proposed openstack/openstacksdk stable/victoria: Don't set list_type to dict for server groups. https://review.opendev.org/763119
03:01:31	openstackgerrit	Emilien Macchi proposed openstack/openstacksdk stable/ussuri: Don't set list_type to dict for server groups. https://review.opendev.org/763120
03:01:42	openstackgerrit	Emilien Macchi proposed openstack/openstacksdk stable/train: Don't set list_type to dict for server groups. https://review.opendev.org/763121
09:54:42	stephenfin	gtema: I was finished for the evening, but I'm here now
10:01:11	gtema	oki, no problem
10:01:47	gtema	"openstack aggregate cache image __aggregate__ __im1__ __im2__ __im3__" is not cool from my pov
10:03:19	stephenfin	Probably best to look at the reply I just left on the review. I'm not recommending this in isolation: there are numerous other examples of this is OSC already
10:04:11	gtema	well, from what I see when we support multiple inputs under the resource - it is a named parameter
10:04:27	gtema	so for me in this case it is really using a named param and not positional
10:04:42	gtema	while positional is used only for i.e. deleting multiple resources
10:05:37	stephenfin	See my reply. That's not true with OSC today. There are other non-deletion examples of passing multiple child resources
10:06:27	stephenfin	And personally I'd like to expand (in a follow-up, of course) some of the ones that only accept a single child resource to accept multiple child resources, e.g. 'aggregate add host'
10:07:12	gtema	for me the "object create _container_ _file1_ _file2_" is example where we do this
10:07:32	gtema	since deletion is not fitting as example - it is top resource
10:07:55	stephenfin	Yes, that's fair. 'object create' is a valid thing too though, and proves that this can work
10:08:07	gtema	I know it can work like that
10:08:21	gtema	it's just in my experience this is not a good UX
10:08:36	stephenfin	Positional arguments wouldn't make sense for something like 'flavor create'. i.e. you wouldn't do 'flavor create 512 4 0' instead of 'flavor create --ram 512 --vcpu 4 --disk 0'
10:09:05	stephenfin	but that's because those additional arguments are attributes of the resource. Also, they're all different meaning it's impossible to parse
10:09:23	gtema	exactly, and one step further if in one call you want to create multiple flavors ...
10:09:35	gtema	here images are also arguments to the aggregate
10:09:43	stephenfin	they're not though
10:09:48	stephenfin	they're resources in their own right
10:10:00	stephenfin	the command is called 'aggregate cache image'
10:10:56	stephenfin	so you're caching an <image> for an <aggregate>; those are two separate resources and there aren't multiple attributes to be set
10:11:44	gtema	well yes. When you use named params you can really mix positions of positional and named ones
10:12:03	gtema	create image _name_ --param1 --param2
10:12:05	gtema	and
10:12:13	gtema	create image --param1 name --param2
10:12:38	gtema	with this way of using only positional ones you have absolutely no choice
10:13:06	stephenfin	I don't think this is an issue
10:13:43	gtema	:) - for me yes. When you use IDs instead of names you have no clue looking to the command you type whether order is right or not
10:14:02	gtema	I was having with that pretty much problems in DNS area
10:14:03	stephenfin	traditional would dictate if your command is called '<resource_a> <action> <resource_b>', then the invocation of that looks like '<resource_a> <resource_b>'
10:14:54	gtema	"image cache cde42cs abcdef46423 cbfedf454334" - what is what
10:15:16	stephenfin	'server add floating ip' -> 'SERVER FLOATING_IP'; 'aggregate add host' -> 'AGGREGATE HOST'
10:15:31	stephenfin	the first one is the aggregate, of course :)
10:15:38	gtema	can you add multiple FIPs in same command?
10:16:12	stephenfin	no, because the FIPs have an optional attribute
10:16:20	stephenfin	(fixed IP address)
10:16:38	gtema	aggregate add host also doesn'T allow multiple hosts
10:16:53	stephenfin	<stephenfin> And personally I'd like to expand (in a follow-up, of course) some of the ones that only accept a single child resource to accept multiple child resources, e.g. 'aggregate add host'
10:17:03	gtema	:D
10:17:19	stephenfin	and again, 'object create' does, so we have prior art here

Earlier   Later