Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-10-06
14:55:06 gtema yupp
14:55:32 stephenfin gtk :)
14:57:20 tremble Python openstacksdk question: Without updating clouds.yaml how do I request a specific version of a services proxy - cloud.block_storage currently gets me the v2 proxy and I need the v3 proxy for a feature.
14:57:49 dtantsur tremble: I'm surprised it doesn't happen automagically..
14:58:19 gtema it happens when the default EP on the block_storage points to v2
14:58:27 gtema and there is endpoint volumev3
14:58:43 gtema but version discovery doesn't work - you end on v2
14:58:51 dtantsur gtema, stephenfin, so, it's a horrible mess, and largely I'm to blame for it.
14:59:05 dtantsur there are currently two approaches to microversions in the SDK and neither work 100% correct
14:59:25 dtantsur there is also pick_microversion that explicitly raises a version higher than the default
14:59:30 dtantsur which you could argue is also incorrect
14:59:49 gtema tremble: for me I use volume_service_type: volumev3 in clouds. But know you want it other way around
15:00:18 gtema dtantsur - that's why I ping you ;-)
15:00:41 dtantsur gtema: remind me please, the default microversion comes from clouds.yaml?
15:00:57 gtema no explicitly, but can be set also there
15:00:58 dtantsur so it's None is most cases except for an explicit OSC argument?
15:01:04 gtema in this case it is argument in OSC
15:01:17 dtantsur yeah, okay, OSC and clouds.yaml, but not implicitly?
15:01:20 tremble gtema, Yeah I want this for an Ansible module, and it seems kinda dumb to tell people to update their clouds.yaml if they want access to a feature
15:01:27 gtema yes, it is none by default, but if you do --os-compute-api-version 2.5 - it is 2.5
15:01:48 dtantsur commented
15:02:18 gtema thanks dtantsur, I will change the default
15:02:30 dtantsur gtema: and please fix pick_microversion
15:02:36 dtantsur I hope ironic won't blow up afterwards :)
15:02:46 gtema would we want an old functionality ever? to simply check whether server side supports the mv?
15:02:59 dtantsur gtema: I don't think so..
15:03:25 dtantsur I mean, it's not useless in theory, but in this context we should respect the default
15:04:09 gtema I actually was meaning, whether respect_default_mv should stay as option but be True by default or whether drop it completely
15:04:52 gtema but in the later case we can not simply check whether server supports given MV
15:05:24 dtantsur *shrug* I'd drop it until somebody needs it
15:05:32 gtema okay. Thks
15:12:38 frickler gtema: the devstack openstacksdk job is still broken on stable/train it seems, see https://zuul.opendev.org/t/openstack/build/82a83f08f9064f18bcb9e12e4b0b9897 , I've asked neutron folk for help now
15:13:21 gtema frickler: ack
15:15:49 gtema dtantsur: I think pick_mv is working correctly, at least wrt "get a new mv if it is higher then default"
15:16:39 gtema if somebody is using it - blame himself and take care of consequences
15:18:15 dtantsur gtema: if we change the behavior, we need to change it in two places
15:18:29 dtantsur otherwise our services will work inconsistently wrt defaults
15:18:37 dtantsur (i.e. compute will respect it, baremetal won't)
15:19:13 gtema in this case I would rather move other services to use "supports"
15:19:34 gtema otherwise the function is doing not what it is describes to be doing
15:20:48 gtema there's only openstack/baremetal/v1/node.py using pick (and one mistakenly openstack/cloud/_compute.py)
15:27:13 dtantsur gtema: you can use pick as a handier wrapper around supports that also handles errors, I guess
15:27:55 gtema not sure. Currently looking to the cloud/_compute.py
15:28:16 gtema it simply wants a MV not even checking it is supported or not
15:28:27 gtema at least verification must be done
15:29:10 gtema so pick is used to enforce using mv other then selected (default)
15:29:30 gtema guess in ironic as well
15:31:42 dtantsur so, the question is: do we want to allow ignoring the default?
15:31:49 dtantsur we used to, with your patch we'll no longer
15:31:59 dtantsur whatever the answer is, we need it to be consistent across services
15:32:11 dtantsur if we think nova shouldn't do it, ironic shouldn't either
15:32:17 gtema I would say in cloud/_copmute I would change it to check whether feature is supported or not
15:32:28 gtema if not supported - ignore setting tags
15:32:50 gtema (I guess this is mostly the ansible usage)
15:35:35 gtema with my patch we will actually start respecting properly default, while currently we don't
15:36:10 gtema I will try to switch all the usages to supports raising error if it feature is not supported
15:36:24 gtema s/it/this/
15:40:37 dtantsur ++
16:21:27 openstackgerrit Merged openstack/cliff master: Bump py37 to py38 in tox.ini https://review.opendev.org/756210
20:07:00 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Respect default microversion in the microversion negotiation https://review.opendev.org/756286
#openstack-sdks - 2020-10-07
02:15:42 openstackgerrit Wenping Song proposed openstack/python-openstackclient master: Remove usage of six https://review.opendev.org/756201
06:26:15 openstackgerrit Arthur Dayne proposed openstack/openstacksdk master: Add 'attachment_update' to openstacksdk https://review.opendev.org/756436
06:31:07 openstackgerrit Xuan Yandong proposed openstack/cliff master: Remove Six https://review.opendev.org/754683
06:35:43 openstackgerrit Qiu Fossen proposed openstack/openstacksdk master: add migrate volume completion https://review.opendev.org/756437
06:37:03 openstackgerrit Arthur Dayne proposed openstack/openstacksdk master: Add 'attachment_update' to openstacksdk https://review.opendev.org/756436
06:38:27 openstackgerrit Xuan Yandong proposed openstack/cliff master: Remove six https://review.opendev.org/754683
06:39:57 openstackgerrit Arthur Dayne proposed openstack/openstacksdk master: Add 'attachment_update' to openstacksdk https://review.opendev.org/756436
07:25:29 openstackgerrit Wenping Song proposed openstack/osc-lib master: Check item type for str https://review.opendev.org/756445
07:46:56 openstackgerrit xuyuanhao proposed openstack/openstacksdk master: add attachment interface for sdk https://review.opendev.org/756447
13:33:35 openstackgerrit Rafael Weing채rtner proposed openstack/openstacksdk master: Deprecate 'remote_ip_prefix' parameter in metering label rules https://review.opendev.org/746578
13:33:35 openstackgerrit Rafael Weingärtner proposed openstack/openstacksdk master: Deprecate 'remote_ip_prefix' parameter in metering label rules https://review.opendev.org/746578
13:34:47 openstackgerrit Rafael Weing채rtner proposed openstack/openstacksdk master: Add source_ip_prefix and destination_ip_prefix to metering label rules https://review.opendev.org/746586
13:34:47 openstackgerrit Rafael Weingärtner proposed openstack/openstacksdk master: Add source_ip_prefix and destination_ip_prefix to metering label rules https://review.opendev.org/746586
15:54:19 openstackgerrit Rafael Weing채rtner proposed openstack/openstacksdk master: Deprecate 'remote_ip_prefix' parameter in metering label rules https://review.opendev.org/746578
15:54:19 openstackgerrit Rafael Weingärtner proposed openstack/openstacksdk master: Deprecate 'remote_ip_prefix' parameter in metering label rules https://review.opendev.org/746578
15:57:36 openstackgerrit Rafael Weing채rtner proposed openstack/openstacksdk master: Add source_ip_prefix and destination_ip_prefix to metering label rules https://review.opendev.org/746586
15:57:36 openstackgerrit Rafael Weingärtner proposed openstack/openstacksdk master: Add source_ip_prefix and destination_ip_prefix to metering label rules https://review.opendev.org/746586
17:00:27 stephenfin dtantsur|afk: Could you cast an eye over https://review.opendev.org/#/c/756286/ again at some point this week, please. I really don't have enough context on that yet
#openstack-sdks - 2020-10-08
02:45:08 openstackgerrit Jorhson Deng proposed openstack/openstacksdk master: Add 'unreserve_volume' to openstacksdk https://review.opendev.org/756622
03:05:34 openstackgerrit Jorhson Deng proposed openstack/openstacksdk master: Add 'reserve_volume' to openstacksdk https://review.opendev.org/756625
06:19:24 openstackgerrit Jorhson Deng proposed openstack/openstacksdk master: Add 'unreserve_volume' to openstacksdk https://review.opendev.org/756622
06:28:59 openstackgerrit Wenping Song proposed openstack/python-openstackclient master: Add list tags for server https://review.opendev.org/756019
06:32:49 openstackgerrit Xinxin Shen proposed openstack/openstacksdk master: Add "update flavor description" to openstack sdk https://review.opendev.org/756642
06:48:54 openstackgerrit Xinxin Shen proposed openstack/openstacksdk master: Add "update flavor description" to openstack sdk https://review.opendev.org/756642
07:03:16 openstackgerrit Xuan Yandong proposed openstack/cliff master: Remove six https://review.opendev.org/754683
07:33:06 openstackgerrit Xuan Yandong proposed openstack/cliff master: Remove six https://review.opendev.org/754683
07:39:16 openstackgerrit Jorhson Deng proposed openstack/openstacksdk master: Add 'reserve_volume' to openstacksdk https://review.opendev.org/756625
07:42:04 openstackgerrit Mark Chappell proposed openstack/openstacksdk master: Add "description" to cinder volume types. https://review.opendev.org/756649
07:43:40 openstackgerrit Mark Chappell proposed openstack/openstacksdk master: Add support for updating cinder (v3) volume types https://review.opendev.org/756650
08:23:50 openstackgerrit Mark Chappell proposed openstack/openstacksdk master: Add support for Block Storage (v3) VolumeType Encyption resources https://review.opendev.org/756655
08:49:41 openstackgerrit Wenping Song proposed openstack/python-openstackclient master: Add create tags for server https://review.opendev.org/756664
12:07:28 openstackgerrit yang yawei proposed openstack/openstacksdk master: add list instance action for sdk https://review.opendev.org/756685
12:11:48 stephenfin gtema: I have three patches against OSC open for a while. Any chance you could take a look over what's left of the week? :) https://review.opendev.org/#/q/owner:%22Stephen+Finucane+%253Cstephenfin%2540redhat.com%253E%22+project:openstack/python-openstackclient+is:open
12:12:27 gtema sure. Thanks for reminding. I remember getting notification recently but not able to find it
12:12:35 gtema will try spend some time today/tomorrow
12:12:49 stephenfin thanks. Let me know if I can return the favour
12:12:57 gtema ok
12:19:42 openstackgerrit yang yawei proposed openstack/openstacksdk master: add migration list for sdk https://review.opendev.org/756692
12:42:30 openstackgerrit yang yawei proposed openstack/openstacksdk master: add defaults quotas for sdk https://review.opendev.org/756698
15:53:08 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Add support for 'keypairs list --user' parameter https://review.opendev.org/755073

Earlier   Later