| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-07-31 | |||
| 20:41:09 | mordred | yeah. did we get the osc patch wrong? | |
| 20:41:37 | mnaser | this is like... weirdly recent | |
| 20:41:40 | mnaser | i dont know what changed.. | |
| 20:41:57 | mordred | yeah - I don't see any code that should make that happen | |
| 20:42:05 | mnaser | gmann: ^ any ideas? this just recently surfaced | |
| 20:42:22 | mnaser | and there isnt much merged into osc lately | |
| 20:42:28 | mnaser | or openstacksdk | |
| 20:42:39 | mnaser | and i don't see anything tagged recently? | |
| 20:43:21 | mordred | nope. | |
| 20:43:40 | mordred | and I don't think we have any support to declaring that a cloud wants to default to import in clouds.yaml | |
| 20:45:01 | mordred | mnaser: | |
| 20:45:02 | mordred | use_import = True | |
| 20:45:02 | mordred | if stores or all_stores or all_stores_must_succeed: | |
| 20:45:14 | gmann | mnaser: it is enabled with GLANCE_USE_IMPORT_WORKFLOW flag in devstack case and that is false by default | |
| 20:45:28 | mnaser | gmann: yeah and in devstack, i don't see it using --import | |
| 20:45:42 | mnaser | but i think mordred is onto something, we're enabling import if we're specifying a store? | |
| 20:46:02 | mordred | we have to - apparently you can't specify stores without import | |
| 20:46:19 | mordred | I mean ... I don't see any stores listed in that command | |
| 20:46:31 | mordred | but maybe osc is passing al_stores by default? | |
| 20:46:32 | mnaser | yeah this is it: openstack --os-cloud=devstack-admin --os-region-name=RegionOne image create cirros-0.5.1-x86_64-disk --public --container-format bare --disk-format qcow2 --property hw_rng_model=virtio | |
| 20:47:14 | mordred | nope - osc doesn't have any support for stores | |
| 20:47:16 | mnaser | yeah | |
| 20:47:16 | mnaser | https://github.com/openstack/python-openstackclient/blob/8aed5feab8a5ae65658ea03fe1f2c238f6ffd908/openstackclient/image/v2/image.py#L399-L400 | |
| 20:47:38 | mnaser | https://github.com/openstack/python-openstackclient/blob/8aed5feab8a5ae65658ea03fe1f2c238f6ffd908/openstackclient/image/v2/image.py#L327-L334 | |
| 20:47:40 | mordred | mnaser: dude. that's weird | |
| 20:47:42 | mnaser | do we have to put a default=false or something? | |
| 20:48:41 | mnaser | and i dont think this has to do with my operator stuff cause the cli invocations dont change | |
| 20:49:41 | mordred | mnaser: zomg, having to put default=False would be super lame | |
| 20:49:57 | mordred | but - would be the best explanation | |
| 20:49:58 | mnaser | but normal devstack would have broken then no? | |
| 20:50:02 | mnaser | i think devstack uses uwsgi too | |
| 20:50:12 | gmann | mnaser: is it tempest-ful-py3 based job? becasue i enabled the import in that | |
| 20:50:47 | mnaser | gmann: i don't think its based off that BUT searching devstack logs shows `GLANCE_USE_IMPORT_WORKFLOW=False` so | |
| 20:51:30 | gmann | yeah it is parent with devstack-tempest | |
| 20:52:28 | mnaser | wth, a more recent change that ran -- https://review.opendev.org/#/c/668668/ -- did not have the same issue | |
| 20:52:42 | mnaser | that is 25 hours ago and i've noticed this surfaced very recently | |
| 20:52:45 | mnaser | like a cople hours ago | |
| 20:53:26 | mordred | mnaser: o_O | |
| 20:56:46 | mnaser | this change 5 hours ago was ok https://review.opendev.org/#/c/743943/ | |
| 20:56:57 | gmann | mnaser: devstack is default to standalone glance (not under uwsgi) and in your jobs also | |
| 20:57:14 | mnaser | ah well i run under uwsgi (the devstack portion is largely noop for glance at that point) | |
| 20:57:25 | mnaser | but even then looking at logs | |
| 20:57:32 | mnaser | its doing post /file | |
| 20:57:45 | mnaser | ohhhh | |
| 20:57:52 | mnaser | i wonder if https://review.opendev.org/#/c/743943/3/devstack/lib/glance is the reason | |
| 20:58:20 | mnaser | this further pushes the theory of enabled_import_methods mattering to the CLI | |
| 20:59:36 | mordred | mnaser: but how? | |
| 21:01:27 | mnaser | mordred: AH | |
| 21:01:34 | mnaser | THE UPLOAD MUST HAVE FAILD! | |
| 21:01:48 | mnaser | and supports_import is still being 'announced' | |
| 21:01:50 | mordred | aroo? | |
| 21:01:58 | mnaser | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/image/v2/_proxy.py#L291-L301 | |
| 21:02:14 | mnaser | raise Exception + supports_import=True => runs use_import code | |
| 21:02:15 | mordred | AH | |
| 21:02:35 | mordred | maybe that's a bad logic | |
| 21:02:54 | mordred | given what we've learned I'm thinking that opting in to import should always be conscious now | |
| 21:03:00 | mnaser | LOW AND BEHOLD | |
| 21:03:02 | mnaser | there is a traceback | |
| 21:03:13 | mnaser | https://www.irccloud.com/pastebin/cl6vW461/ | |
| 21:03:39 | mnaser | yeah because its possible that you end up in a queued image | |
| 21:03:42 | mordred | mnaser: neat! | |
| 21:03:43 | mordred | yeah | |
| 21:03:43 | mnaser | that will never upoad | |
| 21:04:08 | mordred | you wanna remove that logic or want me to? | |
| 21:04:29 | mnaser | mordred: could you? i'm in the middle of six different things | |
| 21:04:55 | mordred | yup | |
| 21:11:31 | mnaser | yeah | |
| 21:11:44 | gmann | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/image/v2/_proxy.py#L281 | |
| 21:11:44 | gmann | different things but we should support other import method (web-dowload or copy-image) also and check it correctly before we calculate supports_import | |
| 21:12:29 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Stop falling back to image import https://review.opendev.org/744254 | |
| 21:12:38 | mordred | mnaser: ^^ | |
| 21:12:42 | gmann | otherwise it will say not supported if image_import_methods['web-download'] | |
| 21:12:56 | mordred | yah | |
| 21:40:25 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Fix rebuild_server named argument https://review.opendev.org/741688 | |
| 21:40:26 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: compute: give server actions proper microversion support https://review.opendev.org/744258 | |
| 21:40:26 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Func test for compute microversion 2.9 https://review.opendev.org/741689 | |
| 21:43:16 | artom | Fuuuun | |
| 21:44:39 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Fix rebuild_server named argument https://review.opendev.org/741688 | |
| 21:44:39 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: compute: give server actions proper microversion support https://review.opendev.org/744258 | |
| 21:44:40 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Func test for compute microversion 2.9 https://review.opendev.org/741689 | |
| 21:44:47 | artom | Accidentally a word in the commit message | |
| 21:46:12 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Fix rebuild_server named argument https://review.opendev.org/741688 | |
| 21:46:12 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: compute: give server actions proper microversion support https://review.opendev.org/744258 | |
| 21:46:13 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Func test for compute microversion 2.9 https://review.opendev.org/741689 | |
| #openstack-sdks - 2020-08-01 | |||
| 17:31:35 | openstackgerrit | Merged openstack/openstacksdk master: Stop falling back to image import https://review.opendev.org/744254 | |
| 18:26:32 | openstackgerrit | Merged openstack/openstacksdk master: Add "numa_affinity_policy" attribute to "port" https://review.opendev.org/740422 | |
| 22:09:50 | openstackgerrit | Ghanshyam Mann proposed openstack/microversion-parse master: DNM: testing gate on ubuntu focal https://review.opendev.org/744298 | |
| 22:18:02 | openstackgerrit | Ghanshyam Mann proposed openstack/os-api-ref master: DNM: testing gate on ubuntu focal https://review.opendev.org/744305 | |
| #openstack-sdks - 2020-08-02 | |||
| 19:57:45 | openstackgerrit | Ghanshyam Mann proposed openstack/microversion-parse master: DNM: testing gate on ubuntu focal https://review.opendev.org/744298 | |
| 19:58:21 | openstackgerrit | Ghanshyam Mann proposed openstack/os-api-ref master: DNM: testing gate on ubuntu focal https://review.opendev.org/744305 | |
| #openstack-sdks - 2020-08-03 | |||
| 10:33:35 | openstackgerrit | jayaditya gupta proposed openstack/python-openstackclient master: openstack CLI migration list support https://review.opendev.org/742210 | |
| 12:08:42 | frickler | mordred: can you take a look at https://review.opendev.org/742647 and it's relation to https://review.opendev.org/713595 and the original patches cited in the first patch? I'm confused as to which issue is now fixed, which fix still needs to be done and how to proceed | |
| 12:09:32 | frickler | the thing I know is that "openstack network rbac create" is currently broken for a non-admin user using OSC >= 5.0.0 | |
| 12:14:53 | frickler | (and 742647 fixed that) | |
| 12:57:31 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add support for filters into the project cleanup https://review.opendev.org/735336 | |
| 13:45:34 | mordred | frickler: done. I think that patch takes care of it. I think if we wanted we could re-revert the 713595 once 742647 lands since osc would handle both exceptions at that point | |
| 14:52:18 | openstackgerrit | Merged openstack/python-openstackclient master: Fix reverted osc-lib interface change https://review.opendev.org/742647 | |
| 17:35:18 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add support for filters into the project cleanup https://review.opendev.org/735336 | |
| #openstack-sdks - 2020-08-04 | |||
| 11:27:20 | nightmare_unreal | can someone review this : https://review.opendev.org/#/c/742210/ | |
| #openstack-sdks - 2020-08-05 | |||
| 15:42:14 | lbragstad | o/ curious if anyone would be interested in taking a look at https://review.opendev.org/#/c/740380/ | |