Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-07-28
12:39:28 mordred dtantsur: ++
12:54:16 openstackgerrit jayaditya gupta proposed openstack/python-openstackclient master: openstack CLI migration list support https://review.opendev.org/742210
12:55:14 dtantsur mordred: a question: what do we expect auth.get_endpoint() (and thus session.get_endpoint) to return: a versioned or unversioned endpoint?
13:00:42 openstackgerrit Dmitry Tantsur proposed openstack/keystoneauth master: [WIP] Correct endpoint discovery for non-keystone plugins https://review.opendev.org/743282
13:03:29 mordred dtantsur: I think versioned? I think we expect get_endpoint() to return a usable endpoint that could then be fed to a session.get call
13:03:35 mordred dtantsur: I *think*
13:03:50 dtantsur mordred: my unit tests show otherwise :( see the WIP patch above
13:04:12 mordred dtantsur: ah - then I think maybe we expect otherwise
13:06:53 dtantsur :)
13:07:12 dtantsur https://review.opendev.org/#/c/743530/ will hopefully give these patches some testing
13:10:55 mordred dtantsur: fingers crossed
13:11:21 dtantsur yeah.. it works locally, but the bifrost CI will also test keystone authentication and no-auth
13:12:42 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP add Ironic modules https://review.opendev.org/743533
13:13:34 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP add Ironic modules https://review.opendev.org/743533
14:13:13 nightmare_unreal can someone look at this patch ( it's getting too big). I want to know if it's even in right direction : https://review.opendev.org/#/c/742210/
14:22:47 openstackgerrit Merged openstack/keystoneauth master: Fix get_endpoint_data for non-keystone plugins https://review.opendev.org/743227
14:38:36 dtantsur mordred: so far, one job passed, one made python segfault :)
14:38:40 dtantsur 1:1 I guess?
14:41:02 dtantsur joking aside, my keystoneauth patches seem working so far
14:41:12 dtantsur (I assume I could not cause the segfault with them)
14:43:31 mordred Yay!
14:44:57 dtantsur mordred: do we need to check anything else? I assume openstack itself takes a different code path (with identity)?
14:46:28 dtantsur okay, I'm adding a reno and a meaningful commit message
14:49:23 mordred dtantsur: I think as long as openstacksdk tests pass and bifrost that we should be pretty good
14:50:17 openstackgerrit Dmitry Tantsur proposed openstack/keystoneauth master: Correct endpoint and major version discovery for non-keystone plugins https://review.opendev.org/743282
14:50:18 dtantsur mordred: okay, please review ^^
14:52:43 mordred dtantsur: I think that looks great
14:55:36 mordred dtantsur: I pinged knikolla about it in the keystone channel (and apparently here now ;) )
14:56:03 dtantsur two pings better than one, right? :)
14:56:03 mordred but maybe lbragstad will save him
14:58:03 knikolla why stop there? haha :)
15:05:52 openstackgerrit Dmitry Tantsur proposed openstack/ansible-collections-openstack master: Do not require ironic_url if cloud or auth.endpoint is provided https://review.opendev.org/742932
15:05:55 dtantsur sshnaidm, TheJulia ^^^
15:10:10 openstackgerrit Dmitry Tantsur proposed openstack/ansible-collections-openstack master: Do not require ironic_url if cloud or auth.endpoint is provided https://review.opendev.org/742932
16:57:00 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add Ironic nodes info module https://review.opendev.org/743533
17:05:56 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add Ironic nodes info module https://review.opendev.org/743533
17:22:08 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add Ironic nodes info module https://review.opendev.org/743533
17:47:29 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add Ironic nodes info module https://review.opendev.org/743533
18:06:29 openstackgerrit Merged openstack/ansible-collections-openstack master: Do not require ironic_url if cloud or auth.endpoint is provided https://review.opendev.org/742932
19:44:43 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add Ironic nodes info module https://review.opendev.org/743533
20:48:49 openstackgerrit melanie witt proposed openstack/python-openstackclient master: WIP Show words indicating booted from volume for server image https://review.opendev.org/743429
21:05:43 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add Ironic nodes info module https://review.opendev.org/743533
22:35:53 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add Ironic nodes info module https://review.opendev.org/743533
#openstack-sdks - 2020-07-30
16:07:48 elmiko API SIG office hour open (only slightly late)
22:52:02 openstackgerrit Ghanshyam Mann proposed openstack/keystoneauth master: DNM: testing gate on ubuntu focal https://review.opendev.org/743118
#openstack-sdks - 2020-07-31
09:32:42 openstackgerrit Dmitry Tantsur proposed openstack/keystoneauth master: Correct major version discovery for non-keystone plugins https://review.opendev.org/743282
10:53:01 dtantsur mordred, cmurphy, a short version, also seems to work for us ^^^
14:11:21 mordred dtantsur: awesome
15:03:49 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "numa_affinity_policy" attribute to "port" https://review.opendev.org/740422
15:19:14 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add NUMA affinity policy parameter to "port" https://review.opendev.org/740501
16:40:43 dtantsur cmurphy, mordred, thank you for approving https://review.opendev.org/#/c/743282/ ! Would it be possible to have a release in the near future?
16:41:57 cmurphy dtantsur: sure, propose it and have knikolla +1 it
16:42:23 dtantsur okie. I'm leaving for a day, so I guess on Monday.
16:42:30 dtantsur (unless it merges really soon)
17:29:25 openstackgerrit Merged openstack/openstacksdk master: Add compute microversion 2.6 and 2.8 https://review.opendev.org/741674
17:29:27 openstackgerrit Merged openstack/openstacksdk master: baremetal-introspection: allow fetching unprocessed data https://review.opendev.org/743517
17:45:45 artom o/
17:46:46 artom In the context of fixing server rebuild parameters and bring them in line with the actual Nova API (https://review.opendev.org/#/c/741688/) - what's the difference between rebuild_server() in openstack/cloud/_compute.py and openstack/compute/v2/_proxy.py?
17:59:51 openstackgerrit Merged openstack/keystoneauth master: Correct major version discovery for non-keystone plugins https://review.opendev.org/743282
18:19:20 mordred artom: openstack/cloud/_compute.py is the layer that used to be shade. it's the layer where we do a bunch of extra business logic for people. If you have a Connection called conn - you'd call that one like conn.rebuild_server - amongst the things it does is hide even which service a particular action comes from (a design that was more important back in the day of nova-image and nova-network alongside glance and neutron)
18:20:06 mordred artom: openstack/compute/v2/_proxy.py is a layer down - we have an eventual goal to have the shade layer use the resource layer instead of making direct rest calls
18:20:26 mordred artom: so - you know - all sorts of good history there :)
18:21:16 artom mordred, so no one is expected to call stuff in openstack/compute/v2/_proxy.py directly?
18:22:24 mordred artom: nah - either are actually fine - that both exist is a historical oddity at this point - with a few things we've gotten all the way to the shade layer being just a backwards compat shim over the other layer
18:22:45 mordred I personally just use the shade layer because it's less typing
18:23:54 artom mordred, so specifically in my rebuild case, shade doesn't actually call the compute proxy, it does the REST request directly
18:24:18 mordred at one point I was thiking that the proxy/resource layer should be the thing that more closely tracks the rest api and the cloud layer is where we do extra things - but it turns out we have to deviate from the rest api at the proxy/resource layer anyway in many cases, so the distinction is one that I think ultimately is not useful
18:24:32 artom Which means if I want to "fix" the rebuild_server args, I'd have to add **kwargs there as well, because there's a whole bunch of stuff that's in the API that's currently impossible with shade
18:25:36 mordred yeah - also, wow that's a terrible signature in that rebuild_server call in the sahde layer :(
18:25:46 artom Tell me about it :(
18:26:52 mordred I almost think we might be better off making the shade layer use your updated resource layer and just figure out how to make the backwards compat not totally suck. I hate that we called the image parameter image_id though :(
18:28:31 artom Ah, I see
18:29:10 artom Yeah, that's a really bizarre method signature
18:29:20 artom Some args are for the rebuild itself, others for when you show the server after
18:29:35 artom Can we burn and start over? :)
18:30:27 mordred at least the shade layer requires image as a parameter! ;)
18:31:06 artom Hehe, true
18:31:21 artom Ugh, I wasn't planning on thinking this much on a Friday afternoon
18:31:57 mordred so - I'm ok with breaking compat in the resource layer for this - like you said the current thing is pretty broken
18:32:29 mordred I think we can do the "update shade layer to use resource layer" as a followon - and we should be able to do it without breaking the shade layer's contract
18:32:41 mordred since we'll just be adding a **kwargs or something similar
18:32:50 artom Shovel down the line, future me can deal with it. I like how you think :)
18:33:00 mordred it'll just be lame that the parameter name is image_id - but if that's the worst thing that happens
18:33:31 mordred (I think we can improve that paramter to take image objects too and just document it - if people don't like the name they can pass it positionally :) )
18:33:58 mordred future me is always smarter than today me anyway
18:35:08 artom Words of wisdom right there.
18:51:21 mordred artom: so - I'm +2 on that once there's a release note - probably with someting in the upgrade section
18:51:45 artom mordred, cool, I have that locally, need to fix the test on top of it, then push
18:52:00 mordred cool.
18:52:09 mordred I might take a stab at the shade patch once you do
18:52:12 mordred or I might leave that for tomorrow us
18:55:32 artom Hehe
19:43:34 openstackgerrit Artom Lifshitz proposed openstack/openstacksdk master: Func test for compute microversion 2.9 https://review.opendev.org/741689
19:43:34 openstackgerrit Artom Lifshitz proposed openstack/openstacksdk master: Fix rebuild_server named argument https://review.opendev.org/741688
20:37:29 mnaser mordred: so i think https://github.com/openstack/openstacksdk/commit/75ae5bf4aadedf47e26264f278c19adb64871735 might actually break every single OSA deployment out there :(
20:38:02 mnaser because by default the 'supports image import' is always enabled, even when we were deploying via uwsgi
20:38:06 mordred mnaser: well that's bad
20:38:20 mnaser dansmith pushed a patch to 'autodisable' that flag which was sadly -2d
20:38:30 mordred mnaser: well ... we default to false
20:38:34 mordred you have to opt-in to using import

Earlier   Later