| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-04-20 | |||
| 18:47:24 | openstackgerrit | Merged openstack/keystoneauth master: Cleanup py27 support https://review.opendev.org/720742 | |
| 19:37:48 | johnsom | Is anyone else getting py36/py37 failures on the openstack.tests.unit.baremetal.v1.test_proxy.TestWaitForNodesProvisionState.test_timeout_and_failures_not_fail test for openstacksdk? | |
| 19:38:15 | johnsom | One of the students I am mentoring pointed out that master seems to have a problem with that test. | |
| 19:38:44 | johnsom | https://www.irccloud.com/pastebin/w06wGSwb/ | |
| 19:42:07 | smcginnis | johnsom: Just ran py37 and it passes for me. | |
| 19:42:30 | johnsom | Hmm, how odd. I could reproduce the problem he was seeing. | |
| 19:42:50 | johnsom | (That paste above was from running local for me) | |
| 19:42:57 | smcginnis | Hmm, very odd. | |
| 19:43:22 | smcginnis | Double checked. I'm on master and up to date. | |
| 19:43:37 | smcginnis | py38 passed too. Don't think I have py36 on this machine. | |
| 19:44:09 | smcginnis | This is odd too: expected str instance, Mock found | |
| 19:44:32 | smcginnis | johnsom: What do you get with .tox/py37/bin/pip freeze | grep -i mock | |
| 19:45:03 | johnsom | requests-mock==1.7.0 | |
| 19:45:03 | johnsom | mock==3.0.5 | |
| 19:45:03 | johnsom | $ .tox/py37/bin/pip freeze | grep -i mock | |
| 19:45:23 | smcginnis | Hmm, same. | |
| 19:45:36 | johnsom | Yeah, mine is a fresh clone | |
| 19:46:09 | smcginnis | Trying "git clean -f; tox -re py37" | |
| 19:47:04 | johnsom | I will, but given it's a completely fresh directory/clone seems like it's already there. | |
| 19:47:21 | smcginnis | No, saying I was going to try that to see if it's something in mine. :) | |
| 19:47:27 | johnsom | Oh, I wonder if it pulled from github at that sync issue is at play. It's an old alias | |
| 19:47:33 | smcginnis | And no, that didn't make any difference. My local run still passed. | |
| 19:47:56 | smcginnis | What's the commit hash of HEAD? | |
| 19:48:01 | johnsom | Nope, it pulled from opendev | |
| 19:49:33 | johnsom | a53edeeaac286124f2e9a212ea95c8643a96f256 | |
| 19:51:25 | smcginnis | OK, yep. That's what I'm at as well. | |
| 19:51:31 | johnsom | It is not the out-of-sync issue for sure, cloned from both, both bomb on 3.7 | |
| 19:52:58 | smcginnis | johnsom: If you want to stare and compare for any other differences: http://paste.openstack.org/show/792433/ | |
| 19:53:25 | smcginnis | Seems like it has to be an evironmental difference issue. | |
| 19:55:41 | johnsom | Yeah, no difference in the list other than you cloned from github | |
| 19:56:16 | smcginnis | Wow, must be an old one. | |
| 20:00:02 | smcginnis | Fresh clone from opendev.org into a new directory. Still passes for me. | |
| 20:00:09 | smcginnis | So something else different in the environment. | |
| 20:00:12 | johnsom | Hmm, the failure seems legit at a quick review. There is '3' in sequence, so I can see how a mock would be there. | |
| 20:03:56 | johnsom | Yeah, the '3' in the list does in fact cause a mock object to go into the remaining list which the debug tries to get an id from. | |
| 20:07:09 | johnsom | Hm, no, it's the ID which is an int | |
| 20:18:42 | johnsom | smcginnis Which python3 are you running? I have python3.7 3.7.5-2~18.04 | |
| 20:21:06 | johnsom | Hmm, fails on my fedora host as well | |
| 20:33:41 | smcginnis | johnsom: Python 3.7.6 | |
| 20:34:01 | johnsom | python3-3.7.6-2.fc31.x86_64 on fedora | |
| 20:34:21 | smcginnis | Yeah, that's probably exactly what I have on this machine. | |
| 20:35:06 | johnsom | This is so odd, I can do a for-in and print the id number fine, but if it's in the shorthand it blows up. | |
| 21:48:31 | openstackgerrit | Noah Mickus proposed openstack/openstacksdk master: Add cipher list support for octavia https://review.opendev.org/721351 | |
| #openstack-sdks - 2020-04-21 | |||
| 06:51:41 | frickler | johnsom: smcginnis: FYI that seems to be some weird test-case interaction. if I just run the one single brokenish test, it fails 100% for me. | |
| 06:51:58 | frickler | running "tox -e py37 -- openstack.tests.unit.baremetal.v1.test_proxy" fails about 20% of the time only | |
| 06:53:04 | frickler | so my intermediate conclusion is that the test is indeed broken, but some of the surrounding mocking is covering that up | |
| 06:54:49 | frickler | dtantsur|afk: ^^ seems you wrote most of that, see https://www.irccloud.com/pastebin/w06wGSwb/ for the failure occuring when you run just that single test | |
| 08:23:58 | nightmare_unreal | hello I am trying to add server-migration-list cmd of nova to openstackclient. I can't seem to figure out how to add it to openstackclient ( I don't mean implmentation) | |
| 08:24:25 | nightmare_unreal | for e.g. openstack server migrate is a valid cmd. I want to add openstack server migration-list (something like this) | |
| 08:30:05 | openstackgerrit | Masayuki Igawa proposed openstack/cliff master: Switch to use stestr https://review.opendev.org/721545 | |
| 08:39:05 | openstackgerrit | Masayuki Igawa proposed openstack/cliff master: Switch to use stestr https://review.opendev.org/721545 | |
| 08:46:56 | openstackgerrit | Masayuki Igawa proposed openstack/cliff master: Switch to use stestr https://review.opendev.org/721545 | |
| 09:01:36 | dtantsur | frickler: hey, sure, will check | |
| 10:21:04 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Fix an unstable bare metal unit test https://review.opendev.org/721566 | |
| 10:21:05 | dtantsur | frickler, mordred ^^ | |
| 10:55:21 | frickler | dtantsur: lgtm, thx | |
| 11:13:46 | gtema | lgtm as well, as soon as tests are there will put a vote | |
| 11:21:03 | dtantsur | also looking for a 2nd +2 on https://review.opendev.org/#/c/720701/ | |
| 11:21:25 | gtema | will be there when tests arrive :D | |
| 11:22:49 | dtantsur | the 2nd one has passed CI quite a while ago, no? | |
| 11:27:09 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Convert os_server_info to use OpenStackModule https://review.opendev.org/721580 | |
| 12:13:11 | gtema | facepalm - you patch will not pass unless we fix our docs | |
| 12:13:20 | dtantsur | \o/ | |
| 12:13:32 | gtema | I know how to fix them, but for this need to touch literaly every doc file | |
| 12:13:33 | dtantsur | do you know what the problem is? I could find it in the output | |
| 12:13:38 | dtantsur | OUCH | |
| 12:13:40 | gtema | latest Sphinx | |
| 12:13:56 | dtantsur | these sphinxes, always puzzle me! | |
| 12:13:59 | gtema | it was capped for some time in the upper-constraints, but them again released | |
| 12:14:14 | gtema | I had a long fight downstream with those | |
| 12:14:35 | gtema | lemme "quickly" try to prepare the patch | |
| 12:17:20 | openstackgerrit | amolkahat proposed openstack/ansible-collections-openstack master: if any changes has been made to the os_router then it was deleting the interfaces. It causes the module failure. https://review.opendev.org/721591 | |
| 12:25:14 | openstackgerrit | jayaditya gupta proposed openstack/python-openstackclient master: Provide support for live-migration-force-complete command in openstackclient https://review.opendev.org/721594 | |
| 13:55:34 | gtema_ | hmm, the fix for docs is ready, but somehow my "git review" hangs enless | |
| 14:37:43 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Update docs to work with newer Sphinx https://review.opendev.org/721631 | |
| 14:38:26 | gtema | meah, did a dirty hack and switched to https from ssh - weird when connecting from home without proxies | |
| 14:50:41 | mordred | gtema: I think doc/.DS_Store got added by accident? | |
| 14:50:50 | gtema | surely | |
| 14:51:11 | mordred | gtema: also - jeez - what a change! | |
| 14:52:41 | mordred | gtema: also - some trailing whitespace (wouldn't want to anger the linter gods) - otherwise looks great, thank you! | |
| 14:52:43 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Update docs to work with newer Sphinx https://review.opendev.org/721631 | |
| 14:53:46 | gtema | holy madness, vim is getting crazy on this change including not showing and not removing those trailing spaces | |
| 14:54:35 | mordred | gtema: we can't have nice things | |
| 14:54:46 | gtema | yupp | |
| 15:06:23 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Update docs to work with newer Sphinx https://review.opendev.org/721631 | |
| 15:06:55 | nmickus | I'm working on patch adding cipher support for Octavia and it's failing the docs test, and could use some assistance figuring out whats wrong/missing if you have the time thanks in advance | |
| 15:07:33 | gtema | nmickus - the patch I pushed right now should fix it after it is merged | |
| 15:08:18 | nmickus | Good to know, Thanks! | |
| 16:08:57 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Convert os_server_info to use OpenStackModule https://review.opendev.org/721580 | |
| 22:43:45 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746 | |
| #openstack-sdks - 2020-04-22 | |||
| 00:49:02 | openstackgerrit | Merged openstack/openstacksdk master: Update docs to work with newer Sphinx https://review.opendev.org/721631 | |
| 05:54:53 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746 | |
| 07:11:51 | openstackgerrit | Daniel Bengtsson proposed openstack/osc-lib master: Stop configuring install_command in tox and stop use pip. https://review.opendev.org/694510 | |
| 08:25:06 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746 | |
| 08:37:49 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP: Add OpenstackModule to os_server_action https://review.opendev.org/721746 | |
| 09:55:54 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP: Add OpenstackModule to os_server_action https://review.opendev.org/721746 | |
| 10:04:55 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746 | |
| 12:33:41 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746 | |
| 13:21:20 | frickler | mordred: gtema: please have a look at this revert, not sure whether we can get a FFE for that, but I think it would make sense https://review.opendev.org/717712 | |
| 13:22:46 | mordred | frickler: I think that seems like a valid reason to re-release. +A | |