Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-04-16
16:29:10 dtantsur ugh :(
16:30:01 elmiko yeah... we need to have someone come and repair it, or buy a new one, and that is making me nervous
16:33:27 dtantsur I can imagine. I hope it ends up well though.
16:33:36 elmiko thanks
16:33:48 dtantsur We've started carefully going outside for walks.. impossible otherwise
16:34:05 elmiko if the worst that happens is i loose a little cheese and milk, i think we'll be ok XD
16:34:41 dtantsur :D
16:36:16 dtantsur okay, I need to leave earlier today. take care!
16:36:22 elmiko you too/
17:06:51 elmiko have a good weekend all
19:33:48 openstackgerrit Merged openstack/ansible-collections-openstack master: Add properties for os_project https://review.opendev.org/715266
#openstack-sdks - 2020-04-17
07:59:37 iurygregory mordred, hey o/ good morning (not sure if you are awake) re your comment in https://review.opendev.org/#/c/718746/1/openstack/baremetal/v1/_proxy.py you wanted to be volume_connectors only for that function since is the one to list correct?
08:26:48 iurygregory hey everyone locally I'm trying to run tox -r -vv -e docs for openstacksdk using the master and it's failling any tips?
08:35:10 amotoki iurygregory: it is caused by sphinx 3.0. If you would like to get the rendered documents, you can avoid the error with sphinx <3.
08:37:02 AJaeger is anybody looking into it or shall I?
08:38:03 amotoki AJaeger: I don't know someone is looking into it. I just confirmed it locally but I have something other to do right now.
08:39:26 AJaeger just noticed the logs - that's not one of the usual errors;( I'll check for 5 mins or so.
08:40:29 gtema I was having to fight downstream with those issues and can prepare fix for SDK docs for support of Sphin >=3.0, but this is quite a lot
08:40:54 AJaeger gtema: that would be appreciated!
08:41:14 gtema ok, taken on my FIFO todo
08:41:34 AJaeger thanks
08:49:40 iurygregory amotoki, i have some high priorities atm >.< otherwise I would be happy to help
09:03:09 dtantsur who could approve this simple patch please? https://review.opendev.org/#/c/717737/
09:03:38 dtantsur amotoki, mordred ^^
09:03:58 amotoki dtantsur: sure
09:29:12 openstackgerrit Dmitry Tantsur proposed openstack/osc-lib master: Remove Babel from requirements https://review.opendev.org/717737
09:29:20 dtantsur amotoki: updated ^^
09:30:29 amotoki dtantsur: thanks. I read thru the translation handling scripts again :)
09:32:01 gtema amotoki, i placed my + there also. If you find ok let's do +A
10:25:31 openstackgerrit Merged openstack/python-openstackclient master: Add resource option immutable https://review.opendev.org/715269
11:35:55 openstackgerrit Merged openstack/openstacksdk stable/rocky: Add ansible collection job to rocky branch https://review.opendev.org/714079
11:35:56 openstackgerrit Merged openstack/openstacksdk stable/rocky: Add tests for Ansible built-in modules in 2.8,2.9 https://review.opendev.org/714086
12:00:24 AJaeger here's a change for os-client-config to cleanup py27 support, please review https://review.opendev.org/#/c/717609/
12:00:29 AJaeger and a similar one for service-types-authority, please: https://review.opendev.org/719183
12:00:33 AJaeger mordred: can you help, please? ^
12:01:07 dtantsur AJaeger: there is a question re 3.5 on the first of them
12:01:20 dtantsur I remember discussing it on another patch, but I don't remember the resolution
12:04:26 openstackgerrit Andreas Jaeger proposed openstack/os-client-config master: Cleanup py27 support https://review.opendev.org/717609
12:05:05 AJaeger dtantsur: I followed your suggestion - as long as shade is testing 3.5, we need 3.5 in there...
12:06:12 dtantsur thanks!
12:15:59 openstackgerrit Dmitry Tantsur proposed openstack/python-openstackclient master: Move Babel to test-requirements https://review.opendev.org/720701
12:16:01 dtantsur not sure if even test-requirements is needed ^^^
12:24:04 openstackgerrit Merged openstack/service-types-authority master: Cleanup py27 support https://review.opendev.org/719183
13:38:29 openstackgerrit Dmitry Tantsur proposed openstack/python-openstackclient master: Remove Babel from requirements https://review.opendev.org/720701
13:38:30 dtantsur updated with the recent findings ^^^
14:49:50 AJaeger who's reviewing shade? Here's a change to update the jobs which we need to move forward with py27 drop, please review https://review.opendev.org/#/c/718068/
14:54:59 openstackgerrit Monty Taylor proposed openstack/shade master: Update master for stable/ussuri https://review.opendev.org/719021
14:55:18 openstackgerrit Monty Taylor proposed openstack/shade master: Add Python3 victoria unit tests https://review.opendev.org/719022
14:55:34 mordred AJaeger: done!
14:58:56 AJaeger thanks, mordred
15:00:35 openstackgerrit Andreas Jaeger proposed openstack/keystoneauth master: Cleanup py27 support https://review.opendev.org/720742
15:07:16 openstackgerrit Sean McGinnis proposed openstack/shade master: Declare py38 support https://review.opendev.org/720746
15:31:40 openstackgerrit Dmitry Tantsur proposed openstack/python-openstackclient master: Remove Babel from requirements https://review.opendev.org/720701
15:32:58 openstackgerrit Dmitry Tantsur proposed openstack/python-openstackclient master: Remove Babel from requirements https://review.opendev.org/720701
15:33:38 dtantsur lower-constraints is quite a fragile thing
15:40:47 AJaeger dtantsur: it's not working as designed IMHO
15:41:15 dtantsur to me we should only list direct dependencies in lower-constraints.txt
15:41:20 dtantsur but I seem to be alone in that
15:41:52 AJaeger dtantsur: Let me write up something...
15:44:37 AJaeger dtantsur: will take a bit, I need an example
15:47:08 dtantsur depending on what you need, I may be able to help
15:51:53 smcginnis Should be able to AND the packages between lower-constraints.txt and (requirements.txt and test-requirements.txt).
15:52:26 smcginnis I think Doug's original reasoning for having other packages was to be able to test all other dependencies too.
15:53:10 dtantsur for me it's very problematic every time the list is updated
15:53:21 dtantsur if we include indirect dependencies (like babel now)
15:53:34 dtantsur I can go back to putting babel in lower-constraints
15:53:46 dtantsur whatever is better
15:53:57 smcginnis Yeah, personally I would prefer to only enforce our direct dependencies too.
15:54:19 smcginnis And trust that they are not installing their own dependencies unconstrained (which actually probably is a risky assumption).
15:56:20 AJaeger The problem is: We install package X in version 0.1, then package Y needs X in version 0.2 - and pip -U installs that ;( I need to dig out an example, this is happening often.
15:58:31 dtantsur is it a problem though?
15:58:46 dtantsur I thought the goal was to verify our minimum caps
15:59:02 dtantsur so that e.g. we don't put requests>=1.0 but use features from 1.2
15:59:16 dtantsur indirect dependencies are not used directly, so it makes no sense for them?
15:59:21 openstackgerrit Merged openstack/shade master: Break out py27 job templates https://review.opendev.org/718068
15:59:22 openstackgerrit Merged openstack/shade master: Update master for stable/ussuri https://review.opendev.org/719021
16:01:03 AJaeger dtantsur: yes, if you change one line, everything blows up as you noticed
16:01:42 smcginnis AJaeger: That may be the reason for inclusing our indirect dependencies in there - to make sure that scenario doesn't happen my locking down everything and make sure we always get the versions we expect to get.
16:01:49 smcginnis *including
16:02:10 AJaeger smcginnis: but we don't - I need an example, give me somem time, please
16:02:19 AJaeger And then let's discuss whether I'm right or not...
16:02:48 dtantsur smcginnis: the other way around. if you include all dependencies, any change will likely cascade.
16:03:09 smcginnis dtantsur: Yes, but that would be by design, right?
16:03:09 dtantsur if you only include direct dependencies, you'll get into trouble only if your minimum cap conflicts with some other.
16:03:19 dtantsur not sure
16:03:31 dtantsur I see the goal of lower-constraints differently
16:03:48 smcginnis If we want a definitive set of requirement minimums that can be used, we need to be explicit about everything that gets installed to be able to verify it actually works.
16:04:11 dtantsur I only care about direct dependencies because that's what we (in a project) control
16:05:16 dtantsur like, in this case I have to care that something else is using babel and pytz. I don't think I should.
16:05:20 smcginnis But like Andreas pointed out, if we say we want version 1.0, but then an indirect dependency raises that to 2.0, we aren't actually capturing (or at least validating) what our minimum version of that lib should be.
16:06:09 dtantsur smcginnis: in this case the job will fail and we'll know :)
16:06:26 dtantsur that's literally what happened with my patch
16:06:39 smcginnis I'm probably missing some context. Which patch is this?
16:06:57 dtantsur smcginnis: tl;dr I've uncapped babel and it got pulled again down the road with a conflicting pytz requirement
16:07:49 smcginnis Yeah, so that points to the reason for why lower-constraints should have packages that are not in requirements and test-requirements.
16:08:00 smcginnis It needs to control the full environment.
16:08:11 dtantsur for me it points to the opposite thing :)
16:08:23 dtantsur I don't need this control. As a developer I don't care about it.
16:08:31 dtantsur Maybe we see the goals of lower-constraints differently?
16:08:42 dtantsur For me it's only to verify that we don't violate our minimum caps

Earlier   Later