Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-03-26
15:41:26 dtantsur maybe :)
15:41:34 dtantsur you can try it locally with `git tag` and see
15:41:49 mordred dtantsur: I modified the revert so that we don't need to revert the cleanup patch - it just won't use futurist for it for that one release
15:42:03 mordred dtantsur: k. I'll try that real quick
15:42:22 gtema and actually nobody will use it so far (likely)
15:42:28 mordred dtantsur: considering we just released the cleanup feature today - I think if we rleease 0.45 and 0.46 back to back - it should be safe
15:42:53 dtantsur mordred: maybe we can/should default to concurrent.futures.ThreadPoolExecutor actually?
15:43:08 dtantsur the same API as futurist, so people can switch easily?
15:44:50 mordred dtantsur: oh - that's not a terrible idea
15:45:09 gtema keep your thought, otherwise mordred will create 30 different patches and we will die ensuring we approve them in correct order ;)
15:45:12 mordred people who want to use futurist.GreenThreadExecutor can still pass it
15:45:18 dtantsur exactly
15:45:38 mordred I think I like that even more. it's basically what we have above except without the second re-revert
15:45:48 mordred maybe should rewrite the release note slightly differently
15:46:09 tremble mordred, Should doing dict(some_resource) result in a *all* parameters (body and URI based) showing up in the new dict ?
15:46:41 mordred tremble: that's an excellent question - I believe so?
15:47:37 mordred dtantsur: the re-tag idea did not work :)
15:47:42 gtema oh, I remember some interesting stuff about that when fighting with replacing cloud layer - something funny was there for sure
15:47:58 dtantsur mordred: oookay, let's go with this patch
15:48:10 dtantsur (the release note could use an update indeed)
15:49:31 gtema tremble, we prefer using https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/resource.py#L918 (to_dict) for those reasons
15:50:14 tremble gtema, That'll do me as a fix :)
15:50:53 tremble gtema, Would misbehaving with dict() be considered a bug?
15:51:05 tremble and if so, where do you want reports :)
15:51:16 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Revert "Switch to futurist for concurrency" https://review.opendev.org/715249
15:51:50 mordred dtantsur, gtema: ^^ I think that should fix the issue. we can land that, gtema's otc fix and then cut an 0.45
15:51:53 gtema tremble - I would not say it is a bug, resource implementation is incredible woodoo
15:52:04 mordred then I still think we should put ina. requires-python for 0.46
15:52:09 tremble gtema, I noticed :)
15:52:39 mordred smcginnis: per scrollback - I think we found a solution that doesn't require removing anything
15:53:07 mordred vphilippon: thanks for the report! we shoudl have a fixed release up soonish (will take a couple of hours for all of the gears to crank)
15:53:27 gtema mordred, so I rebase vendor patch on top of 715249, right?
15:54:45 smcginnis I will watch for the release and try to get it through asap.
15:54:51 smcginnis And the requirements update.
15:55:11 vphilippon @mordred: Alrighty, thanks a lot for the quick reaction. And thanks to everyone else too :)
15:55:54 tremble gtema, to_dict() still seems to exclude the resource.URI entry
15:56:29 gtema ah, and you need those explicitely?
15:56:49 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.6 is required https://review.opendev.org/715243
15:56:49 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Change default image type in the OTC vendor profile https://review.opendev.org/715183
15:57:03 mordred gtema: rebase done ^^
15:57:09 gtema ok, thks mordred
15:57:17 mordred gtema: I'm guessing this is for returning data to an ansible module - which needs json-able dict
15:57:40 mordred smcginnis: I think the constraints patch that's there for us already is now safe
15:58:15 mordred smcginnis: but - we can also just wait to reduce churn
15:58:21 mordred smcginnis: I'll get release patches up asap
15:58:34 smcginnis OK. I need to update that so it's python_version aware. Might as well wait a bit.
15:59:11 tremble gtema, I wanted one for completeness, I can manually copy it over
15:59:34 gtema we can add a parameter for it in to_dict if necessary
15:59:59 tremble yeah, which then requires another release before I could use it in my Ansible module :)
16:00:13 gtema sure :D
16:00:35 elmiko API SIG office hour now open \o/
16:00:39 gtema lots of releases last days, therefore you might need to wait just one day, or one hour
16:00:40 mordred we're killing tremble here
16:00:51 tremble It'd be nice as a parameter, but I wouldn't prioritise it.
16:02:28 openstackgerrit Duc Truong proposed openstack/openstacksdk master: Remove kwargs validation for identity project updates https://review.opendev.org/715255
16:03:27 openstackgerrit Duc Truong proposed openstack/openstacksdk master: Remove kwargs validation for identity project updates https://review.opendev.org/715255
16:04:16 openstackgerrit Duc Truong proposed openstack/openstacksdk master: Remove kwargs validation for identity project updates https://review.opendev.org/715255
16:04:32 tremble gtema, I just got really confused because I tried to do "dict(my_resource)" and some of the parameters disappears compared to just passing the resource directly to Ansible's "exit_json"
16:05:12 gtema oh yes, this is really fun - was also enjoying it writing some modules
16:09:00 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol https://review.opendev.org/714991
16:09:01 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol_info https://review.opendev.org/714992
16:13:14 tremble gtema, On the plus side my integration tests actually caught it :)
16:14:41 gtema ah, there is one more thing to remember - switch on proxy in the cloud layer is not complete, therefore you might have different object types (munch vs resource) for different resources when using cloud layer
16:16:01 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add possibility to include URI attributes in the resource dict https://review.opendev.org/715256
16:17:08 gtema I was starting to work on that, but there are everywhere things to clear, so stuck at some point
16:17:18 gtema will try to revive this
16:17:25 mordred yeah - same
16:17:44 gtema ah, now I know what was the problem - resource object is not cacheable
16:18:01 gtema and this is where we stuck wanting to discuss at some point
16:25:17 mordred oh right
16:26:16 gtema I guess make sense to discuss it before PTG :D
16:30:28 gtema ok guys, need to go off while there is still bit of sun outside
16:31:13 elmiko carpe them diems ;)
16:31:21 gtema thks
16:44:12 openstackgerrit Duc Truong proposed openstack/ansible-collections-openstack master: Add properties for os_project https://review.opendev.org/715266
17:04:21 elmiko have a good weekend all, stay safe out there o/
17:09:28 openstackgerrit Vishakha Agarwal proposed openstack/python-openstackclient master: [WIP] Add immutable option https://review.opendev.org/715269
17:09:28 openstackgerrit Vishakha Agarwal proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444
17:13:54 openstackgerrit Merged openstack/python-openstackclient master: Add libc6-dev to bindep https://review.opendev.org/715210
17:25:38 openstackgerrit Merged openstack/python-openstackclient master: Be explicit about python version in image https://review.opendev.org/715211
18:15:40 openstackgerrit Duc Truong proposed openstack/ansible-collections-openstack master: Add properties for os_project https://review.opendev.org/715266
19:14:32 openstackgerrit Merged openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643
20:22:57 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Ignore more things for the final artifact https://review.opendev.org/715302
20:34:29 openstackgerrit Monty Taylor proposed openstack/cliff master: Re-add support for python 3.5 https://review.opendev.org/715305
20:36:32 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.5 is required https://review.opendev.org/715243
20:37:26 openstackgerrit Monty Taylor proposed openstack/cliff master: Re-add support for python 3.5 https://review.opendev.org/715305
20:38:19 openstackgerrit Monty Taylor proposed openstack/cliff master: Re-add support for python 3.5 https://review.opendev.org/715305
20:46:58 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.5 is required https://review.opendev.org/715243
20:49:50 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.5 is required https://review.opendev.org/715243
20:51:38 openstackgerrit Andreas Jaeger proposed openstack/openstacksdk master: Add requires-python entry indicating 3.5 is required https://review.opendev.org/715243
20:52:40 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.5 is required https://review.opendev.org/715243
20:52:56 mordred smcginnis: good catch
20:53:21 smcginnis Good, I feel better with that. ;)
20:53:39 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.5 is required https://review.opendev.org/715243
20:53:41 smcginnis mordred: Looks like you had a clash with Andreas. He made a minor typo fix.
20:53:47 mordred smcginnis: yeah - just picked it up
20:53:50 smcginnis And there you go..
20:55:05 openstackgerrit Andreas Jaeger proposed openstack/openstacksdk master: Small cleanups after Python2 drop https://review.opendev.org/715309
20:57:07 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Small cleanups after Python2 drop https://review.opendev.org/715309
21:01:41 openstackgerrit Andreas Jaeger proposed openstack/openstacksdk master: Re-add nodepool functional test https://review.opendev.org/715245

Earlier   Later