| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-03-25 | |||
| 20:59:14 | slaweq | and neutron from train don't know this field so it fails | |
| 20:59:15 | mordred | ah - so it's just a test thing | |
| 20:59:26 | slaweq | yes | |
| 20:59:35 | slaweq | and no | |
| 20:59:59 | slaweq | basically test from train branch https://github.com/openstack/openstacksdk/blob/stable/train/openstack/tests/functional/network/v2/test_port_forwarding.py don't send description field | |
| 21:00:00 | mordred | sshnaidm: yeah - we might need to rethink that. the historical position has been "just install latest sdk" | |
| 21:00:20 | slaweq | but the same test from master https://github.com/openstack/openstacksdk/blob/master/openstack/tests/functional/network/v2/test_port_forwarding.py have this new field | |
| 21:00:27 | mordred | slaweq: nod | |
| 21:00:40 | mordred | cool. I think I at least understand the issue | |
| 21:00:49 | mordred | the correct solution on the other hand ... | |
| 21:01:03 | ianw | mordred: ahh, seems i'm only +1, but it LGTM. it's all tangled web, but i guess that's exactly what the SDK takes the burden of so you don't have to! | |
| 21:01:04 | slaweq | and this failure in functional jobs in https://review.opendev.org/#/c/714770/ are because there is run test from master branch (with description field) | |
| 21:02:12 | mordred | sshnaidm: let's remove that branch override from the stable/train sdk branch | |
| 21:02:25 | mordred | sshnaidm: and see if things update themselves properly | |
| 21:02:25 | sshnaidm | mordred, ok | |
| 21:02:40 | slaweq | I hope I helped a bit :) | |
| 21:02:46 | mordred | slaweq: yes - very much! | |
| 21:02:48 | sshnaidm | also os-client-config ? | |
| 21:03:00 | mordred | sshnaidm: honestly os-client-config can probably just be removed | |
| 21:03:08 | mordred | but | |
| 21:03:15 | mordred | yeah - go ahead and just remove its branch override for now | |
| 21:03:23 | mordred | let's clean that up later so we're not shifting too many things at once | |
| 21:03:42 | openstackgerrit | Sagi Shnaidman proposed openstack/openstacksdk stable/train: Remove master override for openstacksdk https://review.opendev.org/715065 | |
| 21:03:44 | sshnaidm | ^^ | |
| 21:03:49 | mordred | sshnaidm: I think we still might want to consider constructing some things (similar to the ansible collection tests) that do things like "test master of openstacksdk against stable/train cloud" | |
| 21:03:54 | mordred | but that's gonna take a little work | |
| 21:04:05 | sshnaidm | mordred, yeah, matrix | |
| 21:04:17 | mordred | sshnaidm: would you remove teh comment too? | |
| 21:05:25 | openstackgerrit | Sagi Shnaidman proposed openstack/openstacksdk stable/train: Remove master override for openstacksdk https://review.opendev.org/715065 | |
| 21:06:11 | openstackgerrit | Sagi Shnaidman proposed openstack/openstacksdk stable/train: Remove master override for openstacksdk https://review.opendev.org/715065 | |
| 21:06:12 | sshnaidm | now ^ | |
| 21:06:48 | mordred | sshnaidm: honestly probably want the same thing on the other stable branches that you care about | |
| 21:07:11 | sshnaidm | it's weird they pass though.. | |
| 21:08:07 | sshnaidm | mordred, well, in stein it's override-branch: stable/stein | |
| 21:08:15 | sshnaidm | seems redundant | |
| 21:08:43 | sshnaidm | maybe just remove it? https://github.com/openstack/openstacksdk/blob/stable/stein/.zuul.yaml#L37:L37 | |
| 21:10:09 | sshnaidm | and override-branch: stable/rocky in rocky: https://github.com/openstack/openstacksdk/blob/stable/rocky/.zuul.yaml#L52 | |
| 21:10:15 | sshnaidm | that's why it works.. | |
| 21:11:35 | mordred | nod. | |
| 21:11:53 | mordred | so - this is something we've fixed before and forgotten about :) | |
| 21:23:39 | sshnaidm | but why need overrides.. | |
| 21:29:35 | mordred | sshnaidm: probably don't | |
| 21:29:44 | mordred | sshnaidm: s/probably// | |
| 22:10:25 | openstackgerrit | Merged openstack/python-openstackclient master: Don't look up project by id if given id https://review.opendev.org/712810 | |
| 22:46:56 | openstackgerrit | Merged openstack/openstacksdk master: Update Rackspace vendor profile for cinder v2 https://review.opendev.org/714630 | |
| 23:55:56 | openstackgerrit | Merged openstack/openstacksdk stable/train: Remove master override for openstacksdk https://review.opendev.org/715065 | |
| #openstack-sdks - 2020-03-26 | |||
| 07:17:25 | openstackgerrit | Merged openstack/openstacksdk master: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715052 | |
| 09:24:58 | openstackgerrit | Sagi Shnaidman proposed openstack/openstacksdk stable/train: Add ansible collection job to train branch https://review.opendev.org/714077 | |
| 10:05:49 | openstackgerrit | Bence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route https://review.opendev.org/674325 | |
| 10:40:45 | openstackgerrit | Sean McGinnis proposed openstack/openstacksdk master: Add cap for hacking https://review.opendev.org/715155 | |
| 12:16:58 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Change default image type in the OTC vendor profile https://review.opendev.org/715183 | |
| 12:27:52 | mordred | smcginnis: your hacking patch hit a set of errors that were apparently getting missed before - you wanna fix them or I can? | |
| 12:28:37 | smcginnis | mordred: I can. Confused on why adding a cap introduced failures though. | |
| 12:29:10 | smcginnis | mordred: Looks like something else going on there - fixtures._fixtures.timeout.TimeoutException | |
| 12:29:42 | smcginnis | But I can fix up the pep8 issues at least. | |
| 12:29:48 | mordred | smcginnis: yeah - that seems super unlikely to be caused by flake8 ... but oy | |
| 12:30:28 | smcginnis | "F821 undefined name 'Optional'" Wasn't that just added? | |
| 12:31:49 | smcginnis | Hmm, and doesn't fail locally for me. | |
| 12:32:12 | tremble | smcginnis, I kept hitting those timeout exceptions too, I think there's a flakey test somewhere. | |
| 12:32:14 | mordred | smcginnis: I LOVE when flake8 is weird like that | |
| 12:32:41 | smcginnis | At least a few of the things are legitimate. Might need to add some ignores in there for others. | |
| 12:32:46 | mordred | smcginnis: maybe it has something to do with the python version? | |
| 12:33:01 | smcginnis | And hopefully another pass through the check queue will get around those UT failures. | |
| 12:33:08 | mordred | the Optional error would be solved by importing Optional from typing | |
| 12:33:39 | smcginnis | Ohhhh, interesting... | |
| 12:33:59 | smcginnis | Current master that states hacking>=2.0.0 results in "hacking==1.1.0" getting installed. | |
| 12:34:09 | smcginnis | And with the patch just adding a cap, 2.0.0 gets installed. | |
| 12:34:21 | mordred | aroo? | |
| 12:34:36 | mordred | can we agree that doesn't make sense? | |
| 12:34:37 | smcginnis | Glad I just pulled a shot. | |
| 12:34:44 | smcginnis | Completely. | |
| 12:35:01 | mordred | tremble: new release of sdk is winding its way through the machinery | |
| 12:36:03 | smcginnis | OK, I need more coffee. | |
| 12:36:14 | smcginnis | I am NOT just adding a cap. | |
| 12:36:19 | sshnaidm | odyssey4me, hi, are you going to backport https://review.opendev.org/#/c/715052/ to stable branches? | |
| 12:36:33 | smcginnis | I actually am bumping hacking to 2.0, which now makes total sense why it would trigger new errors. | |
| 12:36:39 | odyssey4me | sshnaidm: yep, happy to once the preceding patches merge | |
| 12:36:50 | openstackgerrit | Bence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route https://review.opendev.org/674325 | |
| 12:36:52 | smcginnis | And obviously needed more coffee when I did that in the first place, because I should have expected new things to pop up. | |
| 12:38:12 | sshnaidm | odyssey4me, preceding patches..? | |
| 12:38:20 | mordred | smcginnis: haha. well, that at least makes more sense? | |
| 12:38:34 | odyssey4me | sshnaidm: https://review.opendev.org/#/q/I50b1020c896d7d8a7d58e62de778bb8c2b6e970e - I'll pick the patch on top of those | |
| 12:39:05 | openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/openstacksdk stable/train: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715192 | |
| 12:39:08 | sshnaidm | odyssey4me, I can just abandon mines, you have a full solution in yours | |
| 12:40:00 | openstackgerrit | Sagi Shnaidman proposed openstack/openstacksdk stable/train: Run fetch-subunit-output role conditionally https://review.opendev.org/714770 | |
| 12:40:16 | openstackgerrit | Igor Malinovskiy proposed openstack/python-openstackclient master: Add 'address_scope' type support to network rbac commands https://review.opendev.org/709124 | |
| 12:40:37 | openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/openstacksdk stable/stein: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715193 | |
| 12:40:40 | sshnaidm | odyssey4me, train and stein should be fine, rocky is waiting for pep8 fix | |
| 12:41:15 | openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/openstacksdk stable/train: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715192 | |
| 12:41:16 | openstackgerrit | Igor Malinovskiy proposed openstack/python-openstackclient master: Add 'subnetpool' type support to rbac commands https://review.opendev.org/712705 | |
| 12:41:31 | tremble | mordred, zo/ | |
| 12:41:32 | odyssey4me | sshnaidm: either way works - I've picked them already | |
| 12:41:34 | tremble | mordred, \o/ | |
| 12:42:11 | tremble | mordred, Anything I can watch to see it go through? | |
| 12:42:56 | mordred | tremble: https://review.opendev.org/#/c/715090/ | |
| 12:43:03 | mordred | although it looks like it just went through | |
| 12:44:03 | mordred | tremble: there's release jobs in https://zuul.opendev.org/t/openstack/status for the openstack/releases project that will actually publish to pypi | |
| 12:45:44 | tremble | Will the test jobs pick it up already? | |
| 12:47:26 | openstackgerrit | Sean McGinnis proposed openstack/openstacksdk master: Raise hacking to 2.x https://review.opendev.org/715155 | |
| 12:48:06 | smcginnis | tremble: If you filter on "release", there is a job that just started in teh release-post queue. | |