Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-03-25
16:38:46 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643
16:38:47 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686
16:38:48 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider https://review.opendev.org/714632
16:38:49 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider_info https://review.opendev.org/714633
16:38:50 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol https://review.opendev.org/714991
16:38:51 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol_info https://review.opendev.org/714992
16:47:19 openstackgerrit Mark Chappell proposed openstack/openstacksdk master: Add Release notes entry for Identity v3 IDP, Mapping and Protocol https://review.opendev.org/714994
17:50:14 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444
19:27:34 openstackgerrit Merged openstack/openstacksdk master: Add support for Federation Protocols https://review.opendev.org/714431
19:27:35 openstackgerrit Merged openstack/openstacksdk master: Add Release notes entry for Identity v3 IDP, Mapping and Protocol https://review.opendev.org/714994
19:41:02 sshnaidm frickler, can we please revisit this patch again? https://review.opendev.org/#/c/714899/ it pass and fixes a lot of pep8 issues
19:41:39 sshnaidm seems like https://review.opendev.org/#/c/714911/ just ignores them.. also could be an option, of course
20:08:57 openstackgerrit Jesse Pretorius (odyssey4me) proposed openstack/openstacksdk master: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715052
20:25:28 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add unit test for rackspace block-storage workaround https://review.opendev.org/715058
20:25:58 mordred dtantsur|afk: ^^
20:28:07 mordred sshnaidm: just left a comment on your backports of the fetch-subunit-output - let's squash in odyssey4me's
20:28:28 mordred (since I think the two of them together will be a nice improvement for all the branches)
20:29:59 sshnaidm mordred, yeah, totally fine with that
20:30:02 mordred cool
20:30:37 mordred ianw: feel like a +A on https://review.opendev.org/#/c/714630/ ?
20:30:57 mordred ianw: (it'll let us revert the override setting in our own clouds.yamls)
20:40:24 sshnaidm any ideas about neutron tests fail in train? https://review.opendev.org/#/c/714770/
20:46:01 mordred sshnaidm: I'm guessing you would not be happy with "train is old" as an answer ...
20:46:42 mordred sshnaidm: but seriously - no. maybe slaweq has an idea ?
20:47:37 sshnaidm slaweq, can you take a look in your time? devstack should work for train, maybe some settings miss ^
20:48:22 sshnaidm I'm actually fine if it's blocked forever and no breaking patches can come in.. also an option :)
20:52:01 mordred haha
20:53:06 slaweq sshnaidm: mordred looking
20:54:38 slaweq mordred: sshnaidm the issue IMO is that it runs SDK from master branch on this patch
20:54:46 slaweq not train
20:54:57 slaweq and neutron is from train
20:55:15 slaweq where we don't have "description" field in port forwarding
20:55:24 slaweq as it was added just few weeks ago in Neutron master
20:55:37 slaweq that's why those tests are failing
20:55:47 ianw mordred: does https://review.opendev.org/#/c/714630/3/openstack/config/vendors/rackspace.json need a {projectid} on the end of it?
20:56:06 slaweq but I believe it should run tests on stable/train branch of sdk, not master, right?
20:57:37 mordred slaweq: well ... we should probably update something so that master sdk works with train and master of neutron
20:57:54 mordred that said - I agree, the purpose of the stable/train test in this case is to test stable/train of sdk - so that means the test is likely misconfigured
20:58:40 sshnaidm mordred, hmm https://github.com/openstack/openstacksdk/blob/stable/train/.zuul.yaml#L40:L40
20:58:45 mordred ianw: it doesn't - we added a special logic workaround - projectid isn't available at the time substitutions are done
20:58:47 slaweq mordred: sdk will work
20:59:00 ianw mordred: yeah, ok seeing that
20:59:03 slaweq but test in master is always trying to send "description" attribute to neutron server
20:59:14 slaweq and neutron from train don't know this field so it fails
20:59:15 mordred ah - so it's just a test thing
20:59:26 slaweq yes
20:59:35 slaweq and no
20:59:59 slaweq basically test from train branch https://github.com/openstack/openstacksdk/blob/stable/train/openstack/tests/functional/network/v2/test_port_forwarding.py don't send description field
21:00:00 mordred sshnaidm: yeah - we might need to rethink that. the historical position has been "just install latest sdk"
21:00:20 slaweq but the same test from master https://github.com/openstack/openstacksdk/blob/master/openstack/tests/functional/network/v2/test_port_forwarding.py have this new field
21:00:27 mordred slaweq: nod
21:00:40 mordred cool. I think I at least understand the issue
21:00:49 mordred the correct solution on the other hand ...
21:01:03 ianw mordred: ahh, seems i'm only +1, but it LGTM. it's all tangled web, but i guess that's exactly what the SDK takes the burden of so you don't have to!
21:01:04 slaweq and this failure in functional jobs in https://review.opendev.org/#/c/714770/ are because there is run test from master branch (with description field)
21:02:12 mordred sshnaidm: let's remove that branch override from the stable/train sdk branch
21:02:25 mordred sshnaidm: and see if things update themselves properly
21:02:25 sshnaidm mordred, ok
21:02:40 slaweq I hope I helped a bit :)
21:02:46 mordred slaweq: yes - very much!
21:02:48 sshnaidm also os-client-config ?
21:03:00 mordred sshnaidm: honestly os-client-config can probably just be removed
21:03:08 mordred but
21:03:15 mordred yeah - go ahead and just remove its branch override for now
21:03:23 mordred let's clean that up later so we're not shifting too many things at once
21:03:42 openstackgerrit Sagi Shnaidman proposed openstack/openstacksdk stable/train: Remove master override for openstacksdk https://review.opendev.org/715065
21:03:44 sshnaidm ^^
21:03:49 mordred sshnaidm: I think we still might want to consider constructing some things (similar to the ansible collection tests) that do things like "test master of openstacksdk against stable/train cloud"
21:03:54 mordred but that's gonna take a little work
21:04:05 sshnaidm mordred, yeah, matrix
21:04:17 mordred sshnaidm: would you remove teh comment too?
21:05:25 openstackgerrit Sagi Shnaidman proposed openstack/openstacksdk stable/train: Remove master override for openstacksdk https://review.opendev.org/715065
21:06:11 openstackgerrit Sagi Shnaidman proposed openstack/openstacksdk stable/train: Remove master override for openstacksdk https://review.opendev.org/715065
21:06:12 sshnaidm now ^
21:06:48 mordred sshnaidm: honestly probably want the same thing on the other stable branches that you care about
21:07:11 sshnaidm it's weird they pass though..
21:08:07 sshnaidm mordred, well, in stein it's override-branch: stable/stein
21:08:15 sshnaidm seems redundant
21:08:43 sshnaidm maybe just remove it? https://github.com/openstack/openstacksdk/blob/stable/stein/.zuul.yaml#L37:L37
21:10:09 sshnaidm and override-branch: stable/rocky in rocky: https://github.com/openstack/openstacksdk/blob/stable/rocky/.zuul.yaml#L52
21:10:15 sshnaidm that's why it works..
21:11:35 mordred nod.
21:11:53 mordred so - this is something we've fixed before and forgotten about :)
21:23:39 sshnaidm but why need overrides..
21:29:35 mordred sshnaidm: probably don't
21:29:44 mordred sshnaidm: s/probably//
22:10:25 openstackgerrit Merged openstack/python-openstackclient master: Don't look up project by id if given id https://review.opendev.org/712810
22:46:56 openstackgerrit Merged openstack/openstacksdk master: Update Rackspace vendor profile for cinder v2 https://review.opendev.org/714630
23:55:56 openstackgerrit Merged openstack/openstacksdk stable/train: Remove master override for openstacksdk https://review.opendev.org/715065
#openstack-sdks - 2020-03-26
07:17:25 openstackgerrit Merged openstack/openstacksdk master: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715052
09:24:58 openstackgerrit Sagi Shnaidman proposed openstack/openstacksdk stable/train: Add ansible collection job to train branch https://review.opendev.org/714077
10:05:49 openstackgerrit Bence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route https://review.opendev.org/674325
10:40:45 openstackgerrit Sean McGinnis proposed openstack/openstacksdk master: Add cap for hacking https://review.opendev.org/715155
12:16:58 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Change default image type in the OTC vendor profile https://review.opendev.org/715183
12:27:52 mordred smcginnis: your hacking patch hit a set of errors that were apparently getting missed before - you wanna fix them or I can?
12:28:37 smcginnis mordred: I can. Confused on why adding a cap introduced failures though.
12:29:10 smcginnis mordred: Looks like something else going on there - fixtures._fixtures.timeout.TimeoutException
12:29:42 smcginnis But I can fix up the pep8 issues at least.
12:29:48 mordred smcginnis: yeah - that seems super unlikely to be caused by flake8 ... but oy
12:30:28 smcginnis "F821 undefined name 'Optional'" Wasn't that just added?

Earlier   Later