Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-03-23
09:01:26 openstackgerrit Daniel Bengtsson proposed openstack/osc-lib master: Stop configuring install_command in tox and stop use pip. https://review.opendev.org/694510
09:17:02 openstackgerrit Mark Chappell proposed openstack/openstacksdk master: Add support for Identity Providers https://review.opendev.org/714122
09:29:29 rpittau good morning everyone, just a doubt looking at the code, in the service_description module, shouldn't we set skip_discovery to True for the proxy object if we have both endpoint_override and version_string? Precisely inside this "if" https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/service_description.py#L174
10:38:10 dtantsur I'll look after the mandatory tea
10:59:00 dtantsur rpittau: why so? there is still information to discover, e.g. the precise location of a major version or available microversions
11:09:45 rpittau dtantsur: this is related to the migration of ironic-inspector to use openstacksdk for the ironic module, when running the functional test it fails with the current conf, I tracked down the issue to the discovery part between openstacksdk and keystone, when creating the proxy object
11:12:22 dtantsur rpittau: if you have problems with discovery, it usually means you've got a wrong URL
11:12:31 dtantsur and I do agree that the error message may be quite confusing
11:14:44 rpittau dtantsur: yeah, the current config has endpoint_override=http://url , I tried with different ones with no luck
11:15:00 dtantsur rpittau: unless you mock out keystoneauth, it will try accessing that
11:15:35 rpittau dtantsur: I also tried that, maybe I'm mocking it in the wrong place :/
11:16:02 dtantsur rpittau: just mock the hell out of get_client or how it's called now
11:16:11 dtantsur I don't think it's useful to go deeper
11:22:38 rpittau dtantsur: tried that too :/ again maybe I'm doing something wrong while mocking
11:23:04 dtantsur rpittau: do you have a patch with get_client mocked? if it's mocked properly, it cannot end up in keystoneauth
11:24:13 rpittau dtantsur: no, I didn't upload it as it was failing
11:24:44 ouroboros8 I have an open review ( https://review.opendev.org/#/c/713698/ ) for a change to the openstack cli, but one of the later Zuul build steps is failing (osc-promote-image). I've had a look at it but the logs don't really make much sense to me, and I'm not sure what the step is trying to achieve. Anyone able to give me some pointers?
11:26:50 dtantsur ouroboros8: your patch has merged. I'm not sure what that job does, but you may talk to #openstack-infra about it.
11:27:34 ouroboros8 thanks!
11:30:16 dtantsur rpittau: I suggest you upload it and we walk from there?
11:30:27 rpittau dtantsur: alright, will do
12:48:53 openstackgerrit Mark Chappell proposed openstack/openstacksdk master: Add support for Federation Protocols https://review.opendev.org/714431
13:02:20 openstackgerrit jayaditya gupta proposed openstack/python-openstackclient master: FIX for openstack quota set --force https://review.opendev.org/713881
13:09:18 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Change dockerhub password https://review.opendev.org/714436
13:42:49 openstackgerrit Mark Chappell proposed openstack/openstacksdk master: Add support for Federation Protocols https://review.opendev.org/714431
13:55:58 mordred dtantsur, rpittau: another option past normal mocking is to use requests-mock ... although that's probably not a _awesome_ choice in the short-term if this isn't in sdk itself. I started work on building a fixture in sdk that can be used in other places: https://review.opendev.org/#/c/675187/ - but am not yet done
13:56:41 mordred not that it helps today - but the idea there would be to be able to make a FakeOpenStackCloud object and tell it what you want it to do and it'll do all the underlying requests-mock magic that we do in the sdk unit tests
13:56:52 rpittau mordred: hey, thanks :) in the end it was actually a bug in ironic-inspector
13:56:54 mordred but in a form that other projects consuming sdk could actually use
13:56:56 mordred rpittau: cool!
14:02:37 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Add OpenStack Client for Manila docs https://review.opendev.org/706252
14:03:49 gtema_ dtantsur, mordred: I'm back, and so the https://review.opendev.org/#/c/700219 (project cleanup) is now rebased and waiting for your ok
14:06:09 dtantsur thx
14:07:43 mordred gtema: yay!
14:07:47 mordred gtema: welcome back!
14:07:53 gtema thks
14:08:10 mordred gtema: so ... don't hate me ... but I may have *completely* forgotten to tell you about a discussion we had at the shanghai summit
14:08:35 gtema okaaayy, and...???
14:10:08 mordred apparently https://opendev.org/x/ospurge has project cleanup logic and people were suggesting we suck that into sdk and start from there. at this point since you've got the underlying framework maybe instead of doing that we just port in whatever knowledge is in there?
14:10:44 gtema well, 99% of what ospurge could do (AFAIR) is now done
14:11:10 mordred yeah. I just feel bad I didn't mention "just copy in ospurge as a starting point" before you started work :)
14:11:19 gtema oh, no, it was another similar project
14:11:49 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: image: autogenerate docs https://review.opendev.org/693025
14:11:49 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: identity: autogenerate docs https://review.opendev.org/692931
14:11:52 gtema basically my change gives a framework for that and the individual services can be easily covered
14:12:32 gtema so with followups we can integrate more stuff from ospurge, but I would prefer to put it into the cleanup framework
14:13:06 mordred oh - totally. we should definitely put it in the cleanup framework
14:13:13 mordred gtema: left a quick question on that patch
14:13:20 gtema especially that it does not seem to support parallel execution
14:14:14 gtema so you mean I should drop this "single thread fallback"?
14:14:48 mordred I think so? cause I think it's covered with futurist - but maybe dtantsur has a different pov
14:15:26 gtema if he don't mind - will definitely do this
14:16:52 mordred gtema: also - don't know if you saw - but we merged the sdk and osc teams - so welcome to being core on osc now too
14:17:04 gtema cool.
14:17:28 gtema I have seen discussion and adding OSC to cores in SDK, but haven't seen SDKs in OSC
14:17:37 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: Fix network segment range "_get_ranges" function https://review.opendev.org/710031
14:17:51 gtema but am now glad to have possibility to put more efforts in OSC as well ;)
14:18:05 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Switch image to use SDK https://review.opendev.org/650374
14:18:11 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Complete switch from glanceclient to SDK for image service https://review.opendev.org/699416
14:18:16 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Don't look up project by id if given id https://review.opendev.org/712810
14:18:23 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Optimize adding project to image slightly more https://review.opendev.org/712813
14:18:44 gtema any thoughts already on how the virtual PTG will look like?
14:18:45 mordred gtema: we should merge that stack before the ussuri feature freeze :)
14:18:54 gtema oh sure
14:18:58 mordred I think people are working on it
14:19:11 mordred but I don't know what it will look like yet
14:19:18 gtema oki
14:19:46 mordred corvus deployed a POC of jitsi-meet integrated with etherpad that I believe we're going to deploy as a new service
14:20:00 mordred so it's like etherpad as the main screen, but also with video chat capabilities
14:20:24 gtema would be cool, but definitely TZ will play a nice role :D
14:20:30 mordred so hopefully that should help some with virtual ptg
14:20:31 mordred yeah
14:20:59 mordred maybe we should all just give ourselves jetlag in our local location for a week
14:21:08 gtema anyway glad it is not finally decided to do it this way - sitting here in prison and not knowing how the June will look like was a bit ...
14:21:13 mordred and "Fly" to vancouver virtually
14:21:40 gtema I was hoping so much to go to Vancouver (cry)
14:21:45 mordred yeah
14:21:54 mordred it's gonna be a rough next several months
14:22:18 gtema sure. Hopefully next Berlin will take place
14:22:28 mordred I certainly hope so
14:22:33 gtema we can then make SDK hiking tour over germany
14:23:48 mordred sounds like fun! :)
14:24:08 mordred (anything other than an SDK "sitting in a room for months" will be wonderful)
14:24:13 gtema we need to compensate vancouver
14:24:30 gtema "sitting in a virtual room" you mean
14:30:35 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Lay a foundation for the project cleanup https://review.opendev.org/700219
14:31:02 gtema I assumed dtantsur will not object on futurist and removed bypass
14:35:20 openstackgerrit Mark Chappell proposed openstack/openstacksdk master: Add support for Federation Protocols https://review.opendev.org/714431
14:36:21 openstackgerrit Mark Chappell proposed openstack/openstacksdk master: Add support for Identity Providers https://review.opendev.org/714122
14:37:48 mordred cmurphy: if you have some spare time - mind looking at ^^ ?
14:38:00 mordred gtema: cool
14:39:22 tremble gtema, Anywhere you'd like me to add a link to the relevant API docs?
14:39:50 gtema since we have all already found it - nope, it's ok
15:21:27 mgoddard hi, is this the place to ask for cliff reviews? https://review.opendev.org/708882
15:45:20 KeithMnemonic smcginnis: Hello Sean. I hope you are holding up ok. Could you please let me know exactly what is needed for here? https://review.opendev.org/#/c/702260/4 The "cherry picked" from does point to Train so I am not sure I understand exactly what is needed. Thank you.
15:48:38 smcginnis KeithMnemonic: Oh, I saw only the one line and assumed it was directly from master. Typically we keep each line, so by the time you get back to stein you would have a couple cherry-pick lines.
15:48:46 smcginnis This should be fine though.
15:49:14 KeithMnemonic ok thanks for checking again
15:49:33 smcginnis np, thanks for pointing that out.
15:53:39 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Introduce 'quota unset' command https://review.opendev.org/376311

Earlier   Later