| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-03-10 | |||
| 14:10:40 | Shrews | mordred: +A | |
| 14:10:42 | Shrews | gah | |
| 14:21:47 | mordred | Shrews: right? | |
| 14:21:51 | mordred | yay for breaking API changes | |
| 14:35:44 | openstackgerrit | Merged openstack/python-openstackclient master: Disallow setting default on internal network https://review.opendev.org/539303 | |
| 14:36:31 | dtantsur | mordred: I've heard about this microversion thing, pity that nova doesn't use it | |
| 14:36:57 | mordred | dtantsur: heh | |
| 14:50:30 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | |
| 14:50:34 | mordred | dtantsur, Shrews, smcginnis: sorry to bother you again - unit test issue. ^^ | |
| 14:50:48 | mordred | also added a unit test while in there ... and fixed the logic error :) | |
| 14:51:18 | dtantsur | mordred: isinstance(name_or_id, six.string_types + six.binary_types) ? :) | |
| 14:51:23 | dtantsur | okay, okay, not nitpicking | |
| 14:52:19 | dtantsur | mordred: worse issue: what is is_digit? I cannot see it in my python | |
| 14:52:19 | mordred | dtantsur: oh - does that work? | |
| 14:52:30 | dtantsur | mordred: both are tuples, you can concatenate them | |
| 14:52:45 | mordred | cool. | |
| 14:52:51 | mordred | dtantsur: isdigit - no _ | |
| 14:52:56 | dtantsur | ah, gotcha | |
| 14:53:54 | mordred | I wish six just had a "six.seriously_all_the_stringlike_types" | |
| 14:53:57 | dtantsur | mordred: oops, there is only binary_type, not binary_types | |
| 14:54:05 | smcginnis | Hah | |
| 14:54:05 | mordred | blerg. fix coming | |
| 14:54:41 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | |
| 14:55:17 | mordred | I always write patches perfectly the first time | |
| 14:55:20 | dtantsur | mordred: nope, six.string_types + (six.binary_type,) | |
| 14:55:26 | dtantsur | or just ignore me and have two conditions | |
| 14:55:39 | mordred | hahaha | |
| 14:56:03 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | |
| 14:56:15 | mordred | dtantsur: I think the concat actually expresses the idea | |
| 14:58:14 | mordred | Shrews: got a sec for a re+A? | |
| 14:58:33 | Shrews | mordred: looking | |
| 15:00:15 | Shrews | mordred: now that i think about it, should we modify the log line below that to reference the original value if we changed it? or maybe both values? | |
| 15:00:41 | Shrews | otherwise a user might be "that's not the value i asked you to delete" | |
| 15:01:02 | Shrews | oh, we shouldn't actually hit that | |
| 15:01:03 | Shrews | nm | |
| 15:01:31 | Shrews | is this monday? i could swear this is monday | |
| 15:02:06 | mordred | feels like it | |
| 15:02:07 | mordred | did yesterday happen? | |
| 15:02:19 | Shrews | Tuesday is just Second Monday in hobbit world | |
| 15:02:52 | dtantsur | ++ | |
| 16:39:36 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Consistent normalization of Machine objects in the cloud layer https://review.opendev.org/711952 | |
| 16:39:58 | mordred | dtantsur: ^^ rebased that on top of the functional test fix and re-+A'd | |
| 16:40:11 | dtantsur | thx! | |
| 16:40:30 | mordred | I'll cut another release when they land | |
| 16:41:59 | dtantsur | cool. I'll also propose a train backport | |
| 16:43:02 | mordred | ++ | |
| 16:50:35 | openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Import generate_temp_url from swiftclient https://review.opendev.org/711640 | |
| 16:50:47 | rpittau | ^^ rebase on top of the fix | |
| 17:05:30 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Support for stateless security groups https://review.opendev.org/711513 | |
| 17:46:21 | openstackgerrit | Merged openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | |
| 18:19:39 | mordred | woot | |
| 19:27:03 | openstackgerrit | Merged openstack/openstacksdk master: Consistent normalization of Machine objects in the cloud layer https://review.opendev.org/711952 | |
| 19:53:47 | openstackgerrit | Merged openstack/openstacksdk master: Support for stateless security groups https://review.opendev.org/711513 | |
| #openstack-sdks - 2020-03-11 | |||
| 07:17:32 | openstackgerrit | Bram Verschueren proposed openstack/openstacksdk master: Add support for additional volume backup options https://review.opendev.org/688353 | |
| 09:28:30 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk stable/train: Consistent normalization of Machine objects in the cloud layer https://review.opendev.org/712295 | |
| 10:32:51 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Fix microversion negotiation in some bare metal node call https://review.opendev.org/712336 | |
| 10:32:59 | dtantsur | sshnaidm: this ^^^ is probably your issue | |
| 10:33:03 | dtantsur | testing appreciated | |
| 10:39:49 | dtantsur | (this approves that microversion negotiation is hard.. even I do it wrong all the time) | |
| 10:39:52 | dtantsur | * proves | |
| 11:05:07 | dtantsur | mordred: I have a feeling we're somehow running master tests on train Oo see the ironic job https://review.opendev.org/#/c/712295/1 | |
| 11:05:46 | dtantsur | rpittau: do you have a follow-up for the 'retired' functional tests? | |
| 11:06:00 | dtantsur | we somehow end up failing them on train (because the feature is not there) | |
| 11:06:24 | rpittau | dtantsur: yes https://review.opendev.org/711958 | |
| 11:06:48 | rpittau | mmm | |
| 11:06:57 | dtantsur | cool, +A | |
| 11:08:00 | dtantsur | rpittau: oh, sorry, there is an issue there, could you check? | |
| 11:08:05 | rpittau | sure | |
| 11:08:21 | dtantsur | you end up duplicating all tests because of inheritance | |
| 11:10:06 | openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Set min version to test node retirement https://review.opendev.org/711958 | |
| 11:10:26 | openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Set min version to test node retirement https://review.opendev.org/711958 | |
| 11:50:26 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Fix microversion negotiation in some bare metal node call https://review.opendev.org/712336 | |
| 13:49:43 | openstackgerrit | Merged openstack/openstacksdk master: Set min version to test node retirement https://review.opendev.org/711958 | |
| 13:51:05 | dtantsur | mordred: when you have a minute: https://review.opendev.org/#/c/712336/ | |
| 14:15:36 | mordred | dtantsur: oy. | |
| 14:24:28 | mordred | dtantsur: microversion negotiation is hard | |
| 14:24:35 | dtantsur | it is indeed.. | |
| 14:25:20 | smcginnis | It would be great if OSC supported microversions. :P | |
| 14:33:28 | dtantsur | first, we need to agree on the default behavior.. | |
| 15:19:23 | mordred | smcginnis: it does support microversion | |
| 15:19:26 | mordred | microversions | |
| 15:24:02 | mordred | dtantsur: I agree we need to agree on the default behavior. I'd like to argue that osc's default behavior should match SDK's- which is that it should negotiate for the most recent microversion it can handle for a given command | |
| 15:24:58 | mordred | this is a little self-serving of course - since the long-term plan is to port osc on top of sdk - one would imagine that at that point osc's microversion behavior would be delegated to sdk anyway - so it would be good if porting to sdk didn't produce a behavior change | |
| 15:25:40 | smcginnis | mordred: I should have put <sarcasm/> tags on there. ;) | |
| 15:26:18 | mordred | smcginnis: :) | |
| 15:27:10 | mordred | that said - the current OSC behavior if you try something like compute_api_version: 2.latest is ridiculous | |
| 15:27:34 | mordred | but that's going to be because it just defers to novaclient and novaclient's behavior in that case is ridiculous | |
| 15:28:04 | smcginnis | I pushed back on that approach in cinder. | |
| 15:30:17 | mordred | well - the bad behavior here is that 2.latest is just an alias for "2.$whatever_the_highest_Version_hardcoded_into_novaclient_is" ... and is _not_ "2.please_negotiate_for_the_latest_available_version" | |
| 15:30:50 | mordred | so if you set 2.latest and then run opensatck server list against vexxhost, you get: clean_up ListServer: Version 2.81 is not supported by the API. Minimum is 2.1 and maximum is 2.60. (HTTP 406) (Request-ID: req-d368c068-4e37-448c-8e25-74e4aa0385a9) | |
| 15:30:58 | mordred | rather than just getting interactions at 2.60 | |
| 15:48:08 | mordred | dtantsur: ooh. I think I just had an epiphany of how to support 2.latest in sdk safely | |
| 15:48:25 | mordred | WIP patch coming | |
| 15:52:38 | dtantsur | nice! | |
| 15:52:59 | dtantsur | I think in ironic OSC plugin we treat 1 like 1.latest and support it in the correct sense.. | |
| 15:53:16 | smcginnis | Yeah, couldn't OSC do the negotiation to figure out the highest? | |
| 15:57:11 | openstackgerrit | Merged openstack/openstacksdk master: Fix microversion negotiation in some bare metal node call https://review.opendev.org/712336 | |
| 16:02:27 | mordred | smcginnis: sort of - the problem is that if you just do straight latest then a new microversion can come and break you | |
| 16:02:37 | mordred | because there is additional processing of resources returned | |
| 16:03:27 | mordred | smcginnis: which is why what you _really_ want is "negotiate for the latest the client understands" (which is the power of microversions in the first place) | |