| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-03-09 | |||
| 17:37:14 | openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Import generate_temp_url from swiftclient https://review.opendev.org/711640 | |
| 17:42:13 | openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Set min version to test node retirement https://review.opendev.org/711958 | |
| #openstack-sdks - 2020-03-10 | |||
| 01:30:48 | openstackgerrit | Merged openstack/openstacksdk stable/train: Include "fields" to "SecurityGroup" query parameters https://review.opendev.org/711622 | |
| 01:46:09 | openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Change 'Volume' to 'Block Storage' https://review.opendev.org/532439 | |
| 02:03:23 | openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Disallow setting default on internal network https://review.opendev.org/539303 | |
| 02:16:49 | openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Update http links in docs https://review.opendev.org/567729 | |
| 02:34:07 | openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Compute: Add tag support for server add port https://review.opendev.org/580977 | |
| 09:59:20 | frickler | slaweq: could you take a look at https://review.opendev.org/539303 please? I'm not sure this really makes sense in all situations | |
| 10:00:03 | slaweq | frickler: sure, looking | |
| 10:03:51 | slaweq | frickler: IMO it makes sense | |
| 10:04:05 | slaweq | frickler: according to the https://docs.openstack.org/neutron/latest/admin/config-auto-allocation.html at least | |
| 11:02:44 | dtantsur | morning folks, looking for a 2nd +2 on https://review.opendev.org/#/c/711952/ it fixes os_ironic with newer SDK | |
| 11:29:48 | frickler | slaweq: hmm, o.k., thx for checking | |
| 11:56:33 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add option for modules_default groups https://review.opendev.org/712057 | |
| 11:59:30 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add option for modules_default groups https://review.opendev.org/712057 | |
| 12:12:09 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add option for modules_default groups https://review.opendev.org/712057 | |
| 13:04:08 | smcginnis | Anyone aware of a change in the SDK that would cause this: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f9e/711930/2/check/openstacksdk-functional-devstack/f9e911a/testr_results.html | |
| 13:04:23 | smcginnis | Failing on a requirements update patch that doesn't seem to be related. | |
| 13:06:10 | mordred | smcginnis: hrm - yes, possibly - but why would it not have failed on that patch that did it | |
| 13:06:12 | mordred | looking | |
| 13:06:55 | smcginnis | I always ask myself that with these kinds of things. :) | |
| 13:07:11 | mordred | smcginnis: I take it back - I don't see any reason for that | |
| 13:07:23 | rpittau | I'm also seeing some weird errors in testing https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_97c/711640/3/check/openstack-tox-py37/97cfb62/testr_results.html | |
| 13:08:43 | dtantsur | Oo | |
| 13:09:54 | mordred | smcginnis: we might want to check to see if nova recently landed any changes disallowing deleting aggregates by name | |
| 13:13:22 | mordred | rpittau: https://zuul.opendev.org/t/openstack/build/97cfb620a44b4c91b886e02318306ea2/log/job-output.txt#4355 - and https://zuul.opendev.org/t/openstack/build/97cfb620a44b4c91b886e02318306ea2/log/job-output.txt#4166 | |
| 13:13:35 | mordred | rpittau: I thnik something maybe timed out? | |
| 13:13:40 | mordred | and it hit a hard-kill | |
| 13:13:52 | mordred | doesn't look like it was that test - looks like it was another one? | |
| 13:14:07 | rpittau | mordred: yeah, the odd part is that it's happening in other jobs too | |
| 13:14:17 | rpittau | I triggered another recheck | |
| 13:14:44 | mordred | *excellent* | |
| 13:18:57 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | |
| 13:19:39 | mordred | smcginnis, dtantsur: ^^ if you don't mind - nova just landed a change that has broken our functional tests | |
| 13:19:59 | mordred | I'd complain at nova - but it's actually just causing a broken test to be shown to be broken | |
| 13:21:15 | mordred | hrm | |
| 13:21:26 | mordred | actually - no - I think I'm going to go complain | |
| 13:23:41 | rpittau | :D | |
| 13:28:11 | smcginnis | :) | |
| 13:29:44 | mordred | ok. I complained - and I'm back to thinking it's a bug on our side | |
| 13:30:16 | mordred | our delete method has a name_or_id argument, but it just passes it on directly without attempting to get an id | |
| 13:30:18 | smcginnis | Followed there... that makes sense. | |
| 13:30:21 | mordred | the REST call _only_ accepts ids | |
| 13:31:16 | mordred | it also seems they've defined the API to assert that those ids will always be ints - so we have an easy check we can do to see if a name was passed | |
| 13:36:38 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | |
| 13:36:52 | mordred | smcginnis, Shrews, dtantsur: ^^ that should fix the test and the behavior | |
| 13:38:04 | smcginnis | Nice, thanks for the quick fix mordred | |
| 13:39:04 | mordred | let me make one more quick update - I think it would also be fine for someone to pass an aggregate object in | |
| 13:41:31 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | |
| 13:41:35 | mordred | smcginnis: how's that look? | |
| 13:42:28 | smcginnis | Yeah, good call! | |
| 13:42:58 | mordred | we don't advertise being able to pass an object there - but it woudl actually work to :) | |
| 13:43:34 | smcginnis | Yeah, I like that being able to handle it. Could be nice for some situations. | |
| 14:07:50 | dtantsur | mordred: oh sweet :( +2 | |
| 14:10:33 | Shrews | mordred: + | |
| 14:10:40 | Shrews | mordred: +A | |
| 14:10:42 | Shrews | gah | |
| 14:21:47 | mordred | Shrews: right? | |
| 14:21:51 | mordred | yay for breaking API changes | |
| 14:35:44 | openstackgerrit | Merged openstack/python-openstackclient master: Disallow setting default on internal network https://review.opendev.org/539303 | |
| 14:36:31 | dtantsur | mordred: I've heard about this microversion thing, pity that nova doesn't use it | |
| 14:36:57 | mordred | dtantsur: heh | |
| 14:50:30 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | |
| 14:50:34 | mordred | dtantsur, Shrews, smcginnis: sorry to bother you again - unit test issue. ^^ | |
| 14:50:48 | mordred | also added a unit test while in there ... and fixed the logic error :) | |
| 14:51:18 | dtantsur | mordred: isinstance(name_or_id, six.string_types + six.binary_types) ? :) | |
| 14:51:23 | dtantsur | okay, okay, not nitpicking | |
| 14:52:19 | dtantsur | mordred: worse issue: what is is_digit? I cannot see it in my python | |
| 14:52:19 | mordred | dtantsur: oh - does that work? | |
| 14:52:30 | dtantsur | mordred: both are tuples, you can concatenate them | |
| 14:52:45 | mordred | cool. | |
| 14:52:51 | mordred | dtantsur: isdigit - no _ | |
| 14:52:56 | dtantsur | ah, gotcha | |
| 14:53:54 | mordred | I wish six just had a "six.seriously_all_the_stringlike_types" | |
| 14:53:57 | dtantsur | mordred: oops, there is only binary_type, not binary_types | |
| 14:54:05 | smcginnis | Hah | |
| 14:54:05 | mordred | blerg. fix coming | |
| 14:54:41 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | |
| 14:55:17 | mordred | I always write patches perfectly the first time | |
| 14:55:20 | dtantsur | mordred: nope, six.string_types + (six.binary_type,) | |
| 14:55:26 | dtantsur | or just ignore me and have two conditions | |
| 14:55:39 | mordred | hahaha | |
| 14:56:03 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | |
| 14:56:15 | mordred | dtantsur: I think the concat actually expresses the idea | |
| 14:58:14 | mordred | Shrews: got a sec for a re+A? | |
| 14:58:33 | Shrews | mordred: looking | |
| 15:00:15 | Shrews | mordred: now that i think about it, should we modify the log line below that to reference the original value if we changed it? or maybe both values? | |
| 15:00:41 | Shrews | otherwise a user might be "that's not the value i asked you to delete" | |
| 15:01:02 | Shrews | oh, we shouldn't actually hit that | |
| 15:01:03 | Shrews | nm | |
| 15:01:31 | Shrews | is this monday? i could swear this is monday | |
| 15:02:06 | mordred | feels like it | |
| 15:02:07 | mordred | did yesterday happen? | |
| 15:02:19 | Shrews | Tuesday is just Second Monday in hobbit world | |
| 15:02:52 | dtantsur | ++ | |
| 16:39:36 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Consistent normalization of Machine objects in the cloud layer https://review.opendev.org/711952 | |
| 16:39:58 | mordred | dtantsur: ^^ rebased that on top of the functional test fix and re-+A'd | |
| 16:40:11 | dtantsur | thx! | |
| 16:40:30 | mordred | I'll cut another release when they land | |
| 16:41:59 | dtantsur | cool. I'll also propose a train backport | |