Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-01-30
12:51:51 sshnaidm https://github.com/ansible/ansible/commit/6c74e29618a6872bc0da66e4992cfcd9cebf6acc
12:52:08 sshnaidm it was something new ^
12:52:22 odyssey4me yeah, and with that the sdk minimum version should have been updated
12:52:42 odyssey4me odd, though is that we're getting this error from ansible2.8
12:52:52 odyssey4me lemme see if I can find abackport
12:53:38 odyssey4me no, this has not been ported back
12:54:06 odyssey4me ok - so that means that whatever we're getting that back from is actually running ansible 2.9 - not 2.8
12:54:23 odyssey4me I'll push a patch up to ansible to update the minimum SDK version... thanks for the help!
12:54:35 sshnaidm all version: devel (#56453) v2.9.4 v2.9.3 v2.9.2 v2.9.1 v2.9.0 v2.9.0rc5 v2.9.0rc4 v2.9.0rc3 v2.9.0rc2 v2.9.0rc1 v2.9.0b1 stable-2.9-branchpoint
12:55:23 sshnaidm it's good point to think how can we avoid such failures, maybe all new sdk features should come with version check
12:55:37 sshnaidm when they're used in ansible module
13:29:03 odyssey4me sshnaidm: ok, fixes to upstream modules are frozen, right? so I should submit this fix to the collection and directly to stable-2.9?
13:32:46 sshnaidm odyssey4me, well, it could be a problem.. I think we set ci job for modules to fail, so not sure we can merge even to 2.9..
13:33:17 sshnaidm odyssey4me, maybe we need to enabled it for 2.9
13:33:53 sshnaidm odyssey4me, what could be a fix? The revert?
13:36:50 odyssey4me sshnaidm: let me push up patches to ansible and into tyhe collection, then we figure out how to get the fix merged in all the places :)
13:37:06 sshnaidm odyssey4me, ack, thanks
13:47:27 odyssey4me sshnaidm: https://github.com/ansible/ansible/pull/66944 pushed upstream, let me know if you find any other places where the openstacksdk is set
13:47:57 odyssey4me I'm hoping that all the docs key off that, but I couldn't find a doc ref.
13:50:29 sshnaidm odyssey4me, that will fail module if using lower openstacksdk version, right?
13:51:23 odyssey4me sshnaidm: yep
13:52:14 odyssey4me sshnaidm: I suppose an alternative approach would be, in the os_network module, to warn that a newer openstacksdk is required if the current version does not meet the minimum to support that parameter
13:52:27 sshnaidm odyssey4me, I wonder if we can check sdk version and use or not to use dns_* parameter
13:52:28 odyssey4me that's probably nicer than an outright fail
13:54:15 sshnaidm I mean to fail only if this parameter set explicitly
13:54:44 odyssey4me yeah, that'd be a much nicer approach
13:55:23 odyssey4me ok, let me see if I can work that out
13:58:26 odyssey4me hmm, another option is to only fail it for os_network
14:04:12 odyssey4me sshnaidm: do you know where the openstack documentation fragment comes from - I see references to it, but can't find 'it'
14:05:35 odyssey4me sshnaidm: never mind: https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#documentation-fragments
15:02:27 openstackgerrit Pedro Henrique Pereira Martins proposed openstack/openstacksdk master: Add description field to portforwarding NAT rules https://review.opendev.org/705038
16:00:44 sshnaidm who is available for openstack ansible modules meeting?
16:00:58 elmiko API SIG office hour now open
16:01:00 sshnaidm I know I had to create a doodle about a new time, my bad
16:01:05 sshnaidm will do this today..
16:01:53 openstack Meeting started Thu Jan 30 16:01:53 2020 UTC and is due to finish in 60 minutes. The chair is sshnaidm. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:01:53 sshnaidm #startmeeting api-sig
16:01:54 openstack Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:01:56 openstack The meeting name has been set to 'api_sig'
16:02:28 sshnaidm anybody here to talk
16:02:34 sshnaidm to complain
16:04:09 elmiko lol
16:04:13 sshnaidm to tell success stories
16:05:36 sshnaidm mordred, can we be in touch next week for collection pushing?
16:05:53 sshnaidm we need your superpower for submitting a collection to galaxy
16:07:32 sshnaidm ok, seems like the business is as usual
16:08:01 sshnaidm please do reviews in your time: https://review.opendev.org/#/q/project:openstack/ansible-collections-openstack
16:08:18 sshnaidm #endmeeting
16:08:20 openstack Meeting ended Thu Jan 30 16:08:18 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
16:08:21 openstack Minutes: http://eavesdrop.openstack.org/meetings/api_sig/2020/api_sig.2020-01-30-16.01.html
16:08:22 openstack Minutes (text): http://eavesdrop.openstack.org/meetings/api_sig/2020/api_sig.2020-01-30-16.01.txt
16:08:23 openstack Log: http://eavesdrop.openstack.org/meetings/api_sig/2020/api_sig.2020-01-30-16.01.log.html
16:12:50 odyssey4me heh, wow - that went quickly :p
16:13:25 odyssey4me sshnaidm: we don't have documentation fragments in the collection, do we? how do I submit something for the change log
16:13:44 sshnaidm odyssey4me, we should have
16:14:23 sshnaidm this one? ./plugins/doc_fragments/openstack.py
16:15:56 odyssey4me sshnaidm: right, but I need at add a changelog fragment for the bug fix - should I just make a directory called changelogs/fragments ?
16:16:47 sshnaidm odyssey4me, I think it contains all changelogs, not only for openstack?
16:17:15 sshnaidm odyssey4me, well, we don't have policy to make changelogs right now, so not must I think
16:18:02 openstackgerrit Jesse Pretorius (odyssey4me) proposed openstack/ansible-collections-openstack master: Bump minimum openstacksdk version when using os_network/dns_domain https://review.opendev.org/705054
16:18:18 odyssey4me sshnaidm: well, there we go - let's figure it out in review :)
16:22:12 sshnaidm odyssey4me, cool, thanks
16:22:24 sshnaidm odyssey4me, I wonder if we can use it asap..
16:22:54 odyssey4me sshnaidm: I did a brief test locally and it worked for me (adding the dns_domain arg made it fail with the older sdk)
16:23:13 sshnaidm odyssey4me, great
16:31:18 openstackgerrit Jesse Pretorius (odyssey4me) proposed openstack/ansible-collections-openstack master: Bump minimum openstacksdk version when using os_network/dns_domain https://review.opendev.org/705054
16:38:43 odyssey4me sshnaidm: nice to see tests/unit/modules/cloud/openstack/test_os_server.py there - I was thinking that we should do unit testing... so assuming that works, it'd be nice to expand on those
16:40:50 sshnaidm odyssey4me, actually I don't think we execute them currently :) but it's good to have it, yes
16:41:00 openstackgerrit Jesse Pretorius (odyssey4me) proposed openstack/ansible-collections-openstack master: Bump minimum openstacksdk version when using os_network/dns_domain https://review.opendev.org/705054
17:38:19 openstackgerrit Michał Dulko proposed openstack/openstacksdk master: Fix error handling in network trunks operations https://review.opendev.org/705073
17:40:08 openstackgerrit Jesse Pretorius (odyssey4me) proposed openstack/ansible-collections-openstack master: Bump minimum openstacksdk version when using os_network/dns_domain https://review.opendev.org/705054
#openstack-sdks - 2020-01-31
08:28:54 openstackgerrit Shogo Saito proposed openstack/openstacksdk master: Adding basic implementation for Accelerator(Cyborg) https://review.opendev.org/679914
#openstack-sdks - 2020-02-01
11:36:22 openstackgerrit Merged openstack/openstacksdk master: Add allowed_cidrs param to load balancer listener https://review.opendev.org/703040
#openstack-sdks - 2020-02-02
08:14:48 openstackgerrit Vladimir Ermakov proposed openstack/ansible-collections-openstack master: os_image: Add tags parameter https://review.opendev.org/705343
10:13:14 openstackgerrit Vladimir Ermakov proposed openstack/ansible-collections-openstack master: os_image: Add tests for tags parameter https://review.opendev.org/705354
11:15:50 openstackgerrit Andreas Jaeger proposed openstack/python-openstackclient master: Stop testing python2 https://review.opendev.org/686590
#openstack-sdks - 2020-02-03
07:11:22 openstackgerrit Shogo Saito proposed openstack/openstacksdk master: Adding basic implementation for Accelerator(Cyborg) https://review.opendev.org/679914
11:52:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Adding basic implementation for Accelerator(Cyborg) https://review.opendev.org/679914
12:29:12 mordred dtroyer: if you get a sec, https://review.opendev.org/#/c/686590/ finishes off the python 2 ectomy
15:26:57 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Stop silently ignoring invalid 'server create --hint' options https://review.opendev.org/685329
15:27:00 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Use 'KeyValueAppendAction' from osc-lib https://review.opendev.org/685330
15:27:21 stephenfin mordred: Could you ack the first of those?
15:27:35 stephenfin It had a +2 from dtroyer but I don't know why it's been dropped
15:28:13 stephenfin wait, no, I still have it :)
15:29:45 mordred stephenfin: both lgtm
15:29:54 stephenfin mordred++ thanks :)
15:41:27 openstackgerrit Andreas Jaeger proposed openstack/microversion-parse master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/705460
15:42:28 openstackgerrit Andreas Jaeger proposed openstack/microversion-parse master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/705460
16:12:32 openstackgerrit Andreas Jaeger proposed openstack/microversion-parse master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/705460
16:34:01 openstackgerrit Merged openstack/microversion-parse master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/705460
16:34:12 openstackgerrit Andreas Jaeger proposed openstack/os-api-ref master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/705476
18:41:15 openstackgerrit Merged openstack/python-openstackclient master: Stop silently ignoring invalid 'server create --hint' options https://review.opendev.org/685329
#openstack-sdks - 2020-02-04
07:44:41 openstackgerrit Andreas Jaeger proposed openstack/cliff master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/705612
07:46:02 openstackgerrit Andreas Jaeger proposed openstack/cliff master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/705612
09:59:57 openstackgerrit Merged openstack/os-api-ref master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/705476
10:32:00 openstackgerrit Andreas Jaeger proposed openstack/cliff master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/705612
10:55:25 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient stable/train: Stop silently ignoring invalid 'server create --hint' options https://review.opendev.org/705630
12:27:54 openstackgerrit Andreas Jaeger proposed openstack/cliff master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/705612
12:45:08 openstackgerrit Merged openstack/ansible-collections-openstack master: Bump minimum openstacksdk version when using os_network/dns_domain https://review.opendev.org/705054
14:05:39 openstackgerrit Andreas Jaeger proposed openstack/cliff master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/705612

Earlier   Later