| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-01-10 | |||
| 15:40:06 | vkmc | hey all o/ | |
| 15:40:13 | vkmc | we are working on implementing the plugin for osc for manila | |
| 15:40:29 | vkmc | wondering if there are guidelines for creating documentation for it | |
| 15:40:49 | vkmc | I've seen that the osc client has their own docs, which each of the commands that it's implemented | |
| 15:45:01 | mordred | vkmc: if it's a new plugin, it would be *awesome* if we could base it on openstacksdk and get the manila support in sdk solid - for docs, that's a good question ... dtroyer? | |
| 15:45:48 | vkmc | mordred, yes, brand new plugin | |
| 15:49:04 | vkmc | maaritamm, o/ | |
| 15:50:02 | vkmc | mordred, dtroyer, so maaritamm (outreachy intern) is the main lead on the manila plugin development | |
| 15:50:34 | vkmc | we want to make sure we comply to any existing process that the community might have wrt to creating user docs for the client | |
| 15:50:48 | mordred | yay outreachy intern! hi maaritamm | |
| 15:51:15 | maaritamm | o/ | |
| 15:51:51 | maaritamm | hi to all :) | |
| 15:52:28 | mordred | I'm honestly not sure what the osc plugin docs story is ... maybe dtroyer or dtantsur|brb knows? | |
| 15:52:38 | mordred | or amotoki if he's around | |
| 15:53:49 | dtroyer | I think the docs story has changed a bit recently, efried was doing a lot of work on autodoc at the end of last year, and I think that has affected the story for plugins, but I don't have that in my head at the moment | |
| 15:54:41 | vkmc | when is is the weekly meeting for this team? maybe we can use some minutes to talk about this | |
| 15:54:43 | vkmc | if that works for you | |
| 15:55:26 | amotoki | I haven't caught up the recent change on autodoc in osc, but as long as neutronclient osc plugin I think the autogen of OSC plugin CLI still works | |
| 15:56:00 | dtroyer | vkmc: We haven't had weekly meetings in quite some time | |
| 15:56:10 | vkmc | oh ok | |
| 15:56:12 | dtroyer | Pretty much everything happens here as needed | |
| 15:56:18 | vkmc | ok :) | |
| 15:57:31 | efried | vkmc: Plugin docs should live in the plugin. The python-openstackclient should be updated to pull them in via an autoprogram-cliff directive. Let me grab some links... | |
| 15:57:45 | vkmc | efried++ | |
| 15:57:57 | amotoki | vkmc: you can find an example OSC plugin document at https://opendev.org/openstack/python-neutronclient/src/branch/master/doc/source/cli/osc/v2 | |
| 15:58:17 | amotoki | vkmc: all OSC plguin CLI document is generated automatically | |
| 15:58:47 | vkmc | perfect... yes, I assumed there was something to automatize the generation of docs but I wasn't sure | |
| 15:58:56 | vkmc | amotoki, thanks for the sample | |
| 16:00:42 | amotoki | vkmc: I am going to bed soon. if you have questions, feel free to drop them in this channel. | |
| 16:00:53 | vkmc | amotoki, will do, thanks again! | |
| 16:03:14 | mordred | dtroyer: if you have a sec, there's a naming question in https://review.opendev.org/#/c/677857/ that we discussed, but it hasn't landed yet, so would love your ack on where we wound up | |
| 16:09:31 | dtantsur | vkmc: you can check what ironicclient is doing. currently we're hosting its docs as part of docs.o.o/python-ironicclient | |
| 16:09:54 | dtantsur | like https://docs.openstack.org/python-ironicclient/latest/cli/osc_plugin_cli.html | |
| 16:13:42 | vkmc | dtantsur, perfect, I'll take a look at those too | |
| 16:13:44 | vkmc | thanks! | |
| 16:14:39 | efried | - Include your plugin in doc/requirements.txt, like: https://opendev.org/openstack/python-openstackclient/src/branch/master/doc/requirements.txt#L27 | |
| 16:14:39 | efried | Then in python-openstackclient you need to: | |
| 16:14:39 | efried | I think that's just standard fare for plugin-ness. But the important point is that the docs will be generated from the argparse helps defined in the classes' get_parser overrides. | |
| 16:14:39 | efried | ==> The right-hand side is the package:class that handles that. | |
| 16:14:39 | efried | ==> The left-hand side is the subcommand syntax, s/ /_/ | |
| 16:14:39 | efried | - Your plugin's setup.cfg needs to define entry_points for each subcommand in this spirit: https://opendev.org/openstack/python-octaviaclient/src/branch/master/setup.cfg#L24 | |
| 16:14:39 | efried | vkmc: Okay, using octavia as an example: | |
| 16:14:40 | efried | - Don't forget to add your new page ^ to the index https://opendev.org/openstack/python-openstackclient/raw/branch/master/doc/source/cli/plugin-commands/index.rst | |
| 16:14:40 | efried | - Set up a page with a title and any desired preamble text (preferably keep that minimal) with an autoprogram-cliff directive that references your entry point, like: https://opendev.org/openstack/python-openstackclient/raw/branch/master/doc/source/cli/plugin-commands/octavia.rst | |
| 16:14:41 | efried | I *think* that's it. | |
| 16:14:42 | efried | What would be really neat is if you could scribble this process into a doc of its own and publish it in python-openstackclient for future contributors... | |
| 16:16:01 | mordred | ++ | |
| 16:16:06 | vkmc | efried, yep, we definitely need to add this | |
| 16:16:09 | vkmc | I can do that | |
| 16:16:27 | efried | thanks! | |
| 16:16:38 | vkmc | thanks! | |
| 16:17:48 | johnsom | vkmc You can also ping me if you have questions. I authored the docs setup for octaviaclient and ironicclient. | |
| 16:18:06 | johnsom | Well, at least the auto generate bits | |
| 16:20:46 | vkmc | johnsom, oh nice, that would be helpful... in case we get stuck with anything there | |
| 16:22:39 | efried | phew, thanks johnsom -- cause all I did was framework stuff, no real clue how the docs themselves work :P | |
| 17:43:15 | openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Raise hacking to more recent 2.0.0 https://review.opendev.org/702019 | |
| 17:58:04 | openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Stop testing python2 https://review.opendev.org/686590 | |
| 18:01:09 | smcginnis | mordred: Restored and updated your patch, but let me know if there were other conversations around that that I am not aware of. ^^ | |
| 18:06:53 | smcginnis | dtroyer: Note that dropping py2 support requires a major version bump, so not sure if there are any other major-version-bumping-worthy changes in the works that we might want to get in along with that cycle goal change before doing an official release. ^ | |
| 18:08:51 | dtroyer | smcginnis: I don't have any waiting since we just did 4.0, there may be some that I have not seen yet. But that likely needs some work on the openstackclient repo to match, I think I saw some stuff going on about that earlier this week (sorry I wasn't able to actually follow along with that) | |
| 18:09:45 | smcginnis | I'm not aware either. Really just a heads up in case we had anything we were waiting on for an opportune time. ;) | |
| 18:10:53 | dtroyer | sure, thanks. I have a vague memory that mriedem did run across one or two small things, not sure where to find that now | |
| 18:11:40 | smcginnis | We can see how many major versions we can get over the next cycle or two. | |
| 18:13:41 | smcginnis | Oh, I totally missed https://review.opendev.org/#/c/695427/. Oh well, still a couple little things needed per the cycle goal instructions. | |
| 18:14:26 | openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Stop testing python2 https://review.opendev.org/686590 | |
| 18:17:01 | openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Stop testing python2 https://review.opendev.org/686590 | |
| 20:23:22 | openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Raise flake8-import-order version to latest https://review.opendev.org/702036 | |
| 21:36:26 | KeithMnemonic | smcginnis: Thank you very much for helping get the stable openstackclient branches working. it is very appreciated | |
| 21:37:18 | smcginnis | KeithMnemonic: No problem, thanks for getting a lot of that in place to start with. | |
| 21:37:40 | smcginnis | Hopefully we can get those stable branches cleaned up and jobs working again. | |
| 21:38:01 | smcginnis | Only a few outstanding patches, but most look like good fixes to get merged if we can. | |
| 21:39:20 | KeithMnemonic | i agree , it will be a much less stressful when just having to debug the code in the fix itself and not other external issues | |
| #openstack-sdks - 2020-01-11 | |||
| 10:10:32 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Lay a foundation for the project cleanup https://review.opendev.org/700219 | |
| 17:59:48 | openstackgerrit | Merged openstack/openstackclient master: Constrain openstackclient-check-plugins run on master https://review.opendev.org/701293 | |
| 18:04:25 | openstackgerrit | Merged openstack/openstackclient master: Use python3 for openstackclient-check-plugins job https://review.opendev.org/701378 | |
| #openstack-sdks - 2020-01-12 | |||
| 13:13:43 | openstackgerrit | Radosław Piliszek proposed openstack/js-openstack-lib master: WIP: New nodejs jobs https://review.opendev.org/702132 | |
| 13:40:29 | openstackgerrit | Radosław Piliszek proposed openstack/js-openstack-lib master: WIP: New nodejs jobs https://review.opendev.org/702132 | |
| 14:26:14 | openstackgerrit | Radosław Piliszek proposed openstack/js-openstack-lib master: WIP: New nodejs jobs https://review.opendev.org/702132 | |
| 16:18:39 | openstackgerrit | Radosław Piliszek proposed openstack/js-openstack-lib master: WIP: New nodejs jobs https://review.opendev.org/702132 | |
| 16:19:34 | openstackgerrit | Radosław Piliszek proposed openstack/js-openstack-lib master: WIP: New nodejs jobs https://review.opendev.org/702132 | |
| 16:58:03 | openstackgerrit | Radosław Piliszek proposed openstack/js-openstack-lib master: WIP: New nodejs jobs https://review.opendev.org/702132 | |
| #openstack-sdks - 2020-01-13 | |||
| 08:22:15 | openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444 | |
| 09:56:08 | openstackgerrit | Bence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route https://review.opendev.org/674325 | |
| 10:52:19 | gundalow | sshnaidm: Hi, I'm back now :) | |
| 11:05:06 | sshnaidm | gundalow, welcome back! | |
| 11:10:46 | sshnaidm | gundalow, will you be available this week for helping with ansible bits of moving OS modules? | |
| 11:11:34 | gundalow | Sure, is there a doc where we are listing the steps? | |
| 11:14:10 | sshnaidm | gundalow, I think we can use our etherpad for that: https://etherpad.openstack.org/p/openstack-ansible-modules | |
| 11:21:13 | gundalow | sshnaidm: perfect, thank you. Could you remind me if we decided on 1) namespace 2) Collection name 3) Host repo | |
| 11:28:39 | sshnaidm | gundalow, updated in etherpad | |
| 11:38:06 | sshnaidm | bbl | |
| 12:43:51 | sshnaidm | gundalow, I'd like to send a mail to Ansible devs/cores to ask them not to merge patches to OS modules w/o exceptional ack from specific OS cores. Where can I send it to? | |
| 12:44:10 | sshnaidm | gundalow, because we want to freeze them in current state now | |
| 14:53:05 | gundalow | hum, Ansibulbot will also automerge. I wonder if we can somehow make the PRs fail CI | |
| 15:51:11 | sshnaidm | gundalow, I think we can, need just to configure openstack job to fail always, but also I'd like to make people aware about it | |
| 15:51:24 | sshnaidm | gundalow, do you have kind of "ansible-dev" list..? | |
| 16:05:50 | KeithMnemonic | am i reading this failure correctly, that it also due to the thread on openstack-discuss about setuptools and python2? https://zuul.opendev.org/t/openstack/build/372bc8c66d794210aeb571491ed6e893 | |
| 16:25:27 | dtantsur | KeithMnemonic: everything is broken, yes. the infra team is about to work it around though. | |
| 16:28:55 | KeithMnemonic | thanks! | |
| 16:34:11 | mordred | should be fixed now | |