| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-01-09 | |||
| 16:28:46 | gtema | and basically those SDK func tests must install collection first | |
| 16:28:54 | gtema | me too | |
| 16:29:03 | gtema | (not this "me too") | |
| 16:29:16 | sshnaidm | gtema, and apply a patch I suppose.. | |
| 16:29:30 | gtema | well, you can install collection from local | |
| 16:29:50 | sshnaidm | gtema, yeah, I think you make a tarball and then install it, iirc | |
| 16:29:53 | gtema | so it's basically just "ansible-galaxy collection build && ansible-galaxy collection install" | |
| 16:29:59 | gtema | exactly | |
| 16:30:00 | sshnaidm | yep | |
| 16:30:40 | dtantsur | zuul applies patches for you | |
| 16:30:43 | sshnaidm | well, I think it will be more clear when we move it finally | |
| 16:31:06 | sshnaidm | I'm not familiar with SDK jobs | |
| 16:31:18 | sshnaidm | but do we have there something | |
| 16:31:26 | sshnaidm | that can be helpful for modules as well? | |
| 16:31:35 | gtema | there are tests for modules | |
| 16:31:56 | sshnaidm | I suppose we need installed Openstack to run modules that change it | |
| 16:32:05 | sshnaidm | devstack, tripleo, whatever | |
| 16:32:06 | gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/ansible | |
| 16:32:10 | mordred | yah - there is a module function test job that runs against devstack | |
| 16:32:24 | mordred | I totally agree, those should move into the collection repo once we've got it | |
| 16:32:35 | mordred | and we can still also trigger it from sdk for cross-testing | |
| 16:32:46 | gtema | sure | |
| 16:33:04 | mordred | essentially, it runs devstack and then runs the module tests against the api endpoint from the devstack | |
| 16:33:10 | mordred | it's not COMPREHENSIVE | |
| 16:33:16 | mordred | but it's a solid starting place | |
| 16:34:17 | sshnaidm | as I see there are test actions, but not verifications..? like in https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/ansible/roles/keystone_domain/tasks/main.yml | |
| 16:34:29 | dtantsur | ironic coverage can be provided by bifrost | |
| 16:34:33 | gtema | right | |
| 16:34:55 | mordred | sshnaidm: well, the verifications are a little implicit for now | |
| 16:35:25 | mordred | that update isn't going to work if the create didn't, etc ... but we can *definitely* improve these and make them better | |
| 16:35:29 | mordred | and should | |
| 16:35:46 | mordred | it's been harder to improve that with the modules in ansible/ansible and the tests in openstacksdk | |
| 16:36:09 | sshnaidm | yeah, maybe using molecule will be helpful too | |
| 16:36:34 | sshnaidm | for testing on various platforms for example | |
| 16:36:34 | mordred | yah - maybe so - I hear you know something about that :) | |
| 16:36:43 | gtema | not definitely - you want to mess with devstack and molecule? | |
| 16:36:50 | sshnaidm | mordred, yeah, we use it heavily now | |
| 16:37:11 | sshnaidm | devstack is providing openstack cloud | |
| 16:37:28 | sshnaidm | but all tests can be wrapped in molecule | |
| 16:38:11 | sshnaidm | for last triple module I just used keystone container for testing | |
| 16:38:30 | sshnaidm | and running os_keystone_* tasks with it | |
| 16:38:42 | sshnaidm | not even whole openstack | |
| 16:38:59 | sshnaidm | the same tried with ironic dev container | |
| 16:39:30 | mordred | cool | |
| 16:40:07 | sshnaidm | OK, I think we agreed to design a good testing for modules after a move | |
| 16:40:07 | mordred | like - my brain doesn't necessarily know how that all hangs together, but I could imagine seeing some patches would bea . good learning experience all around | |
| 16:40:14 | mordred | ++ | |
| 16:40:55 | sshnaidm | anything else in your minds? | |
| 16:41:35 | sshnaidm | OK, I think we're good for today | |
| 16:41:44 | sshnaidm | and welcome back everyone | |
| 16:41:51 | mordred | happy new year! | |
| 16:42:01 | sshnaidm | +1 | |
| 16:42:09 | sshnaidm | #endmeeting | |
| 16:42:11 | openstack | Meeting ended Thu Jan 9 16:42:09 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:42:12 | openstack | Minutes: http://eavesdrop.openstack.org/meetings/api_sig/2020/api_sig.2020-01-09-16.00.html | |
| 16:42:13 | openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/api_sig/2020/api_sig.2020-01-09-16.00.txt | |
| 16:42:14 | openstack | Log: http://eavesdrop.openstack.org/meetings/api_sig/2020/api_sig.2020-01-09-16.00.log.html | |
| 17:10:27 | openstackgerrit | Sean McGinnis proposed openstack/os-client-config master: Fix pep8 issue in o_c_c/__init__ https://review.opendev.org/701773 | |
| 17:10:27 | openstackgerrit | Sean McGinnis proposed openstack/os-client-config master: Add a release note for Python 2 support removal https://review.opendev.org/701761 | |
| 17:19:53 | smcginnis | mordred and/or amotoki: Could you push through that stack? ^ | |
| 17:20:09 | smcginnis | Pretty trivial, then we can get a release request for milestone 1 updated and get that out. | |
| 17:21:33 | amotoki | smcginnis: I have no +2 right on os-client-config. we need to wait mordred | |
| 17:21:46 | smcginnis | amotoki: OK, thanks for reviewing! | |
| 17:21:53 | mordred | smcginnis: +A | |
| 17:22:09 | smcginnis | Awesome, thanks | |
| 17:27:07 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: "qos_network_policy_id" attribute added to port resource https://review.opendev.org/693247 | |
| 17:54:05 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add qos_network_policy_id to network port https://review.opendev.org/701786 | |
| 17:56:11 | KeithMnemonic | any chance to please get these moving along? https://review.opendev.org/#/c/701293/ https://review.opendev.org/#/c/701378/ dtroyer, amotoki | |
| 17:58:38 | openstackgerrit | Merged openstack/openstacksdk master: Replace six.iteritems() with .items() https://review.opendev.org/701729 | |
| 18:22:20 | openstackgerrit | Colleen Murphy proposed openstack/python-openstackclient master: Add support for app cred access rules https://review.opendev.org/677857 | |
| 18:32:23 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add qos_network_policy_id to network port https://review.opendev.org/701786 | |
| 18:51:13 | KeithMnemonic | thanks for all of the effort it seems python-openstackclient on train is working better now. reviews please https://review.opendev.org/#/c/701299/ | |
| 18:58:58 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add qos_network_policy_id to network port https://review.opendev.org/701786 | |
| 20:05:15 | openstackgerrit | Merged openstack/os-client-config master: Add a release note for Python 2 support removal https://review.opendev.org/701761 | |
| 20:05:15 | openstackgerrit | Merged openstack/os-client-config master: Fix pep8 issue in o_c_c/__init__ https://review.opendev.org/701773 | |
| 22:27:34 | mordred | yoctozepto: https://review.opendev.org/701854 | |
| #openstack-sdks - 2020-01-10 | |||
| 11:17:19 | openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444 | |
| 12:31:09 | frickler | mordred: dtroyer: can the osc4 feature branch be dropped? we do have v4 in master now, don't we? | |
| 15:14:31 | dtroyer | frickler: yes it can | |
| 15:40:06 | vkmc | hey all o/ | |
| 15:40:13 | vkmc | we are working on implementing the plugin for osc for manila | |
| 15:40:29 | vkmc | wondering if there are guidelines for creating documentation for it | |
| 15:40:49 | vkmc | I've seen that the osc client has their own docs, which each of the commands that it's implemented | |
| 15:45:01 | mordred | vkmc: if it's a new plugin, it would be *awesome* if we could base it on openstacksdk and get the manila support in sdk solid - for docs, that's a good question ... dtroyer? | |
| 15:45:48 | vkmc | mordred, yes, brand new plugin | |
| 15:49:04 | vkmc | maaritamm, o/ | |
| 15:50:02 | vkmc | mordred, dtroyer, so maaritamm (outreachy intern) is the main lead on the manila plugin development | |
| 15:50:34 | vkmc | we want to make sure we comply to any existing process that the community might have wrt to creating user docs for the client | |
| 15:50:48 | mordred | yay outreachy intern! hi maaritamm | |
| 15:51:15 | maaritamm | o/ | |
| 15:51:51 | maaritamm | hi to all :) | |
| 15:52:28 | mordred | I'm honestly not sure what the osc plugin docs story is ... maybe dtroyer or dtantsur|brb knows? | |
| 15:52:38 | mordred | or amotoki if he's around | |
| 15:53:49 | dtroyer | I think the docs story has changed a bit recently, efried was doing a lot of work on autodoc at the end of last year, and I think that has affected the story for plugins, but I don't have that in my head at the moment | |
| 15:54:41 | vkmc | when is is the weekly meeting for this team? maybe we can use some minutes to talk about this | |
| 15:54:43 | vkmc | if that works for you | |
| 15:55:26 | amotoki | I haven't caught up the recent change on autodoc in osc, but as long as neutronclient osc plugin I think the autogen of OSC plugin CLI still works | |
| 15:56:00 | dtroyer | vkmc: We haven't had weekly meetings in quite some time | |
| 15:56:10 | vkmc | oh ok | |
| 15:56:12 | dtroyer | Pretty much everything happens here as needed | |