| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-10-29 | |||
| 21:42:30 | mordred | well - this is complicated - because there's the devstack install - and then there's the tox venv inside of which the functional tests run | |
| 21:42:56 | efried | o | |
| 21:43:25 | efried | okay, I'll stfu until it gets a bit further. | |
| 21:44:05 | mordred | looks like the tox file should have been running functional tests themselves in py3 for a while now | |
| 21:44:14 | mordred | so - this will be fun to understand :) | |
| 21:45:53 | mriedem | without basepython set in tox.ini i'm guessing you get whatever node you land on | |
| 21:46:20 | mriedem | so it's probably good to be explicit and switch those functional jobs over to py3 | |
| 21:46:27 | mriedem | and set USE_PYTHON3=True in the zuul job def | |
| 21:46:32 | mordred | well - basepython is set in tox ... | |
| 21:46:42 | mordred | but yeah - we should set USE_PYTHON3=True anyway | |
| 21:46:47 | mordred | just because | |
| 21:47:04 | mriedem | i mean basepython isn't set in https://github.com/openstack/python-openstackclient/blob/master/tox.ini#L6 | |
| 21:47:12 | mriedem | or https://github.com/openstack/python-openstackclient/blob/master/tox.ini#L70 | |
| 21:47:59 | mordred | it's totally set in my local copy - what's up with that? | |
| 21:48:19 | mordred | ah. BWAHAHAHA | |
| 21:49:04 | mordred | https://review.opendev.org/#/c/686590/ <-- that was on the tip of my local checkout :) | |
| 22:00:22 | mordred | efried: am I in the right channel? my irc client somehow split this channel into two different buffers and I'm confused ... | |
| 22:00:53 | efried | mordred: I see you, but was switched out and haven't read anything in the last 18 mins or so. Catching up... | |
| 22:02:08 | efried | mordred: beaut. and as you can see, it failed the same jobs the same way | |
| 22:03:16 | efried | mordred: so basically, you discovered this problem three weeks ago and didn't say anything. | |
| 22:03:24 | efried | :P | |
| 22:03:31 | mordred | efried: neat! | |
| 22:04:18 | efried | my patch got past the previous point okay. It's failing some tests tho, so being able to iterate on the node will be useful. However, I likely will have to bail before then. Is it legit to hold the node until tomorrow? | |
| 22:22:41 | mordred | yah. point me at your key though | |
| 22:22:58 | mordred | efried: I believe the default node hold timeout is 24h | |
| #openstack-sdks - 2019-10-30 | |||
| 08:11:00 | yonglihe | I'm sorry to lost 2 +2, but happy to make it better, thanks for review again: https://review.opendev.org/#/c/680928/ | |
| 08:12:08 | openstackgerrit | Shogo Saito proposed openstack/openstacksdk master: Adding basic implementation for Accelerator(Cyborg) https://review.opendev.org/679914 | |
| 13:33:08 | openstackgerrit | Pedro Henrique Pereira Martins proposed openstack/keystoneauth master: Fixes OIDC authentication with multiple IdPs https://review.opendev.org/692140 | |
| 21:05:52 | efried | Does the sdk image proxy do anything with multiple glance endpoints? | |
| 22:22:14 | openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: Fix functional tests for py3 https://review.opendev.org/691980 | |
| 22:22:38 | efried | mordred, dtroyer: ^ Fingers crossed, that should unwedge the build | |
| 23:52:25 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Fix 'versions show' helps & docs https://review.opendev.org/691989 | |
| #openstack-sdks - 2019-10-31 | |||
| 00:17:53 | openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: Fix functional tests for py3 https://review.opendev.org/691980 | |
| 00:47:08 | openstackgerrit | wangfaxin proposed openstack/js-openstack-lib master: Fix review link. https://review.opendev.org/692249 | |
| 01:59:14 | openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: Fix 'versions show' helps & docs https://review.opendev.org/691989 | |
| 10:21:38 | openstackgerrit | Thomas Bechtold proposed openstack/openstacksdk master: Increase test timeout for 2 tests in TestImageProxy class https://review.opendev.org/692323 | |
| 13:43:54 | openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: Stop testing python2 https://review.opendev.org/686590 | |
| 13:44:34 | mriedem | https://review.opendev.org/#/c/691980/ unblock osc in the gate so would be nice to prioritize that | |
| 14:18:34 | efried | mordred, dtroyer: ^ is green in zuul now, please merge soonest :* | |
| 15:51:38 | efried | amotoki: ^ | |
| 16:00:02 | elmiko | API SIG office hour has begun! | |
| 16:09:57 | efried | o/ | |
| 16:10:12 | efried | (I got nothing, just happened to be in the room) | |
| 16:10:22 | elmiko | hey efried =) | |
| 16:10:57 | elmiko | it's mostly quiet these days, but we are here if folks need us | |
| 16:18:52 | dtroyer | mriedem, efried, etc: +W on https://review.opendev.org/#/c/691980/, thank you for chasing that down. | |
| 16:19:01 | efried | thanks dtroyer | |
| 16:48:29 | openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: Use SDK to get compute API extensions https://review.opendev.org/691039 | |
| 16:48:39 | efried | dtroyer: if you're still about, would you also please send this one, which is holding up the python-novaclient release? https://review.opendev.org/#/c/691039/ | |
| 16:48:53 | efried | mriedem: fyi rebased that on the gate fix to smooth its path | |
| 16:50:52 | mriedem | thanks | |
| 16:51:09 | mriedem | i'm gonna go smooth some food into my gullet | |
| 16:53:30 | openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: Remove redundant OpenStackShell.prepare_to_run_command https://review.opendev.org/691865 | |
| 17:00:54 | elmiko | later all o/ | |
| 17:47:40 | openstackgerrit | Merged openstack/python-openstackclient master: Fix functional tests for py3 https://review.opendev.org/691980 | |
| 18:01:37 | mgariepy | can i have a quick push for this patch please ? https://review.opendev.org/#/c/691375/ | |
| 18:56:27 | efried | mgariepy: FYI I'm working on making all of those pages autogenerated from the command classes | |
| 18:57:52 | efried | mgariepy: https://review.opendev.org/#/c/691767/ -- for this specific case, here's how it renders, which I think is the same as what you've done https://21fbb9beee6499333383-b4831d08abece0047714b6befcdb357a.ssl.cf5.rackcdn.com/691767/1/check/openstack-tox-docs/8df38ae/docs/cli/command-objects/network-agent.html#network-agent-remove-router | |
| 21:49:57 | openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: neutron: autogenerate docs https://review.opendev.org/691767 | |
| 23:41:59 | openstackgerrit | Eric Fried proposed openstack/cliff master: WIP: Add autoprogram_cliff_app_dist_name config opt https://review.opendev.org/692464 | |
| 23:42:52 | openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: Let autoprogram-cliff know who's running https://review.opendev.org/692465 | |
| #openstack-sdks - 2019-11-01 | |||
| 07:07:43 | openstackgerrit | gugug proposed openstack/openstacksdk master: tox: Keeping going with docs https://review.opendev.org/692503 | |
| 07:08:47 | openstackgerrit | gugug proposed openstack/openstacksdk master: tox: Keeping going with docs https://review.opendev.org/692503 | |
| 10:26:24 | openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | |
| 14:28:18 | umbSublime | Is there any way to query the placement API with the SDK ? I can't seem to figure it out | |
| 14:28:38 | frickler | umbSublime: iirc there's a plugin for that | |
| 14:28:47 | umbSublime | osc-placement ? | |
| 14:29:07 | frickler | umbSublime: exactly | |
| 14:29:21 | umbSublime | Ok, that works ! thanks | |
| 14:32:28 | umbSublime | frickler: I don't think I've ever user anything but the sdk or requests to query the API, is there a way I can just register a proxy on my connection object from this ? | |
| 14:35:20 | frickler | umbSublime: oh, you said sdk and not osc, not sure about that. maybe cdent or others can help, but likely many are on their way to the summit currently | |
| 14:35:46 | umbSublime | hehe no worries I have workarounds currently but it feels hacky :) | |
| 14:41:53 | efried | umbSublime: In the sdk you can create a raw placement proxy (connection.placement) and use the REST primitives (.get(), .put(), etc.) | |
| 14:42:10 | efried | Extensive examples in nova's report client... | |
| 14:42:41 | efried | https://opendev.org/openstack/nova/src/branch/master/nova/scheduler/client/report.py#L170 | |
| 14:43:31 | efried | https://opendev.org/openstack/nova/src/branch/master/nova/utils.py#L1012 | |
| 14:43:31 | efried | https://opendev.org/openstack/nova/src/branch/master/nova/scheduler/client/report.py#L229 is where we create the proxy. That calls into... | |
| 14:44:02 | efried | which in nova's case uses oslo.config opts to create the connection; but you should use your regular clouds.yaml thing. | |
| 14:44:38 | umbSublime | efried: awesome thanks ! | |
| 14:45:01 | efried | for your purposes | |
| 14:45:02 | efried | placement_proxy.get(...) etc. | |
| 14:45:02 | efried | placement_proxy = conn.placement | |
| 14:45:02 | efried | conn = openstack.connection.Connection(...) | |
| 14:48:01 | frickler | efried: hmm, I'm assuming that that code is in nova for historical reasons, wouldn't it make sense to move it into a library? not sure whether osc-placement would be the right target or something like python-placementclient | |
| 14:48:40 | efried | frickler: not sure how much history you're signing up for. Grab a cup of coffee and scoot closer to the fire... | |
| 14:49:21 | umbSublime | efried: I've tried what you suggest but I get this message "Skipping over invalid version data. No stability status in version." | |
| 14:49:41 | efried | umbSublime: what release are you on? | |
| 14:50:15 | umbSublime | for this specific cloud 'queens' | |
| 14:50:43 | efried | frickler: The SchedulerReportClient previously talked to placement through a generic ksa Adapter. We cut over to the SDK in Train, after putting a bit of framework in the SDK to accept oslo.config opts. Having done that, the change was a one-liner (plus test): https://review.opendev.org/#/c/656023/ | |
| 14:51:15 | efried | umbSublime: in queens placement was still part of nova, and sdk wasn't ready to create a generic placement proxy. | |
| 14:51:50 | umbSublime | Ahh I see, no worries then, I'll move along with my work around and make a bit more generic | |
| 14:51:55 | efried | umbSublime: you *might* be able to get away with it if you upgrade your openstacksdk to train-level code. But it's also possible you'll encounter some incompatible changes. | |
| 14:52:07 | cdent | presumably the new sdk release will still work with old | |
| 14:52:07 | umbSublime | my sdk is at 0.36 | |
| 14:52:17 | efried | yeah, I'm not so sure about that ^ | |
| 14:53:07 | umbSublime | in fact I was wondering which version to use. i couldn't find any documentatyion saying "Queens should use sdk version XX" | |
| 14:53:21 | cdent | frickler: one of the issues is that the previous PTL of placement (me) thinks people should just write get and put requests to placement as that's the way it was designed to be used, but the newer PTL (tetsuro) feels a bit differently, so there may be changes afoot. efried: meh. meh to that I say | |
| 14:54:03 | cdent | I would assume that mordred would be very sad if modern sdk can't talk to old clouds | |
| 14:54:32 | umbSublime | currently with .36 I can use it on ocata deployment as well | |
| 14:54:37 | efried | frickler: yes, what cdent said, I was getting to that. We will "never" have a python-placementclient. But we may someday add more SDK-ish methods in the SDK. | |