| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-10-29 | |||
| 20:50:10 | efried | well, yeah | |
| 20:50:33 | efried | btw, attempting to run simply tox -e functional on my devstack node deadlocks. | |
| 20:50:46 | mriedem | i don't see anything recent in openstack-zuul-jobs that looks related | |
| 20:50:49 | mriedem | or devstack | |
| 20:51:03 | efried | yeah | |
| 20:51:35 | mriedem | the job does have USE_PYTHON3=False in it | |
| 20:51:38 | mriedem | so it should be using py2 | |
| 20:51:52 | efried | but isn't? | |
| 20:52:54 | mriedem | looks like it's using py3 https://zuul.opendev.org/t/openstack/build/49ff6a5645554095b3fb51bce497aff5/log/job-output.txt#30632 | |
| 20:53:10 | mriedem | $ /usr/bin/python3 -m virtualenv --no-download --python /usr/bin/python3 functional | |
| 20:53:21 | efried | I'll push a fix. | |
| 20:53:35 | efried | ...without for the moment caring that we "should be running py2". Because we really shouldn't. | |
| 20:54:18 | mriedem | i think you just need to put USE_PYTHON3: True in here https://github.com/openstack/python-openstackclient/blob/master/.zuul.yaml#L76 | |
| 20:54:45 | efried | but the problem is that it *is* using py3 and md5().update() needs an encoded string. | |
| 20:55:54 | mriedem | well, a quick fix would be setting basepython = python2 in the tox.ini functional env i think if the job isn't using py3, | |
| 20:56:01 | openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: Fix functional tests for py3 https://review.opendev.org/691980 | |
| 20:56:02 | mriedem | but if the parent is now using py3, yeah idk what's going on there that changed | |
| 20:56:23 | efried | mriedem: That ought to fix at least that error, we'll see if something else crops up. | |
| 20:57:57 | efried | dtroyer: FYI: TL;DR: python-openstackclient builds broke some time between 10/24 and this morning when the functional jobs somehow got cut over to py3. Fixing via https://review.opendev.org/691980 | |
| 20:59:40 | efried | actually, I can narrow it down further. I have a successful build Oct 28 19:31 (that's US Central time) | |
| 20:59:51 | mordred | efried: how did we manage to break builds? | |
| 21:00:02 | efried | mordred: haven't figured that out yet. | |
| 21:00:18 | efried | As far as mriedem and I can tell, "something" cut over to py3 | |
| 21:00:29 | mordred | "awesome" | |
| 21:00:53 | efried | If this build is running py2, that'll be confirmed: https://zuul.opendev.org/t/openstack/build/ad5f0ee04fed4285b9f5429debd9b32d/log/job-output.txt | |
| 21:01:17 | openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | |
| 21:02:33 | efried | I'm not good at definitively determining whether a job is running under py2 or py3, but afaict that one is py2, and today's broken ones are py3 | |
| 21:02:35 | mordred | efried: that one seems to be py2 - I see a bunch of false for use python3 - and an uninstall of python3 package | |
| 21:02:46 | efried | yup | |
| 21:02:47 | efried | so | |
| 21:02:57 | efried | some zuul ancestor somehow cut over to py3 overnight | |
| 21:03:00 | efried | but mriedem and I couldn't find it. | |
| 21:03:33 | efried | now - the right thing of course is for python-openstackclient to be testing under py3 anyway. | |
| 21:03:37 | mordred | yeah | |
| 21:03:45 | mordred | I mean- luckily that patch from you isn't super big | |
| 21:03:47 | efried | those jobs should have probably been (cloned or) cut over yonks ago. | |
| 21:03:51 | mordred | yup | |
| 21:03:53 | efried | well, not yet :) | |
| 21:03:56 | mordred | haha | |
| 21:04:05 | mordred | I assume that patch is perfect and complete | |
| 21:04:24 | efried | I haven't been able to run the suite locally at all, so just have to wait for zuul to tell us whether that's all that's required to cut over. | |
| 21:05:06 | efried | mordred: actually, since you're here with your godlike powers, perhaps you could set that node up to hold when/if it fails so we can get in there and iterate? | |
| 21:05:38 | openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | |
| 21:05:47 | efried | still queued at the moment... | |
| 21:08:24 | mordred | efried: yeah - one sec | |
| 21:10:22 | mordred | efried: k. autohold placed | |
| 21:11:32 | efried | cool | |
| 21:26:30 | openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: Fix 'versions show' helps & docs https://review.opendev.org/691989 | |
| 21:29:50 | mriedem | efried: see http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010430.html - just hit the ML, but says that openstackclient needs to support py27 for swift | |
| 21:30:27 | mriedem | osc isn't a library though so i'm not sure about all that | |
| 21:30:47 | mordred | wait - yeah. doesn't make sense that keystonemiddleware would need openstackclient | |
| 21:30:57 | mriedem | i'm replying | |
| 21:31:42 | mordred | ++ | |
| 21:31:51 | mordred | I just checked - osc is not a dep of keystonemiddleware | |
| 21:33:25 | mriedem | i'm guessing it just means devstack + osc for testing swift, but osc doesn't need to be py2 for that | |
| 21:38:31 | mordred | yeah | |
| 21:38:32 | efried | mriedem: FWIW 'openstackclient' and 'python-openstackclient' are different projects. It's likely they meant the latter even though they said the former. And in any case the former isn't a dep. | |
| 21:38:48 | mordred | neither should be a dep | |
| 21:38:54 | efried | just to add further depth to the confusion. | |
| 21:38:55 | mordred | and if either are, we should fix that :) | |
| 21:38:56 | efried | yeah. | |
| 21:39:50 | efried | mordred: http://zuul.openstack.org/stream/d39bf114ffc943c8b28a5c602395b10b?logfile=console.log I could be wrong, but this appears to be running under py2??? | |
| 21:41:07 | efried | is it possible that certain CI nodes are running py3 by default, so if this job doesn't say anything, it gets whatever it happens to land on?? | |
| 21:41:24 | efried | and all four of the runs previously noted just happened to get lucky? | |
| 21:41:30 | mordred | it really shouldn't be - we use the same images across all clouds | |
| 21:42:03 | efried | mm. So maybe I just don't know what I'm looking at. But I saw lots of "pyXX doesn't match your env" messages fly by. | |
| 21:42:30 | mordred | well - this is complicated - because there's the devstack install - and then there's the tox venv inside of which the functional tests run | |
| 21:42:56 | efried | o | |
| 21:43:25 | efried | okay, I'll stfu until it gets a bit further. | |
| 21:44:05 | mordred | looks like the tox file should have been running functional tests themselves in py3 for a while now | |
| 21:44:14 | mordred | so - this will be fun to understand :) | |
| 21:45:53 | mriedem | without basepython set in tox.ini i'm guessing you get whatever node you land on | |
| 21:46:20 | mriedem | so it's probably good to be explicit and switch those functional jobs over to py3 | |
| 21:46:27 | mriedem | and set USE_PYTHON3=True in the zuul job def | |
| 21:46:32 | mordred | well - basepython is set in tox ... | |
| 21:46:42 | mordred | but yeah - we should set USE_PYTHON3=True anyway | |
| 21:46:47 | mordred | just because | |
| 21:47:04 | mriedem | i mean basepython isn't set in https://github.com/openstack/python-openstackclient/blob/master/tox.ini#L6 | |
| 21:47:12 | mriedem | or https://github.com/openstack/python-openstackclient/blob/master/tox.ini#L70 | |
| 21:47:59 | mordred | it's totally set in my local copy - what's up with that? | |
| 21:48:19 | mordred | ah. BWAHAHAHA | |
| 21:49:04 | mordred | https://review.opendev.org/#/c/686590/ <-- that was on the tip of my local checkout :) | |
| 22:00:22 | mordred | efried: am I in the right channel? my irc client somehow split this channel into two different buffers and I'm confused ... | |
| 22:00:53 | efried | mordred: I see you, but was switched out and haven't read anything in the last 18 mins or so. Catching up... | |
| 22:02:08 | efried | mordred: beaut. and as you can see, it failed the same jobs the same way | |
| 22:03:16 | efried | mordred: so basically, you discovered this problem three weeks ago and didn't say anything. | |
| 22:03:24 | efried | :P | |
| 22:03:31 | mordred | efried: neat! | |
| 22:04:18 | efried | my patch got past the previous point okay. It's failing some tests tho, so being able to iterate on the node will be useful. However, I likely will have to bail before then. Is it legit to hold the node until tomorrow? | |
| 22:22:41 | mordred | yah. point me at your key though | |
| 22:22:58 | mordred | efried: I believe the default node hold timeout is 24h | |
| #openstack-sdks - 2019-10-30 | |||
| 08:11:00 | yonglihe | I'm sorry to lost 2 +2, but happy to make it better, thanks for review again: https://review.opendev.org/#/c/680928/ | |
| 08:12:08 | openstackgerrit | Shogo Saito proposed openstack/openstacksdk master: Adding basic implementation for Accelerator(Cyborg) https://review.opendev.org/679914 | |
| 13:33:08 | openstackgerrit | Pedro Henrique Pereira Martins proposed openstack/keystoneauth master: Fixes OIDC authentication with multiple IdPs https://review.opendev.org/692140 | |
| 21:05:52 | efried | Does the sdk image proxy do anything with multiple glance endpoints? | |
| 22:22:14 | openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: Fix functional tests for py3 https://review.opendev.org/691980 | |
| 22:22:38 | efried | mordred, dtroyer: ^ Fingers crossed, that should unwedge the build | |
| 23:52:25 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Fix 'versions show' helps & docs https://review.opendev.org/691989 | |
| #openstack-sdks - 2019-10-31 | |||
| 00:17:53 | openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: Fix functional tests for py3 https://review.opendev.org/691980 | |
| 00:47:08 | openstackgerrit | wangfaxin proposed openstack/js-openstack-lib master: Fix review link. https://review.opendev.org/692249 | |