Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-10-01
06:47:56 bverschueren_ if someone could have a look at https://review.opendev.org/#/c/682909/ ? thx
08:38:02 mordred rm_work: yay!
08:41:02 cdent I first read that as "rm work ; yay!" which would be pretty yay.
08:48:01 dtantsur rm -rf
08:51:28 mordred ++
08:51:51 mordred cdent: does the system continue working overall with that? like - if I just rm work, do I still get paychecks?
08:52:35 cdent mordred: in my pretty little mind it does
08:53:53 mordred cdent: I like the workings of that mind
08:54:16 cdent it's a very generous mind
08:54:22 dtantsur just copy paycheck somewhere before rm -rf
08:54:46 mordred dtantsur: ++
08:54:53 cdent it's a fifo that you can read from as needed
08:56:00 mordred dtantsur: wow. vendor_data2.json
08:56:04 mordred dtantsur: because that's a filename
08:56:11 dtantsur haha
08:57:30 mordred heaven forbid we put any sort of versioning into the file content itself.
09:12:55 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042
09:13:17 mordred efried, kmalloc, cmurphy: ^^ that's a simpler version and I think should be backportable
10:58:42 openstackgerrit Merged openstack/openstacksdk master: Support vendor data in configdrive building https://review.opendev.org/683842
11:06:27 openstackgerrit Merged openstack/openstacksdk master: Add a non-voting ironic-inspector job https://review.opendev.org/684729
15:15:07 mordred efried: you'll be happy to know that the 401 fix for keystoneauth, in additional to uncovering a different issue with swift (easy to fix) also uncovered the fact that, since we weren't ACTUALLY doing version discovery for nova before, we were falling back to 2.1 in sdk in all cases (which was actually our intention - we wanted to opt-in to newer behavior as we supported it) - but we were falling back
15:15:09 mordred to it accidentally- so with discovery fixed, sdk is getting newest rather than oldest microversion by default - and the change to flavor broke sdk
15:15:11 mordred efried: yay for testing
15:19:33 mordred gtema: didn't we have code in sdk that was supposed to cause sdk to skip trying to do version discovery for swift?
15:19:56 gtema yes - skip_discovery in proxy
15:20:00 mordred like - I feel like we had it - then I forgot about it and wrote it again
15:20:22 mordred gtema: then why is https://07f03003afd3ca1f2387-1738d3a5d5585f54500f5c8600ed53a6.ssl.cf1.rackcdn.com/685042/4/check/openstacksdk-functional-devstack-tips/64dae12/testr_results.html.gz
15:20:31 mordred openstack.tests.functional.object_store.v1.test_account.TestAccount
15:20:39 mordred doing version discovery gets?
15:21:03 gtema that's a different story :D
15:21:15 mordred (I know why they're broken - that's the ksa patch - but upon reflection, why are we doing them in the first place?)
15:21:54 gtema perhaps something else in your patches? lemme try in my cloud fast
15:22:03 mordred gtema: oh!
15:22:07 mordred gtema: it's the test itself
15:22:35 mordred gtema: the functional base test has a "require_service" method which we have a todo to replace
15:22:47 mordred which is doing an explicit get_endpoint_data
15:22:56 gtema aah, ok. In real life discovery is not done for swift
15:23:00 mordred yeah
15:23:28 mordred so - I think ksa should throw a better error in the case that someone tries this - but I also think we should fix these tests
15:23:33 mordred this is a fun rabbit hole
15:25:26 gtema agree. But I like the approach of passing auth to endpoint if we got exception
15:25:32 mordred ++
15:25:34 gtema I have it in my cloud everywhere
15:26:10 gtema and this is exactly what I was pointing in the API-SIG rework about version discovery
15:26:24 gtema those clear requirements were lost
15:32:03 efried mordred: Is sdk *supposed* to be getting the newest rather than the oldest microversion by default? (by design)
15:32:15 mordred nope
15:32:34 efried okay, reread your first message, got it.
15:32:44 mordred so - you know - bugs all around :)
15:32:49 efried Though I would imagine specific operations would explicitly use newer microversions under the covers.
15:32:55 mordred yes - absolutely!
15:33:02 mordred and for those it should absolutely use them
15:33:37 efried but, like, something where /foo changes payload formats with different microversions, and we have a foos() method, I guess we would need you to tell us which shape you wanted the response to take.
15:33:42 mordred we just might need to take additional action sdk-side to keep the sdk api consistent, so we want to opt-in to microversion changes (which is one of the reasons I've become an ardent supporter of microversions)
15:33:52 efried unless we obscure all of that by objectifying the response
15:34:06 efried but there again, some fields might be present/absent depending
15:34:32 mordred yah- in the normal shade and sdk layer, we obscure by objectifying. if you want the REST layer and know what you're doing, requesting like 2.latest should be fine
15:35:02 efried presumably the microversion kwarg passes through request() seamlessly still?
15:35:07 mordred yup
15:35:19 efried yeah, it must, because we're using it for placement from nova
15:35:34 mordred fields being different, specifically flavor, is what caused the tests to catch that the ksa 401 fix had unbroken a discovery thing that was accidentally keeping sdk working properly :)
15:35:40 efried ...unless we're getting the latest, which would also be working without us knowing...
15:36:04 efried yeesh, so we have to fix ksa and then blacklist the fix from sdk until we fix sdk?
15:36:19 mordred no - we can fix sdk before we fix ksa
15:36:21 efried I had a mentor early in my career who called this RBB
15:36:25 efried Revoked Bug Benefit
15:36:28 mordred yah
15:36:36 mordred it's a good term
15:37:13 efried mordred: well, in other news, I think I got compute versioned discovery unauthed working: https://review.opendev.org/685181
15:37:41 mordred \o/
15:37:50 efried question is whether the change in NoAuthMiddleware is going to be acceptable. I would hope that's not being used outside of our own testing, but it seems technically supported by our conf, so I'm not sure.
15:37:57 mordred I'm glad it was broken though - look at all the other stuff we get to fix
15:38:01 efried Unfortunately, people who would know or care seem to be sparse.
15:38:02 efried yeah
15:52:45 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042
15:54:02 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use has_service in functional test's require_service https://review.opendev.org/685995
15:59:15 mordred efried, gtema: I *think* that should handle all the things except for the nova microversion issue
15:59:27 gtema cool
16:00:18 efried ack
16:04:18 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042
16:11:42 mordred gtema, efried: BWAHAHAHAHA. it's "not a bug" that we're requesting a later microversion from nova - we actually bumped the sdk layer microversion for the server resource
16:12:08 mordred but - because of the other bug, we never actually were getting 2.72 payloads in devstack and didn't notice we needed to update our flavor support
16:12:33 gtema life is perfect
16:12:48 gtema (unless one touches anything)
16:12:55 mordred yeah
16:14:04 gtema discovery and microversions are voodoo things in OpenStack
16:23:42 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999
16:24:42 mordred gtema: yah. although they wouldn't have been if the client libraries hadn't hardcoded around them and if people hadn't put versioned endpoints in the catalog for the last 9 years. like - there was this whole system that literally nobody actually used :(
16:24:59 gtema sure
16:25:27 gtema hope we will fix it now with Nova switched to SDK and others using it deeper
16:27:21 mordred gtema: or we've just opened ourselves to a new kind of pain
16:35:11 gtema that's of course as well
#openstack-sdks - 2019-10-02
09:17:24 openstackgerrit Artem Goncharov proposed openstack/python-openstackclient master: Switch image to use SDK https://review.opendev.org/650374
12:39:54 openstackgerrit Artem Goncharov proposed openstack/python-openstackclient master: Switch image to use SDK https://review.opendev.org/650374
15:38:01 openstackgerrit Stephen Finucane proposed openstack/cliff master: Blacklist bandit 1.6.0 due to directory exclusion bug https://review.opendev.org/658522
15:39:35 tosky stephenfin: I think also 1.6.1 and 1.6.2 are buggy, I had to stick to <1.6.0 in sahara
15:41:47 openstackgerrit Stephen Finucane proposed openstack/cliff master: Switch to stestr https://review.opendev.org/581564
15:41:57 stephenfin tosky: Hmm, really? That was just a rebase of amotoki's patch
15:42:35 tosky stephenfin: that was proposed in May, when 1.6.{1,2} have not been released yet
17:25:09 openstackgerrit Merged openstack/cliff master: Modify the help message of `-c`/`--column` parameter https://review.opendev.org/672852

Earlier   Later