Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-08-12
14:15:55 Shrews dtantsur: https://review.opendev.org/675134 would really help openstack infra avoid a pretty bad object leak we are seeing, if you have some time to review it
14:17:57 dtantsur Shrews: found a few minor issues, wanna fix them now or follow-up?
14:19:49 Shrews dtantsur: How does re-raising the exception lose the traceback?
14:20:15 dtantsur Shrews: when you do 'raise e', the traceback will start from this instruction. when you do 'raise', the traceback is reused from the original exception.
14:20:18 dtantsur python fun
14:20:41 Shrews dtantsur: ah. so should all of those just be "raise" then ?
14:21:12 dtantsur Shrews: likely yes. In most case it's an antipattern to do 'except Something as e... raise e'.
14:21:26 dtantsur (python 3 has 'raise from', but let's ignore it for now)
14:21:34 Shrews dtantsur: ok. lemme fix that up then
14:23:51 openstackgerrit David Shrewsbury proposed openstack/openstacksdk master: Retry large object manifest upload https://review.opendev.org/675134
14:24:26 Shrews dtantsur: ok, that look more sane?
14:24:53 dtantsur yep
14:25:27 Shrews dtantsur: thx for the review. will bug mordred when he has internet again
14:37:58 Shrews mordred: since you are back, can you re-examine 675134 por favor?
14:38:16 mordred Shrews: I can!
14:39:12 mordred Shrews: +A - woot
14:40:21 mordred dtantsur: wow, that's fun with user_data
14:40:37 dtantsur yeah..
14:45:16 efried dtantsur: I'm not convinced you've actually done anything there.
14:45:30 dtantsur where?
14:46:01 efried I'm playing around with it locally, but I think 't' vs 'b' only affects the data type you get *back*
14:46:15 efried I'm not sure it affects the data going in.
14:46:56 efried and since you're not returning anything here...
14:47:16 dtantsur I was under impression 't' vs 'b' affects both directions
14:47:58 dtantsur efried: http://paste.openstack.org/show/756340/
14:48:18 dtantsur (this is python 3, I'm not sure there is a difference in python 2)
14:49:17 efried okay, I was trying to come up with a repro like that --^
14:49:31 efried and yeah, I meant to do it in py3, but I'm using py2 instead.
14:49:46 efried so, I stand corrected
14:49:55 efried <waves hand like jedi> I was never here
14:50:26 dtantsur hehe
16:20:56 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Allow services to override proxy creation. https://review.opendev.org/674110
16:20:57 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add support for global_request_id https://review.opendev.org/674807
16:20:57 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix discovery cache sharing https://review.opendev.org/675121
16:20:58 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Validate that connect_as connects as the project https://review.opendev.org/675178
16:20:58 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rationalize endpoint_for and get_endpoint_from_catalog https://review.opendev.org/675130
16:20:59 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Replace catalog-v3.json with keystoneauth fixture https://review.opendev.org/675187
16:23:22 mordred dtantsur: I had to rebase the stack, so I went ahead and squashed the cloud_region rename patch into https://review.opendev.org/#/c/674807
16:24:31 openstackgerrit Merged openstack/openstacksdk master: baremetal.configdrive: tolerate user_data as a string https://review.opendev.org/674298
16:27:32 dtantsur cool
17:31:07 openstackgerrit Merged openstack/openstacksdk master: Retry large object manifest upload https://review.opendev.org/675134
18:31:54 openstackgerrit Alex Schultz proposed openstack/keystoneauth master: Cleanup session on delete https://review.opendev.org/674139
19:05:52 efried mordred: Look, far be it from me to contradict a +1 from melissaml, but I think the test in https://review.opendev.org/#/c/674110/ needs to go a bit deeper.
19:15:24 openstackgerrit Eric Fried proposed openstack/openstacksdk master: DRY test_connection https://review.opendev.org/676009
20:12:11 openstackgerrit Eric Fried proposed openstack/openstacksdk master: Minor refactor cleanup of _make_proxy https://review.opendev.org/676015
#openstack-sdks - 2019-08-13
02:37:24 openstackgerrit Adrian Turjak proposed openstack/keystoneauth master: add support for auth_receipts and multi-method auth https://review.opendev.org/675049
02:46:38 openstackgerrit Adrian Turjak proposed openstack/keystoneauth master: add support for auth_receipts and multi-method auth https://review.opendev.org/675049
04:05:27 openstackgerrit Brin Zhang proposed openstack/python-openstackclient master: Microversion 2.76: Support Specifying AZ to unshelve https://review.opendev.org/665336
06:48:19 openstackgerrit Vieri proposed openstack/openstackclient master: Add Python 3 Train unit tests https://review.opendev.org/676117
10:35:46 dtantsur mmm, so apparently our image API is using an unused "params" argument to Resource.fetch and tests fail if you wire it in..
10:36:20 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Add support for fields in baremetal get_* resources https://review.opendev.org/676154
10:36:23 dtantsur efried: needed for nova ^^ but won't pass unit tests because of the image API test weirdness
10:37:05 dtantsur ooops, sorry, it was DNS API
10:54:49 mordred dtantsur: this is the test_wait_for_task_wait issue?
10:55:22 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Add support for fields in baremetal get_* resources https://review.opendev.org/676154
10:55:24 dtantsur mordred: no. I've uncovered two actual bugs, I think ^^^
10:55:48 mordred ah - neat
10:55:53 dtantsur reminder for us: never ignore arguments, somebody will try to provide them :)
10:56:03 mordred ++
12:10:53 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rationalize endpoint_for and get_endpoint_from_catalog https://review.opendev.org/675130
12:10:53 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix discovery cache sharing https://review.opendev.org/675121
12:10:54 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Validate that connect_as connects as the project https://review.opendev.org/675178
12:10:54 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add support for global_request_id https://review.opendev.org/674807
12:10:55 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Allow services to override proxy creation https://review.opendev.org/674110
12:10:55 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Replace catalog-v3.json with keystoneauth fixture https://review.opendev.org/675187
12:11:49 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rationalize endpoint_for and get_endpoint_from_catalog https://review.opendev.org/675130
12:14:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Validate that connect_as connects as the project https://review.opendev.org/675178
12:14:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add support for global_request_id https://review.opendev.org/674807
12:16:15 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Replace catalog-v3.json with keystoneauth fixture https://review.opendev.org/675187
12:16:15 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rationalize endpoint_for and get_endpoint_from_catalog https://review.opendev.org/675130
12:16:34 mordred sorry for the churn - I thought I could pull one of those patches out to be independent - but turns out I couldn't
12:40:52 openstackgerrit Maxim Babushkin proposed openstack/openstacksdk master: Add 'tag' support to compute with supported microversion https://review.opendev.org/675306
13:03:15 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Add support for fields in baremetal get_* resources https://review.opendev.org/676154
13:49:07 efried dtantsur: I was going to hit you up about that
13:49:23 efried I was looking into it yesterday
13:49:31 dtantsur I hope I didn't step on your shoes
13:49:46 efried just got to my desk, so haven't caught up, except to see that you commented on the nova patch and seem to have identified the/a problem
13:49:57 dtantsur yeah
13:50:01 efried from what I could tell, it was happening during construction of the proxy
13:50:16 efried is that the case?
13:50:57 dtantsur efried: ignore the version blah-blah logging. the actual problem seems to be get_node(<>, fields=..). we never implemented the "fields" bit.
13:51:06 dtantsur my patch above hopefully adds its support
13:51:27 efried dtantsur: Okay, the thing that concers me is...
13:52:56 efried dtantsur: Okay, here
13:52:59 efried https://logs.opendev.org/99/642899/38/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/665016d/controller/logs/screen-n-cpu.txt.gz?level=ERROR
13:53:35 dtantsur "StrictVersion instance has no attribute 'version'" is an annoying exception that *likely* hides the fact that ironic is not up yet
13:53:47 efried Even when this job succeeds, the "Error: StrictVersion instance has no attribute 'version'" always shows up, as does the "VirtDriverNotReady: Virt driver is not ready."
13:53:52 dtantsur the actual problem that fails you https://logs.opendev.org/99/642899/38/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/665016d/controller/logs/screen-n-cpu.txt.gz?level=ERROR#_Aug_13_05_19_11_540713
13:54:02 efried And we always see at least one "No compute node record for host"
13:54:07 dtantsur efried: right, it's a bug in ironicclient that hides the ConnectionRefused or whatever
13:54:18 dtantsur because ironic starts later than nova
13:54:25 efried right, so
13:54:26 dtantsur I may be confusing some details, but the overall picture is like this
13:54:40 efried this error didn't start appearing in this patch until the latest PS
13:54:46 efried let me show you a log from before...
13:55:41 dtantsur I've seen it many times already. Not sure if it's permanent or depends on some ordering in devstack.
13:57:07 efried That job succeeded ^
13:57:07 efried dtantsur: So this is what I consider "good": https://logs.opendev.org/99/642899/36/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/4b528c1/controller/logs/screen-n-cpu.txt.gz?level=ERROR
13:57:07 efried Yeah, I'm just using it as a baseline.
13:57:12 dtantsur same problem in a recent successful run: https://logs.opendev.org/40/675940/1/check/ironicclient-tempest/f57c0f3/controller/logs/screen-n-cpu.txt.gz?level=WARNING#_Aug_12_16_38_40_790400

Earlier   Later