Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-08-07
20:02:21 efried but the train has left the station
20:02:24 mordred my plan is to do some refactoring inside of sdk so that we make the fixture and then we use that fixture in our tests
20:02:36 mordred so that, you know - you can count on it
20:02:53 mordred I thnik it's going to make sdk's tests better too
20:03:02 efried spect so
20:03:06 mordred because we have a bunch of wonky hacks going on right now
20:03:30 efried mordred: Have we done the thing yet where we run some form of nova dsvm CI on sdk patches?
20:03:45 efried you start mucking with endpoint methods, makes me nervous.
20:04:31 mordred don't be nervous - we never write bugs
20:04:37 mordred efried: and no - but we should
20:05:10 mordred efried: we have plenty of dsvm jobs going in sdk - but nothing running a tempest-based anything because up until recently there was no need to
20:08:47 kmalloc mordred: my TODO comments are.... long ago todo ;)
20:08:54 mordred kmalloc: :)
20:09:06 mordred kmalloc: well - check that WIP - I think you'll immediately get where I'm going with that and will hopefully like it
20:09:34 kmalloc mordred: oh that is a good direction
20:09:42 kmalloc didn't even take long to see it.
20:09:44 kmalloc good stuff
20:09:47 mordred \o/
20:12:35 kmalloc i'll review a bit more in depth knowing it's WIP
20:12:43 kmalloc but i think you're headed the right way for sure.
20:20:06 openstackgerrit David Shrewsbury proposed openstack/openstacksdk master: WIP: Retry SLO manifest upload https://review.opendev.org/675134
20:23:17 mordred Shrews: ^^ \o/
20:24:54 Shrews mordred: i'm completely boggled on the new test_slo_manifest_fail test and what requests to mock for the object cleanup phase
20:25:17 Shrews that's where it's barfing for me, atm
20:25:58 Shrews i know what calls i *think* it's going to make, but not the details
20:26:34 mordred hrm.
20:27:12 mordred well - it *should* fire a delete for each segment it sent an upload for, right?
20:27:18 mordred (in some order or another)
20:28:07 mordred oh - well - except - in this case you're going to return a list of segment objects as the return value from the list_objects call it's going to make
20:28:23 mordred so the json you return from list_object in your requests_mock should feed which segments it fires deletes for, yeah?
20:28:49 mordred (and you could probably make it a small list of segments so you don't go crazy)
20:29:23 Shrews i think that's right, just trying to figure out how to make that happen. thus far, it doesn't like my list objects uri i'm creating there
20:31:58 Shrews '{endpoint}/{container}?format=json&prefix={prefix}' <<-- that one
20:44:00 mordred Shrews: oh - so ... theres a thing with url parameters where you have to pass a thing
20:44:15 mordred Shrews: complete_qs=True
20:44:42 mordred Shrews: if the query string is meaningful, complete_qs causes it to be considered
20:45:35 Shrews mordred: i was wondering what that meant
20:46:12 Shrews i found nothing meaningful :( thx
20:46:36 mordred Shrews: are you saying we should document our test framework?
20:47:21 mordred Shrews: if so - you're in luck - because I'm working on extracting all this requests-mock/url stuff into a reusable fixture that openstacksdk consumers can also use - which means we'll necessarily need to give it a proper api and document that API
20:47:30 mordred if that's not what your'e saying, you're still in luck, for the same reason ;)
21:43:06 openstackgerrit Morgan Fainberg proposed openstack/keystoneauth master: Add remove_service to token fixtures https://review.opendev.org/675174
22:05:02 efried mordred: Sundar has been pretty busy today, so only sparsely working with your patch, but we seem to have at least gotten past that initial crash.
22:49:34 mordred efried: sweet
22:51:03 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: WIP Replace catalog-v3.json with keystoneauth fixture https://review.opendev.org/675187
23:08:52 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: WIP Replace catalog-v3.json with keystoneauth fixture https://review.opendev.org/675187
#openstack-sdks - 2019-08-08
01:44:36 openstackgerrit Adrian Turjak proposed openstack/keystoneauth master: add support for auth_receipts and multi-method auth https://review.opendev.org/675049
01:46:40 openstackgerrit Adrian Turjak proposed openstack/keystoneauth master: add support for auth_receipts and multi-method auth https://review.opendev.org/675049
01:47:05 openstackgerrit Merged openstack/keystoneauth master: Add remove_service to token fixtures https://review.opendev.org/675174
07:27:47 openstackgerrit Adrian Turjak proposed openstack/keystoneauth master: add support for auth_receipts and multi-method auth https://review.opendev.org/675049
07:30:53 openstackgerrit Adrian Turjak proposed openstack/keystoneauth master: add support for auth_receipts and multi-method auth https://review.opendev.org/675049
07:31:29 openstackgerrit Adrian Turjak proposed openstack/keystoneauth master: add support for auth_receipts and multi-method auth https://review.opendev.org/675049
07:33:00 openstackgerrit Adrian Turjak proposed openstack/keystoneauth master: add support for auth_receipts and multi-method auth https://review.opendev.org/675049
09:38:07 stingrayza Hi folks. I have a question about the os_zone ansible module. is this the right place, or should I take it over to one of the ansible channels?
09:51:40 frickler stingrayza: I've seen people discuss ansible pull requests here, so you aren't too much off here I'd say
09:54:43 stingrayza not so much a PR discussion, but I just want to sound something out before I log an issue...
09:54:51 stingrayza let me create a pastebin quick
09:55:53 frickler stingrayza: you can use paste.openstack.org instead of some advertisement-heavy pastebin
09:57:08 stingrayza frickler: thanks ;) exactly where I was. sorry - call it pastebin out of habit :)
10:03:55 openstackgerrit Loan Harrouin proposed openstack/openstacksdk master: Add get_actions for server resource https://review.opendev.org/675113
10:06:52 stingrayza When I (try) create a zone using os_zone, I get an error "Zone xxxx not found" - but creating it via the cli works (and then os_zone passes) http://paste.openstack.org/show/755646/
10:07:14 stingrayza just wanted to check I'm not doing anything silly in my os_zone command
10:07:22 stingrayza (triple checked the docs)
10:49:08 frickler stingrayza: ya, I can reproduce this, seems os_zone tries to update the zone instead of creating it: http://paste.openstack.org/show/755648/
10:49:22 frickler mordred: mugsie: ^^
10:51:50 stingrayza frickler: thanks! I'll log an issue - and take a squiz at the code to see if I can submit a PR to fix ;)
11:00:57 frickler stingrayza: mordred: fyi, this looks like a regression in openstacksdk, with 0.31.0 I don't see the error, just with 0.32.0
11:16:27 frickler conn.get_zone('missing.com.') now returns False instead of None, failing the check in https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/openstack/os_zone.py#L197
11:17:34 frickler looks like gtema's patch introduced this https://review.opendev.org/665435 Switch cloud layer to use proxy for DNS
11:23:16 mordred frickler: poo. we have another patch up to fix an ansible regression - lets fix this one too
11:25:07 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix dns return values https://review.opendev.org/675298
11:25:11 mordred frickler: ^^
11:25:49 mordred Shrews, dtantsur: ^^ I can respin the release request with that included (which will also get us a release note for the other fix)
11:29:05 frickler mordred: commented, you've uncovered more inconsistencies
11:30:08 mordred frickler: replied - want me to update the docstring there real quick?
11:30:38 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix dns return values https://review.opendev.org/675298
11:30:45 mordred there ya go :)
11:30:59 frickler mordred: if this is really a doc bug instead of a behaviour change, then I'm fine with it
11:31:19 frickler mordred: let me do a quick crosscheck against 0.31.0
11:33:57 frickler mordred: o.k., 0.31.0 returned None there, too, so that's o.k., then
11:37:53 mordred cool
11:39:21 frickler mordred: but I'd actually tend to agree with Thierry on that the release might better be 0.33.0 than 0.32.1
11:44:23 stingrayza frickler, mordred: fantastic! thanks gents :D
11:44:40 stingrayza at least I know I wasn't going mad ;D
11:45:05 stingrayza ^ my default position when I find a bug.
11:49:26 openstackgerrit Brin Zhang proposed openstack/python-openstackclient master: WIP: Add server migration list CLI https://review.opendev.org/675304
11:50:29 openstackgerrit Maxim Babushkin proposed openstack/openstacksdk master: Add 'tag' support to compute with supported microversion https://review.opendev.org/675306
11:52:41 openstackgerrit Maxim Babushkin proposed openstack/openstacksdk master: Add 'tag' support to compute with supported microversion https://review.opendev.org/675306
11:53:25 openstackgerrit Loan Harrouin proposed openstack/openstacksdk master: Add get_actions for server resource https://review.opendev.org/675113
11:58:52 mordred frickler: yeah - agree re: 0.33
12:29:30 mordred kmalloc: whence you are awakened, I have a question for you on keystone v2 admin interface things
12:30:38 mordred kmalloc: using the token fixture from ksa I've got a catalog in the sdk tests now that uses differnt hostnames for admin and public endpoints - this is flushing out some places where things were off but we weren't noticing because a requests-mock uri registered for either would work (same hostname)
12:30:48 mordred in a few places I'm getting: No mock address: GET https://identity.example.com/v2.0/OS-KSADM/roles
12:31:03 mordred I would have thought that OS-KSADM would really only ever be on the admin interface
12:31:24 mordred but that's telling me the code is making a request to OS-KSADM on the public interface
12:31:31 mordred is the code wrong? or the test wrong?
12:31:38 mordred cmurphy: ^^ in case you know
12:34:18 mordred OR - should I put a pin in it for later since at this point keystonev2 is so old it makes us all want to die inside
13:00:01 openstackgerrit Andrey Kurilin proposed openstack/osc-lib master: Fix usage of NotFound exception https://review.opendev.org/675328
13:05:37 mordred kmalloc:, cmurphy: I think the right answer for now is to just skip it for now - I don't think it's worth the effort to cleanup keystonev2 unless someone actually complains

Earlier   Later