| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-06-05 | |||
| 21:23:10 | mordred | efried: something like that ^^ | |
| 21:23:29 | mordred | efried: work still needed, but I think that's mostly what would be needed for what we need in from_conf | |
| 21:23:48 | efried | mordred: I'll have the test cases up in a sec... | |
| 21:23:56 | mordred | sweet | |
| 21:24:17 | mordred | efried: if we don't watch out - this whole this is going to become viable | |
| 21:24:22 | mordred | then what will we be able to complain about? | |
| 21:24:28 | efried | oh, I have faith | |
| 21:30:58 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: (Broken) from_conf test paths for oslo.config exceptions https://review.opendev.org/663439 | |
| 21:31:05 | efried | mordred: see how that grabs ya ^ | |
| 21:31:40 | mordred | sweet | |
| 21:33:19 | efried | I'm going to put those two in series and try to put a fix on top. | |
| 21:34:09 | mordred | that's exciting | |
| 21:35:05 | efried | [1] like I imagine skydiving to be | |
| 21:35:05 | efried | it's scary, but somewhat liberating [1], to be throwing all these patches around without tracking bugs/stories against them | |
| 21:38:20 | efried | mordred: If instead of raising right away, we just disable service for both cases (1) and (2) listed above, I can get away without importing oslo.config... | |
| 21:40:25 | mordred | efried: oh neat. then we could just do the "raise a useful error instead of None" patch - and further improvements can be around providing better/earlier errors | |
| 21:40:39 | efried | yuh | |
| 22:03:45 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Disable service on exception in from_conf https://review.opendev.org/663449 | |
| 22:03:45 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: WIP Plumb service disabling into Connection adapters https://review.opendev.org/663435 | |
| 22:03:50 | efried | mordred: thar she blows. Works like a charm. | |
| 22:04:18 | efried | mordred: I did a little refactoring of your pieces in there (which could probably be done in your patch instead of mine, but whatever) | |
| 22:21:20 | mordred | efried: \o/ | |
| 22:21:31 | efried | mordred: I'm working on the "better exception" thing. | |
| 22:21:57 | efried | mordred: Not sure if you'll want different/additional testing from what I'm doing. | |
| 22:22:10 | mordred | I'm sure what you're doing is perfect | |
| 22:22:29 | efried | oh, I'm sure. | |
| 22:25:50 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Show a pretty reason when service is disabled https://review.opendev.org/663453 | |
| 22:26:08 | efried | mordred: ^ | |
| 22:27:46 | mordred | efried: dude, that's so cool | |
| 22:27:52 | efried | :) | |
| 22:33:56 | efried | mordred: Hm, if you're feeling generous, it's possible we could consider the testing in the top two patches as sufficient for your otherwise-WIP. | |
| 22:34:42 | efried | so like, squash or reorganize and we're done? | |
| 22:35:59 | mordred | efried: yah - honestly, I think that's probably right. you have a sec to do that squash? (maybe pick the change-id from one of your changes, since those were the "point" of the work) | |
| 22:36:25 | efried | yeah, you want me to just squash them all into one? | |
| 22:37:18 | mordred | yeah - why not - I think it might be easier to understand as one big one | |
| 22:38:50 | efried | on it | |
| 22:41:24 | efried | gosh, I thought I was going to have a really long commit message, but from the pov of a single patch, it's fairly simple :) | |
| 22:46:10 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Handle oslo.config exceptions in from_conf https://review.opendev.org/663439 | |
| 22:46:17 | efried | mordred: blayum | |
| 22:48:32 | mordred | efried: that's actually a pretty nice looking patch | |
| 22:48:43 | efried | Yeah, it came together pretty nicely when squashed | |
| 22:49:16 | efried | mordred: I want to make a couple of little tweaks (noted inline), but I should call it a night. Feel free to fix it up if you like. | |
| 22:50:43 | mordred | efried: coolio. and yeah - it's about time for that for me too | |
| #openstack-sdks - 2019-06-06 | |||
| 08:52:50 | openstackgerrit | zhangboye proposed openstack/shade master: Cap sphinx for py2 to match global requirements https://review.opendev.org/663545 | |
| 11:16:21 | tssurya | dtroyer: hi! could you have a look at https://review.opendev.org/#/c/659124/ when you have time ? thanks in advance! | |
| 11:26:54 | ITD27M01_ | mordred: Hello! Are you online? Did you have time to see the https://github.com/ansible/ansible/pull/51401 ? | |
| 13:14:25 | efried | dtantsur: You around to have a look at https://review.opendev.org/663439 ? I'm fixing up the test failures now, but wanted to catch you before you left. | |
| 13:14:48 | dtantsur | efried: will have a short snack and check it | |
| 13:14:57 | efried | thank you sir | |
| 13:15:15 | dtantsur | having the CI (on the way to being) green is appreciated :) | |
| 13:15:34 | efried | of course | |
| 13:35:36 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Handle oslo.config exceptions in from_conf https://review.opendev.org/663439 | |
| 13:35:42 | efried | dtantsur: That should do it ^ | |
| 13:35:55 | efried | mordred: ^ | |
| 13:43:44 | mordred | efried: oh good - I was just looking at that but hadn't yet figured out what was up with the add_service calls :) | |
| 13:45:26 | mordred | Shrews: if you're bored this morning, ^^ that has 2x+2 but one is from me and I wrote some of the patch, so might be worth having another set of eyes on | |
| 13:45:44 | mordred | Shrews: otoh - efried wrote most of it, so you don't have to worry about much terrible code from me :) | |
| 13:48:18 | efried | mordred, dtantsur: I'll add consolidation of the log message to the fixups catch-all I'm working on now. | |
| 13:48:39 | mordred | coolio | |
| 13:49:45 | mordred | dtantsur: if you have another second, https://review.opendev.org/#/c/662698 by gtema could use another review - it's the underlying base for the rest of his stack | |
| 13:52:41 | dtantsur | lgtm | |
| 13:59:12 | mordred | woot! | |
| 14:33:01 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Minor fixups from from_conf changes https://review.opendev.org/663685 | |
| 14:33:28 | efried | dtantsur, mordred: fixups ^ | |
| 14:34:49 | efried | mordred: You can abandon https://review.opendev.org/#/c/663435/ now, yah? | |
| 14:35:04 | mordred | yup! done | |
| 14:35:27 | mordred | efried: oh - piddle. we didn't add a release note for the service disabling. let me add one real quick | |
| 14:36:46 | efried | mordred: In terms of "here's a new feature you can use"? Cause otherwise, who would notice? | |
| 14:38:14 | mordred | yeah- well, there's a new behavior if you set has_foo in your config file | |
| 14:38:38 | mordred | (also, I think we should cut a release as soon as these changes land, and it would be a release without any release notes to indicate what's in it otherwise :) ) | |
| 14:40:02 | efried | heh | |
| 14:40:07 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add release note for new disable service functionality https://review.opendev.org/663690 | |
| 14:41:02 | efried | mordred: comment inline... | |
| 14:41:18 | mordred | yup. good call | |
| 14:44:00 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add release note for new disable service functionality https://review.opendev.org/663690 | |
| 14:45:47 | efried | whapow, big ol +1 | |
| 14:46:24 | efried | https://www.youtube.com/watch?v=ggXbzjnffAo | |
| 15:07:53 | mordred | this couch is cut in half | |
| 15:08:32 | openstackgerrit | Merged openstack/openstacksdk master: Support skipping unknown QP https://review.opendev.org/662698 | |
| 16:00:15 | elmiko | API SIG office hour is now open! | |
| 16:00:23 | edleafe | Damn, you beat me again | |
| 16:00:30 | elmiko | i even waited that time XD | |
| 16:00:31 | edleafe | Was just going to press Enter | |
| 16:00:43 | elmiko | i figured you would beat me to it lol | |
| 16:04:32 | elmiko | just as a followup to the discussion that happened last week, i proposed a patch to keystoneauth that fixes the issue with api-sig suggested error formatting | |
| 16:04:39 | elmiko | that patch has been merged into the master | |
| 16:05:15 | elmiko | there was a question about backporting from the folks who ran into this originally, but i think that is better left to the keystoneauth team | |
| 16:05:32 | edleafe | Yeah, that patch looked sane | |
| 16:06:30 | elmiko | =) | |
| 16:08:49 | edleafe | We'll try to handle the load ourselves :) | |
| 16:12:20 | elmiko | hehe | |
| 16:35:19 | dtroyer | stephenfin: if you're around I would love to have you take one last look at https://review.opendev.org/#/c/659382/ (—live-migration) before merging it. This is the last thing before cutting a 3.19 release for OSC. | |
| 16:35:52 | dtroyer | mordred: ^^^ if you feel like looking at Something Completely Different(TM) | |
| 16:36:51 | stephenfin | dtroyer: Won't have time for a full review but I've made my peace with that approach. I've already fought with argparse too much, heh | |
| 16:44:01 | edleafe | elmiko: Gotta run out a little early. Try to hold the fort while I'm gone. | |
| 16:44:21 | dtroyer | stephenfin: ok, thanks. I just wanted to make sure there were no outstanding concerns | |
| 16:44:31 | elmiko | edleafe: ack, take care o/ | |
| 16:45:44 | stephenfin | dtroyer: Not from me. My concern was with the duplication in 'migration --live-migration' but I haven't found a way to avoid that that doesn't involve rewriting argparse | |
| 16:45:57 | stephenfin | which is a hole I went far too deep down | |
| 16:47:16 | dtroyer | stephenfin: maybe in a year or so we can bring —live back as an alias :) it would be a forced break for anyone attempting to give it an argument from the old syntax. thanks again | |