| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-05-22 | |||
| 10:24:53 | gtema | This will be likely covered same as for DNS during switching all of those methods to use service proxies | |
| 10:25:31 | gtema | I will start working on those next week | |
| 10:37:48 | ITD27M01_ | gtema: Do you mean that cloud.list_servers can be changed? | |
| 10:37:53 | ITD27M01_ | gtema: I want to invite you to participate in the discussion and review of the pull-request. | |
| 10:38:00 | ITD27M01_ | https://github.com/ansible/ansible/pull/51401 | |
| 10:39:18 | gtema | well, to be honest I see currently that cloud.list_servers already uses proxy layer, meaning all the filters should be already supported | |
| 10:39:56 | gtema | only that there is no filter for metadata | |
| 11:01:46 | ITD27M01_ | gtema: Only one caveat about inventory module in cloud. There is search_hosts method which uses the _utils._filter_list for filtering. | |
| 11:01:47 | ITD27M01_ | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/cloud/inventory.py#L79 | |
| 11:02:04 | openstackgerrit | Dmitriy Rabotyagov (noonedeadpunk) proposed openstack/openstacksdk master: Add ability to provide qos_policy_id for port https://review.opendev.org/660680 | |
| 11:06:18 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: baremetal: allow updating name and extra fields of an allocation https://review.opendev.org/660578 | |
| 11:06:44 | ITD27M01_ | gtema: Remembering the conversation about the division of filters into the server-side and client-side. I do not quite agree with this implementation - there will be a lot of calculations on the client side (in large installations). | |
| 13:11:35 | stingrayza | mnaser: could I pester you for an updated shipit on https://github.com/ansible/ansible/pull/56453 please? (it seems as if the changes I made after invalidated your original one) | |
| 13:11:55 | mnaser | stingrayza: let me have a look | |
| 13:12:02 | stingrayza | thanks! :) | |
| 13:12:33 | mnaser | stingrayza: voilaa | |
| 13:14:02 | stingrayza | mnaser: thanks a mil :) | |
| 13:37:09 | stingrayza | (I'd love a shipit from anybody else that can throw one up... https://github.com/ansible/ansible/pull/56453) | |
| 13:55:55 | stingrayza | mordred: :hat-tip: thanks :) | |
| 14:39:48 | openstackgerrit | Surya Seetharaman proposed openstack/python-openstackclient master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/659124 | |
| 16:46:48 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Add 'openstack server resurrect' command https://review.opendev.org/643578 | |
| 19:49:06 | openstackgerrit | Dean Troyer proposed openstack/osc-lib master: Final switch to stestr https://review.opendev.org/660815 | |
| #openstack-sdks - 2019-05-23 | |||
| 02:36:20 | openstackgerrit | Brin Zhang proposed openstack/python-openstackclient master: Add changes-before attribute to server list https://review.opendev.org/657373 | |
| 04:37:14 | openstackgerrit | Merged openstack/osc-lib master: Final switch to stestr https://review.opendev.org/660815 | |
| 06:00:53 | openstackgerrit | Chinmay Naik proposed openstack/keystoneauth master: Resolves a typo in a link to use Application Credentials https://review.opendev.org/660886 | |
| 06:38:23 | openstackgerrit | zhulingjie proposed openstack/keystoneauth master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/655016 | |
| 07:24:04 | openstackgerrit | ZhouHeng proposed openstack/python-openstackclient master: openstack port create support --extra-dhcp-option https://review.opendev.org/657519 | |
| 07:43:24 | openstackgerrit | ZhouHeng proposed openstack/python-openstackclient master: openstack port create support --extra-dhcp-option https://review.opendev.org/657519 | |
| 08:08:06 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Rework statistics reporting https://review.opendev.org/659841 | |
| 08:17:32 | dtantsur | mordred, gtema, 2x +2, anything blocking approval? https://review.opendev.org/#/c/660578/ | |
| 08:18:01 | gtema | :) - done | |
| 08:18:04 | dtantsur | thx! | |
| 08:37:16 | openstackgerrit | Merged openstack/osc-lib master: Dropping the py35 testing https://review.opendev.org/654659 | |
| 09:44:38 | openstackgerrit | Vishakha Agarwal proposed openstack/keystoneauth master: Bump bandit version and cap sphinx https://review.opendev.org/660956 | |
| 09:55:27 | openstackgerrit | Merged openstack/openstacksdk master: baremetal: allow updating name and extra fields of an allocation https://review.opendev.org/660578 | |
| 10:11:21 | openstackgerrit | Merged openstack/openstacksdk master: Add support for vendor hooks https://review.opendev.org/657848 | |
| 10:21:44 | openstackgerrit | Merged openstack/openstacksdk master: Add ability to provide qos_policy_id for port https://review.opendev.org/660680 | |
| 11:58:26 | openstackgerrit | Surya Seetharaman proposed openstack/python-openstackclient master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/659124 | |
| 12:26:48 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Add 'openstack server resurrect' command https://review.opendev.org/643578 | |
| 14:16:50 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Make 'destination' optional for live migration https://review.opendev.org/626949 | |
| 14:29:47 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Add 'openstack server resurrect' command https://review.opendev.org/643578 | |
| 14:52:48 | openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: Compute: Add user id support for keypair https://review.opendev.org/576507 | |
| 15:46:18 | openstackgerrit | Sergii Golovatiuk proposed openstack/openstacksdk master: Log OpenStackCloudResourceNotFound exceptions https://review.opendev.org/637169 | |
| 16:00:03 | edleafe | Wow! Time for another API-SIG Office Hour!! | |
| 16:03:15 | cdent | I wonder if the api-sig saw the discussion between me and cmurphy about the errors guideline? | |
| 16:03:59 | cdent | this thread: http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006377.html | |
| 16:04:21 | cdent | and colleen's comments: http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006425.html | |
| 16:05:30 | elmiko | o/ | |
| 16:05:57 | edleafe | I saw it, but I wasn't around for any of the original discussions, so I can't add much | |
| 16:11:35 | edleafe | elmiko: you +W'd that change - any impressions? | |
| 16:14:23 | elmiko | i'm reading now | |
| 16:14:55 | cdent | but if you've got stuff to say please add to the thread | |
| 16:17:05 | elmiko | i'm really not sure how to respond to colleen's question | |
| 16:17:23 | elmiko | i mean, having a list of errors seemed like a good idea at the time because more than one could be returned | |
| 16:17:44 | elmiko | i think it was also inspired by prior art within the openstack community | |
| 16:17:47 | edleafe | Are you aware of any other API that does anything similar? | |
| 16:17:56 | edleafe | jinxish | |
| 16:23:03 | elmiko | i vaguely recall at the time we had examples of others doing it that way | |
| 16:28:54 | elmiko | after looking around, maybe we just need to revisit that guideline? | |
| 16:29:15 | elmiko | i don't remember how we arrived at that, and i can't seem to find the reference materials | |
| 16:31:25 | edleafe | I don't understand the confusion surrounding this. Wouldn't a developer *want* to know about all the errors that happened? Usually the last error isn't the genesis of the problem. | |
| 16:32:38 | elmiko | right, and that goes in line with our thinking about having a possible list of errors | |
| 16:38:15 | logan- | hello! in a vendor config, is there a way to specify that a certain provider network is only available in a certain list of regions? I'm asking because https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/config/vendors/limestonenetworks.json#L22 is only available in the us-dfw-1 region. We had a user receiving errors when trying to schedule nodes in the us-slc region related to this network. | |
| 16:38:40 | logan- | the error was: http://paste.openstack.org/show/751177/, and it was worked around with a config for nodepool-launcher to exclude this network: https://github.com/ansible-network/windmill-config/pull/437/files | |
| 16:39:30 | mordred | logan-: yes - all of the settings that you can make can be tied to a region | |
| 16:39:41 | mordred | logan-: let me find you an example | |
| 16:41:03 | mordred | logan-: https://docs.openstack.org/openstacksdk/latest/user/config/configuration.html#per-region-settings | |
| 16:41:19 | mordred | logan-: the regions list can also be a list of dicts | |
| 16:41:31 | elmiko | edleafe: i need to fix an issue with my emails to the list, then i will respond to colleen | |
| 16:41:35 | logan- | thanks mordred | |
| 16:41:52 | edleafe | elmiko: thx | |
| 17:00:58 | elmiko | take care edleafe, have a nice holiday weekend =) | |
| 17:03:39 | edleafe | I shall! You too! | |
| 17:44:30 | openstackgerrit | Logan V proposed openstack/openstacksdk master: Update Limestone Networks vendor config https://review.opendev.org/661063 | |
| 17:45:00 | openstackgerrit | Logan V proposed openstack/openstacksdk master: Update Limestone Networks vendor config https://review.opendev.org/661063 | |
| 17:45:51 | openstackgerrit | Logan V proposed openstack/openstacksdk master: Update Limestone Networks vendor config https://review.opendev.org/661063 | |
| 20:34:53 | cmurphy | edleafe: elmiko cdent my issue is that if more than one error is returned, eg if nova fails because glance fails, I don't think it's the user's business to know what happened on the backend, it could even leak sensitive information, so it should just be nova's job to capture the error and reformat it as one error for the user, the operator has logs to see what really happened on the backend | |
| 20:49:13 | mordred | cmurphy, edleafe, elmiko: it can be confusing as well - because those errors are not actionable. I know we've gotten that at times in Infra - an error booting a node because there was some issue between nova and glance that had nothing to do with our boot command or the image contents | |
| 20:49:51 | mordred | so it tells us "blah blah cna't find /dev/xx05a blah blah ceph blah" - and it's both scary and makes us try to troubleshoot why we were trying to do something with ceph - and it turns out we're not we're just trying to boot a vm | |
| 20:50:03 | edleafe | cmurphy: I don't think that you should ever return internal details in a user-facing API, whether it's a single message or multiple. Your example of glance-level errors should only be on admin APIs | |
| 20:50:29 | mordred | edleafe: should and are have so many differences | |
| 20:50:41 | mordred | edleafe: (but I agree with you) | |
| 20:50:45 | edleafe | mordred: Guidelines are for "should" | |
| 20:50:49 | edleafe | :) | |
| 20:51:06 | mordred | edleafe: life is friendly in should | |
| 20:52:30 | edleafe | cmurphy: But to get back to your point: error messages and details should be informative. Packing every known bit of data in an error messages is just as bad as not including enough | |
| 20:53:04 | edleafe | cmurphy: So if there are more than one relevant bits of information about the error, they should be included, not just one of them | |
| 20:53:44 | edleafe | The guideline is more about how to handle multiple bits of information. It doesn't require that you include more than one, though | |
| 21:41:03 | elmiko | cmurphy: i don't think the intent was for a single service to bubble out errors from other services. i had always thought of it as a single service emitting multiple errors to a single call. | |
| 21:42:31 | elmiko | and i agree with edleafe re: the api not /requiring/ more than one | |
| 23:30:55 | openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: WIP: Deprecate openstack server migrate --host option https://review.opendev.org/659382 | |
| #openstack-sdks - 2019-05-24 | |||
| 00:11:03 | openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: WIP: Deprecate openstack server migrate --host option https://review.opendev.org/659382 | |
| 06:15:02 | cmurphy | edleafe: elmiko do you have an example of an API call that would emit more than one user-facing error for a single request? | |
| 06:15:27 | mfeder | dtroyer/mordred: Hi guys, Is there any chance to move forward with this one https://review.opendev.org/#/c/576507/ ? Thanks for answer. | |
| 09:35:41 | openstackgerrit | Merged openstack/openstacksdk master: Update Limestone Networks vendor config https://review.opendev.org/661063 | |
| 09:55:04 | openstackgerrit | Vishakha Agarwal proposed openstack/keystoneauth master: Blacklist bandit 1.6.0 & cap sphinx for 2.7 https://review.opendev.org/660956 | |
| 10:20:59 | openstackgerrit | Vishakha Agarwal proposed openstack/keystoneauth master: Blacklist bandit 1.6.0 & cap sphinx for 2.7 https://review.opendev.org/660956 | |
| 13:14:20 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Add changes-before attribute to server list https://review.opendev.org/657373 | |
| 14:47:39 | Shrews | mordred: did you get any info on that os_port PR? | |
| 14:48:08 | Shrews | weird that it hasn't merged | |