| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-04-01 | |||
| 19:57:48 | jroll | ^ fairly easy review :) | |
| 20:03:21 | cyberpear | looks good to me | |
| 20:06:01 | dtroyer | jroll: Really, we didn't already do that? /me shakes head… | |
| 20:06:20 | jroll | right? I was surprised | |
| #openstack-sdks - 2019-04-02 | |||
| 07:46:09 | openstackgerrit | Cao Xuan Hoang proposed openstack/openstacksdk master: Expose locked status for Server https://review.openstack.org/648931 | |
| 08:51:42 | pas-ha | hi all, plz review https://review.openstack.org/#/c/564200 (add user password locking capabilities to openstack CLI, supported by Keystone since Rocky) | |
| 10:21:34 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Move Orchestration methods into Proxy https://review.openstack.org/649273 | |
| 10:40:34 | mordred | gtema: nice call on importing resource into normalize :) | |
| 10:41:17 | mordred | gtema: I think you probably already have thought this - but once we're done squishing all of these things together, I hope _normalize.py goes away and we just use the Resource definitions to define the data models | |
| 11:20:33 | openstackgerrit | Merged openstack/os-api-ref master: trivial: Remove unused attribute https://review.openstack.org/649079 | |
| 13:40:19 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Volume backup functional test tweak https://review.openstack.org/649327 | |
| 13:41:53 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Allow dynamic properties on Resource https://review.openstack.org/649329 | |
| 14:44:08 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Move Orchestration methods into Proxy https://review.openstack.org/649273 | |
| 16:24:22 | Shrews | mordred: i was thinking a bit about the statsd key formatting issue (wrt to nodepool). it'd be convenient if the caller could pass a method to use to format the key. but looking at how we pass the statsd info all the way down to Proxy... geesh that's a mess. adding a new param for the formatting func is painful. | |
| 16:25:10 | mordred | Shrews: yeah - I thought about a similar thing and had a similar self response | |
| 16:25:11 | Shrews | somehow factoring that portion out would be ideal.... | |
| 16:25:50 | mordred | like - we COUDL support pushing a formatting filter function - but oy | |
| 16:26:01 | Shrews | yyeah | |
| 17:24:01 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Make 'destination' optional for live migration https://review.openstack.org/626949 | |
| 17:24:16 | stephenfin | I apologize in advance for ^ but it's the best I could do | |
| 17:45:50 | openstackgerrit | Merged openstack/python-openstackclient master: Ignore case in security group rule --ethertype https://review.openstack.org/649174 | |
| 17:56:54 | mordred | stephenfin: I am going to defer to mriedem on that - he has opinions - I have pinged him in nova channel | |
| 18:05:12 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Move Orchestration methods into Proxy https://review.openstack.org/649273 | |
| 18:35:51 | Shrews | mordred: i'm not seeing any reason why statsd clients seem to be instantiated per-CloudRegion. the clouds.yaml section for statsd appears to be at the top level, yeah? (i couldn't actually find examples) | |
| 18:36:51 | Shrews | i think maybe we could move instantiation to Connection and maybe use a singleton for stats reporting | |
| 18:37:31 | Shrews | *then* it would be easier to add a custom key formatter | |
| 18:38:37 | Shrews | maybe... /me tosses around words and ideas like wet cats | |
| 22:13:13 | mordred | Shrews: hrm. good point re: clouds.yaml - although the client object can be passed in per-connection. - so yeah, maybe a singleton something something I like where you're thinking | |
| #openstack-sdks - 2019-04-03 | |||
| 04:28:08 | openstackgerrit | Merged openstack/openstacksdk master: Expose locked status for Server https://review.openstack.org/648931 | |
| 06:50:00 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Move Orchestration methods into Proxy https://review.openstack.org/649273 | |
| 07:01:56 | mordred | dtantsur: if you get a minute - I believe I have addressed your review concerns: https://review.openstack.org/#/c/639760/ | |
| 09:46:35 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Move Orchestration methods into Proxy https://review.openstack.org/649273 | |
| 09:52:26 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Move Orchestration methods into Proxy https://review.openstack.org/649273 | |
| 10:30:52 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Allow specifying destination for cold migrations https://review.openstack.org/649574 | |
| 10:30:52 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Make 'destination' optional for live migration https://review.openstack.org/626949 | |
| 11:06:14 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Move Orchestration methods into Proxy https://review.openstack.org/649273 | |
| 12:26:28 | Shrews | mordred: i have some in-flux code i'll post when i'm more coffeed up | |
| 13:25:31 | openstackgerrit | David Shrewsbury proposed openstack/openstacksdk master: WIP: Stats singleton https://review.openstack.org/649610 | |
| 13:26:26 | Shrews | mordred: that ^^ is where I got to yesterday with unwinding the stats pass-thru stuff before I hit CloudRegion. but that's sort of what I was thinking (which may still be bad) | |
| 13:32:14 | Shrews | mordred: not being very familiar with the new keystoneauth task management, i'm also not sure if there may be badness around multiple thread things and a singleton we define/use | |
| 13:33:30 | mordred | Shrews: shouldn't be. the keystoneauth approach is to manage a sempahore and let concurrency come from whatever app-level concurrency exists | |
| 13:33:56 | mordred | Shrews: we would just need to make sure that whatever singleton we defined was itself thread-safe | |
| 13:35:48 | openstackgerrit | Jeremy Houser proposed openstack/python-openstackclient master: Moved skiptest to setUpClass in order to avoid failures in test_snapshot and test_volume_transfer due to presence of openstack commands within setUpClass https://review.openstack.org/648760 | |
| 15:29:09 | tosky | dtroyer: hi! Back to our discussion about openstackclient-check-plugins failing on stable branches from few weeks ago... is there anything that can be done? | |
| 15:57:08 | dtroyer | cancel my meetings? | |
| 15:58:00 | dtroyer | tosky: I'm sure there is, I don't have that in my head at the moment but yeah, this is a good time to clean that up | |
| 16:02:09 | tosky | dtroyer: I can't help with your meetings :) but I can help with the implementation of a technical solution, if any; I'm just not sure about the right fix | |
| 16:23:41 | openstackgerrit | Merged openstack/openstacksdk master: Add support for generating form-post signatures https://review.openstack.org/639760 | |
| 18:49:29 | johnsom | Is there a reason we don't have http://git.openstack.org/cgit/openstack/python-openstackclient/tree/openstackclient/network/v2/_tag.py in osc_lib? | |
| 18:50:41 | johnsom | Octavia is also doing tags and would like to share that code. | |
| 18:50:48 | openstackgerrit | Jeremy Houser proposed openstack/python-openstackclient master: Prevent setUpClass failures in volume v1 tests https://review.openstack.org/648760 | |
| 18:52:19 | johnsom | I will sign up to "make that happen" if there are no objections. | |
| 19:14:47 | dtroyer | johnsom: probably because it originated there and nobody else has asked yet. I look forward to watching you make that happen :) | |
| 19:15:24 | johnsom | Ok, just wanted to check before effort was expended. | |
| 19:15:39 | dtroyer | np, and thank you | |
| 19:42:49 | openstackgerrit | Merged openstack/openstacksdk master: Move set_temp_url_key logic into resource objects https://review.openstack.org/648347 | |
| 19:42:50 | openstackgerrit | Merged openstack/openstacksdk master: Remove and rearrange object bonged proxy tests https://review.openstack.org/648352 | |
| #openstack-sdks - 2019-04-04 | |||
| 09:49:54 | dtantsur | dustinc, mordred, I've started an etherpad on missing bare metal features in SDK: https://etherpad.openstack.org/p/openstacksdk-baremetal-gaps | |
| 09:50:04 | dtantsur | TheJulia: ^^ | |
| 10:50:34 | brtknr | mordred: sorry to miss you at the OpenInfra days, I was looking forward to your workshop, hope you're feeling better now! | |
| 10:50:47 | brtknr | Are you able to take a look at this again by any chance: https://github.com/ansible/ansible/pull/53757 | |
| 10:51:02 | brtknr | Any idea what it will take to take things forward? | |
| 11:42:03 | mordred | brtknr: yes - I'm also sorry to have missed you and sorry I couldn't give the workshop! :( | |
| 11:45:12 | mordred | brtknr: although - don't hate me - we just had to release an 0.27.0 for senlin with a backported patch off of stable/stein - so we need to bump that protective version to 0.28.0 | |
| 11:45:45 | mordred | brtknr: but if you can do that real quick, I'll leave another shipit, and we'll get mnaser to do the same and it'll land | |
| 11:46:10 | cdent | fair | |
| 11:46:15 | gtema | yeah, I would also like to see SDK release with latest changes | |
| 11:46:27 | mordred | yes. I agree with that | |
| 11:46:35 | mordred | but I think we're not releasing for train yet | |
| 11:46:52 | gtema | mordred: how to become a maintainer in Ansible, so that I can help with PRs | |
| 11:46:58 | mordred | as soon as we are, we can cut one | |
| 11:47:04 | gtema | mordred: ok | |
| 11:47:11 | mordred | gtema: congratualtions, you're a maintainer | |
| 11:47:21 | gtema | wow, that was fast | |
| 11:47:26 | gtema | thanks a lot | |
| 11:48:26 | mordred | (srrsly, I need to make a patch to a file in the repo - and should get mnaser and/or Shrews and/or someone else to ack it) | |
| 11:48:46 | gtema | :D | |
| 11:49:37 | gtema | where is this file hidden? I was not able to find it | |
| 11:50:31 | mordred | oh - I may not know what I'm talking about anymore - | |
| 11:50:50 | mordred | gtema: we may want to wait for mnaser to be around - I may not actually know how this works anymore | |
| 11:51:05 | gtema | ok, no problem | |
| 11:51:31 | gtema | I was also expecting a special file, but can't find anything | |
| 11:51:54 | brtknr | mordred: mnaser: I've bumped the min_version up to 0.28.0 so ready for your magic handwaving :) | |
| 11:52:20 | mordred | brtknr: done | |
| 11:52:22 | mordred | Shrews: ^^ | |
| 11:53:32 | brtknr | mordred: thanks :D | |
| 11:53:34 | mordred | gtema: nevermind. I'm stupid. .github/BOTMETA.yml | |
| 11:53:52 | mordred | gtema: I was searching for mordred, but my github id is emonty because of sadness | |
| 11:54:19 | gtema | mordred: wow, I think I felt off the file somewhere at top | |
| 11:55:59 | brtknr | thanks gtema :D | |
| 11:56:10 | gtema | brtknr: wlcm | |
| 11:59:09 | gtema | ah, the Ansible bot is picky today. It also failed for me - can't find commit | |
| 11:59:25 | gtema | I mean shippable | |
| 12:00:02 | mordred | gtema: https://github.com/ansible/ansible/pull/54850 | |
| 12:00:32 | gtema | thanks a lot mordred | |
| 12:01:02 | Shrews | mordred: brtknr: shippable doesn't seem happy with that | |
| 12:01:27 | mordred | Shrews: I'm sure I'm a bad person | |
| 12:01:28 | gtema | Shrews - it is necessary to kick it | |
| 12:02:36 | Shrews | i do not know how one kicks shippable, but i can kick mordred if that makes things better | |
| 12:02:47 | gtema | :D | |