| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-03-12 | |||
| 22:54:26 | kmalloc | so a little of ksa fixing and SDK is smart enough to know how to do things | |
| 22:54:44 | kmalloc | unscoped tokens suck =/ | |
| 23:15:24 | mordred | kmalloc: ++ | |
| 23:15:46 | mordred | kmalloc: and yeah - I think it's possible that the only issue here is how sdk is creating ksa objects | |
| 23:16:04 | mordred | rather than a ksa deficiency itself - but if there is a deficiency, hopefully it's an easy enough one to fix | |
| #openstack-sdks - 2019-03-13 | |||
| 07:49:51 | kailun | amotoki: hi | |
| 07:49:59 | amotoki | kailun: hi | |
| 07:51:34 | kailun | amotoki: regarding L193 in review 624798, there is another case, that is --shared, --private and --project are all not specified | |
| 07:52:27 | kailun | amotoki: in this situation, we should consider the created range to be a "shared" one, which means "project_id" should not be populated into the attr | |
| 07:53:14 | amotoki | kailun: before digging into the detail, let me sort out which patterns are possible. | |
| 07:53:55 | kailun | amotoki: based on the current logic, this'll goto L205 which populates attrs w/ the current project_id, this is not expected | |
| 07:54:41 | kailun | amotoki: sure | |
| 07:55:22 | amotoki | kailun: possible patterns are (a) none of --shared, --private and --project are specified (b) --shared only (c) --private only (d) --private and --project | |
| 07:55:24 | kailun | amotoki: we should have 6 patterns I guess? | |
| 07:55:41 | amotoki | kailun: the above are valid, right? | |
| 07:56:05 | amotoki | kailun: (e) --project only and (f) --project and --shared are invalid. | |
| 07:56:36 | kailun | amotoki: right | |
| 07:57:16 | amotoki | kailun: regarding L.193, I think the previous logic looks enough. | |
| 07:58:00 | amotoki | it is because "if not parsed_args.private and parsed_args.project" (L.171) catches (e) and (f) cases. | |
| 07:58:02 | amotoki | right? | |
| 07:58:11 | kailun | amotoki: yes, I agree | |
| 07:58:26 | kailun | amotoki: L205 is needed | |
| 07:58:46 | amotoki | kailun: looking at L.205 now | |
| 08:00:29 | amotoki | kailun: L.182-186 ensures attrs['shared'] is False only when --private is specified, so "elif not attrs['shared']" at L.205 looks enough. | |
| 08:00:50 | amotoki | kailun: I mean "and not parsed_args.shared" looks unnecessary at L.205. | |
| 08:01:37 | kailun | amotoki: agree | |
| 08:02:07 | amotoki | kailun: thanks for clarification. I try to simplify the logic for easy maintenance. | |
| 08:02:45 | amotoki | kailun: I will add a note to the review based on this discussion. | |
| 08:03:10 | kailun | amotoki: I kind of know that some conditions are necessary when I write that patch, I just want to make it easier from a semantic level | |
| 08:03:37 | kailun | amotoki: anyway, great thanks for your review, make sense to me | |
| 08:03:45 | amotoki | kailun: yw | |
| 08:03:58 | kailun | *unnecessary | |
| 08:06:32 | amotoki | kailun: I post follow-up comments in your review. thanks | |
| 08:06:57 | kailun | amotoki: sure, thanks much | |
| 08:10:42 | openstackgerrit | Kailun Qin proposed openstack/python-openstackclient master: Fix: incorrect check when no shared/private input https://review.openstack.org/642708 | |
| 08:48:34 | openstackgerrit | Merged openstack/python-openstackclient master: Delete the LB object quotas set command in openstackclient https://review.openstack.org/576465 | |
| 11:03:37 | openstackgerrit | Merged openstack/openstacksdk master: Collapse OpenStackSDKAdapter into Proxy https://review.openstack.org/642231 | |
| 12:41:37 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use auth_url as identity endpoint when not project scoped https://review.openstack.org/643037 | |
| 12:42:13 | mordred | cmurphy, kmalloc, adriant: ^^ I think that should do the trick re: yesterday's discussion of unscoped identity operations | |
| 15:17:32 | openstackgerrit | Glenn Van de Water proposed openstack/python-openstackclient master: Fix service discovery in functional tests https://review.openstack.org/642074 | |
| 16:10:33 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: WIP Split OpenStackCloud into reasonable pieces https://review.openstack.org/642218 | |
| 18:05:38 | mordred | cmurphy, kmalloc: does a domain scoped token get a catalog in its token? | |
| 18:17:57 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use auth_url as identity endpoint when not project scoped https://review.openstack.org/643037 | |
| 18:51:28 | cmurphy | mordred: yes it's basically the same as a project token | |
| 18:52:39 | mordred | kk. cool. so that update should make more sense then | |
| 19:11:19 | cmurphy | cool | |
| 19:27:10 | mordred | cmurphy: so ... there is a possibly completely ill-conceived feature in sdk that your review comment has indicated to me that I should fix | |
| 19:27:30 | cmurphy | \o/ | |
| 19:40:45 | mordred | cmurphy: oh - no - we already do the correct thing. double \o/ | |
| 19:41:42 | cmurphy | awesome | |
| 19:42:24 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use auth_url as identity endpoint when not project scoped https://review.openstack.org/643037 | |
| 19:42:32 | mordred | cmurphy: I think *that* should be correct now | |
| 19:46:59 | cmurphy | mordred: lgtm | |
| 19:47:05 | mordred | yay | |
| 19:47:12 | mordred | thanks for the reviews there | |
| 19:47:37 | cmurphy | np | |
| 21:30:54 | adriant | mordred: will take a look! | |
| 21:41:17 | mordred | adriant: uhoh. maybe I should fix the tests ... | |
| 21:41:39 | adriant | Yes, test is busted :P | |
| 21:42:48 | adriant | oh and mordred, I'll have a new patch up for the Project Resource Cleanup goal hopefully today which rewrites it as additions to the SDK | |
| 21:45:46 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use auth_url as identity endpoint when not project scoped https://review.openstack.org/643037 | |
| 21:53:11 | mordred | adriant: woot! | |
| 21:53:24 | mordred | adriant: (woot on resource cleanup goal) | |
| 21:53:54 | mordred | adriant: also - I think that latest patch is better from a testing perspective - the previous break was due to being lazy and trying to reuse an exitsing test fixture | |
| 22:03:37 | kmalloc | hah =/ | |
| 22:15:12 | brtknr | hey all, how do i make sure os_stack ansible module passes tag arg correctly to update_stack function? | |
| 22:22:26 | brtknr | the server is returning this error: File \"/usr/lib/python2.7/dist-packages/heat/engine/parameters.py\", line 554, in _validate_user_parameters\n raise exception.UnknownUserParameter(key=param)\n\nUnknownUserParameter: The Parameter (tags) was not defined in template. | |
| 22:22:46 | brtknr | IIUC, tags is not a user parameter | |
| #openstack-sdks - 2019-03-14 | |||
| 00:16:51 | openstackgerrit | Bharat Kunwar proposed openstack/openstacksdk master: Do not disregard tags when updating stacks https://review.openstack.org/643195 | |
| 00:22:52 | openstackgerrit | Bharat Kunwar proposed openstack/openstacksdk master: Do not disregard tags when updating stacks https://review.openstack.org/643195 | |
| 00:25:32 | openstackgerrit | Bharat Kunwar proposed openstack/openstacksdk master: Do not disregard tags when updating stacks https://review.openstack.org/643195 | |
| 02:33:11 | adriant | mordred: patch is good. And I forget I still have +2 powers on the SDK. But with the cleanup goal coming that will probably be useful! | |
| 02:33:21 | adriant | I just tested it with: conn = connection.Connection(auth=dict(auth_url=os.environ.get('OS_AUTH_URL'), username=os.environ.get('OS_USERNAME'), password=os.environ.get('OS_PASSWORD'), user_domain_name='default')) | |
| 02:33:36 | adriant | and then: list(conn.identity.user_projects(conn.session.get_user_id())) | |
| 07:58:29 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: WIP Split OpenStackCloud into reasonable pieces https://review.openstack.org/642218 | |
| 08:53:54 | openstackgerrit | Bharat Kunwar proposed openstack/openstacksdk master: Do not disregard tags when updating stacks https://review.openstack.org/643195 | |
| 12:01:32 | openstackgerrit | Pierre Riteau proposed openstack/openstacksdk master: Do not disregard tags when updating stacks https://review.openstack.org/643195 | |
| 12:24:59 | openstackgerrit | Pierre Riteau proposed openstack/openstacksdk master: Do not disregard tags when updating stacks https://review.openstack.org/643195 | |
| 13:51:05 | mordred | adriant: \o/ | |
| 14:18:38 | mordred | Shrews: if you have a minute - mind reviewing https://review.openstack.org/#/c/614834 today ? we need it for the nodepool patches | |
| 14:19:45 | Shrews | mordred: ack | |
| 14:25:37 | Shrews | mordred: are counter stats for statsd the only thing we're going to use? | |
| 14:26:06 | Shrews | s/thing/stats type/ | |
| 14:28:45 | mordred | Shrews: they're the only thing we have been using I think? | |
| 14:29:07 | mordred | Shrews: I basically grabbed the statsd code from the nodepool taskmanager and shoved it in there | |
| 14:29:42 | Shrews | mordred: hrm, i thought nodepool made use of gauge stats somewhere | |
| 14:30:01 | Shrews | mordred: i'll look more in a bit. gotta afk for an appt for a few | |
| 14:30:16 | mordred | Shrews: I think it does - but not for sdk operations | |
| 14:31:12 | mordred | Shrews: fwiw - I also started working on an abstraction library: https://review.openstack.org/#/c/621295/ | |
| 14:40:53 | openstackgerrit | Merged openstack/promstat master: Change openstack-dev to openstack-discuss https://review.openstack.org/622346 | |
| 15:01:28 | edleafe | For you DST-challenged folks, the API-SIG Office hour starts one hour from now | |
| 15:56:20 | gtema | dtantsur: where have you left your mobile in Frankfurt going to USA Embassy? I am hopefully going to the Summit I will manage everything in time | |
| 15:57:20 | dtantsur | gtema: I left at the hotel. but in practice, despite ugly warnings, they accept mobile phones for storing at the security | |
| 15:58:09 | gtema | dtantsur: ok, thanks. It is really interesting. I am traveling with a train for a day, so hotel is no option. | |
| 15:58:42 | dtantsur | gtema: I guess it takes you less time to get there :) | |
| 15:59:04 | gtema | that's for sure | |
| 15:59:17 | dtantsur | for me the fastest ICE is 4 hours, I think | |
| 15:59:18 | gtema | but not if you mean train - 3 hours | |
| 15:59:22 | gtema | ah, ok | |
| 15:59:44 | gtema | and I am not with ICE: RB+RE+ICE | |