Posted	Nick	Remark
#openstack-sdks - 2019-02-26
11:10:17	mordred	oh nice!
11:10:41	mordred	well then maybe I should come to germany to get some nice weather
11:11:04	gtema	yeah, heard already of weather in US :D
11:16:35	mordred	dtantsur: oh goodie. your second comment opens up a whole giant can of worms
11:16:55	dtantsur	which one was the second? :)
11:17:03	mordred	dtantsur: the one after the first ;)
11:17:08	dtantsur	ah, got it
11:17:10	dtantsur	:D
11:17:16	mordred	the one about avoiding the race by returning image_id
11:17:34	mordred	I don't think we can do that - because the method should also work well for people calling it directly on the Proxy - which means we need to return an Image
11:17:36	mordred	BUT
11:18:23	dtantsur	well, for example, baremetal.list_node_vifs return port IDs without trying to convert them to ports (largely because somewhere on the Earth there may be a downstream ironic plugin where VIF IDs are not port IDs)
11:18:29	mordred	we can't just return Image(image_id) - because we don't know what version of the image service we need
11:19:17	mordred	so we'd need, I guess, to use the image proxy class to get an Image resource only populated with the image_id
11:19:37	mordred	and then the shade layer - and other callers - can call wait_for_image on that Image if they want to
11:20:20	gtema	image_id and probably name (it shouldn't be changed anyway)
11:21:18	mordred	yeah
11:59:36	dtantsur	lazy loading of other attributes anyone? :)
11:59:50	dtantsur	I think having a half-populated Resource is even more confusing than returning image_id tbh
12:18:55	openstackgerrit	Artem Goncharov proposed openstack/python-openstackclient master: add multiple attributes to image from APIv2.7 https://review.openstack.org/637528
13:37:29	holser__	dtantsur I reworked https://review.openstack.org/637169
13:37:46	dtantsur	cool. I'm leaving now, can review on Thu
13:37:56	holser__	ok, thanks
15:52:00	tssurya	I have a client side chane here which is sort of the last piece of a blueprint: https://review.openstack.org/#/c/633579/ , reviews would be really appreciated, thanks in advance!
15:52:10	tssurya	s/chane/change
16:59:13	gtema	dtroyer, amotoki osc question: what is the best way to make utils.find_resource find resource, if `list` should be called with a special flag. When image.os_hidden flag is set to true image can be found by name only with `list(os_hidden=True)` - https://review.openstack.org/#/c/637528/
17:24:32	cdent	elmiko, dtantsur|afk, edleafe : I'm looking at my old api-design doc at https://review.openstack.org/#/c/592003/ and wondering where in my head I should prioritize revisiting it on a scale of never to asap. Thoughts?
17:31:46	edleafe	cdent: While I think it's a worthwhile effort, it seems to me that the shared storage discussion could be applied here
17:33:06	cdent	In my head it's sort of a "thing to do when I need to think about something else". But I'm not certain I will ever think about it well or enough to be useful beyond some very anodyne cliches.
17:33:40	cdent	but yeah
17:33:50	cdent	I think I'll set it aside
17:35:00	cdent	done
17:45:57	edleafe	That seems more like a topic for a book than a guideline of a few paragraphs
17:47:35	cdent	you send me the huge advance, i'll write the book
17:59:17	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "name" filter in "list" call when retrieving a single register https://review.openstack.org/637238
18:07:39	elmiko	cdent: i generally agree with edleafe. while i think it would be a lovely doc to have, it could also become a never-ending windmill to tilt at.
18:08:08	elmiko	so, i guess unless o'reilly shows up with a check and a bw picture of a cute animal...
18:08:35	elmiko	although, i would _love_ to see an o'reilly book with a line art bagpus on it XD
18:09:27	elmiko	*bagpuss
18:09:34	fungi	so... for you sdk wonks, some of whom may also be storyboard users/fans, there is a feature in progress to store attachments in swift. the bulk of the backend interface implementation is proposed in https://review.openstack.org/633365 and i'm wondering if anyone would like to weigh in on unified python sdk vs swiftclient there
18:10:10	fungi	mordred: ^ not sure if you're around but you often have strong opinions on things
18:12:43	fungi	this initial version just authenticates directly to swift, so ought to work well with standalone/dedicated swift deployments. i don't know enough about the unified sdk to know whether it complicates standalone swift use cases
18:23:11	openstackgerrit	Rajat Dhasmana proposed openstack/python-openstackclient master: Disabling c-backup service for osc-functional-devstack-tips job https://review.openstack.org/639410
18:26:03	openstackgerrit	Rajat Dhasmana proposed openstack/python-openstackclient master: Fix: Restore output 'VolumeBackupsRestore' object is not iterable https://review.openstack.org/624860
19:04:47	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "name" filter in "list" call when retrieving a single register https://review.openstack.org/637238
19:10:41	mordred	fungi: I recommend using sdk - I feel that nobody should ever use the python-*client libraries for any purpose
19:11:11	mordred	fungi: that said - I have never used it with standalone swift
19:34:45	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Use mock context in test_fwaas https://review.openstack.org/639421
#openstack-sdks - 2019-02-27
06:35:24	openstackgerrit	Rajat Dhasmana proposed openstack/python-openstackclient master: Fix: Restore output 'VolumeBackupsRestore' object is not iterable https://review.openstack.org/624860
06:56:33	openstackgerrit	Kailun Qin proposed openstack/python-openstackclient master: Add network segment range command object https://review.openstack.org/625544
08:07:08	openstackgerrit	Christian Schneemann proposed openstack/python-openstackclient master: Typo fix https://review.openstack.org/635471
09:33:14	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "name" filter in "list" call when retrieving a single register https://review.openstack.org/637238
09:49:54	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Tweak find_image method to search in hidden images https://review.openstack.org/639613
09:57:48	openstackgerrit	Slawek Kaplonski proposed openstack/openstacksdk master: Add agent property: resources-synced https://review.openstack.org/635143
12:37:49	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "name" filter in "list" call when retrieving a single register https://review.openstack.org/637238
12:47:47	openstackgerrit	Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Paginate over usage list to return all usages https://review.openstack.org/639652
13:28:50	openstackgerrit	Merged openstack/openstacksdk master: Add agent property: resources-synced https://review.openstack.org/635143
14:31:53	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Add glance image import support https://review.openstack.org/639122
14:31:53	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Move image methods to sdk image proxy https://review.openstack.org/609684
14:31:56	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Use retriable_status_codes in image upload https://review.openstack.org/639679
14:32:33	mordred	dtantsur|afk: 639679 is a great idea - thanks - but it's also not working with the mocks on one test
14:33:01	mordred	cmurphy, kmalloc: ^^ pinging you as well, as it might be a keystoneauth issue - but it might just be an issue with the test mocks
14:33:33	gtema	mordred: wow, lot to review to guys ;-)
14:34:01	mordred	gtema: :)
14:34:16	gtema	one choco would be not enough
14:36:12	gtema	I would like us to complete image, so that it doesn't look like a mess to add missing bits to image (for OSC)
14:41:10	cmurphy	mordred: o7
14:42:14	mordred	gtema: ++
14:51:10	kmalloc	Hmmm
15:21:01	kmalloc	weird.
15:35:41	kmalloc	mordred: uhm, do we need to explicity set a status_code_retries for 639679?
15:37:14	openstackgerrit	Rajat Dhasmana proposed openstack/python-openstackclient master: Fix: Restore output 'VolumeBackupsRestore' object is not iterable https://review.openstack.org/624860
15:38:30	openstackgerrit	Rajat Dhasmana proposed openstack/python-openstackclient master: Fix: Restore output 'VolumeBackupsRestore' object is not iterable https://review.openstack.org/624860
16:03:26	kmalloc	mordred: i don't think it's a KSA side, but it totally could be something subtle
16:04:16	holser|lunch	good morning
16:05:16	holser_	mordred could you have a look at https://review.openstack.org/#/c/637169/ I have addressed your concerns
16:06:12	holser_	thanks
16:43:41	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Use retriable_status_codes in image upload https://review.openstack.org/639679
16:43:42	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Add glance image import support https://review.openstack.org/639122
16:43:57	mordred	kmalloc: found it - turns out you have to set status_code_retries :)
16:44:26	kmalloc	:P
16:46:54	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "name" filter in "list" call when retrieving a single register https://review.openstack.org/637238
16:52:49	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Add DNS support https://review.openstack.org/623009
17:05:56	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Tweak find_image method to search in hidden images https://review.openstack.org/639613
17:10:19	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Add DNS support https://review.openstack.org/623009
17:16:41	kmalloc	mordred: I'm glad it was a "whoopse missed that" instead of a ksa bug.
17:20:20	mordred	kmalloc: me too. it would have been a pretty bad bug if it had been a bug :)
17:44:48	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: WIP Add support for generating form-post signatures https://review.openstack.org/639760
18:13:49	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: WIP Add support for generating form-post signatures https://review.openstack.org/639760
18:33:00	cdent	Is it the case that openstackclient is not always happy with python 3.5?
18:42:08	cdent	ah appears to be a problem in the openstack module itself
18:45:24	dtroyer	cdent: I am not aware of such an issue
18:47:16	cdent	dtroyer: it seems to be only 3.5, and it looks like it might actually be coming from openstack.exception (as that's one of the few places I can find that is using json.loads directory and it is only when interpreting error responses)
18:47:58	cdent	http://logs.openstack.org/17/639717/2/check/osc-placement-dsvm-functional-py3/fefe661/logs/devstack-gate-post_test_hook.txt.gz#_2019-02-27_17_20_52_120
18:48:23	cdent	unfortunately I don't have a working python3.5 env to hand, so I'm casting about a bit
18:49:33	cdent	and json.loads definitely changed between 3.5 and 3.6
18:52:09	cdent	ayup, that's it
18:54:56	cdent	ugh, but from where...
18:55:56	cdent	got it, the problem is localized to osc-placement, that's good
19:23:39	openstackgerrit	Merged openstack/keystoneauth master: Expose app creds and new attrs in fixtures https://review.openstack.org/636030

Earlier   Later