Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-01-08
15:03:45 mordred what we might need to do is add support for registered_limit in sdk and have the sdk force the system-scope auth regardless of what parameters are otherwise set then update osc to use sdk for these calls
15:04:19 mordred but - let's see if that works first
15:07:48 frickler mordred: doesn't work in my local tests, you cannot use an empty string at that location
15:08:00 mordred blerg
15:08:44 mordred a potentially easier fix would be to update the test runner to not source the env vars but instead to add an --os-cloud command line option to self.openstack in the tests
15:09:18 mordred frickler: do you have the ability to test if --os-project-id='' works if the project-id is coming from clouds.yaml instead of from env vars?
15:09:23 mordred oh - you know what?
15:09:32 frickler mordred: but that sounds ... modern
15:09:45 mordred we could make a new devstack user in clouds.yaml - devstack-system - that would not have project stuff set in teh first place and have system-scoped: all
15:09:55 frickler mordred: also, you could simple use a different cloud ... yeah
15:10:04 mordred I think that sounds like the best bet to me
15:10:19 mordred I'm going to start by changing the func test setup to use --os-cloud instead of env var
15:10:44 mordred and then work on getting an additional clouds.yaml entry for devstack
15:10:51 frickler mordred: the different cloud user should probably be in devstack by default
15:10:54 mordred yah
15:10:57 mordred totally agree
15:11:08 mordred I think it'll be a nice addition to devstack for folks
15:11:54 frickler o.k., I'm away for a bit, I can do reviews later
15:14:07 lbragstad frickler mordred yeah - that's what i do
15:14:18 lbragstad super handy for switching profiles
15:15:24 lbragstad i used it a bunch in a demo, trying to explain scopes https://youtu.be/A1vP6be1U5U?t=353
15:19:05 openstackgerrit Merged openstack/openstacksdk master: Skip block storage v2 functional tests for a minute https://review.openstack.org/629162
15:22:03 mordred gtema: did you see dtantsur's comment on https://review.openstack.org/#/c/621153/ - it came on a +A and was a suggestion for followup, just wanted to make sure you didn't miss it
15:22:41 gtema mordred: yupp, have seen but have a "disaster" at work which I need to take care of
15:22:59 mordred gtema: ugh. "disasters" are the worst. have fun with that
15:23:09 gtema thanks
15:23:22 mordred gtema: is the "disaster" caused by someone else's lack of planning? I really love those
15:24:02 gtema no, it is caused by someone leaving the company and others on a long vacation and suddenly certificates stoped working
15:31:04 mordred gtema: oh double ugh
15:31:19 mordred lbragstad, frickler: remote: https://review.openstack.org/629235 Add a devstack-system cloud for system scoped actions
15:37:35 lbragstad mordred nice, thanks
15:46:06 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Use devstack-system cloud for limit tests https://review.openstack.org/629203
15:46:07 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Use os-cloud instead of OS env vars for functional tests https://review.openstack.org/629243
15:46:33 mordred lbragstad, frickler: ^^ and there's the OSC update to use clouds.yaml - and then to use devstack-system for the limits tests
15:48:25 mordred mmm. donuts. is there nothing they can't do?
16:01:53 openstackgerrit Bruno HALEBLIAN proposed openstack/openstacksdk master: implement identity v3 Proxy "unassign_project_role_from_user" https://review.openstack.org/629073
16:09:11 dtroyer to temporarily unset an env var
16:52:24 frickler dtroyer: I've been testing whether that works, so the idea sounds plausible, but I'm not sure whether it would be worth the code complexity. maybe a global --ignore-environment option instead? but then, using all these options should be deprecated in favor of --os-cloud anyway, so probably let's just work with the latter
17:07:20 dtroyer frickler: my reasoning for the precedence we have (cli options > env vars > clouds.yaml) is because of exactly this case, where you generally want your environment to contain the "normal" setup and can override on the command line for the exceptions.
17:07:46 dtroyer I'm not sure a global 'ignore env' is right, I might only want to change one or two things, project being the one I run into myself most
17:09:42 mordred dtroyer: I thinkm --no-project would be a great addition
17:10:39 mordred dtroyer: although ultimately I'd like for people to be able to use these limit commands without needing to always set --os-system-scope --no-os-project-id --no-os-project-name --no-domain-id --no-domain-name ... because that just seems like we're abusing people :)
17:10:47 mordred that'll be a longer effort though
17:11:51 mordred be I definitely think being able to blank out specific things is a good idea
17:12:18 dtroyer mordred: I think I am behind on the keystone/ksa stuff around system scope, is that a thing we can (or should?) just assume for commands like this?
17:25:02 mordred dtroyer: I think for _this_ one it is? like - from this morning's interaction I'm pretty sure we want to make the sdk automatically system-scope these calls
17:25:19 mordred dtroyer: but - it's also fairly new information - so I could be totally wrong about it
17:44:22 openstack Launchpad bug 1809691 in senlin "Memory leak with senlin-engine sdk drivers" [Undecided,New]
17:44:22 dtruong mordred: Have you seen an issue with openstacksdk reporting too many files open? https://bugs.launchpad.net/senlin/+bug/1809691
17:47:37 mordred dtruong: yeah - I think that's been reported by someone else too? there's one leak that exists that we added a connection.close() method to handle (although there is a patch in flight that should make the need for that go away)
17:47:48 mordred dtruong: that was a thread leak though
17:48:21 mordred but maybe it's the same cause
17:49:40 dtruong the person who reported this bug in senlin proposed a patch set to set 'Connection' to 'Close' in the session header: https://review.openstack.org/#/c/627215/7/senlin/drivers/sdk.py
17:50:05 dtruong Is that the correct way to work around the issue?
17:57:07 openstackgerrit Merged openstack/openstacksdk master: Fix pagination key detection https://review.openstack.org/628977
17:57:31 mordred hrm. that I do not know about ... I'm not sure what that does - but seems to be a manipulation of the low-level requests session
17:57:39 mordred cmurphy, lbragstad: ^^ any chance you know?
17:59:06 mordred dtruong: it seems like that will close the remote connection, yeah - so that could certainly help with a connection/socket leak
17:59:33 mordred I'm a little surprised that would be needed because requests is supposed to be doing connection pooling
18:18:43 openstackgerrit Merged openstack/openstacksdk master: fix typos https://review.openstack.org/627258
18:18:44 openstackgerrit Merged openstack/openstacksdk master: Fix the misspelling of "configuration" https://review.openstack.org/627477
18:30:09 openstackgerrit Monty Taylor proposed openstack/cliff master: Pin cmd2 back to <0.9 on all versions https://review.openstack.org/629283
18:30:22 mordred dhellmann: ^^ there's the cliff patch with a depends-on
18:34:46 openstackgerrit Merged openstack/openstacksdk master: Rework orchestration to add update preview https://review.openstack.org/621154
18:34:46 openstackgerrit Merged openstack/openstacksdk master: Add possibility to override base_path for resource operations https://review.openstack.org/621153
18:46:43 dhellmann mordred : see the "conflicts with" list there; it looks like someone else proposed a similar change and it failed a test. let's see how yours does...
18:47:01 dhellmann oh, he's lacking the depends-on so that's probably why
18:59:01 mordred dhellmann, dtroyer: also - dmsimard was asking about an osc-lib release the other day
19:19:11 dhellmann there are some changes in that list that I don't recognize, so I'm not sure if they're backwards compatible or not
19:19:21 dhellmann http://paste.openstack.org/show/740694
19:19:47 dhellmann "default to using public interface for all clients"
19:20:00 dhellmann mordred : ^
19:21:52 mordred dhellmann: yah - that's to deal with underlying keystoneclient still defaulting to admin interface - even though that's a deprecated concept in general
19:22:33 dhellmann ok, so that sounds like a bug fix?
19:23:09 dhellmann oh, first release for stein so it has to be a feature bump anyway
19:24:59 mordred ++
19:25:01 mordred dmsimard: ^^
19:39:24 dmsimard Yay, thanks.
23:33:47 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Use devstack-system-admin cloud for limit tests https://review.openstack.org/629203
23:33:47 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Use os-cloud instead of OS env vars for functional tests https://review.openstack.org/629243
#openstack-sdks - 2019-01-09
07:42:40 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: Use os-cloud instead of OS env vars for functional tests https://review.openstack.org/629243
10:44:51 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: Use devstack-system-admin cloud for limit tests https://review.openstack.org/629203
11:50:13 openstackgerrit weiyuanjun proposed openstack/python-openstackclient master: fix typo errors https://review.openstack.org/629448
13:27:11 mordred amotoki: I'm confused why the second patch is still showing --os-cloud=devstack-admin in the command line it uses
13:28:40 mordred hrm. maybe the logic to have OS_CLOUD environment variable override the parameter isn't working out. let me try something
13:31:55 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Use devstack-system-admin cloud for limit tests https://review.openstack.org/629203
13:31:55 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Use os-cloud instead of OS env vars for functional tests https://review.openstack.org/629243
13:32:42 mordred amotoki: if that works, maybe we just squash the two of those
13:41:40 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use pagination detection by default https://review.openstack.org/629110
13:44:36 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Skip v2 block-storage tests when service is not found https://review.openstack.org/628969
14:06:26 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Compute location properly in server https://review.openstack.org/626380
14:06:27 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Extract getting connection from proxy into method https://review.openstack.org/629193
14:12:39 openstackgerrit Monty Taylor proposed openstack/os-client-config master: Applying the HTTPS protocal in configuration.rst https://review.openstack.org/617765
14:26:11 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Stop running grenade-py3 https://review.openstack.org/629503
14:26:18 mordred frickler: ^^
14:38:09 frickler mordred: IIUC unpinning g-reqs will require a release of the unpinned sdk
14:42:52 mordred frickler: ok
14:43:02 mordred I'm hoping to cut a release today
15:01:05 openstackgerrit Merged openstack-infra/shade master: Fix grant_role() when user not in default domain https://review.openstack.org/625583
15:04:52 openstackgerrit Merged openstack/os-client-config master: Applying the HTTPS protocal in configuration.rst https://review.openstack.org/617765

Earlier   Later