Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-10-25
18:43:13 kmalloc don't backport features, make it so v1 continues to work as expected
18:43:27 kmalloc ideally the API and the storage backend should have little bearing on eachother
18:43:49 kmalloc Users interact with the API, the service translates those interactions to something the storage system can understand
18:43:53 peschk_l OK, that's what I understood earlier. This is how it has been implemented until now
18:44:11 kmalloc so you'd have new shiny-storage and everyone would migrate to it
18:44:15 kmalloc v1 just uses that
18:44:38 kmalloc and then v2 features expose the new-awesome(tm) [YES TRADEMARKED!] things to the end users that the storage system can do
18:45:08 peschk_l kmalloc: ok, thanks for the clarification :)
18:45:10 kmalloc :)
18:45:13 kmalloc hope that helps
18:45:24 kmalloc now... wsme/pecan vs flask vs webob
18:45:32 kmalloc all of that is independent of your API
18:45:41 kmalloc those are tools/frameworks to build your service
18:45:49 kmalloc you can convert or not
18:45:58 edleafe peschk_l: Also, the 'Note' at the top of this page is useful for distinguishing the different API statuses: https://developer.openstack.org/api-guide/quick-start/
18:46:01 kmalloc there are also ways to layer compatibility in
18:46:19 kmalloc if you want flask i can show you some ways to layer v1 in on top of v2 keeping the old stuff
18:46:31 kmalloc but don't feel like you need to change out the framework just to do v2
18:46:42 kmalloc it is a LOT of work to swap frameworks/change that stuff out
18:47:16 kmalloc fwiw, (and keystone has a huge api surface area) it was almost 100 commits and probably over 30,000 lines of code changed to get there
18:47:29 kmalloc changing frameworks is VERY disruptive, but can be worth it in some cases
18:48:08 kmalloc just keep in mind the technical cost of doing so
18:48:29 kmalloc and plan for that separately from the implementation of the new API(s)
18:49:39 peschk_l kmalloc: we were thinking about an "easy" way: serving two wsgi apps on /v1 and /v2. That way, we'd only need to modify the root controller
18:50:00 kmalloc so i can show you a SUPER easy way
18:50:35 peschk_l (don't worry, cloudkitty's whole codebase is probably smaller thant keystone's API)
18:50:40 peschk_l *than
18:50:51 peschk_l kmalloc: would be glad to hear about it
18:51:06 kmalloc http://werkzeug.pocoo.org/docs/0.14/middlewares/#werkzeug.wsgi.DispatcherMiddleware
18:51:39 kmalloc that middleware right there lets you say "all paths for prefix /XXX goes to app X and all prefixes that don't match fall through to the application"
18:51:55 kmalloc you can have as many rules for matching and passing to apps as you want
18:52:06 kmalloc werkzeug is super cool with the middlewares it provides
18:52:20 kmalloc (werkzeug is the base for flask, but you can use it's middleware without flask)
18:52:33 peschk_l actually, we were planning to use exactly this, but we were not sure if it was a prod-ready
18:53:01 kmalloc keystone ran with it in rocky
18:53:10 kmalloc we subclassed because we needed a LOT of extra stuff
18:53:21 kmalloc but i have no concerns with stable werkzeug code in prod
18:53:35 kmalloc in fact, keystone still uses it
18:53:42 kmalloc and will for the foreseeable future
18:53:58 peschk_l glad to hear that :) is keystone v2 still based on pecan ?
18:54:09 kmalloc https://github.com/openstack/keystone/blob/cd8f7a503673de1cd603b2f5a66e4bbfe3085583/keystone/server/flask/application.py#L163-L171
18:54:20 kmalloc keystone v2 was based on raw webob
18:54:27 kmalloc keystone v2 also has been deleted and no longer exists
18:54:41 kmalloc i used that middleware to dispatch each of keystone's APIs for the transition to flask
18:54:56 kmalloc so i moved /auth to flask and still dispatched code to the old webob v3 api for /projects
18:55:01 kmalloc until /projects was converted
18:55:02 kmalloc for example
18:55:47 kmalloc peschk_l: you can see what we did here https://github.com/openstack/keystone/blob/stable/rocky/keystone/server/flask/application.py#L81
18:56:05 kmalloc we moved parts of our api to flask in smaller chunks
18:56:24 kmalloc (master looks far different as you can see, since we run 100% on flask now)
18:57:21 kmalloc doctor appointment
18:57:25 kmalloc be back in a few hours
18:58:19 peschk_l kmalloc: I'll probably be sleeping when you return, but thank you very much for all the information, it's been a HUGE help :)
18:58:41 kmalloc happy to help!
18:58:45 kmalloc edleafe: i don't envy you
18:58:48 peschk_l edleafe are you still there ?
18:59:00 edleafe yeah
18:59:32 edleafe but about to disappear into several meetings
19:00:16 peschk_l oh, didn't see you need to go too. Just for the record: I saw that paste is still maintained. Is this only for backward compatibility and should we plan to drop it, or can we stick with it ?
19:01:55 peschk_l and in the case we need to move on: is there a recommendation from your side ?
20:04:05 mriedem who besides dean is an osc core that i can bug for reviews on this old bug fix? https://review.openstack.org/545946
20:08:13 mriedem amotoki: ^?
20:21:48 mordred mriedem: looking
20:22:25 mriedem i'm sure it'll be the best thing you've looked at all day
20:22:58 mordred mriedem: I've been on a plane all day - so as long as it's better than Ocean's 8 - I'll be thrilled
20:23:49 mriedem thanks
23:09:59 kmalloc peschk_l: i would plan on moving off paste. I am in process of writing a compat bit for oslo.middleware to load middleware and the app w/o paste
23:10:15 kmalloc peschk_l: but paste is maintained minimally because we have projects leaning on it
#openstack-sdks - 2018-10-26
01:36:33 openstackgerrit Merged openstack/keystoneauth master: Add missing release note for ironic discovery fix https://review.openstack.org/612872
03:20:17 openstackgerrit Merged openstack/python-openstackclient master: Default --nic to 'auto' if creating a server with >= 2.37 https://review.openstack.org/545946
04:26:09 openstackgerrit Ian Wienand proposed openstack/openstacksdk master: Move pre/post run task calls to queue https://review.openstack.org/613503
04:26:10 openstackgerrit Ian Wienand proposed openstack/openstacksdk master: Add doc depends to tox releasenotes environment https://review.openstack.org/613504
04:28:19 openstackgerrit Ian Wienand proposed openstack/openstacksdk master: Add doc depends to tox releasenotes environment https://review.openstack.org/613504
04:28:19 openstackgerrit Ian Wienand proposed openstack/openstacksdk master: Call pre/post run task calls from TaskManager.submit_task() https://review.openstack.org/613503
08:35:55 openstackgerrit Ian Wienand proposed openstack/openstacksdk master: Add doc depends to tox releasenotes environment https://review.openstack.org/613504
08:35:55 openstackgerrit Ian Wienand proposed openstack/openstacksdk master: Call pre/post run task calls from TaskManager.submit_task() https://review.openstack.org/613503
13:13:13 openstackgerrit Sean McGinnis proposed openstack/python-openstackclient master: Add volume backup import/export commands https://review.openstack.org/612735
13:19:06 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Don't pass disk_format or container_format to image task upload https://review.openstack.org/613141
13:40:57 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add doc depends to tox releasenotes environment https://review.openstack.org/613504
13:40:57 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Call pre/post run task calls from TaskManager.submit_task() https://review.openstack.org/613503
14:44:54 openstackgerrit Brian Haley proposed openstack/python-openstackclient master: Update the Neutron CLI decoder document https://review.openstack.org/613605
16:53:37 openstackgerrit Sean McGinnis proposed openstack/python-openstackclient master: Remove deprecated network args https://review.openstack.org/613644
17:05:01 openstackgerrit Sean McGinnis proposed openstack/python-openstackclient master: Remove invalid 'unlock-volume' migration arg https://review.openstack.org/558910
18:51:09 openstackgerrit Daniel Speichert proposed openstack/openstacksdk master: Added basic CRUD functionality around Host Aggregates https://review.openstack.org/609416
18:54:17 openstackgerrit Sean McGinnis proposed openstack/openstacksdk master: Fix incorrect use of flake8:noqa https://review.openstack.org/613667
#openstack-sdks - 2018-10-27
01:13:28 openstackgerrit Merged openstack/openstacksdk master: Add registered limit CRUD support https://review.openstack.org/609572
04:13:05 openstackgerrit Merged openstack/openstacksdk master: Add limit CRUD support https://review.openstack.org/609604
08:14:46 openstackgerrit Yuval Shalev proposed openstack/openstacksdk master: Added assign function to identity v3 proxy https://review.openstack.org/612006
14:47:26 openstackgerrit Merged openstack/openstacksdk master: Fix incorrect use of flake8:noqa https://review.openstack.org/613667
14:47:46 openstackgerrit Merged openstack/openstacksdk master: Don't pass disk_format or container_format to image task upload https://review.openstack.org/613141
14:53:42 openstackgerrit Merged openstack/openstacksdk master: Add vnic_type to create_port valid kwargs https://review.openstack.org/612162
15:53:15 openstackgerrit Merged openstack/openstacksdk master: Add the ability to extend a volume size https://review.openstack.org/595873
16:05:39 openstackgerrit Merged openstack/openstacksdk master: Stop running shade tests https://review.openstack.org/612407
20:22:06 openstackgerrit Maxim Babushkin proposed openstack/openstacksdk master: Add port_security_enabled to create_port valid kwargs https://review.openstack.org/613759
21:48:06 openstackgerrit Maxim Babushkin proposed openstack/openstacksdk master: Add port_security_enabled to create_port valid kwargs https://review.openstack.org/613759
#openstack-sdks - 2018-10-28
13:41:13 openstackgerrit Merged openstack/openstacksdk master: Use python3 format syntax for citycloud https://review.openstack.org/612536
14:52:25 openstackgerrit Merged openstack/openstacksdk master: Add port_security_enabled to create_port valid kwargs https://review.openstack.org/613759
14:52:26 openstackgerrit Merged openstack/openstacksdk master: openstackcloud.py: Implement FWaaS wrapper methods. https://review.openstack.org/604811
15:06:03 ml mordred: thank you
16:02:51 openstackgerrit Merged openstack/openstacksdk master: Fix upload of Swift object smaller than segment limit (create_object) https://review.openstack.org/612113

Earlier   Later