Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-09-21
15:49:30 Shrews mordred: why the call to ret.exception()? We don't seem to do anything with it
15:50:15 Shrews ret.result() should raise an exception if one occurred in the call (if i read the Futures docs correction)
15:50:23 Shrews s/correction/correctly/
15:54:10 mordred Shrews: oh - I couldn't find mention that result would do that - so I guess it's senseless
15:54:36 Shrews mordred: https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.Future.result
15:55:28 mordred Shrews: so, whatyou're saying is thatif I could actually read simple english, my life would be better?
16:07:23 Shrews mordred: left comments :-P
16:08:43 mordred Shrews: \o/
16:09:31 Shrews mordred: i'm not sure if anyone actually uses submit_function_async(), but probably a bad idea to totally remove an API call
16:09:38 Shrews correct me if i'm wrong
16:09:49 Shrews 'cause i know nothing about anything
16:09:54 Shrews 'cause Friday
16:10:17 mordred Shrews: yeah - I agree with you in principle, but in practice I'm 99.9% sure that nodepool is the only consumer of anything related to taskmanager
16:10:29 Shrews i checked nodepool for it, fwiw
16:10:31 Shrews not used
16:10:34 mordred yah
16:10:39 Shrews so i can be convinced to remove it
16:11:01 Shrews mmmm, frothy
16:18:10 openstackgerrit Matthias Lisin proposed openstack/openstacksdk master: Support firewall service for SDK https://review.openstack.org/592303
16:28:27 mordred dtantsur: I think I found the issue with the bifrost
16:28:38 dtantsur with bifrost itself?
16:28:52 mordred nope - with the sdk discovery patch and the failing bifrost test
16:29:32 mordred tl;dr - auth_type='none' and endpoint=ironic_url needs to take ironic_url and put it in the endpoint_override parameter when creating the keystoneauth Adapter
16:29:44 mordred otherwise discovery is sad
16:29:58 mordred it's an easy fix in openstack.config
16:30:35 mordred or - more generally- if none/endpoint are given, then that endpoint should be returned for any/all service endpoint_override values
16:30:59 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292
16:31:00 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Set endpoint_override from endpoint with noauth https://review.openstack.org/604415
16:31:00 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove profile https://review.openstack.org/604414
16:31:09 dtantsur yeah
16:31:24 Shrews is it just me, or is all of that stuff just a confusing mess?
16:31:37 mordred Shrews: bah. it's super simple ;)
16:31:47 mordred dtantsur Shrews: https://review.openstack.org/604415 has that bit fixed - and I did it in a separate patch so that Shrews doesn't kill me
16:31:55 dtantsur staring at it already
16:31:58 mordred I also broke out the profile removal so that the big patch is smaller
16:32:09 dtantsur mordred: do you know what I'm going to ask you? hint: starts with "unit" :)
16:32:14 mordred hahahahaha
16:32:29 mordred yeah. good point ... lemme do that
16:33:53 dtantsur thanks! otherwise the patch looks okay
16:34:08 dtantsur well, I cringe every time we have to hardcode entry points in code... but I guess it's the lesser evil
16:35:17 mordred oh - well, everything in openstack.config is a basis for cringe :)
16:35:46 dtantsur fair enough :)
16:36:41 dtantsur mordred: last (potentially stupid) question: is Python None really synonym of "none" here? I would expect it to default to password..
16:37:46 mordred dtantsur: it should default to password - but I think the codepath works if someone puts a yaml null in there
16:37:57 mordred maybe I should try that
16:38:10 dtantsur mordred: yeah, I'm a bit worried about "in ("none", None)" bit
16:39:33 dtantsur anyway, it's Friday evening, I think I should do something more productive than asking questions :)
16:39:38 dtantsur have a great weekend
16:40:37 mordred dtantsur: you're right- null/None isn't a thing
16:41:18 dtantsur ok :)
16:41:35 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Set endpoint_override from endpoint with noauth https://review.openstack.org/604415
16:41:37 mordred now with tests
17:16:27 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Set endpoint_override from endpoint with noauth https://review.openstack.org/604415
17:16:28 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292
17:40:07 openstackgerrit Matthias Lisin proposed openstack/openstacksdk master: Support firewall service for SDK https://review.openstack.org/592303
19:55:36 mordred Shrews, dtantsur|afk: ZOMG ZOMG - the discovery patch PASSED the bifrost test!!!!
19:56:17 mordred TheJulia: you may also be interested to hear such wonderful and positive news
20:22:50 mordred of course, the downside is that now somebody has to review the beast
20:23:03 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove api version default values https://review.openstack.org/600330
20:35:58 TheJulia Woot!
#openstack-sdks - 2018-09-22
10:52:57 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Turn down stevedore and urllib logging https://review.openstack.org/604515
11:17:08 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove api version default values https://review.openstack.org/600330
11:21:44 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Set python3 as the default basepython https://review.openstack.org/604517
13:29:11 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Import rate limiting TaskManager from nodepool https://review.openstack.org/574285
13:29:11 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Run all tasks through the threadpool https://review.openstack.org/603739
13:29:12 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add support for per-service rate limits https://review.openstack.org/604521
13:29:12 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Make RateLimitingTaskManager the TaskManager https://review.openstack.org/604520
15:30:27 openstackgerrit Merged openstack/openstacksdk master: Implement volume update https://review.openstack.org/600057
#openstack-sdks - 2018-09-23
14:43:19 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Set endpoint_override from endpoint with noauth https://review.openstack.org/604415
14:43:19 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove profile https://review.openstack.org/604414
14:43:20 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove api version default values https://review.openstack.org/600330
14:43:20 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292
14:43:21 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Restore timeout_scaling_factor https://review.openstack.org/604628
15:06:51 openstackgerrit melissaml proposed openstack/python-openstackclient master: Update the URL in doc https://review.openstack.org/604632
15:18:27 openstackgerrit melissaml proposed openstack/api-sig master: Update the URL in doc https://review.openstack.org/604633
15:23:06 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Cache root urls with and without trailing slashes https://review.openstack.org/604635
17:18:57 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Restore timeout_scaling_factor https://review.openstack.org/604628
17:18:58 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Set endpoint_override from endpoint with noauth https://review.openstack.org/604415
17:18:58 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove profile https://review.openstack.org/604414
17:18:59 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove api version default values https://review.openstack.org/600330
17:18:59 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292
17:19:00 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Speacial case network and use it in openstack.cloud https://review.openstack.org/604645
17:19:12 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Special case network and use it in openstack.cloud https://review.openstack.org/604645
#openstack-sdks - 2018-09-24
08:50:59 openstackgerrit melissaml proposed openstack-infra/shade master: Update the url in doc https://review.openstack.org/604701
09:40:07 openstackgerrit Matthias Lisin proposed openstack/openstacksdk master: Support firewall service for SDK https://review.openstack.org/592303
10:52:12 openstackgerrit melissaml proposed openstack/openstacksdk master: Update the URL in doc https://review.openstack.org/604738
12:26:38 openstackgerrit Merged openstack-infra/shade master: Update the url in doc https://review.openstack.org/604701
12:37:05 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove profile https://review.openstack.org/604414
12:37:05 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Restore timeout_scaling_factor https://review.openstack.org/604628
12:37:06 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292
12:37:06 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Set endpoint_override from endpoint with noauth https://review.openstack.org/604415
12:37:07 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Special case network and use it in openstack.cloud https://review.openstack.org/604645
12:37:07 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove api version default values https://review.openstack.org/600330
12:42:50 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Run all tasks through the threadpool https://review.openstack.org/603739
12:42:51 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Make RateLimitingTaskManager the TaskManager https://review.openstack.org/604520
12:42:51 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Import rate limiting TaskManager from nodepool https://review.openstack.org/574285
12:42:52 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add support for per-service rate limits https://review.openstack.org/604521
14:17:33 Horrorcat mmands (e.g. openstack server list, which e.g. fails if the IdP does not offer a compute endpoint).
14:17:33 Horrorcat I think we're seeing a regression between osc-lib 1.9.0 to osc-lib 1.11.0. we are using keystone-to-keystone federation. when executing openstack endpoint list with an openrc configured for federation (using OS_SERVICE_PROVIDER), osc-lib 1.9.0 correctly queries the endpoints of the service provider. osc-lib 1.11.0 queries the endpoints of the identity provider instead. the same holds for other co
14:17:44 Horrorcat is this known/intentional or shall we report this as a bug?

Earlier   Later